All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, git@jeffhostetler.com,
	chakrabortyabhradeep79@gmail.com,
	Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH] pack-bitmap: remove trace2 region from hot path
Date: Fri, 23 Sep 2022 15:17:41 -0400	[thread overview]
Message-ID: <Yy4GVT8VZ4dOyGDy@nand.local> (raw)
In-Reply-To: <xmqq7d1uuh5f.fsf@gitster.g>

On Fri, Sep 23, 2022 at 10:36:44AM -0700, Junio C Hamano wrote:
> diff --git c/t/t5310-pack-bitmaps.sh w/t/t5310-pack-bitmaps.sh
> index 7e50f8e765..2b1efc923b 100755
> --- c/t/t5310-pack-bitmaps.sh
> +++ w/t/t5310-pack-bitmaps.sh
> @@ -455,7 +455,7 @@ test_expect_success 'verify writing bitmap lookup table when enabled' '
>  	grep "\"label\":\"writing_lookup_table\"" trace2
>  '
>
> -test_expect_success 'lookup table is actually used to traverse objects' '
> +: test_expect_success 'lookup table is actually used to traverse objects' '
>  	git repack -adb &&
>  	GIT_TRACE2_EVENT="$(pwd)/trace3" \
>  		git rev-list --use-bitmap-index --count --all &&

Yeah, I would advocate for dropping this test entirely. That trace2
marker is the only indication that is so obvious that we're using the
lookup table to read bitmaps.

Perhaps the pack-bitmap helper could be taught to dump which extensions
it sees, and then write a test based on that? Although that isn't really
testing anything new, either, since we sometimes *notice* the extension
but don't actually read anything based on it (e.g., when disabled).

So I'd be content just dropping this.

Thanks,
Taylor

  parent reply	other threads:[~2022-09-23 19:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 13:00 [PATCH] pack-bitmap: remove trace2 region from hot path Derrick Stolee via GitGitGadget
2022-09-23 17:05 ` Junio C Hamano
2022-09-23 17:25   ` Junio C Hamano
2022-09-23 17:36 ` Junio C Hamano
2022-09-23 18:07   ` Derrick Stolee
2022-09-23 19:17   ` Taylor Blau [this message]
2022-09-26 13:17 ` [PATCH v2] " Derrick Stolee via GitGitGadget
2022-09-26 15:01   ` Ævar Arnfjörð Bjarmason
2022-09-26 17:31     ` Derrick Stolee
2022-09-27 18:37 ` [PATCH] " Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yy4GVT8VZ4dOyGDy@nand.local \
    --to=me@ttaylorr.com \
    --cc=chakrabortyabhradeep79@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.