All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, git@jeffhostetler.com, me@ttaylorr.com,
	chakrabortyabhradeep79@gmail.com,
	Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH] pack-bitmap: remove trace2 region from hot path
Date: Fri, 23 Sep 2022 10:05:27 -0700	[thread overview]
Message-ID: <xmqqpmfmuilk.fsf@gitster.g> (raw)
In-Reply-To: <pull.1365.git.1663938034607.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Fri, 23 Sep 2022 13:00:34 +0000")

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:


> -		trace2_region_enter("pack-bitmap", "reading_lookup_table", the_repository);
>  		/* NEEDSWORK: cache misses aren't recorded */
>  		bitmap = lazy_bitmap_for_commit(bitmap_git, commit);
> -		trace2_region_leave("pack-bitmap", "reading_lookup_table", the_repository);
>  		if (!bitmap)
>  			return NULL;
>  		return lookup_stored_bitmap(bitmap);

As "git blame" is bad in finding a piece of code that no longer
exists, it may make sense to leave a comment around here why we do
not have a trace2 region around this call, perhaps?

+	/* do not add trace2_region around here in the hot path */
	bitmap = lazy_bitmap_for_commit(...);

or something?

Thanks.

  reply	other threads:[~2022-09-23 17:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 13:00 [PATCH] pack-bitmap: remove trace2 region from hot path Derrick Stolee via GitGitGadget
2022-09-23 17:05 ` Junio C Hamano [this message]
2022-09-23 17:25   ` Junio C Hamano
2022-09-23 17:36 ` Junio C Hamano
2022-09-23 18:07   ` Derrick Stolee
2022-09-23 19:17   ` Taylor Blau
2022-09-26 13:17 ` [PATCH v2] " Derrick Stolee via GitGitGadget
2022-09-26 15:01   ` Ævar Arnfjörð Bjarmason
2022-09-26 17:31     ` Derrick Stolee
2022-09-27 18:37 ` [PATCH] " Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpmfmuilk.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chakrabortyabhradeep79@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.