From: Mark Brown <broonie@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, peterz@infradead.org,
acme@kernel.org, mark.rutland@arm.com, will@kernel.org,
catalin.marinas@arm.com, James Clark <james.clark@arm.com>,
Rob Herring <robh@kernel.org>, Marc Zyngier <maz@kernel.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH V2 3/7] arm64/perf: Update struct pmu_hw_events for BRBE
Date: Wed, 14 Sep 2022 10:35:48 +0100 [thread overview]
Message-ID: <YyGgdPzJG3+0nCC4@sirena.org.uk> (raw)
In-Reply-To: <c4800957-825c-a5c7-d8d4-946d9c6cdf6c@arm.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Wed, Sep 14, 2022 at 09:09:10AM +0530, Anshuman Khandual wrote:
> Something like the following change moves the buffer allocation off the stack,
> although it requires updating the driver, and buffer assignment during a PMU
> interrupt. But it does seem to work (will require some more testing).
Yeah, looks like it should do the trick.
> +
> + events->branch_records = kmalloc(sizeof(struct brbe_records), flags);
> + WARN_ON(!events->branch_records);
No need for the WARN_ON(), if we run out of memory the memory
management code is already very loud about it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, peterz@infradead.org,
acme@kernel.org, mark.rutland@arm.com, will@kernel.org,
catalin.marinas@arm.com, James Clark <james.clark@arm.com>,
Rob Herring <robh@kernel.org>, Marc Zyngier <maz@kernel.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH V2 3/7] arm64/perf: Update struct pmu_hw_events for BRBE
Date: Wed, 14 Sep 2022 10:35:48 +0100 [thread overview]
Message-ID: <YyGgdPzJG3+0nCC4@sirena.org.uk> (raw)
In-Reply-To: <c4800957-825c-a5c7-d8d4-946d9c6cdf6c@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 597 bytes --]
On Wed, Sep 14, 2022 at 09:09:10AM +0530, Anshuman Khandual wrote:
> Something like the following change moves the buffer allocation off the stack,
> although it requires updating the driver, and buffer assignment during a PMU
> interrupt. But it does seem to work (will require some more testing).
Yeah, looks like it should do the trick.
> +
> + events->branch_records = kmalloc(sizeof(struct brbe_records), flags);
> + WARN_ON(!events->branch_records);
No need for the WARN_ON(), if we run out of memory the memory
management code is already very loud about it.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-14 9:37 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 5:10 [PATCH V2 0/7] arm64/perf: Enable branch stack sampling Anshuman Khandual
2022-09-08 5:10 ` Anshuman Khandual
2022-09-08 5:10 ` [PATCH V2 1/7] arm64/perf: Add register definitions for BRBE Anshuman Khandual
2022-09-08 5:10 ` Anshuman Khandual
2022-09-12 9:57 ` Mark Brown
2022-09-12 9:57 ` Mark Brown
2022-09-13 6:24 ` Anshuman Khandual
2022-09-13 6:24 ` Anshuman Khandual
2022-09-13 11:30 ` Mark Brown
2022-09-13 11:30 ` Mark Brown
2022-09-08 5:10 ` [PATCH V2 2/7] arm64/perf: Update struct arm_pmu " Anshuman Khandual
2022-09-08 5:10 ` Anshuman Khandual
2022-09-08 5:10 ` [PATCH V2 3/7] arm64/perf: Update struct pmu_hw_events " Anshuman Khandual
2022-09-08 5:10 ` Anshuman Khandual
2022-09-08 12:32 ` kernel test robot
2022-09-09 3:11 ` Anshuman Khandual
2022-09-09 3:11 ` Anshuman Khandual
2022-09-09 3:11 ` Anshuman Khandual
2022-09-08 14:14 ` kernel test robot
2022-09-09 3:14 ` Anshuman Khandual
2022-09-09 3:14 ` Anshuman Khandual
2022-09-09 3:14 ` Anshuman Khandual
2022-09-12 10:12 ` Mark Brown
2022-09-12 10:12 ` Mark Brown
2022-09-13 5:33 ` Anshuman Khandual
2022-09-13 5:33 ` Anshuman Khandual
2022-09-13 11:43 ` Mark Brown
2022-09-13 11:43 ` Mark Brown
2022-09-14 3:39 ` Anshuman Khandual
2022-09-14 3:39 ` Anshuman Khandual
2022-09-14 9:35 ` Mark Brown [this message]
2022-09-14 9:35 ` Mark Brown
2022-09-08 5:10 ` [PATCH V2 4/7] driver/perf/arm_pmu_platform: Add support for BRBE attributes detection Anshuman Khandual
2022-09-08 5:10 ` Anshuman Khandual
2022-09-08 5:10 ` [PATCH V2 5/7] arm64/perf: Drive BRBE from perf event states Anshuman Khandual
2022-09-08 5:10 ` Anshuman Khandual
2022-09-08 15:31 ` kernel test robot
2022-09-08 15:31 ` kernel test robot
2022-09-08 5:10 ` [PATCH V2 6/7] arm64/perf: Add BRBE driver Anshuman Khandual
2022-09-08 5:10 ` Anshuman Khandual
2022-09-08 9:23 ` kernel test robot
2022-09-08 9:23 ` kernel test robot
2022-09-08 10:16 ` Anshuman Khandual
2022-09-08 10:16 ` Anshuman Khandual
2022-09-08 10:16 ` Anshuman Khandual
2022-09-13 10:39 ` James Clark
2022-09-13 10:39 ` James Clark
2022-09-13 11:38 ` Anshuman Khandual
2022-09-13 11:38 ` Anshuman Khandual
2022-09-08 5:10 ` [PATCH V2 7/7] arm64/perf: Enable branch stack sampling Anshuman Khandual
2022-09-08 5:10 ` Anshuman Khandual
2022-09-13 10:55 ` [PATCH V2 0/7] " James Clark
2022-09-13 10:55 ` James Clark
2022-09-13 12:12 ` Anshuman Khandual
2022-09-13 12:12 ` Anshuman Khandual
2022-09-13 13:12 ` James Clark
2022-09-13 13:12 ` James Clark
2022-09-14 4:43 ` Anshuman Khandual
2022-09-14 4:43 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyGgdPzJG3+0nCC4@sirena.org.uk \
--to=broonie@kernel.org \
--cc=acme@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.clark@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.