* [igt-dev] [PATCH i-g-t] tests/kms_dp_aux_dev: Convert test to dynamic
@ 2022-09-19 10:06 Ananya Sharma
2022-09-19 10:35 ` Petri Latvala
0 siblings, 1 reply; 4+ messages in thread
From: Ananya Sharma @ 2022-09-19 10:06 UTC (permalink / raw)
To: igt-dev
Modified kms_universal_plane to include dynamic test cases.
Signed-off-by: Ananya Sharma <ananya.sharma@intel.com>
---
tests/kms_dp_aux_dev.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
index d3249fa3..ac12b500 100644
--- a/tests/kms_dp_aux_dev.c
+++ b/tests/kms_dp_aux_dev.c
@@ -118,7 +118,7 @@ static bool test(int drm_fd, uint32_t connector_id)
return false;
}
-igt_simple_main
+igt_main
{
int valid_connectors = 0;
drmModeRes *res;
@@ -129,8 +129,13 @@ igt_simple_main
res = drmModeGetResources(drm_fd);
igt_require(res);
- for (int i = 0; i < res->count_connectors; i++)
- valid_connectors += test(drm_fd, res->connectors[i]);
+ igt_subtest_with_dynamic("basic") {
+ for (int i = 0; i < res->count_connectors; i++)
+ igt_dynamic_f("subtest-%d", i) {
+ valid_connectors += test(drm_fd, res->connectors[i]);
+ }
+ }
+
igt_require(valid_connectors);
drmModeFreeResources(res);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_aux_dev: Convert test to dynamic
2022-09-19 10:06 [igt-dev] [PATCH i-g-t] tests/kms_dp_aux_dev: Convert test to dynamic Ananya Sharma
@ 2022-09-19 10:35 ` Petri Latvala
0 siblings, 0 replies; 4+ messages in thread
From: Petri Latvala @ 2022-09-19 10:35 UTC (permalink / raw)
To: Ananya Sharma; +Cc: igt-dev
On Mon, Sep 19, 2022 at 03:36:23PM +0530, Ananya Sharma wrote:
> Modified kms_universal_plane to include dynamic test cases.
>
> Signed-off-by: Ananya Sharma <ananya.sharma@intel.com>
> ---
> tests/kms_dp_aux_dev.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
> index d3249fa3..ac12b500 100644
> --- a/tests/kms_dp_aux_dev.c
> +++ b/tests/kms_dp_aux_dev.c
> @@ -118,7 +118,7 @@ static bool test(int drm_fd, uint32_t connector_id)
> return false;
> }
>
> -igt_simple_main
> +igt_main
> {
> int valid_connectors = 0;
> drmModeRes *res;
> @@ -129,8 +129,13 @@ igt_simple_main
> res = drmModeGetResources(drm_fd);
> igt_require(res);
Calling anything that touches DRM outside of an igt_fixture or a
subtest is invalid. drmModeGetResources and its friends here for
example.
--
Petri Latvala
>
> - for (int i = 0; i < res->count_connectors; i++)
> - valid_connectors += test(drm_fd, res->connectors[i]);
> + igt_subtest_with_dynamic("basic") {
> + for (int i = 0; i < res->count_connectors; i++)
> + igt_dynamic_f("subtest-%d", i) {
> + valid_connectors += test(drm_fd, res->connectors[i]);
> + }
> + }
> +
> igt_require(valid_connectors);
>
> drmModeFreeResources(res);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_aux_dev: Convert test to dynamic
2022-09-19 10:26 Ananya Sharma
@ 2022-09-29 10:21 ` Modem, Bhanuprakash
0 siblings, 0 replies; 4+ messages in thread
From: Modem, Bhanuprakash @ 2022-09-29 10:21 UTC (permalink / raw)
To: Ananya Sharma, igt-dev
On Mon-19-09-2022 03:56 pm, Ananya Sharma wrote:
> Modified kms_dp_aux_dev to include dynamic test cases.
>
> Signed-off-by: Ananya Sharma <ananya.sharma@intel.com>
> ---
> tests/kms_dp_aux_dev.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
> index d3249fa3..ac12b500 100644
> --- a/tests/kms_dp_aux_dev.c
> +++ b/tests/kms_dp_aux_dev.c
> @@ -118,7 +118,7 @@ static bool test(int drm_fd, uint32_t connector_id)
> return false;
> }
>
> -igt_simple_main
> +igt_main
> {
> int valid_connectors = 0;
> drmModeRes *res;
> @@ -129,8 +129,13 @@ igt_simple_main
> res = drmModeGetResources(drm_fd);
> igt_require(res);
Move this drm resources part to igt_fixture
>
> - for (int i = 0; i < res->count_connectors; i++)
> - valid_connectors += test(drm_fd, res->connectors[i]);
> + igt_subtest_with_dynamic("basic") {
> + for (int i = 0; i < res->count_connectors; i++)
> + igt_dynamic_f("subtest-%d", i) {
Please use the connector name for dynamic subtest.
Example:
igt_dynamic_f("%s-%d",
kmstest_connector_type_str(connector->connector_type),
connector->connector_type_id)
> + valid_connectors += test(drm_fd, res->connectors[i]);
> + }
> + }
> +
> igt_require(valid_connectors);
This check is not required in case of dynamic subtests, IGT will throw
the SKIP if igt_dynamic() is not executed at least once.
>
> drmModeFreeResources(res);
Move this part to igt_fixture.
- Bhanu
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_dp_aux_dev: Convert test to dynamic
@ 2022-09-19 10:26 Ananya Sharma
2022-09-29 10:21 ` Modem, Bhanuprakash
0 siblings, 1 reply; 4+ messages in thread
From: Ananya Sharma @ 2022-09-19 10:26 UTC (permalink / raw)
To: igt-dev
Modified kms_dp_aux_dev to include dynamic test cases.
Signed-off-by: Ananya Sharma <ananya.sharma@intel.com>
---
tests/kms_dp_aux_dev.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
index d3249fa3..ac12b500 100644
--- a/tests/kms_dp_aux_dev.c
+++ b/tests/kms_dp_aux_dev.c
@@ -118,7 +118,7 @@ static bool test(int drm_fd, uint32_t connector_id)
return false;
}
-igt_simple_main
+igt_main
{
int valid_connectors = 0;
drmModeRes *res;
@@ -129,8 +129,13 @@ igt_simple_main
res = drmModeGetResources(drm_fd);
igt_require(res);
- for (int i = 0; i < res->count_connectors; i++)
- valid_connectors += test(drm_fd, res->connectors[i]);
+ igt_subtest_with_dynamic("basic") {
+ for (int i = 0; i < res->count_connectors; i++)
+ igt_dynamic_f("subtest-%d", i) {
+ valid_connectors += test(drm_fd, res->connectors[i]);
+ }
+ }
+
igt_require(valid_connectors);
drmModeFreeResources(res);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-29 10:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 10:06 [igt-dev] [PATCH i-g-t] tests/kms_dp_aux_dev: Convert test to dynamic Ananya Sharma
2022-09-19 10:35 ` Petri Latvala
2022-09-19 10:26 Ananya Sharma
2022-09-29 10:21 ` Modem, Bhanuprakash
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.