* [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-09-13 20:56 ` Nathan Huckleberry
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Huckleberry @ 2022-09-13 20:56 UTC (permalink / raw)
Cc: Nathan Huckleberry, Dan Carpenter, llvm, Hyun Kwon,
Laurent Pinchart, David Airlie, Daniel Vetter, Michal Simek,
Nathan Chancellor, Nick Desaulniers, Tom Rix, dri-devel,
linux-arm-kernel, linux-kernel
The mode_valid field in drm_connector_helper_funcs is expected to be of
type
enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
struct drm_display_mode *mode);
The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.
The return type of zynqmp_dp_connector_mode_valid should be changed from
int to enum drm_mode_status.
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index d14612b34796..f571b08d23d3 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
return &dp->encoder;
}
-static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
- struct drm_display_mode *mode)
+static enum drm_mode_status
+zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
{
struct zynqmp_dp *dp = connector_to_dp(connector);
u8 max_lanes = dp->link_config.max_lanes;
--
2.37.2.789.g6183377224-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-09-13 20:56 ` Nathan Huckleberry
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Huckleberry @ 2022-09-13 20:56 UTC (permalink / raw)
Cc: Nathan Huckleberry, Dan Carpenter, llvm, Hyun Kwon,
Laurent Pinchart, David Airlie, Daniel Vetter, Michal Simek,
Nathan Chancellor, Nick Desaulniers, Tom Rix, dri-devel,
linux-arm-kernel, linux-kernel
The mode_valid field in drm_connector_helper_funcs is expected to be of
type
enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
struct drm_display_mode *mode);
The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.
The return type of zynqmp_dp_connector_mode_valid should be changed from
int to enum drm_mode_status.
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index d14612b34796..f571b08d23d3 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
return &dp->encoder;
}
-static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
- struct drm_display_mode *mode)
+static enum drm_mode_status
+zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
{
struct zynqmp_dp *dp = connector_to_dp(connector);
u8 max_lanes = dp->link_config.max_lanes;
--
2.37.2.789.g6183377224-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-09-13 20:56 ` Nathan Huckleberry
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Huckleberry @ 2022-09-13 20:56 UTC (permalink / raw)
Cc: linux-kernel, Dan Carpenter, Hyun Kwon, David Airlie, Tom Rix,
llvm, Nick Desaulniers, Michal Simek, dri-devel,
Nathan Huckleberry, Nathan Chancellor, Laurent Pinchart,
linux-arm-kernel
The mode_valid field in drm_connector_helper_funcs is expected to be of
type
enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
struct drm_display_mode *mode);
The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.
The return type of zynqmp_dp_connector_mode_valid should be changed from
int to enum drm_mode_status.
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index d14612b34796..f571b08d23d3 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
return &dp->encoder;
}
-static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
- struct drm_display_mode *mode)
+static enum drm_mode_status
+zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
{
struct zynqmp_dp *dp = connector_to_dp(connector);
u8 max_lanes = dp->link_config.max_lanes;
--
2.37.2.789.g6183377224-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
2022-09-13 20:56 ` Nathan Huckleberry
(?)
@ 2022-09-13 23:21 ` Nathan Chancellor
-1 siblings, 0 replies; 13+ messages in thread
From: Nathan Chancellor @ 2022-09-13 23:21 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, llvm, Hyun Kwon, Laurent Pinchart, David Airlie,
Daniel Vetter, Michal Simek, Nick Desaulniers, Tom Rix,
dri-devel, linux-arm-kernel, linux-kernel
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
> --
> 2.37.2.789.g6183377224-goog
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-09-13 23:21 ` Nathan Chancellor
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Chancellor @ 2022-09-13 23:21 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, llvm, Hyun Kwon, Laurent Pinchart, David Airlie,
Daniel Vetter, Michal Simek, Nick Desaulniers, Tom Rix,
dri-devel, linux-arm-kernel, linux-kernel
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
> --
> 2.37.2.789.g6183377224-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-09-13 23:21 ` Nathan Chancellor
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Chancellor @ 2022-09-13 23:21 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, Hyun Kwon, David Airlie, Tom Rix, llvm,
Nick Desaulniers, Michal Simek, dri-devel, linux-kernel,
Laurent Pinchart, linux-arm-kernel
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
> --
> 2.37.2.789.g6183377224-goog
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
2022-09-13 20:56 ` Nathan Huckleberry
(?)
@ 2022-09-19 17:09 ` Laurent Pinchart
-1 siblings, 0 replies; 13+ messages in thread
From: Laurent Pinchart @ 2022-09-19 17:09 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, llvm, Hyun Kwon, David Airlie, Daniel Vetter,
Michal Simek, Nathan Chancellor, Nick Desaulniers, Tom Rix,
dri-devel, linux-arm-kernel, linux-kernel
Hi Nathan,
Thank you for the patch.
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
I'm not sure what forward edge kCFI is, but the fix looks good, so
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-09-19 17:09 ` Laurent Pinchart
0 siblings, 0 replies; 13+ messages in thread
From: Laurent Pinchart @ 2022-09-19 17:09 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, llvm, Hyun Kwon, David Airlie, Daniel Vetter,
Michal Simek, Nathan Chancellor, Nick Desaulniers, Tom Rix,
dri-devel, linux-arm-kernel, linux-kernel
Hi Nathan,
Thank you for the patch.
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
I'm not sure what forward edge kCFI is, but the fix looks good, so
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-09-19 17:09 ` Laurent Pinchart
0 siblings, 0 replies; 13+ messages in thread
From: Laurent Pinchart @ 2022-09-19 17:09 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, Hyun Kwon, David Airlie, Tom Rix, llvm,
Nick Desaulniers, Michal Simek, dri-devel, linux-kernel,
Nathan Chancellor, linux-arm-kernel
Hi Nathan,
Thank you for the patch.
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
I'm not sure what forward edge kCFI is, but the fix looks good, so
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
2022-09-13 20:56 ` Nathan Huckleberry
(?)
@ 2022-10-31 22:24 ` Nathan Chancellor
-1 siblings, 0 replies; 13+ messages in thread
From: Nathan Chancellor @ 2022-10-31 22:24 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, llvm, Hyun Kwon, Laurent Pinchart, David Airlie,
Daniel Vetter, Michal Simek, Nick Desaulniers, Tom Rix,
dri-devel, linux-arm-kernel, linux-kernel
Hi all,
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
> --
> 2.37.2.789.g6183377224-goog
>
>
Did this patch get lost somewhere? I do not see it picked up. It is
needed to avoid a new WIP warning from clang for catching these CFI
failures:
drivers/gpu/drm/xlnx/zynqmp_dp.c:1396:16: error: incompatible function pointer types initializing 'enum drm_mode_status (*)(struct drm_connector *, struct drm_display_mode *)' with an expression of type 'int (struct drm_connector *, struct drm_display_mode *)' [-Werror,-Wincompatible-function-pointer-types-strict]
.mode_valid = zynqmp_dp_connector_mode_valid,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-10-31 22:24 ` Nathan Chancellor
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Chancellor @ 2022-10-31 22:24 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, Hyun Kwon, David Airlie, Tom Rix, llvm,
Nick Desaulniers, Michal Simek, dri-devel, linux-kernel,
Laurent Pinchart, linux-arm-kernel
Hi all,
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
> --
> 2.37.2.789.g6183377224-goog
>
>
Did this patch get lost somewhere? I do not see it picked up. It is
needed to avoid a new WIP warning from clang for catching these CFI
failures:
drivers/gpu/drm/xlnx/zynqmp_dp.c:1396:16: error: incompatible function pointer types initializing 'enum drm_mode_status (*)(struct drm_connector *, struct drm_display_mode *)' with an expression of type 'int (struct drm_connector *, struct drm_display_mode *)' [-Werror,-Wincompatible-function-pointer-types-strict]
.mode_valid = zynqmp_dp_connector_mode_valid,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid
@ 2022-10-31 22:24 ` Nathan Chancellor
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Chancellor @ 2022-10-31 22:24 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, llvm, Hyun Kwon, Laurent Pinchart, David Airlie,
Daniel Vetter, Michal Simek, Nick Desaulniers, Tom Rix,
dri-devel, linux-arm-kernel, linux-kernel
Hi all,
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote:
> The mode_valid field in drm_connector_helper_funcs is expected to be of
> type
> enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
> struct drm_display_mode *mode);
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of zynqmp_dp_connector_mode_valid should be changed from
> int to enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index d14612b34796..f571b08d23d3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1352,8 +1352,9 @@ zynqmp_dp_connector_best_encoder(struct drm_connector *connector)
> return &dp->encoder;
> }
>
> -static int zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status
> +zynqmp_dp_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> {
> struct zynqmp_dp *dp = connector_to_dp(connector);
> u8 max_lanes = dp->link_config.max_lanes;
> --
> 2.37.2.789.g6183377224-goog
>
>
Did this patch get lost somewhere? I do not see it picked up. It is
needed to avoid a new WIP warning from clang for catching these CFI
failures:
drivers/gpu/drm/xlnx/zynqmp_dp.c:1396:16: error: incompatible function pointer types initializing 'enum drm_mode_status (*)(struct drm_connector *, struct drm_display_mode *)' with an expression of type 'int (struct drm_connector *, struct drm_display_mode *)' [-Werror,-Wincompatible-function-pointer-types-strict]
.mode_valid = zynqmp_dp_connector_mode_valid,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Cheers,
Nathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread