All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: yung-chuan.liao@linux.intel.com,
	pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
	linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com
Subject: Re: [PATCH v2 1/2] soundwire: qcom: update status from device id 1
Date: Tue, 20 Sep 2022 10:34:55 +0530	[thread overview]
Message-ID: <YylJ90Vu7SUhSNIo@matsya> (raw)
In-Reply-To: <20220916135352.19114-1-srinivas.kandagatla@linaro.org>

On 16-09-22, 14:53, Srinivas Kandagatla wrote:
> By default autoenumeration is enabled on QCom SoundWire controller
> which means the core should not be dealing with device 0 w.r.t enumeration.
> 
> During Enumeration if SoundWire core sees status[0] as SDW_SLAVE_ATTACHED and
> start programming the device id, however reading DEVID registers return zeros
> which does not match to any of the slaves in the list and the core attempts
> to park this device to Group 13.  This results in adding SoundWire device
> with enumeration address 0:0:0:0
> 
> Fix this by not passing device 0 status to SoundWire core.

Applied after fixing typi pointed by Pierre, thanks

Also, pls check, I got conflict which was resolved

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
	pierre-louis.bossart@linux.intel.com,
	linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com,
	yung-chuan.liao@linux.intel.com, quic_srivasam@quicinc.com
Subject: Re: [PATCH v2 1/2] soundwire: qcom: update status from device id 1
Date: Tue, 20 Sep 2022 10:34:55 +0530	[thread overview]
Message-ID: <YylJ90Vu7SUhSNIo@matsya> (raw)
In-Reply-To: <20220916135352.19114-1-srinivas.kandagatla@linaro.org>

On 16-09-22, 14:53, Srinivas Kandagatla wrote:
> By default autoenumeration is enabled on QCom SoundWire controller
> which means the core should not be dealing with device 0 w.r.t enumeration.
> 
> During Enumeration if SoundWire core sees status[0] as SDW_SLAVE_ATTACHED and
> start programming the device id, however reading DEVID registers return zeros
> which does not match to any of the slaves in the list and the core attempts
> to park this device to Group 13.  This results in adding SoundWire device
> with enumeration address 0:0:0:0
> 
> Fix this by not passing device 0 status to SoundWire core.

Applied after fixing typi pointed by Pierre, thanks

Also, pls check, I got conflict which was resolved

-- 
~Vinod

  parent reply	other threads:[~2022-09-20  5:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 13:53 [PATCH v2 1/2] soundwire: qcom: update status from device id 1 Srinivas Kandagatla
2022-09-16 13:53 ` Srinivas Kandagatla
2022-09-16 13:53 ` [PATCH v2 2/2] soundwire: qcom: do not send status of device 0 during alert Srinivas Kandagatla
2022-09-16 13:53   ` Srinivas Kandagatla
2022-09-16 14:22   ` Pierre-Louis Bossart
2022-09-16 14:22 ` [PATCH v2 1/2] soundwire: qcom: update status from device id 1 Pierre-Louis Bossart
2022-09-20  5:04 ` Vinod Koul [this message]
2022-09-20  5:04   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YylJ90Vu7SUhSNIo@matsya \
    --to=vkoul@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=quic_srivasam@quicinc.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.