All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list
@ 2022-10-06  5:34 Yonghong Song
  2022-10-06  7:27 ` Jiri Olsa
  2022-10-06 15:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Yonghong Song @ 2022-10-06  5:34 UTC (permalink / raw)
  To: bpf; +Cc: Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann, kernel-team

BPF CI reported that selftest deny_namespace failed with s390x.

  test_unpriv_userns_create_no_bpf:PASS:no-bpf unpriv new user ns 0 nsec
  test_deny_namespace:PASS:skel load 0 nsec
  libbpf: prog 'test_userns_create': failed to attach: ERROR: strerror_r(-524)=22
  libbpf: prog 'test_userns_create': failed to auto-attach: -524
  test_deny_namespace:FAIL:attach unexpected error: -524 (errno 524)
  #57/1    deny_namespace/unpriv_userns_create_no_bpf:FAIL
  #57      deny_namespace:FAIL

BPF program test_userns_create is a BPF LSM type program which is
based on trampoline and s390x does not support s390x. Let add the
test to x390x deny list to avoid this failure in BPF CI.

Signed-off-by: Yonghong Song <yhs@fb.com>
---
 tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
index 17e074eb42b8..0fb03b8047d5 100644
--- a/tools/testing/selftests/bpf/DENYLIST.s390x
+++ b/tools/testing/selftests/bpf/DENYLIST.s390x
@@ -75,3 +75,4 @@ user_ringbuf                             # failed to find kernel BTF type ID of
 lookup_key                               # JIT does not support calling kernel function                                (kfunc)
 verify_pkcs7_sig                         # JIT does not support calling kernel function                                (kfunc)
 kfunc_dynptr_param                       # JIT does not support calling kernel function                                (kfunc)
+deny_namespace                           # failed to attach: ERROR: strerror_r(-524)=22                                (trampoline)
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list
  2022-10-06  5:34 [PATCH bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list Yonghong Song
@ 2022-10-06  7:27 ` Jiri Olsa
  2022-10-06 15:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Jiri Olsa @ 2022-10-06  7:27 UTC (permalink / raw)
  To: Yonghong Song
  Cc: bpf, Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann, kernel-team

On Wed, Oct 05, 2022 at 10:34:29PM -0700, Yonghong Song wrote:
> BPF CI reported that selftest deny_namespace failed with s390x.
> 
>   test_unpriv_userns_create_no_bpf:PASS:no-bpf unpriv new user ns 0 nsec
>   test_deny_namespace:PASS:skel load 0 nsec
>   libbpf: prog 'test_userns_create': failed to attach: ERROR: strerror_r(-524)=22
>   libbpf: prog 'test_userns_create': failed to auto-attach: -524
>   test_deny_namespace:FAIL:attach unexpected error: -524 (errno 524)
>   #57/1    deny_namespace/unpriv_userns_create_no_bpf:FAIL
>   #57      deny_namespace:FAIL
> 
> BPF program test_userns_create is a BPF LSM type program which is
> based on trampoline and s390x does not support s390x. Let add the
> test to x390x deny list to avoid this failure in BPF CI.
> 
> Signed-off-by: Yonghong Song <yhs@fb.com>

lgtm

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
>  tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
> index 17e074eb42b8..0fb03b8047d5 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.s390x
> +++ b/tools/testing/selftests/bpf/DENYLIST.s390x
> @@ -75,3 +75,4 @@ user_ringbuf                             # failed to find kernel BTF type ID of
>  lookup_key                               # JIT does not support calling kernel function                                (kfunc)
>  verify_pkcs7_sig                         # JIT does not support calling kernel function                                (kfunc)
>  kfunc_dynptr_param                       # JIT does not support calling kernel function                                (kfunc)
> +deny_namespace                           # failed to attach: ERROR: strerror_r(-524)=22                                (trampoline)
> -- 
> 2.30.2
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list
  2022-10-06  5:34 [PATCH bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list Yonghong Song
  2022-10-06  7:27 ` Jiri Olsa
@ 2022-10-06 15:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-06 15:30 UTC (permalink / raw)
  To: Yonghong Song; +Cc: bpf, ast, andrii, daniel, kernel-team

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 5 Oct 2022 22:34:29 -0700 you wrote:
> BPF CI reported that selftest deny_namespace failed with s390x.
> 
>   test_unpriv_userns_create_no_bpf:PASS:no-bpf unpriv new user ns 0 nsec
>   test_deny_namespace:PASS:skel load 0 nsec
>   libbpf: prog 'test_userns_create': failed to attach: ERROR: strerror_r(-524)=22
>   libbpf: prog 'test_userns_create': failed to auto-attach: -524
>   test_deny_namespace:FAIL:attach unexpected error: -524 (errno 524)
>   #57/1    deny_namespace/unpriv_userns_create_no_bpf:FAIL
>   #57      deny_namespace:FAIL
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list
    https://git.kernel.org/bpf/bpf-next/c/8206e4e95230

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-06 15:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06  5:34 [PATCH bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list Yonghong Song
2022-10-06  7:27 ` Jiri Olsa
2022-10-06 15:30 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.