phosphor-buttons multihost control

phosphor-buttons multihost control

[zehra.ozdemir]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Hello,

 

There is an isMultiHost() method to control to return true in case the host
selector object is available in button-handler.cpp of the phosphor-buttons.
And if it is not available, it does not return false and the project gets an
error. So we covered this return line with try catch and it works. 

But my question is, does this host selector object has to be strictly
defined for the project to run properly?

 

Thanks.


[-- Attachment #2: Type: text/html, Size: 2067 bytes --]

Re: phosphor-buttons multihost control

[Naveen Moses]

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

The host Selector object is not strictly required. The host selector object
check was only added to identify if the system is single host or multi host
system based on host selector availability.
Thanks.

On Mon, Sep 26, 2022 at 12:58 PM <zehra.ozdemir@inventron.com.tr> wrote:

> Hello,
>
>
>
> There is an isMultiHost() method to control to return true in case the
> host selector object is available in button-handler.cpp of the
> phosphor-buttons. And if it is not available, it does not return false and
> the project gets an error. So we covered this return line with try catch
> and it works.
>
> But my question is, does this host selector object has to be strictly
> defined for the project to run properly?
>
>
>
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 1435 bytes --]

Re: phosphor-buttons multihost control

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

Hi Zehra,

On Mon, Sep 26, 2022 at 07:38:39PM +0530, Naveen Moses wrote:
> The host Selector object is not strictly required. The host selector object
> check was only added to identify if the system is single host or multi host
> system based on host selector availability.
> Thanks.
> 
> On Mon, Sep 26, 2022 at 12:58 PM <zehra.ozdemir@inventron.com.tr> wrote:
> 
> > Hello,
> >
> >
> >
> > There is an isMultiHost() method to control to return true in case the
> > host selector object is available in button-handler.cpp of the
> > phosphor-buttons. And if it is not available, it does not return false and
> > the project gets an error. So we covered this return line with try catch
> > and it works.

Based on what Naveen wrote, it would be helpful if you could submit a
change to improve the implementation to not have this issue.  I'm
surprised no one else has ran into the issues you are seeing.

> >
> > But my question is, does this host selector object has to be strictly
> > defined for the project to run properly?
> >
> >
> >
> > Thanks.
> >

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: phosphor-buttons multihost control

[Thang Nguyen OS]

[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]

Hi Zehra,
I think the issue of isMultiHost() has been resolved with https://github.com/openbmc/phosphor-buttons/commit/4250785723d92b6578176a2d961d47ab66e08124.

BR,
Thang Q. Nguyen

________________________________
From: openbmc <openbmc-bounces+thang=os.amperecomputing.com@lists.ozlabs.org> on behalf of Patrick Williams <patrick@stwcx.xyz>
Sent: Monday, September 26, 2022 11:27 PM
To: Naveen Moses <naveen.moses@hotmail.com>
Cc: zehra.ozdemir@inventron.com.tr <zehra.ozdemir@inventron.com.tr>; openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org>; M. Erhan Yigitbasi <erhan.yigitbasi@inventron.com.tr>; naveen.mosess@hcl.com <naveen.mosess@hcl.com>
Subject: Re: phosphor-buttons multihost control

Hi Zehra,

On Mon, Sep 26, 2022 at 07:38:39PM +0530, Naveen Moses wrote:
> The host Selector object is not strictly required. The host selector object
> check was only added to identify if the system is single host or multi host
> system based on host selector availability.
> Thanks.
>
> On Mon, Sep 26, 2022 at 12:58 PM <zehra.ozdemir@inventron.com.tr> wrote:
>
> > Hello,
> >
> >
> >
> > There is an isMultiHost() method to control to return true in case the
> > host selector object is available in button-handler.cpp of the
> > phosphor-buttons. And if it is not available, it does not return false and
> > the project gets an error. So we covered this return line with try catch
> > and it works.

Based on what Naveen wrote, it would be helpful if you could submit a
change to improve the implementation to not have this issue. I'm
surprised no one else has ran into the issues you are seeing.

> >
> > But my question is, does this host selector object has to be strictly
> > defined for the project to run properly?
> >
> >
> >
> > Thanks.
> >

--
Patrick Williams

[-- Attachment #2: Type: text/html, Size: 2878 bytes --]