From: Peter Xu <peterx@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Gavin Shan <gshan@redhat.com>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
catalin.marinas@arm.com, bgardon@google.com, shuah@kernel.org,
andrew.jones@linux.dev, will@kernel.org, dmatlack@google.com,
pbonzini@redhat.com, zhenyzha@redhat.com, shan.gavin@gmail.com,
james.morse@arm.com, suzuki.poulose@arm.com,
alexandru.elisei@arm.com, oliver.upton@linux.dev
Subject: Re: [PATCH v4 1/6] KVM: x86: Introduce KVM_REQ_RING_SOFT_FULL
Date: Tue, 27 Sep 2022 12:00:42 -0400 [thread overview]
Message-ID: <YzMeKgmJpUJFc7HJ@x1n> (raw)
In-Reply-To: <86y1u56rku.wl-maz@kernel.org>
On Tue, Sep 27, 2022 at 06:26:41AM -0400, Marc Zyngier wrote:
> > +static inline bool kvm_dirty_ring_check_request(struct kvm_vcpu *vcpu)
> > +{
> > + return false;
> > +}
> > +
>
> nit: I don't think this is needed at all. The dirty ring feature is
> not user-selectable, and this is always called from arch code that is
> fully aware of that option.
Agreed. With the change:
Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks,
--
Peter Xu
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, catalin.marinas@arm.com,
andrew.jones@linux.dev, will@kernel.org, shan.gavin@gmail.com,
bgardon@google.com, dmatlack@google.com, pbonzini@redhat.com,
zhenyzha@redhat.com, shuah@kernel.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v4 1/6] KVM: x86: Introduce KVM_REQ_RING_SOFT_FULL
Date: Tue, 27 Sep 2022 12:00:42 -0400 [thread overview]
Message-ID: <YzMeKgmJpUJFc7HJ@x1n> (raw)
In-Reply-To: <86y1u56rku.wl-maz@kernel.org>
On Tue, Sep 27, 2022 at 06:26:41AM -0400, Marc Zyngier wrote:
> > +static inline bool kvm_dirty_ring_check_request(struct kvm_vcpu *vcpu)
> > +{
> > + return false;
> > +}
> > +
>
> nit: I don't think this is needed at all. The dirty ring feature is
> not user-selectable, and this is always called from arch code that is
> fully aware of that option.
Agreed. With the change:
Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks,
--
Peter Xu
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-09-27 16:01 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 0:54 [PATCH v4 0/6] KVM: arm64: Enable ring-based dirty memory tracking Gavin Shan
2022-09-27 0:54 ` Gavin Shan
2022-09-27 0:54 ` [PATCH v4 1/6] KVM: x86: Introduce KVM_REQ_RING_SOFT_FULL Gavin Shan
2022-09-27 0:54 ` Gavin Shan
2022-09-27 10:26 ` Marc Zyngier
2022-09-27 10:26 ` Marc Zyngier
2022-09-27 11:31 ` Gavin Shan
2022-09-27 11:31 ` Gavin Shan
2022-09-27 16:00 ` Peter Xu [this message]
2022-09-27 16:00 ` Peter Xu
2022-09-27 0:54 ` [PATCH v4 2/6] KVM: x86: Move declaration of kvm_cpu_dirty_log_size() to kvm_dirty_ring.h Gavin Shan
2022-09-27 0:54 ` Gavin Shan
2022-09-27 16:00 ` Peter Xu
2022-09-27 16:00 ` Peter Xu
2022-09-27 0:54 ` [PATCH v4 3/6] KVM: arm64: Enable ring-based dirty memory tracking Gavin Shan
2022-09-27 0:54 ` Gavin Shan
2022-09-27 16:02 ` Peter Xu
2022-09-27 16:02 ` Peter Xu
2022-09-27 17:32 ` Marc Zyngier
2022-09-27 17:32 ` Marc Zyngier
2022-09-27 18:21 ` Peter Xu
2022-09-27 18:21 ` Peter Xu
2022-09-27 23:47 ` Gavin Shan
2022-09-27 23:47 ` Gavin Shan
2022-09-28 8:25 ` Marc Zyngier
2022-09-28 8:25 ` Marc Zyngier
2022-09-28 14:52 ` Peter Xu
2022-09-28 14:52 ` Peter Xu
2022-09-29 9:50 ` Gavin Shan
2022-09-29 9:50 ` Gavin Shan
2022-09-29 11:31 ` Gavin Shan
2022-09-29 11:31 ` Gavin Shan
2022-09-29 14:44 ` Marc Zyngier
2022-09-29 14:44 ` Marc Zyngier
2022-09-29 14:32 ` Peter Xu
2022-09-29 14:32 ` Peter Xu
2022-09-30 9:28 ` Marc Zyngier
2022-09-30 9:28 ` Marc Zyngier
2022-09-29 14:42 ` Marc Zyngier
2022-09-29 14:42 ` Marc Zyngier
2022-10-04 4:26 ` Gavin Shan
2022-10-04 4:26 ` Gavin Shan
2022-10-04 13:26 ` Peter Xu
2022-10-04 13:26 ` Peter Xu
2022-10-04 15:45 ` Marc Zyngier
2022-10-04 15:45 ` Marc Zyngier
2022-09-29 14:34 ` Marc Zyngier
2022-09-29 14:34 ` Marc Zyngier
2022-09-27 0:54 ` [PATCH v4 4/6] KVM: selftests: Use host page size to map ring buffer in dirty_log_test Gavin Shan
2022-09-27 0:54 ` Gavin Shan
2022-09-27 0:54 ` [PATCH v4 5/6] KVM: selftests: Clear dirty ring states between two modes " Gavin Shan
2022-09-27 0:54 ` Gavin Shan
2022-09-27 0:54 ` [PATCH v4 6/6] KVM: selftests: Automate choosing dirty ring size " Gavin Shan
2022-09-27 0:54 ` Gavin Shan
2022-09-27 10:30 ` [PATCH v4 0/6] KVM: arm64: Enable ring-based dirty memory tracking Marc Zyngier
2022-09-27 10:30 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzMeKgmJpUJFc7HJ@x1n \
--to=peterx@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=andrew.jones@linux.dev \
--cc=bgardon@google.com \
--cc=catalin.marinas@arm.com \
--cc=dmatlack@google.com \
--cc=gshan@redhat.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.