* [PATCH] cgroup: fix cgroup_get_from_id
@ 2022-09-23 11:51 ` Ming Lei
0 siblings, 0 replies; 10+ messages in thread
From: Ming Lei @ 2022-09-23 11:51 UTC (permalink / raw)
To: Tejun Heo, linux-kernel; +Cc: cgroups, Ming Lei, Marco Patalano, Muneendra
cgroup has to be one kernfs dir, otherwise kernel panic is caused,
especially cgroup id is provide from userspace.
Reported-by: Marco Patalano <mpatalan@redhat.com>
Fixes: 6b658c4863c1 ("scsi: cgroup: Add cgroup_get_from_id()")
Cc: Muneendra <muneendra.kumar@broadcom.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
kernel/cgroup/cgroup.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index e4bb5d57f4d1..5f2090d051ac 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -6049,6 +6049,9 @@ struct cgroup *cgroup_get_from_id(u64 id)
if (!kn)
goto out;
+ if (kernfs_type(kn) != KERNFS_DIR)
+ goto put;
+
rcu_read_lock();
cgrp = rcu_dereference(*(void __rcu __force **)&kn->priv);
@@ -6056,7 +6059,7 @@ struct cgroup *cgroup_get_from_id(u64 id)
cgrp = NULL;
rcu_read_unlock();
-
+put:
kernfs_put(kn);
out:
return cgrp;
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] cgroup: fix cgroup_get_from_id
@ 2022-09-23 11:51 ` Ming Lei
0 siblings, 0 replies; 10+ messages in thread
From: Ming Lei @ 2022-09-23 11:51 UTC (permalink / raw)
To: Tejun Heo, linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA, Ming Lei, Marco Patalano, Muneendra
cgroup has to be one kernfs dir, otherwise kernel panic is caused,
especially cgroup id is provide from userspace.
Reported-by: Marco Patalano <mpatalan-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Fixes: 6b658c4863c1 ("scsi: cgroup: Add cgroup_get_from_id()")
Cc: Muneendra <muneendra.kumar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Signed-off-by: Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
kernel/cgroup/cgroup.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index e4bb5d57f4d1..5f2090d051ac 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -6049,6 +6049,9 @@ struct cgroup *cgroup_get_from_id(u64 id)
if (!kn)
goto out;
+ if (kernfs_type(kn) != KERNFS_DIR)
+ goto put;
+
rcu_read_lock();
cgrp = rcu_dereference(*(void __rcu __force **)&kn->priv);
@@ -6056,7 +6059,7 @@ struct cgroup *cgroup_get_from_id(u64 id)
cgrp = NULL;
rcu_read_unlock();
-
+put:
kernfs_put(kn);
out:
return cgrp;
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] cgroup: fix cgroup_get_from_id
2022-09-23 11:51 ` Ming Lei
@ 2022-09-23 15:43 ` Mukesh Ojha
-1 siblings, 0 replies; 10+ messages in thread
From: Mukesh Ojha @ 2022-09-23 15:43 UTC (permalink / raw)
To: Ming Lei, Tejun Heo, linux-kernel; +Cc: cgroups, Marco Patalano, Muneendra
Hi,
On 9/23/2022 5:21 PM, Ming Lei wrote:
> cgroup has to be one kernfs dir, otherwise kernel panic is caused,
> especially cgroup id is provide from userspace.
>
> Reported-by: Marco Patalano <mpatalan@redhat.com>
> Fixes: 6b658c4863c1 ("scsi: cgroup: Add cgroup_get_from_id()")
> Cc: Muneendra <muneendra.kumar@broadcom.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> kernel/cgroup/cgroup.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index e4bb5d57f4d1..5f2090d051ac 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -6049,6 +6049,9 @@ struct cgroup *cgroup_get_from_id(u64 id)
> if (!kn)
> goto out;
>
> + if (kernfs_type(kn) != KERNFS_DIR)
> + goto put;
> +
> rcu_read_lock();
>
> cgrp = rcu_dereference(*(void __rcu __force **)&kn->priv);
> @@ -6056,7 +6059,7 @@ struct cgroup *cgroup_get_from_id(u64 id)
> cgrp = NULL;
>
> rcu_read_unlock();
> -
> +put:
> kernfs_put(kn);
> out:
> return cgrp;
Good catch.
Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] cgroup: fix cgroup_get_from_id
@ 2022-09-23 15:43 ` Mukesh Ojha
0 siblings, 0 replies; 10+ messages in thread
From: Mukesh Ojha @ 2022-09-23 15:43 UTC (permalink / raw)
To: Ming Lei, Tejun Heo, linux-kernel; +Cc: cgroups, Marco Patalano, Muneendra
Hi,
On 9/23/2022 5:21 PM, Ming Lei wrote:
> cgroup has to be one kernfs dir, otherwise kernel panic is caused,
> especially cgroup id is provide from userspace.
>
> Reported-by: Marco Patalano <mpatalan@redhat.com>
> Fixes: 6b658c4863c1 ("scsi: cgroup: Add cgroup_get_from_id()")
> Cc: Muneendra <muneendra.kumar@broadcom.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> kernel/cgroup/cgroup.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index e4bb5d57f4d1..5f2090d051ac 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -6049,6 +6049,9 @@ struct cgroup *cgroup_get_from_id(u64 id)
> if (!kn)
> goto out;
>
> + if (kernfs_type(kn) != KERNFS_DIR)
> + goto put;
> +
> rcu_read_lock();
>
> cgrp = rcu_dereference(*(void __rcu __force **)&kn->priv);
> @@ -6056,7 +6059,7 @@ struct cgroup *cgroup_get_from_id(u64 id)
> cgrp = NULL;
>
> rcu_read_unlock();
> -
> +put:
> kernfs_put(kn);
> out:
> return cgrp;
Good catch.
Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] cgroup: fix cgroup_get_from_id
@ 2022-09-23 17:29 ` Tejun Heo
0 siblings, 0 replies; 10+ messages in thread
From: Tejun Heo @ 2022-09-23 17:29 UTC (permalink / raw)
To: Ming Lei; +Cc: linux-kernel, cgroups, Marco Patalano, Muneendra
On Fri, Sep 23, 2022 at 07:51:19PM +0800, Ming Lei wrote:
> cgroup has to be one kernfs dir, otherwise kernel panic is caused,
> especially cgroup id is provide from userspace.
>
> Reported-by: Marco Patalano <mpatalan@redhat.com>
> Fixes: 6b658c4863c1 ("scsi: cgroup: Add cgroup_get_from_id()")
> Cc: Muneendra <muneendra.kumar@broadcom.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Applied to cgroup/for-6.0-fixes with the subject changed to "cgroup:
cgroup_get_from_id() must check the looked-up kn is a directory" and stable
cc'd.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] cgroup: fix cgroup_get_from_id
@ 2022-09-23 17:29 ` Tejun Heo
0 siblings, 0 replies; 10+ messages in thread
From: Tejun Heo @ 2022-09-23 17:29 UTC (permalink / raw)
To: Ming Lei
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
cgroups-u79uwXL29TY76Z2rM5mHXA, Marco Patalano, Muneendra
On Fri, Sep 23, 2022 at 07:51:19PM +0800, Ming Lei wrote:
> cgroup has to be one kernfs dir, otherwise kernel panic is caused,
> especially cgroup id is provide from userspace.
>
> Reported-by: Marco Patalano <mpatalan-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Fixes: 6b658c4863c1 ("scsi: cgroup: Add cgroup_get_from_id()")
> Cc: Muneendra <muneendra.kumar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Applied to cgroup/for-6.0-fixes with the subject changed to "cgroup:
cgroup_get_from_id() must check the looked-up kn is a directory" and stable
cc'd.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH cgroup/for-6.1] cgroup: Make cgroup_get_from_id() prettier
@ 2022-09-23 17:31 ` Tejun Heo
0 siblings, 0 replies; 10+ messages in thread
From: Tejun Heo @ 2022-09-23 17:31 UTC (permalink / raw)
To: Ming Lei
Cc: linux-kernel, cgroups, Marco Patalano, Muneendra, Michal Koutný
From 7e1eb5437d3c3fdb61d45378579aab383cafc694 Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Fri, 23 Sep 2022 07:23:06 -1000
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
After merging 836ac87d ("cgroup: fix cgroup_get_from_id") into for-6.1, its
combination with two commits in for-6.1 - 4534dee9 ("cgroup: cgroup: Honor
caller's cgroup NS when resolving cgroup id") and fa7e439c ("cgroup:
Homogenize cgroup_get_from_id() return value") - makes the gotos in the
error handling path too ugly while not adding anything of value.
All that the gotos are saving is one extra kernfs_put() call. Let's remove
the gotos and perform error returns directly.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Michal Koutný <mkoutny@suse.com>
---
Hello,
Ming, Michal, you guys' changes to cgroup_get_from_id() combine to make
cgroup_get_from_id() a bit too ugly, so I applied the following patch to
cgroup/for-6.1. Please take a look and lemme know if I broke anything.
Thanks.
kernel/cgroup/cgroup.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 0d93cd17548c..c1f1ef6090da 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -6066,14 +6066,16 @@ void cgroup_path_from_kernfs_id(u64 id, char *buf, size_t buflen)
struct cgroup *cgroup_get_from_id(u64 id)
{
struct kernfs_node *kn;
- struct cgroup *cgrp = NULL, *root_cgrp;
+ struct cgroup *cgrp, *root_cgrp;
kn = kernfs_find_and_get_node_by_id(cgrp_dfl_root.kf_root, id);
if (!kn)
- goto out;
+ return ERR_PTR(-ENOENT);
- if (kernfs_type(kn) != KERNFS_DIR)
- goto put;
+ if (kernfs_type(kn) != KERNFS_DIR) {
+ kernfs_put(kn);
+ return ERR_PTR(-ENOENT);
+ }
rcu_read_lock();
@@ -6082,21 +6084,20 @@ struct cgroup *cgroup_get_from_id(u64 id)
cgrp = NULL;
rcu_read_unlock();
-put:
kernfs_put(kn);
if (!cgrp)
- goto out;
+ return ERR_PTR(-ENOENT);
spin_lock_irq(&css_set_lock);
root_cgrp = current_cgns_cgroup_from_root(&cgrp_dfl_root);
spin_unlock_irq(&css_set_lock);
if (!cgroup_is_descendant(cgrp, root_cgrp)) {
cgroup_put(cgrp);
- cgrp = NULL;
+ return ERR_PTR(-ENOENT);
}
-out:
- return cgrp ?: ERR_PTR(-ENOENT);
+
+ return cgrp;
}
EXPORT_SYMBOL_GPL(cgroup_get_from_id);
--
2.37.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH cgroup/for-6.1] cgroup: Make cgroup_get_from_id() prettier
@ 2022-09-23 17:31 ` Tejun Heo
0 siblings, 0 replies; 10+ messages in thread
From: Tejun Heo @ 2022-09-23 17:31 UTC (permalink / raw)
To: Ming Lei
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
cgroups-u79uwXL29TY76Z2rM5mHXA, Marco Patalano, Muneendra,
Michal Koutný
From 7e1eb5437d3c3fdb61d45378579aab383cafc694 Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Date: Fri, 23 Sep 2022 07:23:06 -1000
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
After merging 836ac87d ("cgroup: fix cgroup_get_from_id") into for-6.1, its
combination with two commits in for-6.1 - 4534dee9 ("cgroup: cgroup: Honor
caller's cgroup NS when resolving cgroup id") and fa7e439c ("cgroup:
Homogenize cgroup_get_from_id() return value") - makes the gotos in the
error handling path too ugly while not adding anything of value.
All that the gotos are saving is one extra kernfs_put() call. Let's remove
the gotos and perform error returns directly.
Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Michal Koutný <mkoutny-IBi9RG/b67k@public.gmane.org>
---
Hello,
Ming, Michal, you guys' changes to cgroup_get_from_id() combine to make
cgroup_get_from_id() a bit too ugly, so I applied the following patch to
cgroup/for-6.1. Please take a look and lemme know if I broke anything.
Thanks.
kernel/cgroup/cgroup.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 0d93cd17548c..c1f1ef6090da 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -6066,14 +6066,16 @@ void cgroup_path_from_kernfs_id(u64 id, char *buf, size_t buflen)
struct cgroup *cgroup_get_from_id(u64 id)
{
struct kernfs_node *kn;
- struct cgroup *cgrp = NULL, *root_cgrp;
+ struct cgroup *cgrp, *root_cgrp;
kn = kernfs_find_and_get_node_by_id(cgrp_dfl_root.kf_root, id);
if (!kn)
- goto out;
+ return ERR_PTR(-ENOENT);
- if (kernfs_type(kn) != KERNFS_DIR)
- goto put;
+ if (kernfs_type(kn) != KERNFS_DIR) {
+ kernfs_put(kn);
+ return ERR_PTR(-ENOENT);
+ }
rcu_read_lock();
@@ -6082,21 +6084,20 @@ struct cgroup *cgroup_get_from_id(u64 id)
cgrp = NULL;
rcu_read_unlock();
-put:
kernfs_put(kn);
if (!cgrp)
- goto out;
+ return ERR_PTR(-ENOENT);
spin_lock_irq(&css_set_lock);
root_cgrp = current_cgns_cgroup_from_root(&cgrp_dfl_root);
spin_unlock_irq(&css_set_lock);
if (!cgroup_is_descendant(cgrp, root_cgrp)) {
cgroup_put(cgrp);
- cgrp = NULL;
+ return ERR_PTR(-ENOENT);
}
-out:
- return cgrp ?: ERR_PTR(-ENOENT);
+
+ return cgrp;
}
EXPORT_SYMBOL_GPL(cgroup_get_from_id);
--
2.37.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH cgroup/for-6.1] cgroup: Make cgroup_get_from_id() prettier
@ 2022-09-28 11:38 ` Michal Koutný
0 siblings, 0 replies; 10+ messages in thread
From: Michal Koutný @ 2022-09-28 11:38 UTC (permalink / raw)
To: Tejun Heo; +Cc: Ming Lei, linux-kernel, cgroups, Marco Patalano, Muneendra
On Fri, Sep 23, 2022 at 07:31:58AM -1000, Tejun Heo <tj@kernel.org> wrote:
> Ming, Michal, you guys' changes to cgroup_get_from_id() combine to make
> cgroup_get_from_id() a bit too ugly, so I applied the following patch to
> cgroup/for-6.1. Please take a look and lemme know if I broke anything.
The cleanup looks good.
Just for the record, I understand the refernced fix is persisted as
> df02452f3df0 ("cgroup: cgroup_get_from_id() must check the looked-up kn is a directory")
Regards,
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH cgroup/for-6.1] cgroup: Make cgroup_get_from_id() prettier
@ 2022-09-28 11:38 ` Michal Koutný
0 siblings, 0 replies; 10+ messages in thread
From: Michal Koutný @ 2022-09-28 11:38 UTC (permalink / raw)
To: Tejun Heo
Cc: Ming Lei, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
cgroups-u79uwXL29TY76Z2rM5mHXA, Marco Patalano, Muneendra
On Fri, Sep 23, 2022 at 07:31:58AM -1000, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Ming, Michal, you guys' changes to cgroup_get_from_id() combine to make
> cgroup_get_from_id() a bit too ugly, so I applied the following patch to
> cgroup/for-6.1. Please take a look and lemme know if I broke anything.
The cleanup looks good.
Just for the record, I understand the refernced fix is persisted as
> df02452f3df0 ("cgroup: cgroup_get_from_id() must check the looked-up kn is a directory")
Regards,
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-09-28 11:38 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 11:51 [PATCH] cgroup: fix cgroup_get_from_id Ming Lei
2022-09-23 11:51 ` Ming Lei
2022-09-23 15:43 ` Mukesh Ojha
2022-09-23 15:43 ` Mukesh Ojha
2022-09-23 17:29 ` Tejun Heo
2022-09-23 17:29 ` Tejun Heo
2022-09-23 17:31 ` [PATCH cgroup/for-6.1] cgroup: Make cgroup_get_from_id() prettier Tejun Heo
2022-09-23 17:31 ` Tejun Heo
2022-09-28 11:38 ` Michal Koutný
2022-09-28 11:38 ` Michal Koutný
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.