All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
@ 2022-09-26 13:03 ` Jing Zhang
  0 siblings, 0 replies; 8+ messages in thread
From: Jing Zhang @ 2022-09-26 13:03 UTC (permalink / raw)
  To: linux-arm-kernel, linux-perf-users, linux-kernel
  Cc: john.garry, will, james.clark, mike.leach, leo.yan, peterz,
	mingo, acme, mark.rutland, alexander.shishkin, jolsa, namhyung,
	german.gomez, timothy.hayes, alisaidi, xueshuai, zhuo.song,
	renyu.zj

When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
arm-spe: Use SPE data source for neoverse cores") augment the type with
source information by MIDR. However, is_midr_in_range only compares the
first entry in neoverse_spe.

Change is_midr_in_range to is_midr_in_range_list to traverse the
neoverse_spe array so that all neoverse cores synthesize event with data
source packet.

Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
---
 tools/perf/util/arm-spe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
index 22dcfe0..906476a 100644
--- a/tools/perf/util/arm-spe.c
+++ b/tools/perf/util/arm-spe.c
@@ -498,7 +498,7 @@ static void arm_spe__synth_data_source_generic(const struct arm_spe_record *reco
 static u64 arm_spe__synth_data_source(const struct arm_spe_record *record, u64 midr)
 {
 	union perf_mem_data_src	data_src = { 0 };
-	bool is_neoverse = is_midr_in_range(midr, neoverse_spe);
+	bool is_neoverse = is_midr_in_range_list(midr, neoverse_spe);
 
 	if (record->op == ARM_SPE_LD)
 		data_src.mem_op = PERF_MEM_OP_LOAD;
-- 
1.8.3.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
@ 2022-09-26 13:03 ` Jing Zhang
  0 siblings, 0 replies; 8+ messages in thread
From: Jing Zhang @ 2022-09-26 13:03 UTC (permalink / raw)
  To: linux-arm-kernel, linux-perf-users, linux-kernel
  Cc: john.garry, will, james.clark, mike.leach, leo.yan, peterz,
	mingo, acme, mark.rutland, alexander.shishkin, jolsa, namhyung,
	german.gomez, timothy.hayes, alisaidi, xueshuai, zhuo.song,
	renyu.zj

When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
arm-spe: Use SPE data source for neoverse cores") augment the type with
source information by MIDR. However, is_midr_in_range only compares the
first entry in neoverse_spe.

Change is_midr_in_range to is_midr_in_range_list to traverse the
neoverse_spe array so that all neoverse cores synthesize event with data
source packet.

Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
---
 tools/perf/util/arm-spe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
index 22dcfe0..906476a 100644
--- a/tools/perf/util/arm-spe.c
+++ b/tools/perf/util/arm-spe.c
@@ -498,7 +498,7 @@ static void arm_spe__synth_data_source_generic(const struct arm_spe_record *reco
 static u64 arm_spe__synth_data_source(const struct arm_spe_record *record, u64 midr)
 {
 	union perf_mem_data_src	data_src = { 0 };
-	bool is_neoverse = is_midr_in_range(midr, neoverse_spe);
+	bool is_neoverse = is_midr_in_range_list(midr, neoverse_spe);
 
 	if (record->op == ARM_SPE_LD)
 		data_src.mem_op = PERF_MEM_OP_LOAD;
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
  2022-09-26 13:03 ` Jing Zhang
@ 2022-09-26 14:10   ` Ali Saidi
  -1 siblings, 0 replies; 8+ messages in thread
From: Ali Saidi @ 2022-09-26 14:10 UTC (permalink / raw)
  To: renyu.zj
  Cc: acme, alexander.shishkin, alisaidi, german.gomez, james.clark,
	john.garry, jolsa, leo.yan, linux-arm-kernel, linux-kernel,
	linux-perf-users, mark.rutland, mike.leach, mingo, namhyung,
	peterz, timothy.hayes, will, xueshuai, zhuo.song

> When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> arm-spe: Use SPE data source for neoverse cores") augment the type with
> source information by MIDR. However, is_midr_in_range only compares the
> first entry in neoverse_spe.
> 
> Change is_midr_in_range to is_midr_in_range_list to traverse the
> neoverse_spe array so that all neoverse cores synthesize event with data
> source packet.
> 
> Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>

Thanks for catching this, you're absolutely right.

Reviewed-by: Ali Saidi <alisaidi@amazon.com>

Ali


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
@ 2022-09-26 14:10   ` Ali Saidi
  0 siblings, 0 replies; 8+ messages in thread
From: Ali Saidi @ 2022-09-26 14:10 UTC (permalink / raw)
  To: renyu.zj
  Cc: acme, alexander.shishkin, alisaidi, german.gomez, james.clark,
	john.garry, jolsa, leo.yan, linux-arm-kernel, linux-kernel,
	linux-perf-users, mark.rutland, mike.leach, mingo, namhyung,
	peterz, timothy.hayes, will, xueshuai, zhuo.song

> When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> arm-spe: Use SPE data source for neoverse cores") augment the type with
> source information by MIDR. However, is_midr_in_range only compares the
> first entry in neoverse_spe.
> 
> Change is_midr_in_range to is_midr_in_range_list to traverse the
> neoverse_spe array so that all neoverse cores synthesize event with data
> source packet.
> 
> Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>

Thanks for catching this, you're absolutely right.

Reviewed-by: Ali Saidi <alisaidi@amazon.com>

Ali


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
  2022-09-26 14:10   ` Ali Saidi
@ 2022-09-26 15:00     ` Leo Yan
  -1 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2022-09-26 15:00 UTC (permalink / raw)
  To: Ali Saidi
  Cc: renyu.zj, acme, alexander.shishkin, german.gomez, james.clark,
	john.garry, jolsa, linux-arm-kernel, linux-kernel,
	linux-perf-users, mark.rutland, mike.leach, mingo, namhyung,
	peterz, timothy.hayes, will, xueshuai, zhuo.song

On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > source information by MIDR. However, is_midr_in_range only compares the
> > first entry in neoverse_spe.
> > 
> > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > neoverse_spe array so that all neoverse cores synthesize event with data
> > source packet.
> > 
> > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> 
> Thanks for catching this, you're absolutely right.
> 
> Reviewed-by: Ali Saidi <alisaidi@amazon.com>

It's also good for me:
Reviewed-by: Leo Yan <leo.yan@linaro.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
@ 2022-09-26 15:00     ` Leo Yan
  0 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2022-09-26 15:00 UTC (permalink / raw)
  To: Ali Saidi
  Cc: renyu.zj, acme, alexander.shishkin, german.gomez, james.clark,
	john.garry, jolsa, linux-arm-kernel, linux-kernel,
	linux-perf-users, mark.rutland, mike.leach, mingo, namhyung,
	peterz, timothy.hayes, will, xueshuai, zhuo.song

On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > source information by MIDR. However, is_midr_in_range only compares the
> > first entry in neoverse_spe.
> > 
> > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > neoverse_spe array so that all neoverse cores synthesize event with data
> > source packet.
> > 
> > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> 
> Thanks for catching this, you're absolutely right.
> 
> Reviewed-by: Ali Saidi <alisaidi@amazon.com>

It's also good for me:
Reviewed-by: Leo Yan <leo.yan@linaro.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
  2022-09-26 15:00     ` Leo Yan
@ 2022-09-28 14:20       ` Arnaldo Carvalho de Melo
  -1 siblings, 0 replies; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-09-28 14:20 UTC (permalink / raw)
  To: Leo Yan
  Cc: Ali Saidi, renyu.zj, alexander.shishkin, german.gomez,
	james.clark, john.garry, jolsa, linux-arm-kernel, linux-kernel,
	linux-perf-users, mark.rutland, mike.leach, mingo, namhyung,
	peterz, timothy.hayes, will, xueshuai, zhuo.song

Em Mon, Sep 26, 2022 at 11:00:31PM +0800, Leo Yan escreveu:
> On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > > source information by MIDR. However, is_midr_in_range only compares the
> > > first entry in neoverse_spe.
> > > 
> > > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > > neoverse_spe array so that all neoverse cores synthesize event with data
> > > source packet.
> > > 
> > > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> > 
> > Thanks for catching this, you're absolutely right.
> > 
> > Reviewed-by: Ali Saidi <alisaidi@amazon.com>
> 
> It's also good for me:
> Reviewed-by: Leo Yan <leo.yan@linaro.org>

Thanks, applied.

- Arnaldo


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
@ 2022-09-28 14:20       ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-09-28 14:20 UTC (permalink / raw)
  To: Leo Yan
  Cc: Ali Saidi, renyu.zj, alexander.shishkin, german.gomez,
	james.clark, john.garry, jolsa, linux-arm-kernel, linux-kernel,
	linux-perf-users, mark.rutland, mike.leach, mingo, namhyung,
	peterz, timothy.hayes, will, xueshuai, zhuo.song

Em Mon, Sep 26, 2022 at 11:00:31PM +0800, Leo Yan escreveu:
> On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > > source information by MIDR. However, is_midr_in_range only compares the
> > > first entry in neoverse_spe.
> > > 
> > > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > > neoverse_spe array so that all neoverse cores synthesize event with data
> > > source packet.
> > > 
> > > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> > 
> > Thanks for catching this, you're absolutely right.
> > 
> > Reviewed-by: Ali Saidi <alisaidi@amazon.com>
> 
> It's also good for me:
> Reviewed-by: Leo Yan <leo.yan@linaro.org>

Thanks, applied.

- Arnaldo


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-28 14:21 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 13:03 [PATCH] perf arm-spe: augment the data source type with neoverse_spe list Jing Zhang
2022-09-26 13:03 ` Jing Zhang
2022-09-26 14:10 ` Ali Saidi
2022-09-26 14:10   ` Ali Saidi
2022-09-26 15:00   ` Leo Yan
2022-09-26 15:00     ` Leo Yan
2022-09-28 14:20     ` Arnaldo Carvalho de Melo
2022-09-28 14:20       ` Arnaldo Carvalho de Melo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.