* [PATCH] perf test: Fix test case 87 ("perf record tests") for hybrid systems
@ 2022-09-27 5:15 zhengjun.xing
2022-09-28 14:28 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: zhengjun.xing @ 2022-09-27 5:15 UTC (permalink / raw)
To: acme, peterz, mingo, alexander.shishkin, jolsa, namhyung
Cc: linux-kernel, linux-perf-users, irogers, ak, kan.liang, zhengjun.xing
From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
The test case 87 ("perf record tests") failed on hybrid systems,the event
"cpu/br_inst_retired.near_call/p" is only for non-hybrid system. Correct
the test event to support both non-hybrid and hybrid systems.
Before:
# ./perf test 87
87: perf record tests : FAILED!
After:
# ./perf test 87
87: perf record tests : Ok
Fixes: 24f378e66021 ("perf test: Add basic perf record tests")
Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
---
tools/perf/tests/shell/record.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 00c7285ce1ac..301f95427159 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -61,7 +61,7 @@ test_register_capture() {
echo "Register capture test [Skipped missing registers]"
return
fi
- if ! perf record -o - --intr-regs=di,r8,dx,cx -e cpu/br_inst_retired.near_call/p \
+ if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p \
-c 1000 --per-thread true 2> /dev/null \
| perf script -F ip,sym,iregs -i - 2> /dev/null \
| egrep -q "DI:"
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf test: Fix test case 87 ("perf record tests") for hybrid systems
2022-09-27 5:15 [PATCH] perf test: Fix test case 87 ("perf record tests") for hybrid systems zhengjun.xing
@ 2022-09-28 14:28 ` Arnaldo Carvalho de Melo
2022-09-29 2:11 ` Ian Rogers
0 siblings, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-09-28 14:28 UTC (permalink / raw)
To: zhengjun.xing, Ian Rogers
Cc: peterz, mingo, alexander.shishkin, jolsa, namhyung, linux-kernel,
linux-perf-users, ak, kan.liang
Em Tue, Sep 27, 2022 at 01:15:13PM +0800, zhengjun.xing@linux.intel.com escreveu:
> From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>
> The test case 87 ("perf record tests") failed on hybrid systems,the event
> "cpu/br_inst_retired.near_call/p" is only for non-hybrid system. Correct
> the test event to support both non-hybrid and hybrid systems.
>
> Before:
> # ./perf test 87
> 87: perf record tests : FAILED!
>
> After:
> # ./perf test 87
> 87: perf record tests : Ok
Looks sane, applied.
Ian, consider providing your Acked-by,
- Arnaldo
> Fixes: 24f378e66021 ("perf test: Add basic perf record tests")
> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> ---
> tools/perf/tests/shell/record.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 00c7285ce1ac..301f95427159 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -61,7 +61,7 @@ test_register_capture() {
> echo "Register capture test [Skipped missing registers]"
> return
> fi
> - if ! perf record -o - --intr-regs=di,r8,dx,cx -e cpu/br_inst_retired.near_call/p \
> + if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p \
> -c 1000 --per-thread true 2> /dev/null \
> | perf script -F ip,sym,iregs -i - 2> /dev/null \
> | egrep -q "DI:"
> --
> 2.25.1
--
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf test: Fix test case 87 ("perf record tests") for hybrid systems
2022-09-28 14:28 ` Arnaldo Carvalho de Melo
@ 2022-09-29 2:11 ` Ian Rogers
2022-09-29 12:53 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2022-09-29 2:11 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: zhengjun.xing, peterz, mingo, alexander.shishkin, jolsa,
namhyung, linux-kernel, linux-perf-users, ak, kan.liang
On Wed, Sep 28, 2022 at 7:28 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Tue, Sep 27, 2022 at 01:15:13PM +0800, zhengjun.xing@linux.intel.com escreveu:
> > From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> >
> > The test case 87 ("perf record tests") failed on hybrid systems,the event
> > "cpu/br_inst_retired.near_call/p" is only for non-hybrid system. Correct
> > the test event to support both non-hybrid and hybrid systems.
> >
> > Before:
> > # ./perf test 87
> > 87: perf record tests : FAILED!
> >
> > After:
> > # ./perf test 87
> > 87: perf record tests : Ok
>
> Looks sane, applied.
>
> Ian, consider providing your Acked-by,
>
> - Arnaldo
Acked-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
>
> > Fixes: 24f378e66021 ("perf test: Add basic perf record tests")
> > Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> > ---
> > tools/perf/tests/shell/record.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> > index 00c7285ce1ac..301f95427159 100755
> > --- a/tools/perf/tests/shell/record.sh
> > +++ b/tools/perf/tests/shell/record.sh
> > @@ -61,7 +61,7 @@ test_register_capture() {
> > echo "Register capture test [Skipped missing registers]"
> > return
> > fi
> > - if ! perf record -o - --intr-regs=di,r8,dx,cx -e cpu/br_inst_retired.near_call/p \
> > + if ! perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p \
> > -c 1000 --per-thread true 2> /dev/null \
> > | perf script -F ip,sym,iregs -i - 2> /dev/null \
> > | egrep -q "DI:"
> > --
> > 2.25.1
>
> --
>
> - Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf test: Fix test case 87 ("perf record tests") for hybrid systems
2022-09-29 2:11 ` Ian Rogers
@ 2022-09-29 12:53 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-09-29 12:53 UTC (permalink / raw)
To: Ian Rogers
Cc: zhengjun.xing, peterz, mingo, alexander.shishkin, jolsa,
namhyung, linux-kernel, linux-perf-users, ak, kan.liang
Em Wed, Sep 28, 2022 at 07:11:15PM -0700, Ian Rogers escreveu:
> On Wed, Sep 28, 2022 at 7:28 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Tue, Sep 27, 2022 at 01:15:13PM +0800, zhengjun.xing@linux.intel.com escreveu:
> > > From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> > >
> > > The test case 87 ("perf record tests") failed on hybrid systems,the event
> > > "cpu/br_inst_retired.near_call/p" is only for non-hybrid system. Correct
> > > the test event to support both non-hybrid and hybrid systems.
> > >
> > > Before:
> > > # ./perf test 87
> > > 87: perf record tests : FAILED!
> > >
> > > After:
> > > # ./perf test 87
> > > 87: perf record tests : Ok
> >
> > Looks sane, applied.
> >
> > Ian, consider providing your Acked-by,
> Acked-by: Ian Rogers <irogers@google.com>
Thanks, added.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-29 12:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 5:15 [PATCH] perf test: Fix test case 87 ("perf record tests") for hybrid systems zhengjun.xing
2022-09-28 14:28 ` Arnaldo Carvalho de Melo
2022-09-29 2:11 ` Ian Rogers
2022-09-29 12:53 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.