All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
@ 2022-09-18 22:15 Jake Freeland
  2022-09-18 23:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Jake Freeland @ 2022-09-18 22:15 UTC (permalink / raw)
  To: igt-dev; +Cc: Jake Freeland

Signed-off-by: Jake Freeland <jfree@freebsd.org>
---
 lib/i915/gem_mman.c          |  4 ++--
 lib/igt_vgem.c               |  2 +-
 tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
 tests/i915/gem_mmap_offset.c | 14 +++++++-------
 4 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
index aa9ac6f3..0b41ba70 100644
--- a/lib/i915/gem_mman.c
+++ b/lib/i915/gem_mman.c
@@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
 	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
 	else
@@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
 	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
 
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
index 7f933b23..468383c7 100644
--- a/lib/igt_vgem.c
+++ b/lib/igt_vgem.c
@@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo, unsigned prot)
 	if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
 		return NULL;
 
-	ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
+	ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
 	if (ptr == MAP_FAILED)
 		return NULL;
 
diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index 4f05eb18..683eaf16 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -113,11 +113,11 @@ test_access(int fd)
 	mmap_arg.handle = handle;
 	do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
 
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd, mmap_arg.offset));
 
 	/* Check that the same offset on the other fd doesn't work. */
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
 	igt_assert(errno == EACCES);
 
@@ -128,7 +128,7 @@ test_access(int fd)
 
 	/* Recheck that it works after flink. */
 	/* Check that the same offset on the other fd doesn't work. */
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd2, mmap_arg.offset));
 }
 
@@ -159,11 +159,11 @@ test_short(int fd)
 	for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
 		uint8_t *r, *w;
 
-		w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
+		w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
 			   MAP_SHARED, fd, mmap_arg.offset);
 		igt_assert(w != MAP_FAILED);
 
-		r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
+		r = mmap(0, pages * PAGE_SIZE, PROT_READ,
 			   MAP_SHARED, fd, mmap_arg.offset);
 		igt_assert(r != MAP_FAILED);
 
@@ -384,13 +384,13 @@ test_isolation(int i915)
 
 	close(B);
 
-	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 	igt_assert(ptr != MAP_FAILED);
 	munmap(ptr, 4096);
 
 	close(A);
 
-	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 	igt_assert(ptr == MAP_FAILED);
 }
 
@@ -400,7 +400,7 @@ test_close_race(int i915)
 	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 	_Atomic uint32_t *handles;
 
-	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -418,7 +418,7 @@ test_close_race(int i915)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, i915,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
@@ -444,7 +444,7 @@ test_flink_race(int i915)
 	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 	_Atomic uint32_t *handles;
 
-	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -469,7 +469,7 @@ test_flink_race(int i915)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, fd,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
index 5781b2fb..0933ed94 100644
--- a/tests/i915/gem_mmap_offset.c
+++ b/tests/i915/gem_mmap_offset.c
@@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t offset, uint64_t size,
 	if (mmap_offset_ioctl(i915, &arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
 	else
@@ -214,12 +214,12 @@ static void isolation(int i915)
 			 t->name, B, b, offset_b);
 
 		errno = 0;
-		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
+		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
 		igt_assert(ptr == MAP_FAILED);
 		igt_assert_eq(errno, EACCES);
 
 		errno = 0;
-		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
+		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
 		igt_assert(ptr == MAP_FAILED);
 		igt_assert_eq(errno, EACCES);
 
@@ -237,13 +237,13 @@ static void isolation(int i915)
 
 		close(B);
 
-		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 		igt_assert(ptr != MAP_FAILED);
 		munmap(ptr, 4096);
 
 		close(A);
 
-		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 		igt_assert(ptr == MAP_FAILED);
 	}
 }
@@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
 	_Atomic uint32_t *handles;
 	size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
 
-	handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, i915,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
-- 
2.37.3

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Replaced instances of mmap64() with mmap()
  2022-09-18 22:15 [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap() Jake Freeland
@ 2022-09-18 23:51 ` Patchwork
  2022-09-19  1:27 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  2022-09-28 12:33 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
  2 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-09-18 23:51 UTC (permalink / raw)
  To: Jake Freeland; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 6068 bytes --]

== Series Details ==

Series: Replaced instances of mmap64() with mmap()
URL   : https://patchwork.freedesktop.org/series/108698/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12151 -> IGTPW_7795
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/index.html

Participating hosts (40 -> 40)
------------------------------

  Additional (1): fi-tgl-u2 
  Missing    (1): fi-ctg-p8600 

Known issues
------------

  Here are the changes found in IGTPW_7795 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-tgl-u2:          NOTRUN -> [SKIP][1] ([i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-tgl-u2/igt@gem_huc_copy@huc-copy.html

  * igt@i915_selftest@live@gem:
    - fi-blb-e6850:       NOTRUN -> [DMESG-FAIL][2] ([i915#4528])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-blb-e6850/igt@i915_selftest@live@gem.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-hsw-4770:        NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-tgl-u2:          NOTRUN -> [SKIP][4] ([fdo#109284] / [fdo#111827]) +7 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-tgl-u2/igt@kms_chamelium@hdmi-edid-read.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
    - fi-tgl-u2:          NOTRUN -> [SKIP][5] ([i915#4103])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-tgl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-tgl-u2:          NOTRUN -> [SKIP][6] ([fdo#109285])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-tgl-u2/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-tgl-u2:          NOTRUN -> [SKIP][7] ([i915#3555])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-tgl-u2/igt@kms_setmode@basic-clone-single-crtc.html

  
#### Possible fixes ####

  * igt@fbdev@eof:
    - {fi-tgl-mst}:       [SKIP][8] ([i915#2582]) -> [PASS][9] +3 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/fi-tgl-mst/igt@fbdev@eof.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-tgl-mst/igt@fbdev@eof.html

  * igt@i915_module_load@reload:
    - {fi-tgl-mst}:       [WARN][10] ([i915#6596]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/fi-tgl-mst/igt@i915_module_load@reload.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-tgl-mst/igt@i915_module_load@reload.html

  * igt@i915_selftest@live@hangcheck:
    - fi-hsw-4770:        [INCOMPLETE][12] ([i915#4785]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@requests:
    - fi-blb-e6850:       [DMESG-FAIL][14] ([i915#4528]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/fi-blb-e6850/igt@i915_selftest@live@requests.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-blb-e6850/igt@i915_selftest@live@requests.html
    - {bat-rpls-1}:       [INCOMPLETE][16] ([i915#6257] / [i915#6380]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/bat-rpls-1/igt@i915_selftest@live@requests.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/bat-rpls-1/igt@i915_selftest@live@requests.html

  * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-hdmi-a-2:
    - fi-bdw-5557u:       [INCOMPLETE][18] ([i915#146]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/fi-bdw-5557u/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-hdmi-a-2.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/fi-bdw-5557u/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-hdmi-a-2.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
  [i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
  [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
  [i915#6596]: https://gitlab.freedesktop.org/drm/intel/issues/6596


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6656 -> IGTPW_7795

  CI-20190529: 20190529
  CI_DRM_12151: 4f26414e4247ecc9b81e5b3c256795b02b2e60d6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7795: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/index.html
  IGT_6656: 24100c4e181c50e3678aeca9c641b8a43555ad73 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/index.html

[-- Attachment #2: Type: text/html, Size: 6919 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for Replaced instances of mmap64() with mmap()
  2022-09-18 22:15 [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap() Jake Freeland
  2022-09-18 23:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-09-19  1:27 ` Patchwork
  2022-09-28 12:33 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
  2 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-09-19  1:27 UTC (permalink / raw)
  To: Jake Freeland; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 39413 bytes --]

== Series Details ==

Series: Replaced instances of mmap64() with mmap()
URL   : https://patchwork.freedesktop.org/series/108698/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12151_full -> IGTPW_7795_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_7795_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_7795_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/index.html

Participating hosts (11 -> 8)
------------------------------

  Missing    (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_7795_full:

### IGT changes ###

#### Possible regressions ####

  * igt@drm_import_export@flink:
    - shard-apl:          NOTRUN -> [DMESG-WARN][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl3/igt@drm_import_export@flink.html
    - shard-glk:          NOTRUN -> [DMESG-WARN][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk6/igt@drm_import_export@flink.html

  * igt@drm_import_export@prime:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-apl7/igt@drm_import_export@prime.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl3/igt@drm_import_export@prime.html

  
Known issues
------------

  Here are the changes found in IGTPW_7795_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@process:
    - shard-snb:          NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-snb2/igt@gem_ctx_persistence@process.html

  * igt@gem_exec_balancer@parallel:
    - shard-iclb:         [PASS][6] -> [SKIP][7] ([i915#4525])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb1/igt@gem_exec_balancer@parallel.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@gem_exec_balancer@parallel.html

  * igt@gem_exec_fair@basic-flow@rcs0:
    - shard-tglb:         [PASS][8] -> [FAIL][9] ([i915#2842])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-tglb8/igt@gem_exec_fair@basic-flow@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-glk:          [PASS][10] -> [FAIL][11] ([i915#2842])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-glk2/igt@gem_exec_fair@basic-none-share@rcs0.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk8/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-apl:          [PASS][12] -> [FAIL][13] ([i915#2842])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-apl3/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl7/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-iclb:         NOTRUN -> [FAIL][14] ([i915#2842])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
    - shard-tglb:         NOTRUN -> [FAIL][15] ([i915#2842])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
    - shard-glk:          NOTRUN -> [FAIL][16] ([i915#2842])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk9/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-iclb:         [PASS][17] -> [FAIL][18] ([i915#2842])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_params@secure-non-root:
    - shard-iclb:         NOTRUN -> [SKIP][19] ([fdo#112283])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb3/igt@gem_exec_params@secure-non-root.html
    - shard-tglb:         NOTRUN -> [SKIP][20] ([fdo#112283])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb3/igt@gem_exec_params@secure-non-root.html

  * igt@gem_lmem_swapping@massive-random:
    - shard-iclb:         NOTRUN -> [SKIP][21] ([i915#4613]) +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@gem_lmem_swapping@massive-random.html
    - shard-apl:          NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4613]) +1 similar issue
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl1/igt@gem_lmem_swapping@massive-random.html

  * igt@gem_lmem_swapping@random:
    - shard-tglb:         NOTRUN -> [SKIP][23] ([i915#4613]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb3/igt@gem_lmem_swapping@random.html
    - shard-glk:          NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk2/igt@gem_lmem_swapping@random.html

  * igt@gem_pxp@create-regular-buffer:
    - shard-glk:          NOTRUN -> [SKIP][25] ([fdo#109271]) +40 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk5/igt@gem_pxp@create-regular-buffer.html

  * igt@gem_pxp@protected-raw-src-copy-not-readible:
    - shard-iclb:         NOTRUN -> [SKIP][26] ([i915#4270]) +2 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb5/igt@gem_pxp@protected-raw-src-copy-not-readible.html

  * igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
    - shard-tglb:         NOTRUN -> [SKIP][27] ([i915#4270]) +2 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb7/igt@gem_pxp@verify-pxp-key-change-after-suspend-resume.html

  * igt@gem_userptr_blits@coherency-sync:
    - shard-iclb:         NOTRUN -> [SKIP][28] ([fdo#109290])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb6/igt@gem_userptr_blits@coherency-sync.html
    - shard-tglb:         NOTRUN -> [SKIP][29] ([fdo#110542])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb8/igt@gem_userptr_blits@coherency-sync.html

  * igt@gem_userptr_blits@coherency-unsync:
    - shard-iclb:         NOTRUN -> [SKIP][30] ([i915#3297]) +1 similar issue
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb3/igt@gem_userptr_blits@coherency-unsync.html

  * igt@gem_userptr_blits@huge-split:
    - shard-iclb:         [PASS][31] -> [FAIL][32] ([i915#3376])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb4/igt@gem_userptr_blits@huge-split.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb3/igt@gem_userptr_blits@huge-split.html

  * igt@gem_userptr_blits@input-checking:
    - shard-iclb:         NOTRUN -> [DMESG-WARN][33] ([i915#4991])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@gem_userptr_blits@input-checking.html

  * igt@gen7_exec_parse@oacontrol-tracking:
    - shard-iclb:         NOTRUN -> [SKIP][34] ([fdo#109289])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@gen7_exec_parse@oacontrol-tracking.html

  * igt@gen9_exec_parse@basic-rejected:
    - shard-tglb:         NOTRUN -> [SKIP][35] ([i915#2527] / [i915#2856]) +1 similar issue
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb1/igt@gen9_exec_parse@basic-rejected.html
    - shard-iclb:         NOTRUN -> [SKIP][36] ([i915#2856]) +1 similar issue
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb3/igt@gen9_exec_parse@basic-rejected.html

  * igt@i915_module_load@resize-bar:
    - shard-iclb:         NOTRUN -> [SKIP][37] ([i915#6412])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@i915_module_load@resize-bar.html
    - shard-tglb:         NOTRUN -> [SKIP][38] ([i915#6412])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb7/igt@i915_module_load@resize-bar.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [PASS][39] -> [SKIP][40] ([fdo#109271])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl1/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_query@query-topology-unsupported:
    - shard-iclb:         NOTRUN -> [SKIP][41] ([fdo#109302])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb4/igt@i915_query@query-topology-unsupported.html

  * igt@kms_atomic_transition@plane-all-modeset-transition:
    - shard-iclb:         NOTRUN -> [SKIP][42] ([i915#1769])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb4/igt@kms_atomic_transition@plane-all-modeset-transition.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
    - shard-iclb:         NOTRUN -> [SKIP][43] ([i915#1769] / [i915#3555])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb4/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
    - shard-tglb:         NOTRUN -> [SKIP][44] ([i915#1769] / [i915#3555])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb1/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
    - shard-iclb:         NOTRUN -> [SKIP][45] ([i915#5286]) +2 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180:
    - shard-tglb:         NOTRUN -> [SKIP][46] ([i915#5286]) +2 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180.html

  * igt@kms_big_fb@x-tiled-16bpp-rotate-90:
    - shard-iclb:         NOTRUN -> [SKIP][47] ([fdo#110725] / [fdo#111614])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html
    - shard-tglb:         NOTRUN -> [SKIP][48] ([fdo#111614])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb1/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-8bpp-rotate-0:
    - shard-iclb:         NOTRUN -> [SKIP][49] ([fdo#110723])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0:
    - shard-tglb:         NOTRUN -> [SKIP][50] ([fdo#111615]) +1 similar issue
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb5/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0.html

  * igt@kms_big_joiner@2x-modeset:
    - shard-tglb:         NOTRUN -> [SKIP][51] ([i915#2705])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb3/igt@kms_big_joiner@2x-modeset.html
    - shard-iclb:         NOTRUN -> [SKIP][52] ([i915#2705])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb3/igt@kms_big_joiner@2x-modeset.html

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
    - shard-glk:          NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#3886]) +2 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk1/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
    - shard-iclb:         NOTRUN -> [SKIP][54] ([fdo#109278] / [i915#3886]) +3 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html
    - shard-tglb:         NOTRUN -> [SKIP][55] ([i915#3689] / [i915#3886])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb7/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
    - shard-apl:          NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3886]) +2 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][57] ([i915#6095])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb8/igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs.html

  * igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_rc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][58] ([i915#3689]) +2 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb5/igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_rc_ccs.html

  * igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs:
    - shard-iclb:         NOTRUN -> [SKIP][59] ([fdo#109278]) +9 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs.html

  * igt@kms_chamelium@dp-audio:
    - shard-iclb:         NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +4 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb1/igt@kms_chamelium@dp-audio.html

  * igt@kms_chamelium@dp-hpd-after-suspend:
    - shard-snb:          NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +2 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-snb6/igt@kms_chamelium@dp-hpd-after-suspend.html

  * igt@kms_color_chamelium@ctm-max:
    - shard-tglb:         NOTRUN -> [SKIP][62] ([fdo#109284] / [fdo#111827]) +2 similar issues
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb5/igt@kms_color_chamelium@ctm-max.html
    - shard-glk:          NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk8/igt@kms_color_chamelium@ctm-max.html
    - shard-apl:          NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl7/igt@kms_color_chamelium@ctm-max.html

  * igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
    - shard-iclb:         NOTRUN -> [SKIP][65] ([fdo#109274]) +3 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb7/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html
    - shard-tglb:         NOTRUN -> [SKIP][66] ([fdo#109274] / [fdo#111825])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb5/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html

  * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
    - shard-glk:          [PASS][67] -> [FAIL][68] ([i915#2346]) +1 similar issue
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html

  * igt@kms_flip@2x-plain-flip-interruptible:
    - shard-tglb:         NOTRUN -> [SKIP][69] ([fdo#109274] / [fdo#111825] / [i915#3637]) +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb7/igt@kms_flip@2x-plain-flip-interruptible.html

  * igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode:
    - shard-iclb:         NOTRUN -> [SKIP][70] ([i915#3555]) +2 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
    - shard-iclb:         NOTRUN -> [SKIP][71] ([i915#2672]) +5 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html

  * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
    - shard-iclb:         NOTRUN -> [SKIP][72] ([i915#2587] / [i915#2672]) +6 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html

  * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
    - shard-iclb:         NOTRUN -> [SKIP][73] ([i915#2672] / [i915#3555])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
    - shard-iclb:         [PASS][74] -> [FAIL][75] ([i915#1888] / [i915#2546])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
    - shard-iclb:         NOTRUN -> [SKIP][76] ([fdo#109280]) +18 similar issues
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-modesetfrombusy:
    - shard-tglb:         NOTRUN -> [SKIP][77] ([i915#6497]) +3 similar issues
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-modesetfrombusy.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
    - shard-apl:          NOTRUN -> [SKIP][78] ([fdo#109271]) +53 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html
    - shard-snb:          NOTRUN -> [SKIP][79] ([fdo#109271]) +81 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-snb4/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html
    - shard-tglb:         NOTRUN -> [SKIP][80] ([fdo#109280] / [fdo#111825]) +11 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html

  * igt@kms_plane_lowres@tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][81] ([fdo#112054] / [i915#5288])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb8/igt@kms_plane_lowres@tiling-yf.html

  * igt@kms_plane_lowres@tiling-yf@pipe-b-edp-1:
    - shard-iclb:         NOTRUN -> [SKIP][82] ([i915#3536]) +2 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@kms_plane_lowres@tiling-yf@pipe-b-edp-1.html

  * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-c-edp-1:
    - shard-iclb:         NOTRUN -> [SKIP][83] ([i915#5176]) +2 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-c-edp-1.html

  * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
    - shard-iclb:         NOTRUN -> [SKIP][84] ([i915#658])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb6/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
    - shard-glk:          NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
    - shard-iclb:         NOTRUN -> [SKIP][86] ([fdo#111068] / [i915#658])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
    - shard-apl:          NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#658])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
    - shard-tglb:         NOTRUN -> [SKIP][88] ([i915#2920])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb5/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         NOTRUN -> [SKIP][89] ([fdo#109441]) +1 similar issue
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
    - shard-tglb:         NOTRUN -> [FAIL][90] ([i915#132] / [i915#3467])
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb8/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][91] -> [SKIP][92] ([fdo#109441]) +2 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
    - shard-iclb:         [PASS][93] -> [SKIP][94] ([i915#5519])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb7/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html

  * igt@kms_selftest@all:
    - shard-iclb:         NOTRUN -> [SKIP][95] ([i915#6433])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@kms_selftest@all.html

  * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
    - shard-iclb:         NOTRUN -> [SKIP][96] ([i915#2530]) +1 similar issue
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html

  * igt@prime_nv_test@i915_nv_sharing:
    - shard-tglb:         NOTRUN -> [SKIP][97] ([fdo#109291])
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb1/igt@prime_nv_test@i915_nv_sharing.html

  * igt@prime_nv_test@nv_write_i915_cpu_mmap_read:
    - shard-iclb:         NOTRUN -> [SKIP][98] ([fdo#109291]) +1 similar issue
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb8/igt@prime_nv_test@nv_write_i915_cpu_mmap_read.html

  * igt@prime_vgem@fence-read-hang:
    - shard-iclb:         NOTRUN -> [SKIP][99] ([fdo#109295])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb7/igt@prime_vgem@fence-read-hang.html
    - shard-tglb:         NOTRUN -> [SKIP][100] ([fdo#109295])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb5/igt@prime_vgem@fence-read-hang.html

  * igt@sysfs_clients@sema-25:
    - shard-apl:          NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#2994]) +1 similar issue
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl3/igt@sysfs_clients@sema-25.html
    - shard-tglb:         NOTRUN -> [SKIP][102] ([i915#2994])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb3/igt@sysfs_clients@sema-25.html
    - shard-glk:          NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#2994])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk9/igt@sysfs_clients@sema-25.html
    - shard-iclb:         NOTRUN -> [SKIP][104] ([i915#2994])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb3/igt@sysfs_clients@sema-25.html

  
#### Possible fixes ####

  * igt@gem_ctx_exec@basic-nohangcheck:
    - shard-tglb:         [FAIL][105] ([i915#6268]) -> [PASS][106]
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-tglb1/igt@gem_ctx_exec@basic-nohangcheck.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_exec_balancer@parallel-keep-in-fence:
    - shard-iclb:         [SKIP][107] ([i915#4525]) -> [PASS][108] +2 similar issues
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb5/igt@gem_exec_balancer@parallel-keep-in-fence.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb1/igt@gem_exec_balancer@parallel-keep-in-fence.html

  * igt@gem_exec_endless@dispatch@bcs0:
    - {shard-rkl}:        [SKIP][109] ([i915#6247]) -> [PASS][110]
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-rkl-5/igt@gem_exec_endless@dispatch@bcs0.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-rkl-2/igt@gem_exec_endless@dispatch@bcs0.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-iclb:         [FAIL][111] ([i915#2842]) -> [PASS][112]
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs0:
    - shard-glk:          [FAIL][113] ([i915#2842]) -> [PASS][114] +1 similar issue
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-glk9/igt@gem_exec_fair@basic-none@vcs0.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk8/igt@gem_exec_fair@basic-none@vcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglb:         [FAIL][115] ([i915#2842]) -> [PASS][116]
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_schedule@wide@rcs0:
    - {shard-tglu}:       [INCOMPLETE][117] -> [PASS][118]
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-tglu-3/igt@gem_exec_schedule@wide@rcs0.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglu-6/igt@gem_exec_schedule@wide@rcs0.html

  * igt@i915_pm_dc@dc5-psr:
    - shard-tglb:         [FAIL][119] ([i915#3989]) -> [PASS][120]
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-tglb8/igt@i915_pm_dc@dc5-psr.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-tglb3/igt@i915_pm_dc@dc5-psr.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-iclb:         [SKIP][121] ([i915#4281]) -> [PASS][122]
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb6/igt@i915_pm_dc@dc9-dpms.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [SKIP][123] ([fdo#109441]) -> [PASS][124]
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

  * igt@perf@polling-parameterized:
    - shard-glk:          [FAIL][125] ([i915#5639]) -> [PASS][126]
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-glk2/igt@perf@polling-parameterized.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-glk1/igt@perf@polling-parameterized.html

  
#### Warnings ####

  * igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
    - shard-iclb:         [SKIP][127] ([i915#658]) -> [SKIP][128] ([i915#2920])
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area:
    - shard-iclb:         [SKIP][129] ([fdo#111068] / [i915#658]) -> [SKIP][130] ([i915#2920])
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-iclb3/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html

  * igt@runner@aborted:
    - shard-apl:          ([FAIL][131], [FAIL][132], [FAIL][133]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139]) ([fdo#109271] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-apl3/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-apl7/igt@runner@aborted.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12151/shard-apl3/igt@runner@aborted.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl1/igt@runner@aborted.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl3/igt@runner@aborted.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl3/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl1/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl1/igt@runner@aborted.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/shard-apl1/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
  [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
  [i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
  [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
  [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
  [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
  [i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
  [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
  [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
  [i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
  [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
  [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
  [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
  [i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
  [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
  [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
  [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
  [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
  [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
  [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
  [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
  [i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
  [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
  [i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6656 -> IGTPW_7795
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_12151: 4f26414e4247ecc9b81e5b3c256795b02b2e60d6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7795: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/index.html
  IGT_6656: 24100c4e181c50e3678aeca9c641b8a43555ad73 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7795/index.html

[-- Attachment #2: Type: text/html, Size: 43929 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-09-18 22:15 [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap() Jake Freeland
  2022-09-18 23:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2022-09-19  1:27 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-09-28 12:33 ` Kamil Konieczny
  2022-09-28 12:44   ` Petri Latvala
  2 siblings, 1 reply; 15+ messages in thread
From: Kamil Konieczny @ 2022-09-28 12:33 UTC (permalink / raw)
  To: igt-dev; +Cc: Jake Freeland, Petri Latvala

Hi Jake,

this patch is missing commit message. Please put here short
description of change and why you do it. Change looks resonable
as on 64-bit systems both functions are the same.

On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> Signed-off-by: Jake Freeland <jfree@freebsd.org>

Adding Petri on cc as I do not know if anyone compiles this on
32-bit platforms.

Regards,
Kamil

> ---
>  lib/i915/gem_mman.c          |  4 ++--
>  lib/igt_vgem.c               |  2 +-
>  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
>  tests/i915/gem_mmap_offset.c | 14 +++++++-------
>  4 files changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> index aa9ac6f3..0b41ba70 100644
> --- a/lib/i915/gem_mman.c
> +++ b/lib/i915/gem_mman.c
> @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
>  	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
>  		return NULL;
>  
> -	ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> +	ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
>  	if (ptr == MAP_FAILED)
>  		ptr = NULL;
>  	else
> @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
>  	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
>  		return NULL;
>  
> -	ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> +	ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
>  
>  	if (ptr == MAP_FAILED)
>  		ptr = NULL;
> diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> index 7f933b23..468383c7 100644
> --- a/lib/igt_vgem.c
> +++ b/lib/igt_vgem.c
> @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo, unsigned prot)
>  	if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
>  		return NULL;
>  
> -	ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> +	ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
>  	if (ptr == MAP_FAILED)
>  		return NULL;
>  
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index 4f05eb18..683eaf16 100644
> --- a/tests/i915/gem_mmap_gtt.c
> +++ b/tests/i915/gem_mmap_gtt.c
> @@ -113,11 +113,11 @@ test_access(int fd)
>  	mmap_arg.handle = handle;
>  	do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
>  
> -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
>  			  MAP_SHARED, fd, mmap_arg.offset));
>  
>  	/* Check that the same offset on the other fd doesn't work. */
> -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
>  			  MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
>  	igt_assert(errno == EACCES);
>  
> @@ -128,7 +128,7 @@ test_access(int fd)
>  
>  	/* Recheck that it works after flink. */
>  	/* Check that the same offset on the other fd doesn't work. */
> -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
>  			  MAP_SHARED, fd2, mmap_arg.offset));
>  }
>  
> @@ -159,11 +159,11 @@ test_short(int fd)
>  	for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
>  		uint8_t *r, *w;
>  
> -		w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> +		w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
>  			   MAP_SHARED, fd, mmap_arg.offset);
>  		igt_assert(w != MAP_FAILED);
>  
> -		r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> +		r = mmap(0, pages * PAGE_SIZE, PROT_READ,
>  			   MAP_SHARED, fd, mmap_arg.offset);
>  		igt_assert(r != MAP_FAILED);
>  
> @@ -384,13 +384,13 @@ test_isolation(int i915)
>  
>  	close(B);
>  
> -	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> +	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
>  	igt_assert(ptr != MAP_FAILED);
>  	munmap(ptr, 4096);
>  
>  	close(A);
>  
> -	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> +	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
>  	igt_assert(ptr == MAP_FAILED);
>  }
>  
> @@ -400,7 +400,7 @@ test_close_race(int i915)
>  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
>  	_Atomic uint32_t *handles;
>  
> -	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> +	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>  	igt_assert(handles != MAP_FAILED);
>  
>  	igt_fork(child, ncpus + 1) {
> @@ -418,7 +418,7 @@ test_close_race(int i915)
>  				  &mmap_arg) != -1) {
>  				void *ptr;
>  
> -				ptr = mmap64(0, 4096,
> +				ptr = mmap(0, 4096,
>  					     PROT_WRITE, MAP_SHARED, i915,
>  					     mmap_arg.offset);
>  				if (ptr != MAP_FAILED) {
> @@ -444,7 +444,7 @@ test_flink_race(int i915)
>  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
>  	_Atomic uint32_t *handles;
>  
> -	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> +	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>  	igt_assert(handles != MAP_FAILED);
>  
>  	igt_fork(child, ncpus + 1) {
> @@ -469,7 +469,7 @@ test_flink_race(int i915)
>  				  &mmap_arg) != -1) {
>  				void *ptr;
>  
> -				ptr = mmap64(0, 4096,
> +				ptr = mmap(0, 4096,
>  					     PROT_WRITE, MAP_SHARED, fd,
>  					     mmap_arg.offset);
>  				if (ptr != MAP_FAILED) {
> diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
> index 5781b2fb..0933ed94 100644
> --- a/tests/i915/gem_mmap_offset.c
> +++ b/tests/i915/gem_mmap_offset.c
> @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t offset, uint64_t size,
>  	if (mmap_offset_ioctl(i915, &arg))
>  		return NULL;
>  
> -	ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> +	ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
>  	if (ptr == MAP_FAILED)
>  		ptr = NULL;
>  	else
> @@ -214,12 +214,12 @@ static void isolation(int i915)
>  			 t->name, B, b, offset_b);
>  
>  		errno = 0;
> -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
>  		igt_assert(ptr == MAP_FAILED);
>  		igt_assert_eq(errno, EACCES);
>  
>  		errno = 0;
> -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
>  		igt_assert(ptr == MAP_FAILED);
>  		igt_assert_eq(errno, EACCES);
>  
> @@ -237,13 +237,13 @@ static void isolation(int i915)
>  
>  		close(B);
>  
> -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
>  		igt_assert(ptr != MAP_FAILED);
>  		munmap(ptr, 4096);
>  
>  		close(A);
>  
> -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
>  		igt_assert(ptr == MAP_FAILED);
>  	}
>  }
> @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
>  	_Atomic uint32_t *handles;
>  	size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
>  
> -	handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> +	handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>  	igt_assert(handles != MAP_FAILED);
>  
>  	igt_fork(child, ncpus + 1) {
> @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
>  				  &mmap_arg) != -1) {
>  				void *ptr;
>  
> -				ptr = mmap64(0, 4096,
> +				ptr = mmap(0, 4096,
>  					     PROT_WRITE, MAP_SHARED, i915,
>  					     mmap_arg.offset);
>  				if (ptr != MAP_FAILED) {
> -- 
> 2.37.3
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-09-28 12:33 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
@ 2022-09-28 12:44   ` Petri Latvala
  2022-09-28 15:19     ` Jake Freeland
  2022-09-28 15:36     ` Kamil Konieczny
  0 siblings, 2 replies; 15+ messages in thread
From: Petri Latvala @ 2022-09-28 12:44 UTC (permalink / raw)
  To: Kamil Konieczny, igt-dev, Jake Freeland

On Wed, Sep 28, 2022 at 02:33:14PM +0200, Kamil Konieczny wrote:
> Hi Jake,
> 
> this patch is missing commit message. Please put here short
> description of change and why you do it. Change looks resonable
> as on 64-bit systems both functions are the same.
> 
> On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> > Signed-off-by: Jake Freeland <jfree@freebsd.org>
> 
> Adding Petri on cc as I do not know if anyone compiles this on
> 32-bit platforms.

Aren't you supposed to use mmap() with _LARGEFILE_something even on
32-bit builds, instead of mmap64?


-- 
Petri Latvala



> 
> Regards,
> Kamil
> 
> > ---
> >  lib/i915/gem_mman.c          |  4 ++--
> >  lib/igt_vgem.c               |  2 +-
> >  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
> >  tests/i915/gem_mmap_offset.c | 14 +++++++-------
> >  4 files changed, 21 insertions(+), 21 deletions(-)
> > 
> > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > index aa9ac6f3..0b41ba70 100644
> > --- a/lib/i915/gem_mman.c
> > +++ b/lib/i915/gem_mman.c
> > @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
> >  	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
> >  		return NULL;
> >  
> > -	ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > +	ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> >  	if (ptr == MAP_FAILED)
> >  		ptr = NULL;
> >  	else
> > @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
> >  	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
> >  		return NULL;
> >  
> > -	ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > +	ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> >  
> >  	if (ptr == MAP_FAILED)
> >  		ptr = NULL;
> > diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> > index 7f933b23..468383c7 100644
> > --- a/lib/igt_vgem.c
> > +++ b/lib/igt_vgem.c
> > @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo, unsigned prot)
> >  	if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
> >  		return NULL;
> >  
> > -	ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > +	ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> >  	if (ptr == MAP_FAILED)
> >  		return NULL;
> >  
> > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> > index 4f05eb18..683eaf16 100644
> > --- a/tests/i915/gem_mmap_gtt.c
> > +++ b/tests/i915/gem_mmap_gtt.c
> > @@ -113,11 +113,11 @@ test_access(int fd)
> >  	mmap_arg.handle = handle;
> >  	do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
> >  
> > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> >  			  MAP_SHARED, fd, mmap_arg.offset));
> >  
> >  	/* Check that the same offset on the other fd doesn't work. */
> > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> >  			  MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
> >  	igt_assert(errno == EACCES);
> >  
> > @@ -128,7 +128,7 @@ test_access(int fd)
> >  
> >  	/* Recheck that it works after flink. */
> >  	/* Check that the same offset on the other fd doesn't work. */
> > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> >  			  MAP_SHARED, fd2, mmap_arg.offset));
> >  }
> >  
> > @@ -159,11 +159,11 @@ test_short(int fd)
> >  	for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
> >  		uint8_t *r, *w;
> >  
> > -		w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > +		w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> >  			   MAP_SHARED, fd, mmap_arg.offset);
> >  		igt_assert(w != MAP_FAILED);
> >  
> > -		r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> > +		r = mmap(0, pages * PAGE_SIZE, PROT_READ,
> >  			   MAP_SHARED, fd, mmap_arg.offset);
> >  		igt_assert(r != MAP_FAILED);
> >  
> > @@ -384,13 +384,13 @@ test_isolation(int i915)
> >  
> >  	close(B);
> >  
> > -	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > +	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> >  	igt_assert(ptr != MAP_FAILED);
> >  	munmap(ptr, 4096);
> >  
> >  	close(A);
> >  
> > -	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > +	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> >  	igt_assert(ptr == MAP_FAILED);
> >  }
> >  
> > @@ -400,7 +400,7 @@ test_close_race(int i915)
> >  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> >  	_Atomic uint32_t *handles;
> >  
> > -	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > +	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> >  	igt_assert(handles != MAP_FAILED);
> >  
> >  	igt_fork(child, ncpus + 1) {
> > @@ -418,7 +418,7 @@ test_close_race(int i915)
> >  				  &mmap_arg) != -1) {
> >  				void *ptr;
> >  
> > -				ptr = mmap64(0, 4096,
> > +				ptr = mmap(0, 4096,
> >  					     PROT_WRITE, MAP_SHARED, i915,
> >  					     mmap_arg.offset);
> >  				if (ptr != MAP_FAILED) {
> > @@ -444,7 +444,7 @@ test_flink_race(int i915)
> >  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> >  	_Atomic uint32_t *handles;
> >  
> > -	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > +	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> >  	igt_assert(handles != MAP_FAILED);
> >  
> >  	igt_fork(child, ncpus + 1) {
> > @@ -469,7 +469,7 @@ test_flink_race(int i915)
> >  				  &mmap_arg) != -1) {
> >  				void *ptr;
> >  
> > -				ptr = mmap64(0, 4096,
> > +				ptr = mmap(0, 4096,
> >  					     PROT_WRITE, MAP_SHARED, fd,
> >  					     mmap_arg.offset);
> >  				if (ptr != MAP_FAILED) {
> > diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
> > index 5781b2fb..0933ed94 100644
> > --- a/tests/i915/gem_mmap_offset.c
> > +++ b/tests/i915/gem_mmap_offset.c
> > @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t offset, uint64_t size,
> >  	if (mmap_offset_ioctl(i915, &arg))
> >  		return NULL;
> >  
> > -	ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > +	ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> >  	if (ptr == MAP_FAILED)
> >  		ptr = NULL;
> >  	else
> > @@ -214,12 +214,12 @@ static void isolation(int i915)
> >  			 t->name, B, b, offset_b);
> >  
> >  		errno = 0;
> > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> >  		igt_assert(ptr == MAP_FAILED);
> >  		igt_assert_eq(errno, EACCES);
> >  
> >  		errno = 0;
> > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> >  		igt_assert(ptr == MAP_FAILED);
> >  		igt_assert_eq(errno, EACCES);
> >  
> > @@ -237,13 +237,13 @@ static void isolation(int i915)
> >  
> >  		close(B);
> >  
> > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> >  		igt_assert(ptr != MAP_FAILED);
> >  		munmap(ptr, 4096);
> >  
> >  		close(A);
> >  
> > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> >  		igt_assert(ptr == MAP_FAILED);
> >  	}
> >  }
> > @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
> >  	_Atomic uint32_t *handles;
> >  	size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
> >  
> > -	handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > +	handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> >  	igt_assert(handles != MAP_FAILED);
> >  
> >  	igt_fork(child, ncpus + 1) {
> > @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
> >  				  &mmap_arg) != -1) {
> >  				void *ptr;
> >  
> > -				ptr = mmap64(0, 4096,
> > +				ptr = mmap(0, 4096,
> >  					     PROT_WRITE, MAP_SHARED, i915,
> >  					     mmap_arg.offset);
> >  				if (ptr != MAP_FAILED) {
> > -- 
> > 2.37.3
> > 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-09-28 12:44   ` Petri Latvala
@ 2022-09-28 15:19     ` Jake Freeland
  2022-09-28 15:35       ` Petri Latvala
  2022-09-28 15:42       ` Kamil Konieczny
  2022-09-28 15:36     ` Kamil Konieczny
  1 sibling, 2 replies; 15+ messages in thread
From: Jake Freeland @ 2022-09-28 15:19 UTC (permalink / raw)
  To: Petri Latvala; +Cc: igt-dev, Jake Freeland

[-- Attachment #1: Type: text/plain, Size: 10217 bytes --]

I cannot find any relevant documentation for both Linux and FreeBSD
that mentions an mmap flag that supports large file allocation on
32-bit architectures.

Commit message:
The mmap64() function exists to point 32-bit architectures to an mmap
interface with the capability to address a 64-bit memory address space.
As 32-bit machines are replaced by 64-bit, there is no longer a need to
keep mmap64() around. This is especially apparent in operating systems
like FreeBSD that exclude the mmap64() function altogether. This patch
replaces all instances of mmap64() with mmap().

Jake Freeland

On Wed, Sep 28, 2022 at 7:45 AM Petri Latvala <petri.latvala@intel.com>
wrote:

> On Wed, Sep 28, 2022 at 02:33:14PM +0200, Kamil Konieczny wrote:
> > Hi Jake,
> >
> > this patch is missing commit message. Please put here short
> > description of change and why you do it. Change looks resonable
> > as on 64-bit systems both functions are the same.
> >
> > On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> > > Signed-off-by: Jake Freeland <jfree@freebsd.org>
> >
> > Adding Petri on cc as I do not know if anyone compiles this on
> > 32-bit platforms.
>
> Aren't you supposed to use mmap() with _LARGEFILE_something even on
> 32-bit builds, instead of mmap64?
>
>
> --
> Petri Latvala
>
>
>
> >
> > Regards,
> > Kamil
> >
> > > ---
> > >  lib/i915/gem_mman.c          |  4 ++--
> > >  lib/igt_vgem.c               |  2 +-
> > >  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
> > >  tests/i915/gem_mmap_offset.c | 14 +++++++-------
> > >  4 files changed, 21 insertions(+), 21 deletions(-)
> > >
> > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > index aa9ac6f3..0b41ba70 100644
> > > --- a/lib/i915/gem_mman.c
> > > +++ b/lib/i915/gem_mman.c
> > > @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle,
> uint64_t size, unsigned prot)
> > >     if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
> > >             return NULL;
> > >
> > > -   ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > +   ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > >     if (ptr == MAP_FAILED)
> > >             ptr = NULL;
> > >     else
> > > @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle,
> uint64_t offset, uint64_t size,
> > >     if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
> > >             return NULL;
> > >
> > > -   ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > +   ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > >
> > >     if (ptr == MAP_FAILED)
> > >             ptr = NULL;
> > > diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> > > index 7f933b23..468383c7 100644
> > > --- a/lib/igt_vgem.c
> > > +++ b/lib/igt_vgem.c
> > > @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo,
> unsigned prot)
> > >     if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
> > >             return NULL;
> > >
> > > -   ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > +   ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > >     if (ptr == MAP_FAILED)
> > >             return NULL;
> > >
> > > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> > > index 4f05eb18..683eaf16 100644
> > > --- a/tests/i915/gem_mmap_gtt.c
> > > +++ b/tests/i915/gem_mmap_gtt.c
> > > @@ -113,11 +113,11 @@ test_access(int fd)
> > >     mmap_arg.handle = handle;
> > >     do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
> > >
> > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > >                       MAP_SHARED, fd, mmap_arg.offset));
> > >
> > >     /* Check that the same offset on the other fd doesn't work. */
> > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > >                       MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
> > >     igt_assert(errno == EACCES);
> > >
> > > @@ -128,7 +128,7 @@ test_access(int fd)
> > >
> > >     /* Recheck that it works after flink. */
> > >     /* Check that the same offset on the other fd doesn't work. */
> > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > >                       MAP_SHARED, fd2, mmap_arg.offset));
> > >  }
> > >
> > > @@ -159,11 +159,11 @@ test_short(int fd)
> > >     for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
> > >             uint8_t *r, *w;
> > >
> > > -           w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > +           w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > >                        MAP_SHARED, fd, mmap_arg.offset);
> > >             igt_assert(w != MAP_FAILED);
> > >
> > > -           r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> > > +           r = mmap(0, pages * PAGE_SIZE, PROT_READ,
> > >                        MAP_SHARED, fd, mmap_arg.offset);
> > >             igt_assert(r != MAP_FAILED);
> > >
> > > @@ -384,13 +384,13 @@ test_isolation(int i915)
> > >
> > >     close(B);
> > >
> > > -   ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > +   ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > >     igt_assert(ptr != MAP_FAILED);
> > >     munmap(ptr, 4096);
> > >
> > >     close(A);
> > >
> > > -   ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > +   ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > >     igt_assert(ptr == MAP_FAILED);
> > >  }
> > >
> > > @@ -400,7 +400,7 @@ test_close_race(int i915)
> > >     const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > >     _Atomic uint32_t *handles;
> > >
> > > -   handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> 0);
> > > +   handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > >     igt_assert(handles != MAP_FAILED);
> > >
> > >     igt_fork(child, ncpus + 1) {
> > > @@ -418,7 +418,7 @@ test_close_race(int i915)
> > >                               &mmap_arg) != -1) {
> > >                             void *ptr;
> > >
> > > -                           ptr = mmap64(0, 4096,
> > > +                           ptr = mmap(0, 4096,
> > >                                          PROT_WRITE, MAP_SHARED, i915,
> > >                                          mmap_arg.offset);
> > >                             if (ptr != MAP_FAILED) {
> > > @@ -444,7 +444,7 @@ test_flink_race(int i915)
> > >     const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > >     _Atomic uint32_t *handles;
> > >
> > > -   handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> 0);
> > > +   handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > >     igt_assert(handles != MAP_FAILED);
> > >
> > >     igt_fork(child, ncpus + 1) {
> > > @@ -469,7 +469,7 @@ test_flink_race(int i915)
> > >                               &mmap_arg) != -1) {
> > >                             void *ptr;
> > >
> > > -                           ptr = mmap64(0, 4096,
> > > +                           ptr = mmap(0, 4096,
> > >                                          PROT_WRITE, MAP_SHARED, fd,
> > >                                          mmap_arg.offset);
> > >                             if (ptr != MAP_FAILED) {
> > > diff --git a/tests/i915/gem_mmap_offset.c
> b/tests/i915/gem_mmap_offset.c
> > > index 5781b2fb..0933ed94 100644
> > > --- a/tests/i915/gem_mmap_offset.c
> > > +++ b/tests/i915/gem_mmap_offset.c
> > > @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t
> offset, uint64_t size,
> > >     if (mmap_offset_ioctl(i915, &arg))
> > >             return NULL;
> > >
> > > -   ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > > +   ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > >     if (ptr == MAP_FAILED)
> > >             ptr = NULL;
> > >     else
> > > @@ -214,12 +214,12 @@ static void isolation(int i915)
> > >                      t->name, B, b, offset_b);
> > >
> > >             errno = 0;
> > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> offset_a);
> > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> > >             igt_assert(ptr == MAP_FAILED);
> > >             igt_assert_eq(errno, EACCES);
> > >
> > >             errno = 0;
> > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> offset_b);
> > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> > >             igt_assert(ptr == MAP_FAILED);
> > >             igt_assert_eq(errno, EACCES);
> > >
> > > @@ -237,13 +237,13 @@ static void isolation(int i915)
> > >
> > >             close(B);
> > >
> > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > >             igt_assert(ptr != MAP_FAILED);
> > >             munmap(ptr, 4096);
> > >
> > >             close(A);
> > >
> > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > >             igt_assert(ptr == MAP_FAILED);
> > >     }
> > >  }
> > > @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
> > >     _Atomic uint32_t *handles;
> > >     size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
> > >
> > > -   handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > +   handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > >     igt_assert(handles != MAP_FAILED);
> > >
> > >     igt_fork(child, ncpus + 1) {
> > > @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
> > >                               &mmap_arg) != -1) {
> > >                             void *ptr;
> > >
> > > -                           ptr = mmap64(0, 4096,
> > > +                           ptr = mmap(0, 4096,
> > >                                          PROT_WRITE, MAP_SHARED, i915,
> > >                                          mmap_arg.offset);
> > >                             if (ptr != MAP_FAILED) {
> > > --
> > > 2.37.3
> > >
>

[-- Attachment #2: Type: text/html, Size: 13611 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-09-28 15:19     ` Jake Freeland
@ 2022-09-28 15:35       ` Petri Latvala
  2022-09-28 15:42       ` Kamil Konieczny
  1 sibling, 0 replies; 15+ messages in thread
From: Petri Latvala @ 2022-09-28 15:35 UTC (permalink / raw)
  To: Jake Freeland; +Cc: igt-dev, Jake Freeland

On Wed, Sep 28, 2022 at 10:19:04AM -0500, Jake Freeland wrote:
> I cannot find any relevant documentation for both Linux and FreeBSD
> that mentions an mmap flag that supports large file allocation on
> 32-bit architectures.

Me neither, apart from old posts on SO. I suppose everything these
days has 64bit off_t.

Acked-by: Petri Latvala <petri.latvala@intel.com>

> 
> Commit message:
> The mmap64() function exists to point 32-bit architectures to an mmap
> interface with the capability to address a 64-bit memory address space.
> As 32-bit machines are replaced by 64-bit, there is no longer a need to
> keep mmap64() around. This is especially apparent in operating systems
> like FreeBSD that exclude the mmap64() function altogether. This patch
> replaces all instances of mmap64() with mmap().
> 
> Jake Freeland
> 
> On Wed, Sep 28, 2022 at 7:45 AM Petri Latvala <petri.latvala@intel.com>
> wrote:
> 
> > On Wed, Sep 28, 2022 at 02:33:14PM +0200, Kamil Konieczny wrote:
> > > Hi Jake,
> > >
> > > this patch is missing commit message. Please put here short
> > > description of change and why you do it. Change looks resonable
> > > as on 64-bit systems both functions are the same.
> > >
> > > On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> > > > Signed-off-by: Jake Freeland <jfree@freebsd.org>
> > >
> > > Adding Petri on cc as I do not know if anyone compiles this on
> > > 32-bit platforms.
> >
> > Aren't you supposed to use mmap() with _LARGEFILE_something even on
> > 32-bit builds, instead of mmap64?
> >
> >
> > --
> > Petri Latvala
> >
> >
> >
> > >
> > > Regards,
> > > Kamil
> > >
> > > > ---
> > > >  lib/i915/gem_mman.c          |  4 ++--
> > > >  lib/igt_vgem.c               |  2 +-
> > > >  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
> > > >  tests/i915/gem_mmap_offset.c | 14 +++++++-------
> > > >  4 files changed, 21 insertions(+), 21 deletions(-)
> > > >
> > > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > > index aa9ac6f3..0b41ba70 100644
> > > > --- a/lib/i915/gem_mman.c
> > > > +++ b/lib/i915/gem_mman.c
> > > > @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle,
> > uint64_t size, unsigned prot)
> > > >     if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
> > > >             return NULL;
> > > >
> > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > > +   ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > >     if (ptr == MAP_FAILED)
> > > >             ptr = NULL;
> > > >     else
> > > > @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle,
> > uint64_t offset, uint64_t size,
> > > >     if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
> > > >             return NULL;
> > > >
> > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > > +   ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > >
> > > >     if (ptr == MAP_FAILED)
> > > >             ptr = NULL;
> > > > diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> > > > index 7f933b23..468383c7 100644
> > > > --- a/lib/igt_vgem.c
> > > > +++ b/lib/igt_vgem.c
> > > > @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo,
> > unsigned prot)
> > > >     if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
> > > >             return NULL;
> > > >
> > > > -   ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > > +   ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > >     if (ptr == MAP_FAILED)
> > > >             return NULL;
> > > >
> > > > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> > > > index 4f05eb18..683eaf16 100644
> > > > --- a/tests/i915/gem_mmap_gtt.c
> > > > +++ b/tests/i915/gem_mmap_gtt.c
> > > > @@ -113,11 +113,11 @@ test_access(int fd)
> > > >     mmap_arg.handle = handle;
> > > >     do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
> > > >
> > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >                       MAP_SHARED, fd, mmap_arg.offset));
> > > >
> > > >     /* Check that the same offset on the other fd doesn't work. */
> > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >                       MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
> > > >     igt_assert(errno == EACCES);
> > > >
> > > > @@ -128,7 +128,7 @@ test_access(int fd)
> > > >
> > > >     /* Recheck that it works after flink. */
> > > >     /* Check that the same offset on the other fd doesn't work. */
> > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >                       MAP_SHARED, fd2, mmap_arg.offset));
> > > >  }
> > > >
> > > > @@ -159,11 +159,11 @@ test_short(int fd)
> > > >     for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
> > > >             uint8_t *r, *w;
> > > >
> > > > -           w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > > +           w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > >                        MAP_SHARED, fd, mmap_arg.offset);
> > > >             igt_assert(w != MAP_FAILED);
> > > >
> > > > -           r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> > > > +           r = mmap(0, pages * PAGE_SIZE, PROT_READ,
> > > >                        MAP_SHARED, fd, mmap_arg.offset);
> > > >             igt_assert(r != MAP_FAILED);
> > > >
> > > > @@ -384,13 +384,13 @@ test_isolation(int i915)
> > > >
> > > >     close(B);
> > > >
> > > > -   ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +   ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >     igt_assert(ptr != MAP_FAILED);
> > > >     munmap(ptr, 4096);
> > > >
> > > >     close(A);
> > > >
> > > > -   ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +   ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >     igt_assert(ptr == MAP_FAILED);
> > > >  }
> > > >
> > > > @@ -400,7 +400,7 @@ test_close_race(int i915)
> > > >     const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > >     _Atomic uint32_t *handles;
> > > >
> > > > -   handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> > 0);
> > > > +   handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >     igt_assert(handles != MAP_FAILED);
> > > >
> > > >     igt_fork(child, ncpus + 1) {
> > > > @@ -418,7 +418,7 @@ test_close_race(int i915)
> > > >                               &mmap_arg) != -1) {
> > > >                             void *ptr;
> > > >
> > > > -                           ptr = mmap64(0, 4096,
> > > > +                           ptr = mmap(0, 4096,
> > > >                                          PROT_WRITE, MAP_SHARED, i915,
> > > >                                          mmap_arg.offset);
> > > >                             if (ptr != MAP_FAILED) {
> > > > @@ -444,7 +444,7 @@ test_flink_race(int i915)
> > > >     const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > >     _Atomic uint32_t *handles;
> > > >
> > > > -   handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> > 0);
> > > > +   handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >     igt_assert(handles != MAP_FAILED);
> > > >
> > > >     igt_fork(child, ncpus + 1) {
> > > > @@ -469,7 +469,7 @@ test_flink_race(int i915)
> > > >                               &mmap_arg) != -1) {
> > > >                             void *ptr;
> > > >
> > > > -                           ptr = mmap64(0, 4096,
> > > > +                           ptr = mmap(0, 4096,
> > > >                                          PROT_WRITE, MAP_SHARED, fd,
> > > >                                          mmap_arg.offset);
> > > >                             if (ptr != MAP_FAILED) {
> > > > diff --git a/tests/i915/gem_mmap_offset.c
> > b/tests/i915/gem_mmap_offset.c
> > > > index 5781b2fb..0933ed94 100644
> > > > --- a/tests/i915/gem_mmap_offset.c
> > > > +++ b/tests/i915/gem_mmap_offset.c
> > > > @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t
> > offset, uint64_t size,
> > > >     if (mmap_offset_ioctl(i915, &arg))
> > > >             return NULL;
> > > >
> > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > > > +   ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > > >     if (ptr == MAP_FAILED)
> > > >             ptr = NULL;
> > > >     else
> > > > @@ -214,12 +214,12 @@ static void isolation(int i915)
> > > >                      t->name, B, b, offset_b);
> > > >
> > > >             errno = 0;
> > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> > offset_a);
> > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> > > >             igt_assert(ptr == MAP_FAILED);
> > > >             igt_assert_eq(errno, EACCES);
> > > >
> > > >             errno = 0;
> > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> > offset_b);
> > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> > > >             igt_assert(ptr == MAP_FAILED);
> > > >             igt_assert_eq(errno, EACCES);
> > > >
> > > > @@ -237,13 +237,13 @@ static void isolation(int i915)
> > > >
> > > >             close(B);
> > > >
> > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >             igt_assert(ptr != MAP_FAILED);
> > > >             munmap(ptr, 4096);
> > > >
> > > >             close(A);
> > > >
> > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >             igt_assert(ptr == MAP_FAILED);
> > > >     }
> > > >  }
> > > > @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
> > > >     _Atomic uint32_t *handles;
> > > >     size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
> > > >
> > > > -   handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > > +   handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >     igt_assert(handles != MAP_FAILED);
> > > >
> > > >     igt_fork(child, ncpus + 1) {
> > > > @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
> > > >                               &mmap_arg) != -1) {
> > > >                             void *ptr;
> > > >
> > > > -                           ptr = mmap64(0, 4096,
> > > > +                           ptr = mmap(0, 4096,
> > > >                                          PROT_WRITE, MAP_SHARED, i915,
> > > >                                          mmap_arg.offset);
> > > >                             if (ptr != MAP_FAILED) {
> > > > --
> > > > 2.37.3
> > > >
> >

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-09-28 12:44   ` Petri Latvala
  2022-09-28 15:19     ` Jake Freeland
@ 2022-09-28 15:36     ` Kamil Konieczny
  2022-10-03 13:16       ` Petri Latvala
  1 sibling, 1 reply; 15+ messages in thread
From: Kamil Konieczny @ 2022-09-28 15:36 UTC (permalink / raw)
  To: igt-dev; +Cc: Jake Freeland, Petri Latvala

On 2022-09-28 at 15:44:54 +0300, Petri Latvala wrote:
> On Wed, Sep 28, 2022 at 02:33:14PM +0200, Kamil Konieczny wrote:
> > Hi Jake,
> > 
> > this patch is missing commit message. Please put here short
> > description of change and why you do it. Change looks resonable
> > as on 64-bit systems both functions are the same.
> > 
> > On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> > > Signed-off-by: Jake Freeland <jfree@freebsd.org>
> > 
> > Adding Petri on cc as I do not know if anyone compiles this on
> > 32-bit platforms.
> 
> Aren't you supposed to use mmap() with _LARGEFILE_something even on
> 32-bit builds, instead of mmap64?
> 
> 
> -- 
> Petri Latvala
> 

imho _LARGEFILE_... is indeed needed on 32-bit builds, no need
for this on our current builds as Linux runs now on 64-bit
machines.

I was asking if you know of anyone compiling and using igt i915
code for 32-bit platform.

I see that this patch touches also igt_vgem lib so maybe we
should also ask arm igt users ?

--
Kamil

> 
> 
> > 
> > Regards,
> > Kamil
> > 
> > > ---
> > >  lib/i915/gem_mman.c          |  4 ++--
> > >  lib/igt_vgem.c               |  2 +-
> > >  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
> > >  tests/i915/gem_mmap_offset.c | 14 +++++++-------
> > >  4 files changed, 21 insertions(+), 21 deletions(-)
> > > 
> > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > index aa9ac6f3..0b41ba70 100644
> > > --- a/lib/i915/gem_mman.c
> > > +++ b/lib/i915/gem_mman.c
> > > @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
> > >  	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
> > >  		return NULL;
> > >  
> > > -	ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > +	ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > >  	if (ptr == MAP_FAILED)
> > >  		ptr = NULL;
> > >  	else
> > > @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
> > >  	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
> > >  		return NULL;
> > >  
> > > -	ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > +	ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > >  
> > >  	if (ptr == MAP_FAILED)
> > >  		ptr = NULL;
> > > diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> > > index 7f933b23..468383c7 100644
> > > --- a/lib/igt_vgem.c
> > > +++ b/lib/igt_vgem.c
> > > @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo, unsigned prot)
> > >  	if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
> > >  		return NULL;
> > >  
> > > -	ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > +	ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > >  	if (ptr == MAP_FAILED)
> > >  		return NULL;
> > >  
> > > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> > > index 4f05eb18..683eaf16 100644
> > > --- a/tests/i915/gem_mmap_gtt.c
> > > +++ b/tests/i915/gem_mmap_gtt.c
> > > @@ -113,11 +113,11 @@ test_access(int fd)
> > >  	mmap_arg.handle = handle;
> > >  	do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
> > >  
> > > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > >  			  MAP_SHARED, fd, mmap_arg.offset));
> > >  
> > >  	/* Check that the same offset on the other fd doesn't work. */
> > > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > >  			  MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
> > >  	igt_assert(errno == EACCES);
> > >  
> > > @@ -128,7 +128,7 @@ test_access(int fd)
> > >  
> > >  	/* Recheck that it works after flink. */
> > >  	/* Check that the same offset on the other fd doesn't work. */
> > > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > >  			  MAP_SHARED, fd2, mmap_arg.offset));
> > >  }
> > >  
> > > @@ -159,11 +159,11 @@ test_short(int fd)
> > >  	for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
> > >  		uint8_t *r, *w;
> > >  
> > > -		w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > +		w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > >  			   MAP_SHARED, fd, mmap_arg.offset);
> > >  		igt_assert(w != MAP_FAILED);
> > >  
> > > -		r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> > > +		r = mmap(0, pages * PAGE_SIZE, PROT_READ,
> > >  			   MAP_SHARED, fd, mmap_arg.offset);
> > >  		igt_assert(r != MAP_FAILED);
> > >  
> > > @@ -384,13 +384,13 @@ test_isolation(int i915)
> > >  
> > >  	close(B);
> > >  
> > > -	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > +	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > >  	igt_assert(ptr != MAP_FAILED);
> > >  	munmap(ptr, 4096);
> > >  
> > >  	close(A);
> > >  
> > > -	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > +	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > >  	igt_assert(ptr == MAP_FAILED);
> > >  }
> > >  
> > > @@ -400,7 +400,7 @@ test_close_race(int i915)
> > >  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > >  	_Atomic uint32_t *handles;
> > >  
> > > -	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > +	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > >  	igt_assert(handles != MAP_FAILED);
> > >  
> > >  	igt_fork(child, ncpus + 1) {
> > > @@ -418,7 +418,7 @@ test_close_race(int i915)
> > >  				  &mmap_arg) != -1) {
> > >  				void *ptr;
> > >  
> > > -				ptr = mmap64(0, 4096,
> > > +				ptr = mmap(0, 4096,
> > >  					     PROT_WRITE, MAP_SHARED, i915,
> > >  					     mmap_arg.offset);
> > >  				if (ptr != MAP_FAILED) {
> > > @@ -444,7 +444,7 @@ test_flink_race(int i915)
> > >  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > >  	_Atomic uint32_t *handles;
> > >  
> > > -	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > +	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > >  	igt_assert(handles != MAP_FAILED);
> > >  
> > >  	igt_fork(child, ncpus + 1) {
> > > @@ -469,7 +469,7 @@ test_flink_race(int i915)
> > >  				  &mmap_arg) != -1) {
> > >  				void *ptr;
> > >  
> > > -				ptr = mmap64(0, 4096,
> > > +				ptr = mmap(0, 4096,
> > >  					     PROT_WRITE, MAP_SHARED, fd,
> > >  					     mmap_arg.offset);
> > >  				if (ptr != MAP_FAILED) {
> > > diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
> > > index 5781b2fb..0933ed94 100644
> > > --- a/tests/i915/gem_mmap_offset.c
> > > +++ b/tests/i915/gem_mmap_offset.c
> > > @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t offset, uint64_t size,
> > >  	if (mmap_offset_ioctl(i915, &arg))
> > >  		return NULL;
> > >  
> > > -	ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > > +	ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > >  	if (ptr == MAP_FAILED)
> > >  		ptr = NULL;
> > >  	else
> > > @@ -214,12 +214,12 @@ static void isolation(int i915)
> > >  			 t->name, B, b, offset_b);
> > >  
> > >  		errno = 0;
> > > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> > > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> > >  		igt_assert(ptr == MAP_FAILED);
> > >  		igt_assert_eq(errno, EACCES);
> > >  
> > >  		errno = 0;
> > > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> > > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> > >  		igt_assert(ptr == MAP_FAILED);
> > >  		igt_assert_eq(errno, EACCES);
> > >  
> > > @@ -237,13 +237,13 @@ static void isolation(int i915)
> > >  
> > >  		close(B);
> > >  
> > > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > >  		igt_assert(ptr != MAP_FAILED);
> > >  		munmap(ptr, 4096);
> > >  
> > >  		close(A);
> > >  
> > > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > >  		igt_assert(ptr == MAP_FAILED);
> > >  	}
> > >  }
> > > @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
> > >  	_Atomic uint32_t *handles;
> > >  	size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
> > >  
> > > -	handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > +	handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > >  	igt_assert(handles != MAP_FAILED);
> > >  
> > >  	igt_fork(child, ncpus + 1) {
> > > @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
> > >  				  &mmap_arg) != -1) {
> > >  				void *ptr;
> > >  
> > > -				ptr = mmap64(0, 4096,
> > > +				ptr = mmap(0, 4096,
> > >  					     PROT_WRITE, MAP_SHARED, i915,
> > >  					     mmap_arg.offset);
> > >  				if (ptr != MAP_FAILED) {
> > > -- 
> > > 2.37.3
> > > 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-09-28 15:19     ` Jake Freeland
  2022-09-28 15:35       ` Petri Latvala
@ 2022-09-28 15:42       ` Kamil Konieczny
  2022-09-28 20:53         ` Jake Freeland
  1 sibling, 1 reply; 15+ messages in thread
From: Kamil Konieczny @ 2022-09-28 15:42 UTC (permalink / raw)
  To: igt-dev; +Cc: Jake Freeland, Petri Latvala

Hi Jake,

On 2022-09-28 at 10:19:04 -0500, Jake Freeland wrote:
> I cannot find any relevant documentation for both Linux and FreeBSD
> that mentions an mmap flag that supports large file allocation on
> 32-bit architectures.
> 
> Commit message:
> The mmap64() function exists to point 32-bit architectures to an mmap
> interface with the capability to address a 64-bit memory address space.
> As 32-bit machines are replaced by 64-bit, there is no longer a need to
> keep mmap64() around. This is especially apparent in operating systems
> like FreeBSD that exclude the mmap64() function altogether. This patch
> replaces all instances of mmap64() with mmap().
> 
> Jake Freeland

Commit message looks ok, please repost patch with this.

For the _LARGEFILE64_SOURCE, it looks like it is enough to define
_FILE_OFFSET_BITS on 32-bit platform during compile, see:

https://stackoverflow.com/questions/59453555/is-there-any-difference-between-mmap-vs-mmap64

The question is: are there any igt users of 32-bit platform with
GPU memory size bigger then 2GB ?

Regards,
Kamil

> 
> On Wed, Sep 28, 2022 at 7:45 AM Petri Latvala <petri.latvala@intel.com>
> wrote:
> 
> > On Wed, Sep 28, 2022 at 02:33:14PM +0200, Kamil Konieczny wrote:
> > > Hi Jake,
> > >
> > > this patch is missing commit message. Please put here short
> > > description of change and why you do it. Change looks resonable
> > > as on 64-bit systems both functions are the same.
> > >
> > > On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> > > > Signed-off-by: Jake Freeland <jfree@freebsd.org>
> > >
> > > Adding Petri on cc as I do not know if anyone compiles this on
> > > 32-bit platforms.
> >
> > Aren't you supposed to use mmap() with _LARGEFILE_something even on
> > 32-bit builds, instead of mmap64?
> >
> >
> > --
> > Petri Latvala
> >
> >
> >
> > >
> > > Regards,
> > > Kamil
> > >
> > > > ---
> > > >  lib/i915/gem_mman.c          |  4 ++--
> > > >  lib/igt_vgem.c               |  2 +-
> > > >  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
> > > >  tests/i915/gem_mmap_offset.c | 14 +++++++-------
> > > >  4 files changed, 21 insertions(+), 21 deletions(-)
> > > >
> > > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > > index aa9ac6f3..0b41ba70 100644
> > > > --- a/lib/i915/gem_mman.c
> > > > +++ b/lib/i915/gem_mman.c
> > > > @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle,
> > uint64_t size, unsigned prot)
> > > >     if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
> > > >             return NULL;
> > > >
> > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > > +   ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > >     if (ptr == MAP_FAILED)
> > > >             ptr = NULL;
> > > >     else
> > > > @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle,
> > uint64_t offset, uint64_t size,
> > > >     if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
> > > >             return NULL;
> > > >
> > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > > +   ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > >
> > > >     if (ptr == MAP_FAILED)
> > > >             ptr = NULL;
> > > > diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> > > > index 7f933b23..468383c7 100644
> > > > --- a/lib/igt_vgem.c
> > > > +++ b/lib/igt_vgem.c
> > > > @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo,
> > unsigned prot)
> > > >     if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
> > > >             return NULL;
> > > >
> > > > -   ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > > +   ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > >     if (ptr == MAP_FAILED)
> > > >             return NULL;
> > > >
> > > > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> > > > index 4f05eb18..683eaf16 100644
> > > > --- a/tests/i915/gem_mmap_gtt.c
> > > > +++ b/tests/i915/gem_mmap_gtt.c
> > > > @@ -113,11 +113,11 @@ test_access(int fd)
> > > >     mmap_arg.handle = handle;
> > > >     do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
> > > >
> > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >                       MAP_SHARED, fd, mmap_arg.offset));
> > > >
> > > >     /* Check that the same offset on the other fd doesn't work. */
> > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >                       MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
> > > >     igt_assert(errno == EACCES);
> > > >
> > > > @@ -128,7 +128,7 @@ test_access(int fd)
> > > >
> > > >     /* Recheck that it works after flink. */
> > > >     /* Check that the same offset on the other fd doesn't work. */
> > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >                       MAP_SHARED, fd2, mmap_arg.offset));
> > > >  }
> > > >
> > > > @@ -159,11 +159,11 @@ test_short(int fd)
> > > >     for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
> > > >             uint8_t *r, *w;
> > > >
> > > > -           w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > > +           w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > >                        MAP_SHARED, fd, mmap_arg.offset);
> > > >             igt_assert(w != MAP_FAILED);
> > > >
> > > > -           r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> > > > +           r = mmap(0, pages * PAGE_SIZE, PROT_READ,
> > > >                        MAP_SHARED, fd, mmap_arg.offset);
> > > >             igt_assert(r != MAP_FAILED);
> > > >
> > > > @@ -384,13 +384,13 @@ test_isolation(int i915)
> > > >
> > > >     close(B);
> > > >
> > > > -   ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +   ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >     igt_assert(ptr != MAP_FAILED);
> > > >     munmap(ptr, 4096);
> > > >
> > > >     close(A);
> > > >
> > > > -   ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +   ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >     igt_assert(ptr == MAP_FAILED);
> > > >  }
> > > >
> > > > @@ -400,7 +400,7 @@ test_close_race(int i915)
> > > >     const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > >     _Atomic uint32_t *handles;
> > > >
> > > > -   handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> > 0);
> > > > +   handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >     igt_assert(handles != MAP_FAILED);
> > > >
> > > >     igt_fork(child, ncpus + 1) {
> > > > @@ -418,7 +418,7 @@ test_close_race(int i915)
> > > >                               &mmap_arg) != -1) {
> > > >                             void *ptr;
> > > >
> > > > -                           ptr = mmap64(0, 4096,
> > > > +                           ptr = mmap(0, 4096,
> > > >                                          PROT_WRITE, MAP_SHARED, i915,
> > > >                                          mmap_arg.offset);
> > > >                             if (ptr != MAP_FAILED) {
> > > > @@ -444,7 +444,7 @@ test_flink_race(int i915)
> > > >     const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > >     _Atomic uint32_t *handles;
> > > >
> > > > -   handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> > 0);
> > > > +   handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >     igt_assert(handles != MAP_FAILED);
> > > >
> > > >     igt_fork(child, ncpus + 1) {
> > > > @@ -469,7 +469,7 @@ test_flink_race(int i915)
> > > >                               &mmap_arg) != -1) {
> > > >                             void *ptr;
> > > >
> > > > -                           ptr = mmap64(0, 4096,
> > > > +                           ptr = mmap(0, 4096,
> > > >                                          PROT_WRITE, MAP_SHARED, fd,
> > > >                                          mmap_arg.offset);
> > > >                             if (ptr != MAP_FAILED) {
> > > > diff --git a/tests/i915/gem_mmap_offset.c
> > b/tests/i915/gem_mmap_offset.c
> > > > index 5781b2fb..0933ed94 100644
> > > > --- a/tests/i915/gem_mmap_offset.c
> > > > +++ b/tests/i915/gem_mmap_offset.c
> > > > @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t
> > offset, uint64_t size,
> > > >     if (mmap_offset_ioctl(i915, &arg))
> > > >             return NULL;
> > > >
> > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > > > +   ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > > >     if (ptr == MAP_FAILED)
> > > >             ptr = NULL;
> > > >     else
> > > > @@ -214,12 +214,12 @@ static void isolation(int i915)
> > > >                      t->name, B, b, offset_b);
> > > >
> > > >             errno = 0;
> > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> > offset_a);
> > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> > > >             igt_assert(ptr == MAP_FAILED);
> > > >             igt_assert_eq(errno, EACCES);
> > > >
> > > >             errno = 0;
> > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> > offset_b);
> > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> > > >             igt_assert(ptr == MAP_FAILED);
> > > >             igt_assert_eq(errno, EACCES);
> > > >
> > > > @@ -237,13 +237,13 @@ static void isolation(int i915)
> > > >
> > > >             close(B);
> > > >
> > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >             igt_assert(ptr != MAP_FAILED);
> > > >             munmap(ptr, 4096);
> > > >
> > > >             close(A);
> > > >
> > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >             igt_assert(ptr == MAP_FAILED);
> > > >     }
> > > >  }
> > > > @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
> > > >     _Atomic uint32_t *handles;
> > > >     size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
> > > >
> > > > -   handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > > +   handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >     igt_assert(handles != MAP_FAILED);
> > > >
> > > >     igt_fork(child, ncpus + 1) {
> > > > @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
> > > >                               &mmap_arg) != -1) {
> > > >                             void *ptr;
> > > >
> > > > -                           ptr = mmap64(0, 4096,
> > > > +                           ptr = mmap(0, 4096,
> > > >                                          PROT_WRITE, MAP_SHARED, i915,
> > > >                                          mmap_arg.offset);
> > > >                             if (ptr != MAP_FAILED) {
> > > > --
> > > > 2.37.3
> > > >
> >

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-09-28 15:42       ` Kamil Konieczny
@ 2022-09-28 20:53         ` Jake Freeland
  0 siblings, 0 replies; 15+ messages in thread
From: Jake Freeland @ 2022-09-28 20:53 UTC (permalink / raw)
  To: Kamil Konieczny, igt-dev, Jake Freeland, Petri Latvala

[-- Attachment #1: Type: text/plain, Size: 12104 bytes --]

Kamil,

I just resubmitted 4 patches with appropriate commit messages.

Given 32-bit's maximum of 4GB of RAM, I am doubtful that it
would be practical to map over half of that to video memory.
At least from an integrated GPU's perspective.

Jake Freeland

On Wed, Sep 28, 2022 at 10:42 AM Kamil Konieczny <
kamil.konieczny@linux.intel.com> wrote:

> Hi Jake,
>
> On 2022-09-28 at 10:19:04 -0500, Jake Freeland wrote:
> > I cannot find any relevant documentation for both Linux and FreeBSD
> > that mentions an mmap flag that supports large file allocation on
> > 32-bit architectures.
> >
> > Commit message:
> > The mmap64() function exists to point 32-bit architectures to an mmap
> > interface with the capability to address a 64-bit memory address space.
> > As 32-bit machines are replaced by 64-bit, there is no longer a need to
> > keep mmap64() around. This is especially apparent in operating systems
> > like FreeBSD that exclude the mmap64() function altogether. This patch
> > replaces all instances of mmap64() with mmap().
> >
> > Jake Freeland
>
> Commit message looks ok, please repost patch with this.
>
> For the _LARGEFILE64_SOURCE, it looks like it is enough to define
> _FILE_OFFSET_BITS on 32-bit platform during compile, see:
>
>
> https://stackoverflow.com/questions/59453555/is-there-any-difference-between-mmap-vs-mmap64
>
> The question is: are there any igt users of 32-bit platform with
> GPU memory size bigger then 2GB ?
>
> Regards,
> Kamil
>
> >
> > On Wed, Sep 28, 2022 at 7:45 AM Petri Latvala <petri.latvala@intel.com>
> > wrote:
> >
> > > On Wed, Sep 28, 2022 at 02:33:14PM +0200, Kamil Konieczny wrote:
> > > > Hi Jake,
> > > >
> > > > this patch is missing commit message. Please put here short
> > > > description of change and why you do it. Change looks resonable
> > > > as on 64-bit systems both functions are the same.
> > > >
> > > > On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> > > > > Signed-off-by: Jake Freeland <jfree@freebsd.org>
> > > >
> > > > Adding Petri on cc as I do not know if anyone compiles this on
> > > > 32-bit platforms.
> > >
> > > Aren't you supposed to use mmap() with _LARGEFILE_something even on
> > > 32-bit builds, instead of mmap64?
> > >
> > >
> > > --
> > > Petri Latvala
> > >
> > >
> > >
> > > >
> > > > Regards,
> > > > Kamil
> > > >
> > > > > ---
> > > > >  lib/i915/gem_mman.c          |  4 ++--
> > > > >  lib/igt_vgem.c               |  2 +-
> > > > >  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
> > > > >  tests/i915/gem_mmap_offset.c | 14 +++++++-------
> > > > >  4 files changed, 21 insertions(+), 21 deletions(-)
> > > > >
> > > > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > > > index aa9ac6f3..0b41ba70 100644
> > > > > --- a/lib/i915/gem_mman.c
> > > > > +++ b/lib/i915/gem_mman.c
> > > > > @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle,
> > > uint64_t size, unsigned prot)
> > > > >     if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
> > > > >             return NULL;
> > > > >
> > > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > > > +   ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > > >     if (ptr == MAP_FAILED)
> > > > >             ptr = NULL;
> > > > >     else
> > > > > @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t
> handle,
> > > uint64_t offset, uint64_t size,
> > > > >     if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
> > > > >             return NULL;
> > > > >
> > > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset +
> offset);
> > > > > +   ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > > >
> > > > >     if (ptr == MAP_FAILED)
> > > > >             ptr = NULL;
> > > > > diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> > > > > index 7f933b23..468383c7 100644
> > > > > --- a/lib/igt_vgem.c
> > > > > +++ b/lib/igt_vgem.c
> > > > > @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo,
> > > unsigned prot)
> > > > >     if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
> > > > >             return NULL;
> > > > >
> > > > > -   ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > > > +   ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > > >     if (ptr == MAP_FAILED)
> > > > >             return NULL;
> > > > >
> > > > > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> > > > > index 4f05eb18..683eaf16 100644
> > > > > --- a/tests/i915/gem_mmap_gtt.c
> > > > > +++ b/tests/i915/gem_mmap_gtt.c
> > > > > @@ -113,11 +113,11 @@ test_access(int fd)
> > > > >     mmap_arg.handle = handle;
> > > > >     do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
> > > > >
> > > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > >                       MAP_SHARED, fd, mmap_arg.offset));
> > > > >
> > > > >     /* Check that the same offset on the other fd doesn't work. */
> > > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > >                       MAP_SHARED, fd2, mmap_arg.offset) ==
> MAP_FAILED);
> > > > >     igt_assert(errno == EACCES);
> > > > >
> > > > > @@ -128,7 +128,7 @@ test_access(int fd)
> > > > >
> > > > >     /* Recheck that it works after flink. */
> > > > >     /* Check that the same offset on the other fd doesn't work. */
> > > > > -   igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > > +   igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > >                       MAP_SHARED, fd2, mmap_arg.offset));
> > > > >  }
> > > > >
> > > > > @@ -159,11 +159,11 @@ test_short(int fd)
> > > > >     for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1)
> {
> > > > >             uint8_t *r, *w;
> > > > >
> > > > > -           w = mmap64(0, pages * PAGE_SIZE, PROT_READ |
> PROT_WRITE,
> > > > > +           w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > > >                        MAP_SHARED, fd, mmap_arg.offset);
> > > > >             igt_assert(w != MAP_FAILED);
> > > > >
> > > > > -           r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> > > > > +           r = mmap(0, pages * PAGE_SIZE, PROT_READ,
> > > > >                        MAP_SHARED, fd, mmap_arg.offset);
> > > > >             igt_assert(r != MAP_FAILED);
> > > > >
> > > > > @@ -384,13 +384,13 @@ test_isolation(int i915)
> > > > >
> > > > >     close(B);
> > > > >
> > > > > -   ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > > +   ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > >     igt_assert(ptr != MAP_FAILED);
> > > > >     munmap(ptr, 4096);
> > > > >
> > > > >     close(A);
> > > > >
> > > > > -   ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > > +   ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > >     igt_assert(ptr == MAP_FAILED);
> > > > >  }
> > > > >
> > > > > @@ -400,7 +400,7 @@ test_close_race(int i915)
> > > > >     const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > > >     _Atomic uint32_t *handles;
> > > > >
> > > > > -   handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON,
> -1,
> > > 0);
> > > > > +   handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> 0);
> > > > >     igt_assert(handles != MAP_FAILED);
> > > > >
> > > > >     igt_fork(child, ncpus + 1) {
> > > > > @@ -418,7 +418,7 @@ test_close_race(int i915)
> > > > >                               &mmap_arg) != -1) {
> > > > >                             void *ptr;
> > > > >
> > > > > -                           ptr = mmap64(0, 4096,
> > > > > +                           ptr = mmap(0, 4096,
> > > > >                                          PROT_WRITE, MAP_SHARED,
> i915,
> > > > >                                          mmap_arg.offset);
> > > > >                             if (ptr != MAP_FAILED) {
> > > > > @@ -444,7 +444,7 @@ test_flink_race(int i915)
> > > > >     const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > > >     _Atomic uint32_t *handles;
> > > > >
> > > > > -   handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON,
> -1,
> > > 0);
> > > > > +   handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> 0);
> > > > >     igt_assert(handles != MAP_FAILED);
> > > > >
> > > > >     igt_fork(child, ncpus + 1) {
> > > > > @@ -469,7 +469,7 @@ test_flink_race(int i915)
> > > > >                               &mmap_arg) != -1) {
> > > > >                             void *ptr;
> > > > >
> > > > > -                           ptr = mmap64(0, 4096,
> > > > > +                           ptr = mmap(0, 4096,
> > > > >                                          PROT_WRITE, MAP_SHARED,
> fd,
> > > > >                                          mmap_arg.offset);
> > > > >                             if (ptr != MAP_FAILED) {
> > > > > diff --git a/tests/i915/gem_mmap_offset.c
> > > b/tests/i915/gem_mmap_offset.c
> > > > > index 5781b2fb..0933ed94 100644
> > > > > --- a/tests/i915/gem_mmap_offset.c
> > > > > +++ b/tests/i915/gem_mmap_offset.c
> > > > > @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t
> > > offset, uint64_t size,
> > > > >     if (mmap_offset_ioctl(i915, &arg))
> > > > >             return NULL;
> > > > >
> > > > > -   ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset +
> offset);
> > > > > +   ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset +
> offset);
> > > > >     if (ptr == MAP_FAILED)
> > > > >             ptr = NULL;
> > > > >     else
> > > > > @@ -214,12 +214,12 @@ static void isolation(int i915)
> > > > >                      t->name, B, b, offset_b);
> > > > >
> > > > >             errno = 0;
> > > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> > > offset_a);
> > > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915,
> offset_a);
> > > > >             igt_assert(ptr == MAP_FAILED);
> > > > >             igt_assert_eq(errno, EACCES);
> > > > >
> > > > >             errno = 0;
> > > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> > > offset_b);
> > > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915,
> offset_b);
> > > > >             igt_assert(ptr == MAP_FAILED);
> > > > >             igt_assert_eq(errno, EACCES);
> > > > >
> > > > > @@ -237,13 +237,13 @@ static void isolation(int i915)
> > > > >
> > > > >             close(B);
> > > > >
> > > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A,
> offset_a);
> > > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A,
> offset_a);
> > > > >             igt_assert(ptr != MAP_FAILED);
> > > > >             munmap(ptr, 4096);
> > > > >
> > > > >             close(A);
> > > > >
> > > > > -           ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A,
> offset_a);
> > > > > +           ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A,
> offset_a);
> > > > >             igt_assert(ptr == MAP_FAILED);
> > > > >     }
> > > > >  }
> > > > > @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
> > > > >     _Atomic uint32_t *handles;
> > > > >     size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
> > > > >
> > > > > -   handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON,
> -1, 0);
> > > > > +   handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1,
> 0);
> > > > >     igt_assert(handles != MAP_FAILED);
> > > > >
> > > > >     igt_fork(child, ncpus + 1) {
> > > > > @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
> > > > >                               &mmap_arg) != -1) {
> > > > >                             void *ptr;
> > > > >
> > > > > -                           ptr = mmap64(0, 4096,
> > > > > +                           ptr = mmap(0, 4096,
> > > > >                                          PROT_WRITE, MAP_SHARED,
> i915,
> > > > >                                          mmap_arg.offset);
> > > > >                             if (ptr != MAP_FAILED) {
> > > > > --
> > > > > 2.37.3
> > > > >
> > >
>

[-- Attachment #2: Type: text/html, Size: 17162 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-09-28 15:36     ` Kamil Konieczny
@ 2022-10-03 13:16       ` Petri Latvala
  2022-10-05 20:38         ` Jake Freeland
  0 siblings, 1 reply; 15+ messages in thread
From: Petri Latvala @ 2022-10-03 13:16 UTC (permalink / raw)
  To: Kamil Konieczny, igt-dev, Jake Freeland

On Wed, Sep 28, 2022 at 05:36:36PM +0200, Kamil Konieczny wrote:
> On 2022-09-28 at 15:44:54 +0300, Petri Latvala wrote:
> > On Wed, Sep 28, 2022 at 02:33:14PM +0200, Kamil Konieczny wrote:
> > > Hi Jake,
> > > 
> > > this patch is missing commit message. Please put here short
> > > description of change and why you do it. Change looks resonable
> > > as on 64-bit systems both functions are the same.
> > > 
> > > On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> > > > Signed-off-by: Jake Freeland <jfree@freebsd.org>
> > > 
> > > Adding Petri on cc as I do not know if anyone compiles this on
> > > 32-bit platforms.
> > 
> > Aren't you supposed to use mmap() with _LARGEFILE_something even on
> > 32-bit builds, instead of mmap64?
> > 
> > 
> > -- 
> > Petri Latvala
> > 
> 
> imho _LARGEFILE_... is indeed needed on 32-bit builds, no need
> for this on our current builds as Linux runs now on 64-bit
> machines.
> 
> I was asking if you know of anyone compiling and using igt i915
> code for 32-bit platform.
> 
> I see that this patch touches also igt_vgem lib so maybe we
> should also ask arm igt users ?

Rob Clark suggested just using drm_mmap() and letting it figure out
whether to call mmap or mmap64. Although it just seems to call mmap()
anyway and assumes largefile always, except on android, except when
__LP64__ is set.

For IGT we could either use drm_mmap or just make the same documented
assumption.

-- 
Petri Latvala


> 
> --
> Kamil
> 
> > 
> > 
> > > 
> > > Regards,
> > > Kamil
> > > 
> > > > ---
> > > >  lib/i915/gem_mman.c          |  4 ++--
> > > >  lib/igt_vgem.c               |  2 +-
> > > >  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
> > > >  tests/i915/gem_mmap_offset.c | 14 +++++++-------
> > > >  4 files changed, 21 insertions(+), 21 deletions(-)
> > > > 
> > > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > > index aa9ac6f3..0b41ba70 100644
> > > > --- a/lib/i915/gem_mman.c
> > > > +++ b/lib/i915/gem_mman.c
> > > > @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
> > > >  	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
> > > >  		return NULL;
> > > >  
> > > > -	ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > > +	ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > >  	if (ptr == MAP_FAILED)
> > > >  		ptr = NULL;
> > > >  	else
> > > > @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
> > > >  	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
> > > >  		return NULL;
> > > >  
> > > > -	ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > > +	ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
> > > >  
> > > >  	if (ptr == MAP_FAILED)
> > > >  		ptr = NULL;
> > > > diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> > > > index 7f933b23..468383c7 100644
> > > > --- a/lib/igt_vgem.c
> > > > +++ b/lib/igt_vgem.c
> > > > @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo, unsigned prot)
> > > >  	if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
> > > >  		return NULL;
> > > >  
> > > > -	ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > > +	ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > >  	if (ptr == MAP_FAILED)
> > > >  		return NULL;
> > > >  
> > > > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> > > > index 4f05eb18..683eaf16 100644
> > > > --- a/tests/i915/gem_mmap_gtt.c
> > > > +++ b/tests/i915/gem_mmap_gtt.c
> > > > @@ -113,11 +113,11 @@ test_access(int fd)
> > > >  	mmap_arg.handle = handle;
> > > >  	do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
> > > >  
> > > > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >  			  MAP_SHARED, fd, mmap_arg.offset));
> > > >  
> > > >  	/* Check that the same offset on the other fd doesn't work. */
> > > > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >  			  MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
> > > >  	igt_assert(errno == EACCES);
> > > >  
> > > > @@ -128,7 +128,7 @@ test_access(int fd)
> > > >  
> > > >  	/* Recheck that it works after flink. */
> > > >  	/* Check that the same offset on the other fd doesn't work. */
> > > > -	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > +	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > >  			  MAP_SHARED, fd2, mmap_arg.offset));
> > > >  }
> > > >  
> > > > @@ -159,11 +159,11 @@ test_short(int fd)
> > > >  	for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
> > > >  		uint8_t *r, *w;
> > > >  
> > > > -		w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > > +		w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
> > > >  			   MAP_SHARED, fd, mmap_arg.offset);
> > > >  		igt_assert(w != MAP_FAILED);
> > > >  
> > > > -		r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> > > > +		r = mmap(0, pages * PAGE_SIZE, PROT_READ,
> > > >  			   MAP_SHARED, fd, mmap_arg.offset);
> > > >  		igt_assert(r != MAP_FAILED);
> > > >  
> > > > @@ -384,13 +384,13 @@ test_isolation(int i915)
> > > >  
> > > >  	close(B);
> > > >  
> > > > -	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >  	igt_assert(ptr != MAP_FAILED);
> > > >  	munmap(ptr, 4096);
> > > >  
> > > >  	close(A);
> > > >  
> > > > -	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >  	igt_assert(ptr == MAP_FAILED);
> > > >  }
> > > >  
> > > > @@ -400,7 +400,7 @@ test_close_race(int i915)
> > > >  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > >  	_Atomic uint32_t *handles;
> > > >  
> > > > -	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > > +	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >  	igt_assert(handles != MAP_FAILED);
> > > >  
> > > >  	igt_fork(child, ncpus + 1) {
> > > > @@ -418,7 +418,7 @@ test_close_race(int i915)
> > > >  				  &mmap_arg) != -1) {
> > > >  				void *ptr;
> > > >  
> > > > -				ptr = mmap64(0, 4096,
> > > > +				ptr = mmap(0, 4096,
> > > >  					     PROT_WRITE, MAP_SHARED, i915,
> > > >  					     mmap_arg.offset);
> > > >  				if (ptr != MAP_FAILED) {
> > > > @@ -444,7 +444,7 @@ test_flink_race(int i915)
> > > >  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > >  	_Atomic uint32_t *handles;
> > > >  
> > > > -	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > > +	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >  	igt_assert(handles != MAP_FAILED);
> > > >  
> > > >  	igt_fork(child, ncpus + 1) {
> > > > @@ -469,7 +469,7 @@ test_flink_race(int i915)
> > > >  				  &mmap_arg) != -1) {
> > > >  				void *ptr;
> > > >  
> > > > -				ptr = mmap64(0, 4096,
> > > > +				ptr = mmap(0, 4096,
> > > >  					     PROT_WRITE, MAP_SHARED, fd,
> > > >  					     mmap_arg.offset);
> > > >  				if (ptr != MAP_FAILED) {
> > > > diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
> > > > index 5781b2fb..0933ed94 100644
> > > > --- a/tests/i915/gem_mmap_offset.c
> > > > +++ b/tests/i915/gem_mmap_offset.c
> > > > @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t offset, uint64_t size,
> > > >  	if (mmap_offset_ioctl(i915, &arg))
> > > >  		return NULL;
> > > >  
> > > > -	ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > > > +	ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
> > > >  	if (ptr == MAP_FAILED)
> > > >  		ptr = NULL;
> > > >  	else
> > > > @@ -214,12 +214,12 @@ static void isolation(int i915)
> > > >  			 t->name, B, b, offset_b);
> > > >  
> > > >  		errno = 0;
> > > > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> > > > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
> > > >  		igt_assert(ptr == MAP_FAILED);
> > > >  		igt_assert_eq(errno, EACCES);
> > > >  
> > > >  		errno = 0;
> > > > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> > > > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
> > > >  		igt_assert(ptr == MAP_FAILED);
> > > >  		igt_assert_eq(errno, EACCES);
> > > >  
> > > > @@ -237,13 +237,13 @@ static void isolation(int i915)
> > > >  
> > > >  		close(B);
> > > >  
> > > > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >  		igt_assert(ptr != MAP_FAILED);
> > > >  		munmap(ptr, 4096);
> > > >  
> > > >  		close(A);
> > > >  
> > > > -		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > +		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > >  		igt_assert(ptr == MAP_FAILED);
> > > >  	}
> > > >  }
> > > > @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
> > > >  	_Atomic uint32_t *handles;
> > > >  	size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
> > > >  
> > > > -	handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > > +	handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
> > > >  	igt_assert(handles != MAP_FAILED);
> > > >  
> > > >  	igt_fork(child, ncpus + 1) {
> > > > @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
> > > >  				  &mmap_arg) != -1) {
> > > >  				void *ptr;
> > > >  
> > > > -				ptr = mmap64(0, 4096,
> > > > +				ptr = mmap(0, 4096,
> > > >  					     PROT_WRITE, MAP_SHARED, i915,
> > > >  					     mmap_arg.offset);
> > > >  				if (ptr != MAP_FAILED) {
> > > > -- 
> > > > 2.37.3
> > > > 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
  2022-10-03 13:16       ` Petri Latvala
@ 2022-10-05 20:38         ` Jake Freeland
  0 siblings, 0 replies; 15+ messages in thread
From: Jake Freeland @ 2022-10-05 20:38 UTC (permalink / raw)
  To: Petri Latvala; +Cc: igt-dev, Jake Freeland

[-- Attachment #1: Type: text/plain, Size: 12172 bytes --]

Petri and Kamil,

I just sent in a new patch under the name "Replaced instances of mmap64()
with drm_mmap()".
This patch follows Rob Clark's advice and uses drm_mmap() instead of mmap()
so 32-bit
machines are (partially) accounted for.

Thank you,
Jake Freeland

On Mon, Oct 3, 2022 at 8:17 AM Petri Latvala <petri.latvala@intel.com>
wrote:

> On Wed, Sep 28, 2022 at 05:36:36PM +0200, Kamil Konieczny wrote:
> > On 2022-09-28 at 15:44:54 +0300, Petri Latvala wrote:
> > > On Wed, Sep 28, 2022 at 02:33:14PM +0200, Kamil Konieczny wrote:
> > > > Hi Jake,
> > > >
> > > > this patch is missing commit message. Please put here short
> > > > description of change and why you do it. Change looks resonable
> > > > as on 64-bit systems both functions are the same.
> > > >
> > > > On 2022-09-18 at 17:15:35 -0500, Jake Freeland wrote:
> > > > > Signed-off-by: Jake Freeland <jfree@freebsd.org>
> > > >
> > > > Adding Petri on cc as I do not know if anyone compiles this on
> > > > 32-bit platforms.
> > >
> > > Aren't you supposed to use mmap() with _LARGEFILE_something even on
> > > 32-bit builds, instead of mmap64?
> > >
> > >
> > > --
> > > Petri Latvala
> > >
> >
> > imho _LARGEFILE_... is indeed needed on 32-bit builds, no need
> > for this on our current builds as Linux runs now on 64-bit
> > machines.
> >
> > I was asking if you know of anyone compiling and using igt i915
> > code for 32-bit platform.
> >
> > I see that this patch touches also igt_vgem lib so maybe we
> > should also ask arm igt users ?
>
> Rob Clark suggested just using drm_mmap() and letting it figure out
> whether to call mmap or mmap64. Although it just seems to call mmap()
> anyway and assumes largefile always, except on android, except when
> __LP64__ is set.
>
> For IGT we could either use drm_mmap or just make the same documented
> assumption.
>
> --
> Petri Latvala
>
>
> >
> > --
> > Kamil
> >
> > >
> > >
> > > >
> > > > Regards,
> > > > Kamil
> > > >
> > > > > ---
> > > > >  lib/i915/gem_mman.c          |  4 ++--
> > > > >  lib/igt_vgem.c               |  2 +-
> > > > >  tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
> > > > >  tests/i915/gem_mmap_offset.c | 14 +++++++-------
> > > > >  4 files changed, 21 insertions(+), 21 deletions(-)
> > > > >
> > > > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> > > > > index aa9ac6f3..0b41ba70 100644
> > > > > --- a/lib/i915/gem_mman.c
> > > > > +++ b/lib/i915/gem_mman.c
> > > > > @@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle,
> uint64_t size, unsigned prot)
> > > > >         if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
> > > > >                 return NULL;
> > > > >
> > > > > -       ptr = mmap64(0, size, prot, MAP_SHARED, fd,
> mmap_arg.offset);
> > > > > +       ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
> > > > >         if (ptr == MAP_FAILED)
> > > > >                 ptr = NULL;
> > > > >         else
> > > > > @@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t
> handle, uint64_t offset, uint64_t size,
> > > > >         if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
> > > > >                 return NULL;
> > > > >
> > > > > -       ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset +
> offset);
> > > > > +       ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset +
> offset);
> > > > >
> > > > >         if (ptr == MAP_FAILED)
> > > > >                 ptr = NULL;
> > > > > diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
> > > > > index 7f933b23..468383c7 100644
> > > > > --- a/lib/igt_vgem.c
> > > > > +++ b/lib/igt_vgem.c
> > > > > @@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo,
> unsigned prot)
> > > > >         if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
> > > > >                 return NULL;
> > > > >
> > > > > -       ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd,
> arg.offset);
> > > > > +       ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
> > > > >         if (ptr == MAP_FAILED)
> > > > >                 return NULL;
> > > > >
> > > > > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> > > > > index 4f05eb18..683eaf16 100644
> > > > > --- a/tests/i915/gem_mmap_gtt.c
> > > > > +++ b/tests/i915/gem_mmap_gtt.c
> > > > > @@ -113,11 +113,11 @@ test_access(int fd)
> > > > >         mmap_arg.handle = handle;
> > > > >         do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
> > > > >
> > > > > -       igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > > +       igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > >                           MAP_SHARED, fd, mmap_arg.offset));
> > > > >
> > > > >         /* Check that the same offset on the other fd doesn't
> work. */
> > > > > -       igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > > +       igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > >                           MAP_SHARED, fd2, mmap_arg.offset) ==
> MAP_FAILED);
> > > > >         igt_assert(errno == EACCES);
> > > > >
> > > > > @@ -128,7 +128,7 @@ test_access(int fd)
> > > > >
> > > > >         /* Recheck that it works after flink. */
> > > > >         /* Check that the same offset on the other fd doesn't
> work. */
> > > > > -       igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > > +       igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
> > > > >                           MAP_SHARED, fd2, mmap_arg.offset));
> > > > >  }
> > > > >
> > > > > @@ -159,11 +159,11 @@ test_short(int fd)
> > > > >         for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages
> <<= 1) {
> > > > >                 uint8_t *r, *w;
> > > > >
> > > > > -               w = mmap64(0, pages * PAGE_SIZE, PROT_READ |
> PROT_WRITE,
> > > > > +               w = mmap(0, pages * PAGE_SIZE, PROT_READ |
> PROT_WRITE,
> > > > >                            MAP_SHARED, fd, mmap_arg.offset);
> > > > >                 igt_assert(w != MAP_FAILED);
> > > > >
> > > > > -               r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
> > > > > +               r = mmap(0, pages * PAGE_SIZE, PROT_READ,
> > > > >                            MAP_SHARED, fd, mmap_arg.offset);
> > > > >                 igt_assert(r != MAP_FAILED);
> > > > >
> > > > > @@ -384,13 +384,13 @@ test_isolation(int i915)
> > > > >
> > > > >         close(B);
> > > > >
> > > > > -       ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > > +       ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > >         igt_assert(ptr != MAP_FAILED);
> > > > >         munmap(ptr, 4096);
> > > > >
> > > > >         close(A);
> > > > >
> > > > > -       ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > > +       ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
> > > > >         igt_assert(ptr == MAP_FAILED);
> > > > >  }
> > > > >
> > > > > @@ -400,7 +400,7 @@ test_close_race(int i915)
> > > > >         const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > > >         _Atomic uint32_t *handles;
> > > > >
> > > > > -       handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED |
> MAP_ANON, -1, 0);
> > > > > +       handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON,
> -1, 0);
> > > > >         igt_assert(handles != MAP_FAILED);
> > > > >
> > > > >         igt_fork(child, ncpus + 1) {
> > > > > @@ -418,7 +418,7 @@ test_close_race(int i915)
> > > > >                                   &mmap_arg) != -1) {
> > > > >                                 void *ptr;
> > > > >
> > > > > -                               ptr = mmap64(0, 4096,
> > > > > +                               ptr = mmap(0, 4096,
> > > > >                                              PROT_WRITE,
> MAP_SHARED, i915,
> > > > >                                              mmap_arg.offset);
> > > > >                                 if (ptr != MAP_FAILED) {
> > > > > @@ -444,7 +444,7 @@ test_flink_race(int i915)
> > > > >         const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
> > > > >         _Atomic uint32_t *handles;
> > > > >
> > > > > -       handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED |
> MAP_ANON, -1, 0);
> > > > > +       handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON,
> -1, 0);
> > > > >         igt_assert(handles != MAP_FAILED);
> > > > >
> > > > >         igt_fork(child, ncpus + 1) {
> > > > > @@ -469,7 +469,7 @@ test_flink_race(int i915)
> > > > >                                   &mmap_arg) != -1) {
> > > > >                                 void *ptr;
> > > > >
> > > > > -                               ptr = mmap64(0, 4096,
> > > > > +                               ptr = mmap(0, 4096,
> > > > >                                              PROT_WRITE,
> MAP_SHARED, fd,
> > > > >                                              mmap_arg.offset);
> > > > >                                 if (ptr != MAP_FAILED) {
> > > > > diff --git a/tests/i915/gem_mmap_offset.c
> b/tests/i915/gem_mmap_offset.c
> > > > > index 5781b2fb..0933ed94 100644
> > > > > --- a/tests/i915/gem_mmap_offset.c
> > > > > +++ b/tests/i915/gem_mmap_offset.c
> > > > > @@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle,
> uint64_t offset, uint64_t size,
> > > > >         if (mmap_offset_ioctl(i915, &arg))
> > > > >                 return NULL;
> > > > >
> > > > > -       ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset +
> offset);
> > > > > +       ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset +
> offset);
> > > > >         if (ptr == MAP_FAILED)
> > > > >                 ptr = NULL;
> > > > >         else
> > > > > @@ -214,12 +214,12 @@ static void isolation(int i915)
> > > > >                          t->name, B, b, offset_b);
> > > > >
> > > > >                 errno = 0;
> > > > > -               ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> offset_a);
> > > > > +               ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915,
> offset_a);
> > > > >                 igt_assert(ptr == MAP_FAILED);
> > > > >                 igt_assert_eq(errno, EACCES);
> > > > >
> > > > >                 errno = 0;
> > > > > -               ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915,
> offset_b);
> > > > > +               ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915,
> offset_b);
> > > > >                 igt_assert(ptr == MAP_FAILED);
> > > > >                 igt_assert_eq(errno, EACCES);
> > > > >
> > > > > @@ -237,13 +237,13 @@ static void isolation(int i915)
> > > > >
> > > > >                 close(B);
> > > > >
> > > > > -               ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A,
> offset_a);
> > > > > +               ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A,
> offset_a);
> > > > >                 igt_assert(ptr != MAP_FAILED);
> > > > >                 munmap(ptr, 4096);
> > > > >
> > > > >                 close(A);
> > > > >
> > > > > -               ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A,
> offset_a);
> > > > > +               ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A,
> offset_a);
> > > > >                 igt_assert(ptr == MAP_FAILED);
> > > > >         }
> > > > >  }
> > > > > @@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
> > > > >         _Atomic uint32_t *handles;
> > > > >         size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
> > > > >
> > > > > -       handles = mmap64(0, len, PROT_WRITE, MAP_SHARED |
> MAP_ANON, -1, 0);
> > > > > +       handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON,
> -1, 0);
> > > > >         igt_assert(handles != MAP_FAILED);
> > > > >
> > > > >         igt_fork(child, ncpus + 1) {
> > > > > @@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
> > > > >                                   &mmap_arg) != -1) {
> > > > >                                 void *ptr;
> > > > >
> > > > > -                               ptr = mmap64(0, 4096,
> > > > > +                               ptr = mmap(0, 4096,
> > > > >                                              PROT_WRITE,
> MAP_SHARED, i915,
> > > > >                                              mmap_arg.offset);
> > > > >                                 if (ptr != MAP_FAILED) {
> > > > > --
> > > > > 2.37.3
> > > > >
>

[-- Attachment #2: Type: text/html, Size: 17229 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
@ 2022-10-05 20:18 Jake Freeland
  0 siblings, 0 replies; 15+ messages in thread
From: Jake Freeland @ 2022-10-05 20:18 UTC (permalink / raw)
  To: igt-dev, kamil.konieczny, petri.latvala; +Cc: Jake Freeland

The mmap64() function exists to point 32-bit architectures to an mmap
interface with the capability to address a 64-bit memory address space.
As 32-bit machines are replaced by 64-bit, there is no longer a need to
keep mmap64() around. This is especially apparent in operating systems
like FreeBSD that exclude the mmap64() function altogether. This patch
replaces all instances of mmap64() with mmap().

Signed-off-by: Jake Freeland <jfree@freebsd.org>
---
 lib/i915/gem_mman.c          |  4 ++--
 lib/igt_vgem.c               |  2 +-
 tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
 tests/i915/gem_mmap_offset.c | 12 ++++++------
 4 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
index aa9ac6f3..a9a3bc42 100644
--- a/lib/i915/gem_mman.c
+++ b/lib/i915/gem_mman.c
@@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
 	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
+	ptr = drm_mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
 	else
@@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
 	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
+	ptr = drm_mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
 
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
index 7f933b23..4e30415b 100644
--- a/lib/igt_vgem.c
+++ b/lib/igt_vgem.c
@@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo, unsigned prot)
 	if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
 		return NULL;
 
-	ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
+	ptr = drm_mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
 	if (ptr == MAP_FAILED)
 		return NULL;
 
diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index e39b9047..64c4de60 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -113,11 +113,11 @@ test_access(int fd)
 	mmap_arg.handle = handle;
 	do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
 
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(drm_mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd, mmap_arg.offset));
 
 	/* Check that the same offset on the other fd doesn't work. */
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(drm_mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
 	igt_assert(errno == EACCES);
 
@@ -128,7 +128,7 @@ test_access(int fd)
 
 	/* Recheck that it works after flink. */
 	/* Check that the same offset on the other fd doesn't work. */
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(drm_mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd2, mmap_arg.offset));
 }
 
@@ -159,11 +159,11 @@ test_short(int fd)
 	for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
 		uint8_t *r, *w;
 
-		w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
+		w = drm_mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
 			   MAP_SHARED, fd, mmap_arg.offset);
 		igt_assert(w != MAP_FAILED);
 
-		r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
+		r = drm_mmap(0, pages * PAGE_SIZE, PROT_READ,
 			   MAP_SHARED, fd, mmap_arg.offset);
 		igt_assert(r != MAP_FAILED);
 
@@ -384,13 +384,13 @@ test_isolation(int i915)
 
 	close(B);
 
-	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+	ptr = drm_mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 	igt_assert(ptr != MAP_FAILED);
 	munmap(ptr, 4096);
 
 	close(A);
 
-	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+	ptr = drm_mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 	igt_assert(ptr == MAP_FAILED);
 }
 
@@ -400,7 +400,7 @@ test_close_race(int i915)
 	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 	_Atomic uint32_t *handles;
 
-	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = drm_mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -418,7 +418,7 @@ test_close_race(int i915)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = drm_mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, i915,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
@@ -444,7 +444,7 @@ test_flink_race(int i915)
 	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 	_Atomic uint32_t *handles;
 
-	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = drm_mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -469,7 +469,7 @@ test_flink_race(int i915)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = drm_mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, fd,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
index 2b416edd..126aaa24 100644
--- a/tests/i915/gem_mmap_offset.c
+++ b/tests/i915/gem_mmap_offset.c
@@ -67,7 +67,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t offset, uint64_t size,
 	if (mmap_offset_ioctl(i915, &arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
+	ptr = drm_mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
 	else
@@ -321,12 +321,12 @@ static void isolation(int i915)
 				 t->name, B, b, offset_b);
 
 			errno = 0;
-			ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
+			ptr = drm_mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
 			igt_assert(ptr == MAP_FAILED);
 			igt_assert_eq(errno, EACCES);
 
 			errno = 0;
-			ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
+			ptr = drm_mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
 			igt_assert(ptr == MAP_FAILED);
 			igt_assert_eq(errno, EACCES);
 
@@ -344,13 +344,13 @@ static void isolation(int i915)
 
 			close(B);
 
-			ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+			ptr = drm_mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 			igt_assert(ptr != MAP_FAILED);
 			munmap(ptr, 4096);
 
 			close(A);
 
-			ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+			ptr = drm_mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 			igt_assert(ptr == MAP_FAILED);
 		}
 	}
@@ -553,7 +553,7 @@ static void close_race(int i915, int timeout)
 	_Atomic uint32_t *handles;
 	size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
 
-	handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = drm_mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
-- 
2.37.0 (Apple Git-136)

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
@ 2022-09-28 20:22 Jake Freeland
  0 siblings, 0 replies; 15+ messages in thread
From: Jake Freeland @ 2022-09-28 20:22 UTC (permalink / raw)
  To: igt-dev; +Cc: Jake Freeland

The mmap64() function exists to point 32-bit architectures to an mmap
interface with the capability to address a 64-bit memory address space.
As 32-bit machines are replaced by 64-bit, there is no longer a need to
keep mmap64() around. This is especially apparent in operating systems
like FreeBSD that exclude the mmap64() function altogether. This patch
replaces all instances of mmap64() with mmap().

Signed-off-by: Jake Freeland <jfree@freebsd.org>
---
 lib/i915/gem_mman.c          |  4 ++--
 lib/igt_vgem.c               |  2 +-
 tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
 tests/i915/gem_mmap_offset.c | 14 +++++++-------
 4 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
index aa9ac6f3..0b41ba70 100644
--- a/lib/i915/gem_mman.c
+++ b/lib/i915/gem_mman.c
@@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
 	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
 	else
@@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
 	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
 
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
index 7f933b23..468383c7 100644
--- a/lib/igt_vgem.c
+++ b/lib/igt_vgem.c
@@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo, unsigned prot)
 	if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
 		return NULL;
 
-	ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
+	ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
 	if (ptr == MAP_FAILED)
 		return NULL;
 
diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index 4f05eb18..683eaf16 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -113,11 +113,11 @@ test_access(int fd)
 	mmap_arg.handle = handle;
 	do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
 
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd, mmap_arg.offset));
 
 	/* Check that the same offset on the other fd doesn't work. */
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
 	igt_assert(errno == EACCES);
 
@@ -128,7 +128,7 @@ test_access(int fd)
 
 	/* Recheck that it works after flink. */
 	/* Check that the same offset on the other fd doesn't work. */
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd2, mmap_arg.offset));
 }
 
@@ -159,11 +159,11 @@ test_short(int fd)
 	for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
 		uint8_t *r, *w;
 
-		w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
+		w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
 			   MAP_SHARED, fd, mmap_arg.offset);
 		igt_assert(w != MAP_FAILED);
 
-		r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
+		r = mmap(0, pages * PAGE_SIZE, PROT_READ,
 			   MAP_SHARED, fd, mmap_arg.offset);
 		igt_assert(r != MAP_FAILED);
 
@@ -384,13 +384,13 @@ test_isolation(int i915)
 
 	close(B);
 
-	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 	igt_assert(ptr != MAP_FAILED);
 	munmap(ptr, 4096);
 
 	close(A);
 
-	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 	igt_assert(ptr == MAP_FAILED);
 }
 
@@ -400,7 +400,7 @@ test_close_race(int i915)
 	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 	_Atomic uint32_t *handles;
 
-	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -418,7 +418,7 @@ test_close_race(int i915)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, i915,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
@@ -444,7 +444,7 @@ test_flink_race(int i915)
 	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 	_Atomic uint32_t *handles;
 
-	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -469,7 +469,7 @@ test_flink_race(int i915)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, fd,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
index fc4245f6..c0031e34 100644
--- a/tests/i915/gem_mmap_offset.c
+++ b/tests/i915/gem_mmap_offset.c
@@ -67,7 +67,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t offset, uint64_t size,
 	if (mmap_offset_ioctl(i915, &arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
 	else
@@ -321,12 +321,12 @@ static void isolation(int i915)
 				 t->name, B, b, offset_b);
 
 			errno = 0;
-			ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
+			ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
 			igt_assert(ptr == MAP_FAILED);
 			igt_assert_eq(errno, EACCES);
 
 			errno = 0;
-			ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
+			ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
 			igt_assert(ptr == MAP_FAILED);
 			igt_assert_eq(errno, EACCES);
 
@@ -344,13 +344,13 @@ static void isolation(int i915)
 
 			close(B);
 
-			ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+			ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 			igt_assert(ptr != MAP_FAILED);
 			munmap(ptr, 4096);
 
 			close(A);
 
-			ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+			ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 			igt_assert(ptr == MAP_FAILED);
 		}
 	}
@@ -553,7 +553,7 @@ static void close_race(int i915, int timeout)
 	_Atomic uint32_t *handles;
 	size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
 
-	handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -572,7 +572,7 @@ static void close_race(int i915, int timeout)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, i915,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
-- 
2.37.3

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap()
@ 2022-09-28 19:35 Jake Freeland
  0 siblings, 0 replies; 15+ messages in thread
From: Jake Freeland @ 2022-09-28 19:35 UTC (permalink / raw)
  To: igt-dev, kamil.konieczny, petri.latvala; +Cc: Jake Freeland

The mmap64() function exists to point 32-bit architectures to an mmap
interface with the capability to address a 64-bit memory address space.
As 32-bit machines are replaced by 64-bit, there is no longer a need to
keep mmap64() around. This is especially apparent in operating systems
like FreeBSD that exclude the mmap64() function altogether. This patch
replaces all instances of mmap64() with mmap().

Signed-off-by: Jake Freeland <jfree@freebsd.org>
---
 lib/i915/gem_mman.c          |  4 ++--
 lib/igt_vgem.c               |  2 +-
 tests/i915/gem_mmap_gtt.c    | 22 +++++++++++-----------
 tests/i915/gem_mmap_offset.c | 14 +++++++-------
 4 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
index aa9ac6f3..0b41ba70 100644
--- a/lib/i915/gem_mman.c
+++ b/lib/i915/gem_mman.c
@@ -118,7 +118,7 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
 	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, fd, mmap_arg.offset);
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
 	else
@@ -331,7 +331,7 @@ void *__gem_mmap_offset(int fd, uint32_t handle, uint64_t offset, uint64_t size,
 	if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, fd, arg.offset + offset);
 
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c
index 7f933b23..468383c7 100644
--- a/lib/igt_vgem.c
+++ b/lib/igt_vgem.c
@@ -76,7 +76,7 @@ void *__vgem_mmap(int fd, struct vgem_bo *bo, unsigned prot)
 	if (drmIoctl(fd, DRM_IOCTL_MODE_MAP_DUMB, &arg))
 		return NULL;
 
-	ptr = mmap64(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
+	ptr = mmap(0, bo->size, prot, MAP_SHARED, fd, arg.offset);
 	if (ptr == MAP_FAILED)
 		return NULL;
 
diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index 4f05eb18..683eaf16 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -113,11 +113,11 @@ test_access(int fd)
 	mmap_arg.handle = handle;
 	do_ioctl(fd, DRM_IOCTL_I915_GEM_MMAP_GTT, &mmap_arg);
 
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd, mmap_arg.offset));
 
 	/* Check that the same offset on the other fd doesn't work. */
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd2, mmap_arg.offset) == MAP_FAILED);
 	igt_assert(errno == EACCES);
 
@@ -128,7 +128,7 @@ test_access(int fd)
 
 	/* Recheck that it works after flink. */
 	/* Check that the same offset on the other fd doesn't work. */
-	igt_assert(mmap64(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
+	igt_assert(mmap(0, OBJECT_SIZE, PROT_READ | PROT_WRITE,
 			  MAP_SHARED, fd2, mmap_arg.offset));
 }
 
@@ -159,11 +159,11 @@ test_short(int fd)
 	for (pages = 1; pages <= OBJECT_SIZE / PAGE_SIZE; pages <<= 1) {
 		uint8_t *r, *w;
 
-		w = mmap64(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
+		w = mmap(0, pages * PAGE_SIZE, PROT_READ | PROT_WRITE,
 			   MAP_SHARED, fd, mmap_arg.offset);
 		igt_assert(w != MAP_FAILED);
 
-		r = mmap64(0, pages * PAGE_SIZE, PROT_READ,
+		r = mmap(0, pages * PAGE_SIZE, PROT_READ,
 			   MAP_SHARED, fd, mmap_arg.offset);
 		igt_assert(r != MAP_FAILED);
 
@@ -384,13 +384,13 @@ test_isolation(int i915)
 
 	close(B);
 
-	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 	igt_assert(ptr != MAP_FAILED);
 	munmap(ptr, 4096);
 
 	close(A);
 
-	ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+	ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 	igt_assert(ptr == MAP_FAILED);
 }
 
@@ -400,7 +400,7 @@ test_close_race(int i915)
 	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 	_Atomic uint32_t *handles;
 
-	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -418,7 +418,7 @@ test_close_race(int i915)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, i915,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
@@ -444,7 +444,7 @@ test_flink_race(int i915)
 	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 	_Atomic uint32_t *handles;
 
-	handles = mmap64(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -469,7 +469,7 @@ test_flink_race(int i915)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, fd,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
index 5781b2fb..0933ed94 100644
--- a/tests/i915/gem_mmap_offset.c
+++ b/tests/i915/gem_mmap_offset.c
@@ -66,7 +66,7 @@ __mmap_offset(int i915, uint32_t handle, uint64_t offset, uint64_t size,
 	if (mmap_offset_ioctl(i915, &arg))
 		return NULL;
 
-	ptr = mmap64(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
+	ptr = mmap(0, size, prot, MAP_SHARED, i915, arg.offset + offset);
 	if (ptr == MAP_FAILED)
 		ptr = NULL;
 	else
@@ -214,12 +214,12 @@ static void isolation(int i915)
 			 t->name, B, b, offset_b);
 
 		errno = 0;
-		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
+		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_a);
 		igt_assert(ptr == MAP_FAILED);
 		igt_assert_eq(errno, EACCES);
 
 		errno = 0;
-		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
+		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, i915, offset_b);
 		igt_assert(ptr == MAP_FAILED);
 		igt_assert_eq(errno, EACCES);
 
@@ -237,13 +237,13 @@ static void isolation(int i915)
 
 		close(B);
 
-		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 		igt_assert(ptr != MAP_FAILED);
 		munmap(ptr, 4096);
 
 		close(A);
 
-		ptr = mmap64(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
+		ptr = mmap(0, 4096, PROT_READ, MAP_SHARED, A, offset_a);
 		igt_assert(ptr == MAP_FAILED);
 	}
 }
@@ -401,7 +401,7 @@ static void close_race(int i915, int timeout)
 	_Atomic uint32_t *handles;
 	size_t len = ALIGN((ncpus + 1) * sizeof(uint32_t), 4096);
 
-	handles = mmap64(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+	handles = mmap(0, len, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(handles != MAP_FAILED);
 
 	igt_fork(child, ncpus + 1) {
@@ -420,7 +420,7 @@ static void close_race(int i915, int timeout)
 				  &mmap_arg) != -1) {
 				void *ptr;
 
-				ptr = mmap64(0, 4096,
+				ptr = mmap(0, 4096,
 					     PROT_WRITE, MAP_SHARED, i915,
 					     mmap_arg.offset);
 				if (ptr != MAP_FAILED) {
-- 
2.37.3

^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-10-05 20:39 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-18 22:15 [igt-dev] [PATCH i-g-t] Replaced instances of mmap64() with mmap() Jake Freeland
2022-09-18 23:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-09-19  1:27 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-28 12:33 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2022-09-28 12:44   ` Petri Latvala
2022-09-28 15:19     ` Jake Freeland
2022-09-28 15:35       ` Petri Latvala
2022-09-28 15:42       ` Kamil Konieczny
2022-09-28 20:53         ` Jake Freeland
2022-09-28 15:36     ` Kamil Konieczny
2022-10-03 13:16       ` Petri Latvala
2022-10-05 20:38         ` Jake Freeland
2022-09-28 19:35 Jake Freeland
2022-09-28 20:22 Jake Freeland
2022-10-05 20:18 Jake Freeland

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.