All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][next] ext4: remove unused string "deprecated_msg"
@ 2022-10-04 11:21 Colin Ian King
  2022-10-04 17:19 ` Ojaswin Mujoo
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-10-04 11:21 UTC (permalink / raw)
  To: Theodore Ts'o, Andreas Dilger, linux-ext4
  Cc: kernel-janitors, linux-kernel

The string deprecated_msg is no longer being used, remove it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/ext4/super.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 2335452efed0..981563c8245e 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1740,10 +1740,6 @@ static const struct fs_parameter_spec ext4_param_specs[] = {
 
 #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))
 
-static const char deprecated_msg[] =
-	"Mount option \"%s\" will be removed by %s\n"
-	"Contact linux-ext4@vger.kernel.org if you think we should keep it.\n";
-
 #define MOPT_SET	0x0001
 #define MOPT_CLEAR	0x0002
 #define MOPT_NOSUPPORT	0x0004
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] ext4: remove unused string "deprecated_msg"
  2022-10-04 11:21 [PATCH][next] ext4: remove unused string "deprecated_msg" Colin Ian King
@ 2022-10-04 17:19 ` Ojaswin Mujoo
  0 siblings, 0 replies; 2+ messages in thread
From: Ojaswin Mujoo @ 2022-10-04 17:19 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, kernel-janitors,
	linux-kernel

On Tue, Oct 04, 2022 at 12:21:14PM +0100, Colin Ian King wrote:
> The string deprecated_msg is no longer being used, remove it.

So if IIUC we use this string as a standard message whenever we use any
mount options about to be deprecated. We don't seem to have any
deprecated mount options right now but we might want to keep the string
around for future?

> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  fs/ext4/super.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 2335452efed0..981563c8245e 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1740,10 +1740,6 @@ static const struct fs_parameter_spec ext4_param_specs[] = {
>  
>  #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))
>  
> -static const char deprecated_msg[] =
> -	"Mount option \"%s\" will be removed by %s\n"
> -	"Contact linux-ext4@vger.kernel.org if you think we should keep it.\n";
> -
>  #define MOPT_SET	0x0001
>  #define MOPT_CLEAR	0x0002
>  #define MOPT_NOSUPPORT	0x0004
> -- 
> 2.37.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-04 17:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 11:21 [PATCH][next] ext4: remove unused string "deprecated_msg" Colin Ian King
2022-10-04 17:19 ` Ojaswin Mujoo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.