Help in patch message

Help in patch message

[Kloudifold]

Dear Outreachy Mentors,

I hope this email finds you well. As an Outreachy applicant,
I have been working on submitting patches to the kernel, but
I seem to be having trouble getting them accepted. I have
read the Outreachy tutorials and tried to follow the best practices,
but my patch messages keep getting rejected.

I really wonder if I have some kind of language problem, I don't
actually know how to say something?

Recently, I submitted a patch that has been rejected, and I am not
sure whether to go ahead and fix it or create a new one.
I would greatly appreciate your guidance on how to proceed

Thank you for your help and guidance throughout this process.
I look forward to your response.

Best regards,

Kloudifold

Re: Help in patch message

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

On Tue, Mar 14, 2023 at 09:53:46AM +0800, Kloudifold wrote:
> Recently, I submitted a patch that has been rejected, and I am not
> sure whether to go ahead and fix it or create a new one.
> I would greatly appreciate your guidance on how to proceed

I think you refer to [1].

First and foremost, read Documentation/process/submittingpatches.rst.
Specifically, you need to address review changes requested by reviewers
who reply to your patch.

Then, send v3 with all requests addressed. Don't forget to build test
your patch. Don't forget to git pull latest staging tree and rebase
your patch on top of it.

Thanks.

[1]: https://lore.kernel.org/all/ZA+K6OdPe21k8F2k@CloudiRingWorld/ 

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Help in patch message

[Julia Lawall]

> Recently, I submitted a patch that has been rejected, and I am not
> sure whether to go ahead and fix it or create a new one.
> I would greatly appreciate your guidance on how to proceed

Please include relevant context in your message.  If a patch has been
rejected, eg someone says "This change is not a good idea for reason XYZ",
then you should move on to something else.  If you have gotten some
feedback on a patch, you should follow the feedback, and try to improve
the patch.

julia

Re: Help in patch message

[Khadija Kamran]

On Tue, Mar 14, 2023 at 09:53:46AM +0800, Kloudifold wrote:
> Dear Outreachy Mentors,
> 
> I hope this email finds you well. As an Outreachy applicant,
> I have been working on submitting patches to the kernel, but
> I seem to be having trouble getting them accepted. I have
> read the Outreachy tutorials and tried to follow the best practices,
> but my patch messages keep getting rejected.
> 
> I really wonder if I have some kind of language problem, I don't
> actually know how to say something?
> 
> Recently, I submitted a patch that has been rejected, and I am not
> sure whether to go ahead and fix it or create a new one.
> I would greatly appreciate your guidance on how to proceed
> 
> Thank you for your help and guidance throughout this process.
> I look forward to your response.
> 
> Best regards,
> 
> Kloudifold
> 
>

Hey Kloudifold!
Just keep going and do not give up. Keep asking questions if you get
stuck. You are already done with the setup. Patches are taking time for
me too. So I have submitted them with revisions. And if a change is not
accepted I go through some other files and send new patches. 
Best of luck! :)

Regards,
Khadija 

Re: Help in patch message

[Alison Schofield]

On Tue, Mar 14, 2023 at 09:53:46AM +0800, Kloudifold wrote:
> Dear Outreachy Mentors,
> 
> I hope this email finds you well. As an Outreachy applicant,
> I have been working on submitting patches to the kernel, but
> I seem to be having trouble getting them accepted. I have
> read the Outreachy tutorials and tried to follow the best practices,
> but my patch messages keep getting rejected.
> 
> I really wonder if I have some kind of language problem, I don't
> actually know how to say something?
> 
> Recently, I submitted a patch that has been rejected, and I am not
> sure whether to go ahead and fix it or create a new one.
> I would greatly appreciate your guidance on how to proceed
> 
> Thank you for your help and guidance throughout this process.
> I look forward to your response.

Hi Kloudifold,

I echo the other responses here. 
Before you press 'send' on v3, walk thru the tutorial again. There will
be parts that make more sense now that you are doing revisions and 
that you have comments.

It looks like you will be preparing and sending v3 of your camelcase patch.

The biggest thing I see recently is compile errors on your patch, and
others patches. Sometimes lkp finds compile errors in build environments
that are less common, and that is less of a concern. They need to be fixed,
but I don't expect you all to run all build environments. That is what lkp does.

That said, be sure to check for new .o's each time you think you are 
compiling the driver.

Kudos to you for driving one patch to completion before sending out
another!

Keep at it!
Alison

> 
> Best regards,
> 
> Kloudifold
> 
>