* [PATCH] nfc: trf7970a: mark OF related data as maybe unused
@ 2023-03-11 11:13 Krzysztof Kozlowski
2023-03-13 16:28 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-11 11:13 UTC (permalink / raw)
To: Mark Greer, Krzysztof Kozlowski, linux-wireless, netdev, linux-kernel
The driver can be compile tested with !CONFIG_OF making certain data
unused:
drivers/nfc/trf7970a.c:2232:34: error: ‘trf7970a_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/nfc/trf7970a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
index 21d68664fe08..7eb17f46a815 100644
--- a/drivers/nfc/trf7970a.c
+++ b/drivers/nfc/trf7970a.c
@@ -2229,7 +2229,7 @@ static const struct dev_pm_ops trf7970a_pm_ops = {
trf7970a_pm_runtime_resume, NULL)
};
-static const struct of_device_id trf7970a_of_match[] = {
+static const struct of_device_id trf7970a_of_match[] __maybe_unused = {
{.compatible = "ti,trf7970a",},
{},
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nfc: trf7970a: mark OF related data as maybe unused
2023-03-11 11:13 [PATCH] nfc: trf7970a: mark OF related data as maybe unused Krzysztof Kozlowski
@ 2023-03-13 16:28 ` Simon Horman
2023-03-14 4:08 ` Mark Greer
2023-03-15 8:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-03-13 16:28 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Mark Greer, linux-wireless, netdev, linux-kernel
On Sat, Mar 11, 2023 at 12:13:28PM +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/nfc/trf7970a.c:2232:34: error: ‘trf7970a_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nfc: trf7970a: mark OF related data as maybe unused
2023-03-11 11:13 [PATCH] nfc: trf7970a: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-13 16:28 ` Simon Horman
@ 2023-03-14 4:08 ` Mark Greer
2023-03-15 8:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Mark Greer @ 2023-03-14 4:08 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Mark Greer, linux-wireless, netdev, linux-kernel
On Sat, Mar 11, 2023 at 12:13:28PM +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/nfc/trf7970a.c:2232:34: error: ‘trf7970a_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/nfc/trf7970a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 21d68664fe08..7eb17f46a815 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c
> @@ -2229,7 +2229,7 @@ static const struct dev_pm_ops trf7970a_pm_ops = {
> trf7970a_pm_runtime_resume, NULL)
> };
>
> -static const struct of_device_id trf7970a_of_match[] = {
> +static const struct of_device_id trf7970a_of_match[] __maybe_unused = {
> {.compatible = "ti,trf7970a",},
> {},
> };
> --
> 2.34.1
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nfc: trf7970a: mark OF related data as maybe unused
2023-03-11 11:13 [PATCH] nfc: trf7970a: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-13 16:28 ` Simon Horman
2023-03-14 4:08 ` Mark Greer
@ 2023-03-15 8:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-15 8:10 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: mgreer, linux-wireless, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Sat, 11 Mar 2023 12:13:28 +0100 you wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/nfc/trf7970a.c:2232:34: error: ‘trf7970a_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> [...]
Here is the summary with links:
- nfc: trf7970a: mark OF related data as maybe unused
https://git.kernel.org/netdev/net-next/c/a52ed50a04de
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-15 8:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 11:13 [PATCH] nfc: trf7970a: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-13 16:28 ` Simon Horman
2023-03-14 4:08 ` Mark Greer
2023-03-15 8:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.