a tiny patch related to two shell scripts that use 2&>1 in place of 2>&1

a tiny patch related to two shell scripts that use 2&>1 in place of 2>&1

[Patrice Duroux]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hi,

Further to the following item reported to the Debian QA mailing list:
https://lists.debian.org/debian-qa/2023/02/msg00052.html
here is attached a patch regarding two possible candidates in the
linux source tree.

Regards,
Patrice

[-- Attachment #2: linux_scripts.patch --]
[-- Type: text/x-patch, Size: 1107 bytes --]

diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
index e01973d4e0fb..f062ae9a95e1 100755
--- a/tools/perf/tests/shell/record_offcpu.sh
+++ b/tools/perf/tests/shell/record_offcpu.sh
@@ -65,7 +65,7 @@ test_offcpu_child() {
 
   # perf bench sched messaging creates 400 processes
   if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
-    perf bench sched messaging -g 10 > /dev/null 2&>1
+    perf bench sched messaging -g 10 > /dev/null 2>&1
   then
     echo "Child task off-cpu test [Failed record]"
     err=1
diff --git a/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh b/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
index a1f269ee84da..92acab83fbe2 100755
--- a/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
+++ b/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
@@ -31,7 +31,7 @@ trap 'cleanup' EXIT
 
 eth=${NETIFS[p1]}
 
-ip link del br0 2&>1 >/dev/null || :
+ip link del br0 2>&1 >/dev/null || :
 ip link add br0 type bridge && ip link set $eth master br0
 
 (while :; do

[PATCH 2/2] replace 2&>1 by 2>&1

[Patrice Duroux]

Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
---
 .../testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh b/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
index a1f269ee84da..92acab83fbe2 100755
--- a/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
+++ b/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
@@ -31,7 +31,7 @@ trap 'cleanup' EXIT
 
 eth=${NETIFS[p1]}
 
-ip link del br0 2&>1 >/dev/null || :
+ip link del br0 2>&1 >/dev/null || :
 ip link add br0 type bridge && ip link set $eth master br0
 
 (while :; do
-- 
2.39.2

[PATCH 1/2] replace 2&>1 by 2>&1

[Patrice Duroux]

Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
---
 tools/perf/tests/shell/record_offcpu.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
index e01973d4e0fb..f062ae9a95e1 100755
--- a/tools/perf/tests/shell/record_offcpu.sh
+++ b/tools/perf/tests/shell/record_offcpu.sh
@@ -65,7 +65,7 @@ test_offcpu_child() {
 
   # perf bench sched messaging creates 400 processes
   if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
-    perf bench sched messaging -g 10 > /dev/null 2&>1
+    perf bench sched messaging -g 10 > /dev/null 2>&1
   then
     echo "Child task off-cpu test [Failed record]"
     err=1
-- 
2.39.2

Re: [PATCH 2/2] replace 2&>1 by 2>&1

[Shuah Khan]

On 3/3/23 12:20, Patrice Duroux wrote:

Missing commit log and the commit summary doesn't include
the subsystem - try selftests/net:

Also say what this change is fixing instead of making that
the commit summary.

> Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
> ---
>   .../testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh b/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
> index a1f269ee84da..92acab83fbe2 100755
> --- a/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
> +++ b/tools/testing/selftests/drivers/net/dsa/test_bridge_fdb_stress.sh
> @@ -31,7 +31,7 @@ trap 'cleanup' EXIT
>   
>   eth=${NETIFS[p1]}
>   
> -ip link del br0 2&>1 >/dev/null || :
> +ip link del br0 2>&1 >/dev/null || :
>   ip link add br0 type bridge && ip link set $eth master br0
>   
>   (while :; do

thanks,
-- Shuah

Re: [PATCH 1/2] replace 2&>1 by 2>&1

[Ian Rogers]

On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
>
> Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>

Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/record_offcpu.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> index e01973d4e0fb..f062ae9a95e1 100755
> --- a/tools/perf/tests/shell/record_offcpu.sh
> +++ b/tools/perf/tests/shell/record_offcpu.sh
> @@ -65,7 +65,7 @@ test_offcpu_child() {
>
>    # perf bench sched messaging creates 400 processes
>    if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> -    perf bench sched messaging -g 10 > /dev/null 2&>1
> +    perf bench sched messaging -g 10 > /dev/null 2>&1
>    then
>      echo "Child task off-cpu test [Failed record]"
>      err=1
> --
> 2.39.2
>

Re: [PATCH 1/2] replace 2&>1 by 2>&1

[Ian Rogers]

On Mon, Mar 6, 2023 at 1:46 PM Ian Rogers <irogers@google.com> wrote:
>
> On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
> >
> > Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
>
> Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
> Acked-by: Ian Rogers <irogers@google.com>
>
> Thanks,
> Ian

Arnaldo, could we pick this up?

Thanks,
Ian

> > ---
> >  tools/perf/tests/shell/record_offcpu.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> > index e01973d4e0fb..f062ae9a95e1 100755
> > --- a/tools/perf/tests/shell/record_offcpu.sh
> > +++ b/tools/perf/tests/shell/record_offcpu.sh
> > @@ -65,7 +65,7 @@ test_offcpu_child() {
> >
> >    # perf bench sched messaging creates 400 processes
> >    if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> > -    perf bench sched messaging -g 10 > /dev/null 2&>1
> > +    perf bench sched messaging -g 10 > /dev/null 2>&1
> >    then
> >      echo "Child task off-cpu test [Failed record]"
> >      err=1
> > --
> > 2.39.2
> >

Re: [PATCH 1/2] replace 2&>1 by 2>&1

[Arnaldo Carvalho de Melo]

Em Thu, Mar 23, 2023 at 11:03:49AM -0700, Ian Rogers escreveu:
> On Mon, Mar 6, 2023 at 1:46 PM Ian Rogers <irogers@google.com> wrote:
> >
> > On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
> > >
> > > Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
> >
> > Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
> > Acked-by: Ian Rogers <irogers@google.com>
> >
> > Thanks,
> > Ian
> 
> Arnaldo, could we pick this up?

Yeah, but next time please write in the subject line that its a patch
for the perf tools :-)

- Arnaldo
 
> Thanks,
> Ian
> 
> > > ---
> > >  tools/perf/tests/shell/record_offcpu.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> > > index e01973d4e0fb..f062ae9a95e1 100755
> > > --- a/tools/perf/tests/shell/record_offcpu.sh
> > > +++ b/tools/perf/tests/shell/record_offcpu.sh
> > > @@ -65,7 +65,7 @@ test_offcpu_child() {
> > >
> > >    # perf bench sched messaging creates 400 processes
> > >    if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> > > -    perf bench sched messaging -g 10 > /dev/null 2&>1
> > > +    perf bench sched messaging -g 10 > /dev/null 2>&1
> > >    then
> > >      echo "Child task off-cpu test [Failed record]"
> > >      err=1
> > > --
> > > 2.39.2
> > >

-- 

- Arnaldo

Re: [PATCH 1/2] replace 2&>1 by 2>&1

[Namhyung Kim]

Hello,

On Fri, Mar 24, 2023 at 1:19 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Mar 23, 2023 at 11:03:49AM -0700, Ian Rogers escreveu:
> > On Mon, Mar 6, 2023 at 1:46 PM Ian Rogers <irogers@google.com> wrote:
> > >
> > > On Fri, Mar 3, 2023 at 11:31 AM Patrice Duroux <patrice.duroux@gmail.com> wrote:
> > > >
> > > > Signed-off-by: Patrice Duroux <patrice.duroux@gmail.com>
> > >
> > > Fixes: ade1d0307b2f ("perf offcpu: Update offcpu test for child process")
> > > Acked-by: Ian Rogers <irogers@google.com>
> > >
> > > Thanks,
> > > Ian
> >
> > Arnaldo, could we pick this up?
>
> Yeah, but next time please write in the subject line that its a patch
> for the perf tools :-)

Oops, it was me who messed this up.. sorry about that.
At least now I know where the file named "1" is created. :)

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> >
> > > > ---
> > > >  tools/perf/tests/shell/record_offcpu.sh | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
> > > > index e01973d4e0fb..f062ae9a95e1 100755
> > > > --- a/tools/perf/tests/shell/record_offcpu.sh
> > > > +++ b/tools/perf/tests/shell/record_offcpu.sh
> > > > @@ -65,7 +65,7 @@ test_offcpu_child() {
> > > >
> > > >    # perf bench sched messaging creates 400 processes
> > > >    if ! perf record --off-cpu -e dummy -o ${perfdata} -- \
> > > > -    perf bench sched messaging -g 10 > /dev/null 2&>1
> > > > +    perf bench sched messaging -g 10 > /dev/null 2>&1
> > > >    then
> > > >      echo "Child task off-cpu test [Failed record]"
> > > >      err=1
> > > > --
> > > > 2.39.2
> > > >
>
> --
>
> - Arnaldo