* [PATCH] soundwire: qcom: correct setting ignore bit on v1.5.1
@ 2023-02-22 14:03 Krzysztof Kozlowski
2023-02-22 14:40 ` Konrad Dybcio
2023-03-15 13:36 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-22 14:03 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Bard Liao, Pierre-Louis Bossart, Sanyog Kale,
Srinivas Kandagatla, linux-arm-msm, alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski, stable
According to the comment and to downstream sources, the
SWRM_CONTINUE_EXEC_ON_CMD_IGNORE in SWRM_CMD_FIFO_CFG_ADDR register
should be set for v1.5.1 and newer, so fix the >= operator.
Fixes: 542d3491cdd7 ("soundwire: qcom: set continue execution flag for ignored commands")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index d5b73b7f98bf..29035cf15407 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -733,7 +733,7 @@ static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl)
}
/* Configure number of retries of a read/write cmd */
- if (ctrl->version > 0x01050001) {
+ if (ctrl->version >= 0x01050001) {
/* Only for versions >= 1.5.1 */
ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR,
SWRM_RD_WR_CMD_RETRIES |
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: qcom: correct setting ignore bit on v1.5.1
2023-02-22 14:03 [PATCH] soundwire: qcom: correct setting ignore bit on v1.5.1 Krzysztof Kozlowski
@ 2023-02-22 14:40 ` Konrad Dybcio
2023-03-15 13:36 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-02-22 14:40 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Vinod Koul,
Bard Liao, Pierre-Louis Bossart, Sanyog Kale,
Srinivas Kandagatla, linux-arm-msm, alsa-devel, linux-kernel
Cc: stable
On 22.02.2023 15:03, Krzysztof Kozlowski wrote:
> According to the comment and to downstream sources, the
> SWRM_CONTINUE_EXEC_ON_CMD_IGNORE in SWRM_CMD_FIFO_CFG_ADDR register
> should be set for v1.5.1 and newer, so fix the >= operator.
>
> Fixes: 542d3491cdd7 ("soundwire: qcom: set continue execution flag for ignored commands")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/soundwire/qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index d5b73b7f98bf..29035cf15407 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -733,7 +733,7 @@ static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl)
> }
>
> /* Configure number of retries of a read/write cmd */
> - if (ctrl->version > 0x01050001) {
> + if (ctrl->version >= 0x01050001) {
> /* Only for versions >= 1.5.1 */
> ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR,
> SWRM_RD_WR_CMD_RETRIES |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: qcom: correct setting ignore bit on v1.5.1
2023-02-22 14:03 [PATCH] soundwire: qcom: correct setting ignore bit on v1.5.1 Krzysztof Kozlowski
2023-02-22 14:40 ` Konrad Dybcio
@ 2023-03-15 13:36 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-03-15 13:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Bard Liao,
Pierre-Louis Bossart, Sanyog Kale, Srinivas Kandagatla,
linux-arm-msm, alsa-devel, linux-kernel, stable
On 22-02-23, 15:03, Krzysztof Kozlowski wrote:
> According to the comment and to downstream sources, the
> SWRM_CONTINUE_EXEC_ON_CMD_IGNORE in SWRM_CMD_FIFO_CFG_ADDR register
> should be set for v1.5.1 and newer, so fix the >= operator.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-15 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-22 14:03 [PATCH] soundwire: qcom: correct setting ignore bit on v1.5.1 Krzysztof Kozlowski
2023-02-22 14:40 ` Konrad Dybcio
2023-03-15 13:36 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.