From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Yi Liu <yi.l.liu@intel.com>,
kevin.tian@intel.com, joro@8bytes.org, robin.murphy@arm.com,
cohuck@redhat.com, eric.auger@redhat.com, nicolinc@nvidia.com,
kvm@vger.kernel.org, mjrosato@linux.ibm.com,
chao.p.peng@linux.intel.com, yi.y.sun@linux.intel.com,
peterx@redhat.com, jasowang@redhat.com,
shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
suravee.suthikulpanit@amd.com,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-s390@vger.kernel.org,
xudong.hao@intel.com, yan.y.zhao@intel.com,
terrence.xu@intel.com, yanting.jiang@intel.com
Subject: Re: [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD
Date: Wed, 29 Mar 2023 20:22:13 -0300 [thread overview]
Message-ID: <ZCTIJScfgbWWguD5@nvidia.com> (raw)
In-Reply-To: <20230329150055.3dee2476.alex.williamson@redhat.com>
On Wed, Mar 29, 2023 at 03:00:55PM -0600, Alex Williamson wrote:
> > + * The user should provide a device cookie when calling this ioctl. The
> > + * cookie is carried only in event e.g. I/O fault reported to userspace
> > + * via iommufd. The user should use devid returned by this ioctl to mark
> > + * the target device in other ioctls (e.g. iommu hardware infomration query
> > + * via iommufd, and etc.).
>
> AFAICT, the whole concept of this dev_cookie is a fantasy. It only
> exists in this series in these comments and the structure below. It's
> not even defined whether it needs to be unique within an iommufd
> context, and clearly nothing here validates that. There's not enough
> implementation for it to exist in this series. Maybe dev_cookie is
> appended to the end of the structure and indicated with a flag when it
> has some meaning.
Yes, I've asked for this to be punted to the PRI series enough times
already, why does it keep coming back ??
> > + * @argsz: user filled size of this data.
> > + * @flags: reserved for future extension.
> > + * @dev_cookie: a per device cookie provided by userspace.
> > + * @iommufd: iommufd to bind. a negative value means noiommu.
>
> "Use a negative value for no-iommu, where supported", or better, should
> we define this explicitly as -1, or why not use a flag bit to specify
> no-iommu? Maybe minsz is only through flags for the noiommu use case.
I was happy enough for this to be defined as -1. We could give it a
formal sounding constant too
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: mjrosato@linux.ibm.com, jasowang@redhat.com,
xudong.hao@intel.com, peterx@redhat.com, terrence.xu@intel.com,
chao.p.peng@linux.intel.com, linux-s390@vger.kernel.org,
Yi Liu <yi.l.liu@intel.com>,
kvm@vger.kernel.org, lulu@redhat.com, yanting.jiang@intel.com,
joro@8bytes.org, nicolinc@nvidia.com, yan.y.zhao@intel.com,
intel-gfx@lists.freedesktop.org, eric.auger@redhat.com,
intel-gvt-dev@lists.freedesktop.org, yi.y.sun@linux.intel.com,
cohuck@redhat.com, shameerali.kolothum.thodi@huawei.com,
suravee.suthikulpanit@amd.com, robin.murphy@arm.com
Subject: Re: [Intel-gfx] [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD
Date: Wed, 29 Mar 2023 20:22:13 -0300 [thread overview]
Message-ID: <ZCTIJScfgbWWguD5@nvidia.com> (raw)
In-Reply-To: <20230329150055.3dee2476.alex.williamson@redhat.com>
On Wed, Mar 29, 2023 at 03:00:55PM -0600, Alex Williamson wrote:
> > + * The user should provide a device cookie when calling this ioctl. The
> > + * cookie is carried only in event e.g. I/O fault reported to userspace
> > + * via iommufd. The user should use devid returned by this ioctl to mark
> > + * the target device in other ioctls (e.g. iommu hardware infomration query
> > + * via iommufd, and etc.).
>
> AFAICT, the whole concept of this dev_cookie is a fantasy. It only
> exists in this series in these comments and the structure below. It's
> not even defined whether it needs to be unique within an iommufd
> context, and clearly nothing here validates that. There's not enough
> implementation for it to exist in this series. Maybe dev_cookie is
> appended to the end of the structure and indicated with a flag when it
> has some meaning.
Yes, I've asked for this to be punted to the PRI series enough times
already, why does it keep coming back ??
> > + * @argsz: user filled size of this data.
> > + * @flags: reserved for future extension.
> > + * @dev_cookie: a per device cookie provided by userspace.
> > + * @iommufd: iommufd to bind. a negative value means noiommu.
>
> "Use a negative value for no-iommu, where supported", or better, should
> we define this explicitly as -1, or why not use a flag bit to specify
> no-iommu? Maybe minsz is only through flags for the noiommu use case.
I was happy enough for this to be defined as -1. We could give it a
formal sounding constant too
Jason
next prev parent reply other threads:[~2023-03-29 23:22 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:40 [PATCH v8 00/24] Add vfio_device cdev for iommufd support Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 01/24] vfio: Allocate per device file structure Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 02/24] vfio: Refine vfio file kAPIs for KVM Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 03/24] vfio: Remove vfio_file_is_group() Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-30 23:50 ` Jason Gunthorpe
2023-03-30 23:50 ` [Intel-gfx] " Jason Gunthorpe
2023-03-27 9:40 ` [PATCH v8 04/24] vfio: Accept vfio device file in the KVM facing kAPI Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 05/24] kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fd Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 06/24] kvm/vfio: Accept vfio device file from userspace Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 07/24] vfio: Pass struct vfio_device_file * to vfio_device_open/close() Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 08/24] vfio: Block device access via device fd until device is opened Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-28 21:33 ` Alex Williamson
2023-03-28 21:33 ` Alex Williamson
2023-03-29 2:23 ` Liu, Yi L
2023-03-29 2:23 ` [Intel-gfx] " Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 09/24] vfio: Add cdev_device_open_cnt to vfio_group Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 10/24] vfio: Make vfio_device_open() single open for device cdev path Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-30 23:52 ` Jason Gunthorpe
2023-03-30 23:52 ` [Intel-gfx] " Jason Gunthorpe
2023-03-27 9:40 ` [PATCH v8 11/24] vfio: Make vfio_device_first_open() to accept NULL iommufd for noiommu Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-30 23:56 ` Jason Gunthorpe
2023-03-30 23:56 ` [Intel-gfx] " Jason Gunthorpe
2023-03-27 9:40 ` [PATCH v8 12/24] vfio-iommufd: Move noiommu support out of vfio_iommufd_bind() Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 13/24] vfio-iommufd: Split bind/attach into two steps Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 14/24] vfio: Record devid in vfio_device_file Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 15/24] vfio-iommufd: Add detach_ioas support for physical VFIO devices Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 16/24] iommufd/device: Add iommufd_access_detach() API Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-28 2:23 ` Jon Pan-Doh
2023-03-28 2:23 ` [Intel-gfx] " Jon Pan-Doh
2023-03-28 15:54 ` Nicolin Chen
2023-03-28 15:54 ` [Intel-gfx] " Nicolin Chen
2023-03-29 2:24 ` Liu, Yi L
2023-03-29 2:24 ` [Intel-gfx] " Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 17/24] vfio-iommufd: Add detach_ioas support for emulated VFIO devices Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-27 9:40 ` [PATCH v8 18/24] vfio: Determine noiommu in vfio_device registration Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-28 6:36 ` Tian, Kevin
2023-03-28 6:36 ` [Intel-gfx] " Tian, Kevin
2023-03-27 9:40 ` [PATCH v8 19/24] vfio: Name noiommu vfio_device with "noiommu-" prefix Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-28 6:37 ` Tian, Kevin
2023-03-28 6:37 ` [Intel-gfx] " Tian, Kevin
2023-03-27 9:40 ` [PATCH v8 20/24] vfio: Add cdev for vfio_device Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-29 19:57 ` Alex Williamson
2023-03-29 19:57 ` [Intel-gfx] " Alex Williamson
2023-03-30 5:35 ` Liu, Yi L
2023-03-30 5:35 ` [Intel-gfx] " Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-29 21:00 ` Alex Williamson
2023-03-29 21:00 ` Alex Williamson
2023-03-29 23:22 ` Jason Gunthorpe [this message]
2023-03-29 23:22 ` [Intel-gfx] " Jason Gunthorpe
2023-03-30 12:52 ` Liu, Yi L
2023-03-30 12:52 ` [Intel-gfx] " Liu, Yi L
2023-03-30 12:59 ` Jason Gunthorpe
2023-03-30 12:59 ` [Intel-gfx] " Jason Gunthorpe
2023-03-30 7:09 ` Liu, Yi L
2023-03-30 7:09 ` [Intel-gfx] " Liu, Yi L
2023-03-30 11:52 ` Jason Gunthorpe
2023-03-30 11:52 ` Jason Gunthorpe
2023-03-30 12:53 ` Liu, Yi L
2023-03-30 12:53 ` [Intel-gfx] " Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 22/24] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-29 21:19 ` Alex Williamson
2023-03-29 21:19 ` [Intel-gfx] " Alex Williamson
2023-03-30 13:02 ` Liu, Yi L
2023-03-30 13:02 ` Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 23/24] vfio: Compile group optionally Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-29 21:51 ` Alex Williamson
2023-03-29 21:51 ` Alex Williamson
2023-03-30 13:06 ` Liu, Yi L
2023-03-30 13:06 ` [Intel-gfx] " Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 24/24] docs: vfio: Add vfio device cdev description Yi Liu
2023-03-27 9:40 ` [Intel-gfx] " Yi Liu
2023-03-29 22:47 ` Alex Williamson
2023-03-29 22:47 ` Alex Williamson
2023-03-29 22:57 ` Alex Williamson
2023-03-29 22:57 ` [Intel-gfx] " Alex Williamson
2023-03-30 13:11 ` Liu, Yi L
2023-03-30 13:11 ` [Intel-gfx] " Liu, Yi L
2023-03-27 12:03 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev9) Patchwork
2023-03-27 17:48 ` [Intel-gfx] [PATCH v8 00/24] Add vfio_device cdev for iommufd support Nicolin Chen
2023-03-27 17:48 ` Nicolin Chen
2023-03-28 23:16 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev10) Patchwork
2023-03-31 3:10 ` [PATCH v8 00/24] Add vfio_device cdev for iommufd support Jiang, Yanting
2023-03-31 3:10 ` [Intel-gfx] " Jiang, Yanting
2023-03-31 5:01 ` Jiang, Yanting
2023-03-31 5:01 ` [Intel-gfx] " Jiang, Yanting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCTIJScfgbWWguD5@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jasowang@redhat.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=terrence.xu@intel.com \
--cc=xudong.hao@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yanting.jiang@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.