From: Matthew Brost <matthew.brost@intel.com> To: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 12/14] drm/xe: Limit CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE to itself. Date: Tue, 2 May 2023 15:35:23 +0000 [thread overview] Message-ID: <ZFEtu9QAh098FVJA@DUT025-TGLU.fm.intel.com> (raw) In-Reply-To: <20230426205713.512695-13-rodrigo.vivi@intel.com> On Wed, Apr 26, 2023 at 04:57:11PM -0400, Rodrigo Vivi wrote: > There are multiple kind of config prints and with the upcoming > devcoredump there will be another layer. Let's limit the config > to the top level functions and leave the clean-up work for the > compilers so we don't create a spider-web of configs. > > No functional change. Just a preparation for the devcoredump. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Again will conflict with GPUVA, not that big of a deal, I'll leave it up to you. Reviewed-by: Matthew Brost <matthew.brost@intel.com> > --- > drivers/gpu/drm/xe/xe_vm.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c > index bdf82d34eb66..4cffdb84680a 100644 > --- a/drivers/gpu/drm/xe/xe_vm.c > +++ b/drivers/gpu/drm/xe/xe_vm.c > @@ -3369,7 +3369,6 @@ int xe_vm_invalidate_vma(struct xe_vma *vma) > return 0; > } > > -#if IS_ENABLED(CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE) > int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id) > { > struct rb_node *node; > @@ -3405,9 +3404,3 @@ int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id) > > return 0; > } > -#else > -int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id) > -{ > - return 0; > -} > -#endif > -- > 2.39.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Brost <matthew.brost@intel.com> To: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-xe] [PATCH 12/14] drm/xe: Limit CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE to itself. Date: Tue, 2 May 2023 15:35:23 +0000 [thread overview] Message-ID: <ZFEtu9QAh098FVJA@DUT025-TGLU.fm.intel.com> (raw) In-Reply-To: <20230426205713.512695-13-rodrigo.vivi@intel.com> On Wed, Apr 26, 2023 at 04:57:11PM -0400, Rodrigo Vivi wrote: > There are multiple kind of config prints and with the upcoming > devcoredump there will be another layer. Let's limit the config > to the top level functions and leave the clean-up work for the > compilers so we don't create a spider-web of configs. > > No functional change. Just a preparation for the devcoredump. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Again will conflict with GPUVA, not that big of a deal, I'll leave it up to you. Reviewed-by: Matthew Brost <matthew.brost@intel.com> > --- > drivers/gpu/drm/xe/xe_vm.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c > index bdf82d34eb66..4cffdb84680a 100644 > --- a/drivers/gpu/drm/xe/xe_vm.c > +++ b/drivers/gpu/drm/xe/xe_vm.c > @@ -3369,7 +3369,6 @@ int xe_vm_invalidate_vma(struct xe_vma *vma) > return 0; > } > > -#if IS_ENABLED(CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE) > int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id) > { > struct rb_node *node; > @@ -3405,9 +3404,3 @@ int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id) > > return 0; > } > -#else > -int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id) > -{ > - return 0; > -} > -#endif > -- > 2.39.2 >
next prev parent reply other threads:[~2023-05-02 15:35 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-26 20:56 [PATCH 00/14] Introduce xe_devcoredump Rodrigo Vivi 2023-04-26 20:56 ` [Intel-xe] " Rodrigo Vivi 2023-04-26 20:57 ` [PATCH 01/14] drm/xe: Fix print of RING_EXECLIST_SQ_CONTENTS_HI Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-04-26 21:40 ` Lucas De Marchi 2023-04-26 21:59 ` Rodrigo Vivi 2023-04-26 20:57 ` [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-04-27 8:28 ` Thomas Hellström 2023-05-02 7:57 ` Matthew Brost 2023-05-02 18:06 ` Rodrigo Vivi 2023-05-02 18:06 ` Rodrigo Vivi 2023-05-02 20:29 ` Matthew Brost 2023-05-02 20:29 ` Matthew Brost 2023-05-02 7:55 ` Jani Nikula 2023-05-02 17:25 ` Rodrigo Vivi 2023-04-26 20:57 ` [PATCH 03/14] drm/xe: Do not take any action if our device was removed Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 15:40 ` Matthew Brost 2023-05-02 17:21 ` Rodrigo Vivi 2023-05-02 23:06 ` Matthew Brost 2023-04-26 20:57 ` [PATCH 04/14] drm/xe: Extract non mapped regions out of GuC CTB into its own struct Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 5:12 ` Matthew Brost 2023-04-26 20:57 ` [PATCH 05/14] drm/xe: Convert GuC CT print to snapshot capture and print Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 5:27 ` Matthew Brost 2023-04-26 20:57 ` [PATCH 06/14] drm/xe: Add GuC CT snapshot to xe_devcoredump Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 14:55 ` Matthew Brost 2023-05-02 14:55 ` [Intel-xe] " Matthew Brost 2023-04-26 20:57 ` [PATCH 07/14] drm/xe: Introduce guc_submit_types.h with relevant structs Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 7:44 ` Matthew Brost 2023-05-02 7:44 ` [Intel-xe] " Matthew Brost 2023-04-26 20:57 ` [Intel-xe] [PATCH 08/14] drm/xe: Convert GuC Engine print to snapshot capture and print Rodrigo Vivi 2023-04-26 20:57 ` Rodrigo Vivi 2023-05-02 15:01 ` [Intel-xe] " Matthew Brost 2023-04-26 20:57 ` [Intel-xe] [PATCH 09/14] drm/xe: Add GuC Submit Engine snapshot to xe_devcoredump Rodrigo Vivi 2023-04-26 20:57 ` Rodrigo Vivi 2023-05-02 15:03 ` Matthew Brost 2023-05-02 15:03 ` [Intel-xe] " Matthew Brost 2023-04-26 20:57 ` [Intel-xe] [PATCH 10/14] drm/xe: Convert Xe HW Engine print to snapshot capture and print Rodrigo Vivi 2023-04-26 20:57 ` Rodrigo Vivi 2023-05-02 15:20 ` [Intel-xe] " Matthew Brost 2023-04-26 20:57 ` [PATCH 11/14] drm/xe: Add HW Engine snapshot to xe_devcoredump Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 15:30 ` Matthew Brost 2023-04-26 20:57 ` [PATCH 12/14] drm/xe: Limit CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE to itself Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 15:35 ` Matthew Brost [this message] 2023-05-02 15:35 ` Matthew Brost 2023-04-26 20:57 ` [PATCH 13/14] drm/xe: Convert VM print to snapshot capture and print Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 7:50 ` Matthew Brost 2023-05-02 8:07 ` Matthew Brost 2023-04-26 20:57 ` [PATCH 14/14] drm/xe: Add VM snapshot to xe_devcoredump Rodrigo Vivi 2023-04-26 20:57 ` [Intel-xe] " Rodrigo Vivi 2023-05-02 15:38 ` Matthew Brost 2023-04-26 21:01 ` [Intel-xe] ✓ CI.Patch_applied: success for Introduce xe_devcoredump Patchwork 2023-04-26 21:02 ` [Intel-xe] ✓ CI.KUnit: " Patchwork 2023-04-26 21:06 ` [Intel-xe] ✓ CI.Build: " Patchwork 2023-04-26 21:29 ` [Intel-xe] ○ CI.BAT: info " Patchwork 2023-05-02 8:11 ` [Intel-xe] [PATCH 00/14] " Matthew Brost
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZFEtu9QAh098FVJA@DUT025-TGLU.fm.intel.com \ --to=matthew.brost@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-xe@lists.freedesktop.org \ --cc=rodrigo.vivi@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.