From: Matthew Wilcox <willy@infradead.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Vasily Averin <vasily.averin@linux.dev>,
hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
shakeelb@google.com, akpm@linux-foundation.org,
muchun.song@linux.dev, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memcg: remove unused mem_cgroup_from_obj()
Date: Sat, 27 May 2023 05:00:49 +0100 [thread overview]
Message-ID: <ZHGAcaqOx/e8lqwV@casper.infradead.org> (raw)
In-Reply-To: <20230527103126.398267-1-linmiaohe@huawei.com>
On Sat, May 27, 2023 at 06:31:26PM +0800, Miaohe Lin wrote:
> The function mem_cgroup_from_obj() is not used anymore. Remove it and
> clean up relevant comments.
You should have looked at the git history to see why it was created
and who used it.
Shakeel, Vasily, are you going to retry adding commit 1d0403d20f6c?
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Vasily Averin
<vasily.averin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] memcg: remove unused mem_cgroup_from_obj()
Date: Sat, 27 May 2023 05:00:49 +0100 [thread overview]
Message-ID: <ZHGAcaqOx/e8lqwV@casper.infradead.org> (raw)
In-Reply-To: <20230527103126.398267-1-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Sat, May 27, 2023 at 06:31:26PM +0800, Miaohe Lin wrote:
> The function mem_cgroup_from_obj() is not used anymore. Remove it and
> clean up relevant comments.
You should have looked at the git history to see why it was created
and who used it.
Shakeel, Vasily, are you going to retry adding commit 1d0403d20f6c?
next prev parent reply other threads:[~2023-05-27 4:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 10:31 [PATCH] memcg: remove unused mem_cgroup_from_obj() Miaohe Lin
2023-05-27 10:31 ` Miaohe Lin
2023-05-27 3:55 ` Yosry Ahmed
2023-05-27 3:55 ` Yosry Ahmed
2023-05-27 4:00 ` Matthew Wilcox [this message]
2023-05-27 4:00 ` Matthew Wilcox
2023-05-27 4:13 ` Yosry Ahmed
2023-05-27 4:13 ` Yosry Ahmed
2023-05-27 15:07 ` Matthew Wilcox
2023-05-27 15:07 ` Matthew Wilcox
2023-05-27 18:54 ` Yosry Ahmed
2023-05-27 18:54 ` Yosry Ahmed
2023-05-28 13:01 ` Muchun Song
2023-05-28 13:01 ` Muchun Song
2023-05-28 19:36 ` Matthew Wilcox
2023-05-29 18:53 ` Shakeel Butt
2023-05-29 18:53 ` Shakeel Butt
2023-05-28 20:19 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHGAcaqOx/e8lqwV@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=vasily.averin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.