From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v2] meson saradc: add iio device attrib to switch channel 7 mux
Date: Sun, 28 May 2023 13:55:20 +0300 [thread overview]
Message-ID: <ZHMzGHsGEylDdgg7@smile.fi.intel.com> (raw)
In-Reply-To: <ZHMxDHPBWQOJSuaZ@smile.fi.intel.com>
On Sun, May 28, 2023 at 01:46:37PM +0300, Andy Shevchenko wrote:
> On Sun, May 28, 2023 at 12:48:54AM +0300, George Stark wrote:
...
> > +static const char * const chan7_vol[] = {
> > + "gnd",
> > + "vdd/4",
> > + "vdd/2",
> > + "vdd*3/4",
> > + "vdd",
> > + "ch7_input",
> > +};
One more thing to discuss (Jonathan, what's your opinion?) I think the
following easier to understand and has less problematic characters in the names
(in case of sysfs direct use from shelll):
static const char * const chan7_vol[] = {
"gnd", // alternatively GND
"0.25vdd", // alternatively 0.25_vdd, 0.25Vdd, 0.25_Vdd
"0.5vdd",
"0.75vdd",
"vdd", // Vdd
"ch7_input",
};
That said, my personal preference:
static const char * const chan7_vol[] = {
"GND",
"0.25Vdd",
"0.5Vdd",
"0.75Vdd",
"Vdd",
"ch7_input",
};
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v2] meson saradc: add iio device attrib to switch channel 7 mux
Date: Sun, 28 May 2023 13:55:20 +0300 [thread overview]
Message-ID: <ZHMzGHsGEylDdgg7@smile.fi.intel.com> (raw)
In-Reply-To: <ZHMxDHPBWQOJSuaZ@smile.fi.intel.com>
On Sun, May 28, 2023 at 01:46:37PM +0300, Andy Shevchenko wrote:
> On Sun, May 28, 2023 at 12:48:54AM +0300, George Stark wrote:
...
> > +static const char * const chan7_vol[] = {
> > + "gnd",
> > + "vdd/4",
> > + "vdd/2",
> > + "vdd*3/4",
> > + "vdd",
> > + "ch7_input",
> > +};
One more thing to discuss (Jonathan, what's your opinion?) I think the
following easier to understand and has less problematic characters in the names
(in case of sysfs direct use from shelll):
static const char * const chan7_vol[] = {
"gnd", // alternatively GND
"0.25vdd", // alternatively 0.25_vdd, 0.25Vdd, 0.25_Vdd
"0.5vdd",
"0.75vdd",
"vdd", // Vdd
"ch7_input",
};
That said, my personal preference:
static const char * const chan7_vol[] = {
"GND",
"0.25Vdd",
"0.5Vdd",
"0.75Vdd",
"Vdd",
"ch7_input",
};
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v2] meson saradc: add iio device attrib to switch channel 7 mux
Date: Sun, 28 May 2023 13:55:20 +0300 [thread overview]
Message-ID: <ZHMzGHsGEylDdgg7@smile.fi.intel.com> (raw)
In-Reply-To: <ZHMxDHPBWQOJSuaZ@smile.fi.intel.com>
On Sun, May 28, 2023 at 01:46:37PM +0300, Andy Shevchenko wrote:
> On Sun, May 28, 2023 at 12:48:54AM +0300, George Stark wrote:
...
> > +static const char * const chan7_vol[] = {
> > + "gnd",
> > + "vdd/4",
> > + "vdd/2",
> > + "vdd*3/4",
> > + "vdd",
> > + "ch7_input",
> > +};
One more thing to discuss (Jonathan, what's your opinion?) I think the
following easier to understand and has less problematic characters in the names
(in case of sysfs direct use from shelll):
static const char * const chan7_vol[] = {
"gnd", // alternatively GND
"0.25vdd", // alternatively 0.25_vdd, 0.25Vdd, 0.25_Vdd
"0.5vdd",
"0.75vdd",
"vdd", // Vdd
"ch7_input",
};
That said, my personal preference:
static const char * const chan7_vol[] = {
"GND",
"0.25Vdd",
"0.5Vdd",
"0.75Vdd",
"Vdd",
"ch7_input",
};
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-05-28 10:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 21:48 [PATCH v2] meson saradc: add iio device attrib to switch channel 7 mux George Stark
2023-05-27 21:48 ` George Stark
2023-05-27 21:48 ` George Stark
2023-05-28 10:46 ` Andy Shevchenko
2023-05-28 10:46 ` Andy Shevchenko
2023-05-28 10:46 ` Andy Shevchenko
2023-05-28 10:55 ` Andy Shevchenko [this message]
2023-05-28 10:55 ` Andy Shevchenko
2023-05-28 10:55 ` Andy Shevchenko
2023-05-28 11:00 ` Andy Shevchenko
2023-05-28 11:00 ` Andy Shevchenko
2023-05-28 11:00 ` Andy Shevchenko
2023-05-28 15:12 ` Jonathan Cameron
2023-05-28 15:12 ` Jonathan Cameron
2023-05-28 15:12 ` Jonathan Cameron
2023-05-28 22:31 ` George Stark
2023-05-28 22:31 ` George Stark
2023-05-28 22:31 ` George Stark
2023-05-29 23:32 ` andy.shevchenko
2023-05-29 23:32 ` andy.shevchenko
2023-05-29 23:32 ` andy.shevchenko
2023-05-28 15:11 ` Jonathan Cameron
2023-05-28 15:11 ` Jonathan Cameron
2023-05-28 15:11 ` Jonathan Cameron
2023-05-28 21:52 ` George Stark
2023-05-28 21:52 ` George Stark
2023-05-28 21:52 ` George Stark
2023-05-29 20:04 ` Martin Blumenstingl
2023-05-29 20:04 ` Martin Blumenstingl
2023-05-29 20:04 ` Martin Blumenstingl
2023-06-04 12:52 ` Jonathan Cameron
2023-06-04 12:52 ` Jonathan Cameron
2023-06-04 12:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHMzGHsGEylDdgg7@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gnstark@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.