All of lore.kernel.org
 help / color / mirror / Atom feed
From: andy.shevchenko@gmail.com
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/8] pinctrl: qcom: qdf2xxx: drop ACPI_PTR
Date: Fri, 2 Jun 2023 00:42:50 +0300	[thread overview]
Message-ID: <ZHkQ2j6axPYGq_Lg@surfacebook> (raw)
In-Reply-To: <20230601152026.1182648-1-krzysztof.kozlowski@linaro.org>

Thu, Jun 01, 2023 at 05:20:19PM +0200, Krzysztof Kozlowski kirjoitti:
> Driver can bind only via ACPI matching and acpi_device_id is there
> unconditionally, so drop useless ACPI_PTR() macro.

With this acpi.h becomes unused and has to be replaced with (AFAICT)
property.h
mod_devicetable.h
(maybe others, but I haven't checked deeply)

With that,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> index b0f1b3dc6831..b5808fcfb13c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> @@ -142,7 +142,7 @@ MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
>  static struct platform_driver qdf2xxx_pinctrl_driver = {
>  	.driver = {
>  		.name = "qdf2xxx-pinctrl",
> -		.acpi_match_table = ACPI_PTR(qdf2xxx_acpi_ids),
> +		.acpi_match_table = qdf2xxx_acpi_ids,
>  	},
>  	.probe = qdf2xxx_pinctrl_probe,
>  	.remove = msm_pinctrl_remove,
> -- 
> 2.34.1
> 

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2023-06-01 21:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 15:20 [PATCH 1/8] pinctrl: qcom: qdf2xxx: drop ACPI_PTR Krzysztof Kozlowski
2023-06-01 15:20 ` [PATCH 2/8] pinctrl: qcom: fix indentation in Kconfig Krzysztof Kozlowski
2023-06-02  9:02   ` Konrad Dybcio
2023-06-01 15:20 ` [PATCH 3/8] pinctrl: qcom: correct language typo (Technologies) Krzysztof Kozlowski
2023-06-02  9:02   ` Konrad Dybcio
2023-06-01 15:20 ` [PATCH 4/8] pinctrl: qcom: drop unneeded GPIOLIB dependency Krzysztof Kozlowski
2023-06-02  9:03   ` Konrad Dybcio
2023-06-01 15:20 ` [PATCH 5/8] pinctrl: qcom: mark true OF dependency - common MSM pinctrl code Krzysztof Kozlowski
2023-06-02  9:07   ` Konrad Dybcio
2023-06-01 15:20 ` [PATCH 6/8] pinctrl: qcom: allow true compile testing Krzysztof Kozlowski
2023-06-02  9:08   ` Konrad Dybcio
2023-06-02  9:17     ` Krzysztof Kozlowski
2023-06-02  9:08   ` Konrad Dybcio
2023-06-01 15:20 ` [PATCH 7/8] pinctrl: qcom: organize main SoC drivers in new Kconfig.msm Krzysztof Kozlowski
2023-06-01 21:45   ` andy.shevchenko
2023-06-02  7:47   ` Linus Walleij
2023-06-02  9:09   ` Konrad Dybcio
2023-06-01 15:20 ` [PATCH 8/8] pinctrl: qcom: organize audio drivers in menuconfig Krzysztof Kozlowski
2023-06-01 21:42 ` andy.shevchenko [this message]
2023-06-02  9:01 ` [PATCH 1/8] pinctrl: qcom: qdf2xxx: drop ACPI_PTR Konrad Dybcio
2023-06-09  7:12 ` Linus Walleij
2023-06-09 10:09   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHkQ2j6axPYGq_Lg@surfacebook \
    --to=andy.shevchenko@gmail.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.