All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: Switch i2c drivers back to use .probe()
@ 2023-05-25 21:03 ` Uwe Kleine-König
  0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2023-05-25 21:03 UTC (permalink / raw)
  To: Tudor Ambarus, Herbert Xu, David S. Miller
  Cc: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, linux-crypto,
	linux-arm-kernel, kernel

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/crypto/atmel-ecc.c     | 2 +-
 drivers/crypto/atmel-sha204a.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index aac64b555204..432beabd79e6 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -389,7 +389,7 @@ static struct i2c_driver atmel_ecc_driver = {
 		.name	= "atmel-ecc",
 		.of_match_table = of_match_ptr(atmel_ecc_dt_ids),
 	},
-	.probe_new	= atmel_ecc_probe,
+	.probe		= atmel_ecc_probe,
 	.remove		= atmel_ecc_remove,
 	.id_table	= atmel_ecc_id,
 };
diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index 44a185a84760..c77f482d2a97 100644
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -141,7 +141,7 @@ static const struct i2c_device_id atmel_sha204a_id[] = {
 MODULE_DEVICE_TABLE(i2c, atmel_sha204a_id);
 
 static struct i2c_driver atmel_sha204a_driver = {
-	.probe_new		= atmel_sha204a_probe,
+	.probe			= atmel_sha204a_probe,
 	.remove			= atmel_sha204a_remove,
 	.id_table		= atmel_sha204a_id,
 

base-commit: ac9a78681b921877518763ba0e89202254349d1b
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] crypto: Switch i2c drivers back to use .probe()
@ 2023-05-25 21:03 ` Uwe Kleine-König
  0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2023-05-25 21:03 UTC (permalink / raw)
  To: Tudor Ambarus, Herbert Xu, David S. Miller
  Cc: Alexandre Belloni, linux-crypto, kernel, Claudiu Beznea,
	linux-arm-kernel

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/crypto/atmel-ecc.c     | 2 +-
 drivers/crypto/atmel-sha204a.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index aac64b555204..432beabd79e6 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -389,7 +389,7 @@ static struct i2c_driver atmel_ecc_driver = {
 		.name	= "atmel-ecc",
 		.of_match_table = of_match_ptr(atmel_ecc_dt_ids),
 	},
-	.probe_new	= atmel_ecc_probe,
+	.probe		= atmel_ecc_probe,
 	.remove		= atmel_ecc_remove,
 	.id_table	= atmel_ecc_id,
 };
diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index 44a185a84760..c77f482d2a97 100644
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -141,7 +141,7 @@ static const struct i2c_device_id atmel_sha204a_id[] = {
 MODULE_DEVICE_TABLE(i2c, atmel_sha204a_id);
 
 static struct i2c_driver atmel_sha204a_driver = {
-	.probe_new		= atmel_sha204a_probe,
+	.probe			= atmel_sha204a_probe,
 	.remove			= atmel_sha204a_remove,
 	.id_table		= atmel_sha204a_id,
 

base-commit: ac9a78681b921877518763ba0e89202254349d1b
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: Switch i2c drivers back to use .probe()
  2023-05-25 21:03 ` Uwe Kleine-König
@ 2023-05-26  7:49   ` Tudor Ambarus
  -1 siblings, 0 replies; 6+ messages in thread
From: Tudor Ambarus @ 2023-05-26  7:49 UTC (permalink / raw)
  To: Uwe Kleine-König, Herbert Xu, David S. Miller
  Cc: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, linux-crypto,
	linux-arm-kernel, kernel



On 5/25/23 22:03, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>

> ---
>  drivers/crypto/atmel-ecc.c     | 2 +-
>  drivers/crypto/atmel-sha204a.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index aac64b555204..432beabd79e6 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -389,7 +389,7 @@ static struct i2c_driver atmel_ecc_driver = {
>  		.name	= "atmel-ecc",
>  		.of_match_table = of_match_ptr(atmel_ecc_dt_ids),
>  	},
> -	.probe_new	= atmel_ecc_probe,
> +	.probe		= atmel_ecc_probe,
>  	.remove		= atmel_ecc_remove,
>  	.id_table	= atmel_ecc_id,
>  };
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index 44a185a84760..c77f482d2a97 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -141,7 +141,7 @@ static const struct i2c_device_id atmel_sha204a_id[] = {
>  MODULE_DEVICE_TABLE(i2c, atmel_sha204a_id);
>  
>  static struct i2c_driver atmel_sha204a_driver = {
> -	.probe_new		= atmel_sha204a_probe,
> +	.probe			= atmel_sha204a_probe,
>  	.remove			= atmel_sha204a_remove,
>  	.id_table		= atmel_sha204a_id,
>  
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: Switch i2c drivers back to use .probe()
@ 2023-05-26  7:49   ` Tudor Ambarus
  0 siblings, 0 replies; 6+ messages in thread
From: Tudor Ambarus @ 2023-05-26  7:49 UTC (permalink / raw)
  To: Uwe Kleine-König, Herbert Xu, David S. Miller
  Cc: Alexandre Belloni, linux-crypto, kernel, Claudiu Beznea,
	linux-arm-kernel



On 5/25/23 22:03, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>

> ---
>  drivers/crypto/atmel-ecc.c     | 2 +-
>  drivers/crypto/atmel-sha204a.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index aac64b555204..432beabd79e6 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -389,7 +389,7 @@ static struct i2c_driver atmel_ecc_driver = {
>  		.name	= "atmel-ecc",
>  		.of_match_table = of_match_ptr(atmel_ecc_dt_ids),
>  	},
> -	.probe_new	= atmel_ecc_probe,
> +	.probe		= atmel_ecc_probe,
>  	.remove		= atmel_ecc_remove,
>  	.id_table	= atmel_ecc_id,
>  };
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index 44a185a84760..c77f482d2a97 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -141,7 +141,7 @@ static const struct i2c_device_id atmel_sha204a_id[] = {
>  MODULE_DEVICE_TABLE(i2c, atmel_sha204a_id);
>  
>  static struct i2c_driver atmel_sha204a_driver = {
> -	.probe_new		= atmel_sha204a_probe,
> +	.probe			= atmel_sha204a_probe,
>  	.remove			= atmel_sha204a_remove,
>  	.id_table		= atmel_sha204a_id,
>  
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: Switch i2c drivers back to use .probe()
  2023-05-25 21:03 ` Uwe Kleine-König
@ 2023-06-02 10:25   ` Herbert Xu
  -1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2023-06-02 10:25 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Alexandre Belloni, David S. Miller, Tudor Ambarus, linux-crypto,
	kernel, Claudiu Beznea, linux-arm-kernel

On Thu, May 25, 2023 at 11:03:47PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/crypto/atmel-ecc.c     | 2 +-
>  drivers/crypto/atmel-sha204a.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: Switch i2c drivers back to use .probe()
@ 2023-06-02 10:25   ` Herbert Xu
  0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2023-06-02 10:25 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Tudor Ambarus, David S. Miller, Nicolas Ferre, Alexandre Belloni,
	Claudiu Beznea, linux-crypto, linux-arm-kernel, kernel

On Thu, May 25, 2023 at 11:03:47PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/crypto/atmel-ecc.c     | 2 +-
>  drivers/crypto/atmel-sha204a.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-02 10:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-25 21:03 [PATCH] crypto: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-25 21:03 ` Uwe Kleine-König
2023-05-26  7:49 ` Tudor Ambarus
2023-05-26  7:49   ` Tudor Ambarus
2023-06-02 10:25 ` Herbert Xu
2023-06-02 10:25   ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.