Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Markus Elfring]

> The following patches (submitted by you) have been updated in Patchwork:
>
>  * linux-i2c: [1/2] i2c-davinci: Delete an error message for a failed memory allocation in davinci_i2c_probe()
>      - http://patchwork.ozlabs.org/project/linux-i2c/patch/f890924b-ca68-253b-a7c8-fce269393867@users.sourceforge.net/
>      - for: Linux I2C development
>     was: New
>     now: Superseded
>
>  * linux-i2c: [2/2] i2c-davinci: Improve a size determination in davinci_i2c_probe()
>      - http://patchwork.ozlabs.org/project/linux-i2c/patch/e16ba754-078a-097a-7333-076f43718645@users.sourceforge.net/
>      - for: Linux I2C development
>     was: New
>     now: Superseded

May I know which changes superseded my update suggestions (from 2018-02-02) here?
https://elixir.bootlin.com/linux/v6.4-rc5/source/drivers/i2c/busses/i2c-davinci.c#L759

Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]


> May I know which changes superseded my update suggestions (from 2018-02-02) here?

http://patchwork.ozlabs.org/project/linux-i2c/patch/20230515175042.495377-2-afd@ti.com/


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 175 bytes --]


> May I know which changes superseded my update suggestions (from 2018-02-02) here?

http://patchwork.ozlabs.org/project/linux-i2c/patch/20230515175042.495377-2-afd@ti.com/


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Markus Elfring]

>> May I know which changes superseded my update suggestions (from 2018-02-02) here?
>
> http://patchwork.ozlabs.org/project/linux-i2c/patch/20230515175042.495377-2-afd@ti.com/

I find it interesting somehow that you found a contribution by Andrew Davis (from 2023-05-15)
more appropriate.

i2c: davinci: Use struct name not type with devm_kzalloc()
https://lore.kernel.org/linux-i2c/20230515175042.495377-2-afd@ti.com/

Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]


> I find it interesting somehow that you found a contribution by Andrew Davis (from 2023-05-15)
> more appropriate.

It got reviewed from someone else. Patches which get a review from
someone else get a priority boost. But don't be sad, because of this
patch, I noticed all your other (unreviewed!) patches and applied them.
That's good, right?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 347 bytes --]


> I find it interesting somehow that you found a contribution by Andrew Davis (from 2023-05-15)
> more appropriate.

It got reviewed from someone else. Patches which get a review from
someone else get a priority boost. But don't be sad, because of this
patch, I noticed all your other (unreviewed!) patches and applied them.
That's good, right?


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Markus Elfring]

>> I find it interesting somehow that you found a contribution by Andrew Davis (from 2023-05-15)
>> more appropriate.
>
> It got reviewed from someone else. Patches which get a review from
> someone else get a priority boost.

Such an effect can occasionally be also nice.

Unfortunately, it seems that the patch quality was still improvable.


>                                    But don't be sad, because of this
> patch, I noticed all your other (unreviewed!) patches and applied them.

I was informed that another selection of change possibilities was accepted.


> That's good, right?

Yes. - I hope so.

More positive feedback can be nice.

* How will the patch integration evolve further for suggestions which seem to be
  still in waiting queues?

* How far back would you like to support the known development history
  for discussed Linux software components?

Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]


> Unfortunately, it seems that the patch quality was still improvable.

It was not perfect but good enough.

> * How will the patch integration evolve further for suggestions which seem to be
>   still in waiting queues?

Easy, it will evolve quite similar with the amount of review/reviewers.

> * How far back would you like to support the known development history
>   for discussed Linux software components?

Dunno, if I got the question right, but I don't want to break existing
stuff. Why do you ask?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 510 bytes --]


> Unfortunately, it seems that the patch quality was still improvable.

It was not perfect but good enough.

> * How will the patch integration evolve further for suggestions which seem to be
>   still in waiting queues?

Easy, it will evolve quite similar with the amount of review/reviewers.

> * How far back would you like to support the known development history
>   for discussed Linux software components?

Dunno, if I got the question right, but I don't want to break existing
stuff. Why do you ask?


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Markus Elfring]

>> * How far back would you like to support the known development history
>>   for discussed Linux software components?
>
> Dunno, if I got the question right,

Another bit of clarification follows follows …


> but I don't want to break existing stuff.

I am trying also to avoid some breakage.


> Why do you ask?

If I look at patches which I contributed for the software area “I2C”,
I got the impression that further constructive feedback will be helpful also for
six change possibilities from days like the following.
https://patchwork.ozlabs.org/project/linux-i2c/list/?submitter=65077&state=*&archive=both

* 2017-10-25
* 2016-09-23


Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]


> If I look at patches which I contributed for the software area “I2C”,
> I got the impression that further constructive feedback will be helpful also for
> six change possibilities from days like the following.

Yes, you are right. these patches need feedback. This is why I haven't
applied them yet.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 316 bytes --]


> If I look at patches which I contributed for the software area “I2C”,
> I got the impression that further constructive feedback will be helpful also for
> six change possibilities from days like the following.

Yes, you are right. these patches need feedback. This is why I haven't
applied them yet.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-i2c] Patch notification: DaVinci: 2 patches updated

[Markus Elfring]

> But don't be sad, because of this patch,

I became curious also how collateral evolution will be continued.


> I noticed all your other (unreviewed!) patches and applied them.

You converted some update suggestions into special change combinations.

* i2c: Delete error messages for failed memory allocations
  https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20230609&id=6b3b21a8542fd2fb6ffc61bc13b9419f0c58ebad

* i2c: Improve size determinations
  https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20230609&id=06e989578232da33a7fe96b04191b862af8b2cec


> That's good, right?

I hope that development interests will grow accordingly.

Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel