* [PATCH ethtool] netlink: fix duplex setting
@ 2023-06-27 11:09 Ladislav Michl
2023-07-01 22:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Ladislav Michl @ 2023-06-27 11:09 UTC (permalink / raw)
To: Michal Kubecek; +Cc: netdev
From: Ladislav Michl <ladis@linux-mips.org>
nl_parse_lookup_u8 handler is used with duplex_values defined as
lookup_entry_u32. While it still works on little endian machines,
duplex is always 0 (DUPLEX_HALF) on big endian ones...
Fixes: 392b12e38747 ("netlink: add netlink handler for sset (-s)")
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
netlink/settings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netlink/settings.c b/netlink/settings.c
index 4fd75d2..9aad8d9 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -1089,7 +1089,7 @@ static const struct bitset_parser_data advertise_parser_data = {
.force_hex = true,
};
-static const struct lookup_entry_u32 duplex_values[] = {
+static const struct lookup_entry_u8 duplex_values[] = {
{ .arg = "half", .val = DUPLEX_HALF },
{ .arg = "full", .val = DUPLEX_FULL },
{}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH ethtool] netlink: fix duplex setting
2023-06-27 11:09 [PATCH ethtool] netlink: fix duplex setting Ladislav Michl
@ 2023-07-01 22:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-01 22:30 UTC (permalink / raw)
To: Ladislav Michl; +Cc: mkubecek, netdev
Hello:
This patch was applied to ethtool/ethtool.git (master)
by Michal Kubecek <mkubecek@suse.cz>:
On Tue, 27 Jun 2023 13:09:03 +0200 you wrote:
> From: Ladislav Michl <ladis@linux-mips.org>
>
> nl_parse_lookup_u8 handler is used with duplex_values defined as
> lookup_entry_u32. While it still works on little endian machines,
> duplex is always 0 (DUPLEX_HALF) on big endian ones...
>
> Fixes: 392b12e38747 ("netlink: add netlink handler for sset (-s)")
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
>
> [...]
Here is the summary with links:
- [ethtool] netlink: fix duplex setting
https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=f493e6381c8a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-01 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-27 11:09 [PATCH ethtool] netlink: fix duplex setting Ladislav Michl
2023-07-01 22:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.