* [PATCH] scsi: aic7xxx: fix firmware build fatal error
@ 2023-07-11 8:47 Wang Jinchao
2023-07-31 16:12 ` Martin K. Petersen
2023-08-08 2:50 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Wang Jinchao @ 2023-07-11 8:47 UTC (permalink / raw)
To: Hannes Reinecke, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
Cc: stone.xulei
When building with CONFIG_AIC7XXX_BUILD_FIRMWARE=y, two fatal errors
are reported as shown below:
> aicasm_gram.tab.c:203:10: fatal error: aicasm_gram.tab.h:
> No such file or directory
> aicasm_macro_gram.tab.c:167:10: fatal error: aicasm_macro_gram.tab.h:
> No such file or directory
Fix these issues to make randconfig builds more reliable.
Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
---
drivers/scsi/aic7xxx/aicasm/Makefile | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aicasm/Makefile b/drivers/scsi/aic7xxx/aicasm/Makefile
index 243adb0a38d1..a3f2357a3f08 100644
--- a/drivers/scsi/aic7xxx/aicasm/Makefile
+++ b/drivers/scsi/aic7xxx/aicasm/Makefile
@@ -61,23 +61,11 @@ $(OUTDIR)/aicdb.h:
clean:
rm -f $(clean-files)
-# Create a dependency chain in generated files
-# to avoid concurrent invocations of the single
-# rule that builds them all.
-$(OUTDIR)/aicasm_gram.c: $(OUTDIR)/aicasm_gram.h
$(OUTDIR)/aicasm_gram.c $(OUTDIR)/aicasm_gram.h: aicasm_gram.y
- $(YACC) $(YFLAGS) -b $(<:.y=) $<
- mv $(<:.y=).tab.c $(OUTDIR)/$(<:.y=.c)
- mv $(<:.y=).tab.h $(OUTDIR)/$(<:.y=.h)
-
-# Create a dependency chain in generated files
-# to avoid concurrent invocations of the single
-# rule that builds them all.
-$(OUTDIR)/aicasm_macro_gram.c: $(OUTDIR)/aicasm_macro_gram.h
+ $(YACC) $(YFLAGS) -b $(<:.y=) $< -o $(OUTDIR)/$(<:.y=.c)
+
$(OUTDIR)/aicasm_macro_gram.c $(OUTDIR)/aicasm_macro_gram.h: aicasm_macro_gram.y
- $(YACC) $(YFLAGS) -b $(<:.y=) -p mm $<
- mv $(<:.y=).tab.c $(OUTDIR)/$(<:.y=.c)
- mv $(<:.y=).tab.h $(OUTDIR)/$(<:.y=.h)
+ $(YACC) $(YFLAGS) -b $(<:.y=) -p mm $< -o $(OUTDIR)/$(<:.y=.c)
$(OUTDIR)/aicasm_scan.c: aicasm_scan.l
$(LEX) $(LFLAGS) -o $@ $<
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: aic7xxx: fix firmware build fatal error
2023-07-11 8:47 [PATCH] scsi: aic7xxx: fix firmware build fatal error Wang Jinchao
@ 2023-07-31 16:12 ` Martin K. Petersen
2023-08-08 2:50 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-07-31 16:12 UTC (permalink / raw)
To: Wang Jinchao
Cc: Hannes Reinecke, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel, stone.xulei
Wang,
> When building with CONFIG_AIC7XXX_BUILD_FIRMWARE=y, two fatal errors
> are reported as shown below:
>> aicasm_gram.tab.c:203:10: fatal error: aicasm_gram.tab.h:
>> No such file or directory
>> aicasm_macro_gram.tab.c:167:10: fatal error: aicasm_macro_gram.tab.h:
>> No such file or directory
> Fix these issues to make randconfig builds more reliable.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: aic7xxx: fix firmware build fatal error
2023-07-11 8:47 [PATCH] scsi: aic7xxx: fix firmware build fatal error Wang Jinchao
2023-07-31 16:12 ` Martin K. Petersen
@ 2023-08-08 2:50 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-08-08 2:50 UTC (permalink / raw)
To: Hannes Reinecke, James E.J. Bottomley, linux-scsi, linux-kernel,
Wang Jinchao
Cc: Martin K . Petersen, stone.xulei
On Tue, 11 Jul 2023 16:47:30 +0800, Wang Jinchao wrote:
> When building with CONFIG_AIC7XXX_BUILD_FIRMWARE=y, two fatal errors
> are reported as shown below:
> > aicasm_gram.tab.c:203:10: fatal error: aicasm_gram.tab.h:
> > No such file or directory
> > aicasm_macro_gram.tab.c:167:10: fatal error: aicasm_macro_gram.tab.h:
> > No such file or directory
> Fix these issues to make randconfig builds more reliable.
>
> [...]
Applied to 6.6/scsi-queue, thanks!
[1/1] scsi: aic7xxx: fix firmware build fatal error
https://git.kernel.org/mkp/scsi/c/ec6c7c9f5fc4
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-08 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-11 8:47 [PATCH] scsi: aic7xxx: fix firmware build fatal error Wang Jinchao
2023-07-31 16:12 ` Martin K. Petersen
2023-08-08 2:50 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.