* [PATCH net] wifi: airo: avoid uninitialized warning in airo_get_rate()
@ 2023-07-09 13:31 Randy Dunlap
2023-07-11 17:25 ` Simon Horman
2023-07-12 2:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2023-07-09 13:31 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Geert Uytterhoeven, Kalle Valo, linux-wireless,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
Quieten a gcc (11.3.0) build error or warning by checking the function
call status and returning -EBUSY if the function call failed.
This is similar to what several other wireless drivers do for the
SIOCGIWRATE ioctl call when there is a locking problem.
drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: lore.kernel.org/r/39abf2c7-24a-f167-91da-ed4c5435d1c4@linux-m68k.org
Cc: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
---
drivers/net/wireless/cisco/airo.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff -- a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c
--- a/drivers/net/wireless/cisco/airo.c
+++ b/drivers/net/wireless/cisco/airo.c
@@ -6157,8 +6157,11 @@ static int airo_get_rate(struct net_devi
struct iw_param *vwrq = &wrqu->bitrate;
struct airo_info *local = dev->ml_priv;
StatusRid status_rid; /* Card status info */
+ int ret;
- readStatusRid(local, &status_rid, 1);
+ ret = readStatusRid(local, &status_rid, 1);
+ if (ret)
+ return -EBUSY;
vwrq->value = le16_to_cpu(status_rid.currentXmitRate) * 500000;
/* If more than one rate, set auto */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] wifi: airo: avoid uninitialized warning in airo_get_rate()
2023-07-09 13:31 [PATCH net] wifi: airo: avoid uninitialized warning in airo_get_rate() Randy Dunlap
@ 2023-07-11 17:25 ` Simon Horman
2023-07-11 21:07 ` Randy Dunlap
2023-07-12 2:30 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 5+ messages in thread
From: Simon Horman @ 2023-07-11 17:25 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Geert Uytterhoeven, Kalle Valo, linux-wireless,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
On Sun, Jul 09, 2023 at 06:31:54AM -0700, Randy Dunlap wrote:
> Quieten a gcc (11.3.0) build error or warning by checking the function
> call status and returning -EBUSY if the function call failed.
> This is similar to what several other wireless drivers do for the
> SIOCGIWRATE ioctl call when there is a locking problem.
>
> drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]
Hi Randy,
There seem to be other calls to readStatusRid() in the same file
with similar properties. Perhaps it would be best to fix them too?
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Link: lore.kernel.org/r/39abf2c7-24a-f167-91da-ed4c5435d1c4@linux-m68k.org
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> ---
> drivers/net/wireless/cisco/airo.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c
> --- a/drivers/net/wireless/cisco/airo.c
> +++ b/drivers/net/wireless/cisco/airo.c
> @@ -6157,8 +6157,11 @@ static int airo_get_rate(struct net_devi
> struct iw_param *vwrq = &wrqu->bitrate;
> struct airo_info *local = dev->ml_priv;
> StatusRid status_rid; /* Card status info */
> + int ret;
>
> - readStatusRid(local, &status_rid, 1);
> + ret = readStatusRid(local, &status_rid, 1);
> + if (ret)
> + return -EBUSY;
>
> vwrq->value = le16_to_cpu(status_rid.currentXmitRate) * 500000;
> /* If more than one rate, set auto */
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] wifi: airo: avoid uninitialized warning in airo_get_rate()
2023-07-11 17:25 ` Simon Horman
@ 2023-07-11 21:07 ` Randy Dunlap
2023-07-13 8:38 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2023-07-11 21:07 UTC (permalink / raw)
To: Simon Horman
Cc: linux-kernel, Geert Uytterhoeven, Kalle Valo, linux-wireless,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
Hi Simon,
On 7/11/23 10:25, Simon Horman wrote:
> On Sun, Jul 09, 2023 at 06:31:54AM -0700, Randy Dunlap wrote:
>> Quieten a gcc (11.3.0) build error or warning by checking the function
>> call status and returning -EBUSY if the function call failed.
>> This is similar to what several other wireless drivers do for the
>> SIOCGIWRATE ioctl call when there is a locking problem.
>>
>> drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]
>
> Hi Randy,
>
> There seem to be other calls to readStatusRid() in the same file
> with similar properties. Perhaps it would be best to fix them too?
>
Yes, there are 40+ calls that could have problems.
Please see this thread:
https://lore.kernel.org/all/2f6ffd1c-a756-b7b8-bba4-77c2308f26b9@infradead.org/
This is an attempt to shut up the build error/warning, which only occurs after
this one function call.
For such an old driver/hardware, I don't plan to do massive surgery
to it.
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Link: lore.kernel.org/r/39abf2c7-24a-f167-91da-ed4c5435d1c4@linux-m68k.org
>> Cc: Kalle Valo <kvalo@kernel.org>
>> Cc: linux-wireless@vger.kernel.org
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Eric Dumazet <edumazet@google.com>
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> Cc: Paolo Abeni <pabeni@redhat.com>
>> Cc: netdev@vger.kernel.org
>> ---
>> drivers/net/wireless/cisco/airo.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff -- a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c
>> --- a/drivers/net/wireless/cisco/airo.c
>> +++ b/drivers/net/wireless/cisco/airo.c
>> @@ -6157,8 +6157,11 @@ static int airo_get_rate(struct net_devi
>> struct iw_param *vwrq = &wrqu->bitrate;
>> struct airo_info *local = dev->ml_priv;
>> StatusRid status_rid; /* Card status info */
>> + int ret;
>>
>> - readStatusRid(local, &status_rid, 1);
>> + ret = readStatusRid(local, &status_rid, 1);
>> + if (ret)
>> + return -EBUSY;
>>
>> vwrq->value = le16_to_cpu(status_rid.currentXmitRate) * 500000;
>> /* If more than one rate, set auto */
>>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] wifi: airo: avoid uninitialized warning in airo_get_rate()
2023-07-09 13:31 [PATCH net] wifi: airo: avoid uninitialized warning in airo_get_rate() Randy Dunlap
2023-07-11 17:25 ` Simon Horman
@ 2023-07-12 2:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-12 2:30 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, geert, kvalo, linux-wireless, davem, edumazet,
kuba, pabeni, netdev
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 9 Jul 2023 06:31:54 -0700 you wrote:
> Quieten a gcc (11.3.0) build error or warning by checking the function
> call status and returning -EBUSY if the function call failed.
> This is similar to what several other wireless drivers do for the
> SIOCGIWRATE ioctl call when there is a locking problem.
>
> drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]
>
> [...]
Here is the summary with links:
- [net] wifi: airo: avoid uninitialized warning in airo_get_rate()
https://git.kernel.org/netdev/net/c/9373771aaed1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] wifi: airo: avoid uninitialized warning in airo_get_rate()
2023-07-11 21:07 ` Randy Dunlap
@ 2023-07-13 8:38 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2023-07-13 8:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Geert Uytterhoeven, Kalle Valo, linux-wireless,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
On Tue, Jul 11, 2023 at 02:07:57PM -0700, Randy Dunlap wrote:
> Hi Simon,
>
> On 7/11/23 10:25, Simon Horman wrote:
> > On Sun, Jul 09, 2023 at 06:31:54AM -0700, Randy Dunlap wrote:
> >> Quieten a gcc (11.3.0) build error or warning by checking the function
> >> call status and returning -EBUSY if the function call failed.
> >> This is similar to what several other wireless drivers do for the
> >> SIOCGIWRATE ioctl call when there is a locking problem.
> >>
> >> drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]
> >
> > Hi Randy,
> >
> > There seem to be other calls to readStatusRid() in the same file
> > with similar properties. Perhaps it would be best to fix them too?
> >
>
> Yes, there are 40+ calls that could have problems.
> Please see this thread:
> https://lore.kernel.org/all/2f6ffd1c-a756-b7b8-bba4-77c2308f26b9@infradead.org/
>
> This is an attempt to shut up the build error/warning, which only occurs after
> this one function call.
>
> For such an old driver/hardware, I don't plan to do massive surgery
> to it.
Thanks Randy,
given the circumstances I agree this is a reasonable approach.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-13 8:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-09 13:31 [PATCH net] wifi: airo: avoid uninitialized warning in airo_get_rate() Randy Dunlap
2023-07-11 17:25 ` Simon Horman
2023-07-11 21:07 ` Randy Dunlap
2023-07-13 8:38 ` Simon Horman
2023-07-12 2:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.