[PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

[PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

[Heinrich Schuchardt]

Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
table generation. Add it to the documentation.

Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
v2:
	mention that acpi=on is the default
---
 docs/system/riscv/virt.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
index f5fa7b8b29..9a06f95a34 100644
--- a/docs/system/riscv/virt.rst
+++ b/docs/system/riscv/virt.rst
@@ -95,6 +95,11 @@ The following machine-specific options are supported:
   SiFive CLINT. When not specified, this option is assumed to be "off".
   This option is restricted to the TCG accelerator.
 
+- acpi=[on|off|auto]
+
+  When this option is "on" (which is the default), ACPI tables are generated and
+  exposed as firmware tables etc/acpi/rsdp and etc/acpi/tables.
+
 - aia=[none|aplic|aplic-imsic]
 
   This option allows selecting interrupt controller defined by the AIA
-- 
2.40.1

Re: [PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

[Daniel Henrique Barboza]

On 12/20/23 16:34, Heinrich Schuchardt wrote:
> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
> table generation. Add it to the documentation.
> 
> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

> v2:
> 	mention that acpi=on is the default
> ---
>   docs/system/riscv/virt.rst | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
> index f5fa7b8b29..9a06f95a34 100644
> --- a/docs/system/riscv/virt.rst
> +++ b/docs/system/riscv/virt.rst
> @@ -95,6 +95,11 @@ The following machine-specific options are supported:
>     SiFive CLINT. When not specified, this option is assumed to be "off".
>     This option is restricted to the TCG accelerator.
>   
> +- acpi=[on|off|auto]
> +
> +  When this option is "on" (which is the default), ACPI tables are generated and
> +  exposed as firmware tables etc/acpi/rsdp and etc/acpi/tables.
> +
>   - aia=[none|aplic|aplic-imsic]
>   
>     This option allows selecting interrupt controller defined by the AIA

Re: [PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

[Sunil V L]

On Wed, Dec 20, 2023 at 08:34:36PM +0100, Heinrich Schuchardt wrote:
> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
> table generation. Add it to the documentation.
> 
> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> v2:
> 	mention that acpi=on is the default
> ---
>  docs/system/riscv/virt.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks!
Sunil

Re: [PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

[Alistair Francis]

On Thu, Dec 21, 2023 at 6:03 AM Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
> table generation. Add it to the documentation.
>
> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
> v2:
>         mention that acpi=on is the default
> ---
>  docs/system/riscv/virt.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
> index f5fa7b8b29..9a06f95a34 100644
> --- a/docs/system/riscv/virt.rst
> +++ b/docs/system/riscv/virt.rst
> @@ -95,6 +95,11 @@ The following machine-specific options are supported:
>    SiFive CLINT. When not specified, this option is assumed to be "off".
>    This option is restricted to the TCG accelerator.
>
> +- acpi=[on|off|auto]
> +
> +  When this option is "on" (which is the default), ACPI tables are generated and
> +  exposed as firmware tables etc/acpi/rsdp and etc/acpi/tables.
> +
>  - aia=[none|aplic|aplic-imsic]
>
>    This option allows selecting interrupt controller defined by the AIA
> --
> 2.40.1
>
>

Re: [PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

[Alistair Francis]

On Thu, Dec 21, 2023 at 6:03 AM Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
> table generation. Add it to the documentation.
>
> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
> v2:
>         mention that acpi=on is the default
> ---
>  docs/system/riscv/virt.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
> index f5fa7b8b29..9a06f95a34 100644
> --- a/docs/system/riscv/virt.rst
> +++ b/docs/system/riscv/virt.rst
> @@ -95,6 +95,11 @@ The following machine-specific options are supported:
>    SiFive CLINT. When not specified, this option is assumed to be "off".
>    This option is restricted to the TCG accelerator.
>
> +- acpi=[on|off|auto]
> +
> +  When this option is "on" (which is the default), ACPI tables are generated and
> +  exposed as firmware tables etc/acpi/rsdp and etc/acpi/tables.
> +
>  - aia=[none|aplic|aplic-imsic]
>
>    This option allows selecting interrupt controller defined by the AIA
> --
> 2.40.1
>
>