* [PATCH] firmware: coreboot: make coreboot_bus_type const
@ 2024-02-04 16:10 Ricardo B. Marliere
2024-02-05 12:50 ` Greg Kroah-Hartman
2024-02-06 4:01 ` Tzung-Bi Shih
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo B. Marliere @ 2024-02-04 16:10 UTC (permalink / raw)
To: Tzung-Bi Shih, Brian Norris, Julius Werner
Cc: chrome-platform, linux-kernel, Greg Kroah-Hartman, Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type,
move the coreboot_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/firmware/google/coreboot_table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/google/coreboot_table.c
index 2a4469bf1b81..fcdc387ae7aa 100644
--- a/drivers/firmware/google/coreboot_table.c
+++ b/drivers/firmware/google/coreboot_table.c
@@ -53,7 +53,7 @@ static void coreboot_bus_remove(struct device *dev)
driver->remove(device);
}
-static struct bus_type coreboot_bus_type = {
+static const struct bus_type coreboot_bus_type = {
.name = "coreboot",
.match = coreboot_bus_match,
.probe = coreboot_bus_probe,
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240204-bus_cleanup-firmware-99d006104626
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: coreboot: make coreboot_bus_type const
2024-02-04 16:10 [PATCH] firmware: coreboot: make coreboot_bus_type const Ricardo B. Marliere
@ 2024-02-05 12:50 ` Greg Kroah-Hartman
2024-02-06 4:01 ` Tzung-Bi Shih
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-05 12:50 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Tzung-Bi Shih, Brian Norris, Julius Werner, chrome-platform,
linux-kernel
On Sun, Feb 04, 2024 at 01:10:18PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the coreboot_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: coreboot: make coreboot_bus_type const
2024-02-04 16:10 [PATCH] firmware: coreboot: make coreboot_bus_type const Ricardo B. Marliere
2024-02-05 12:50 ` Greg Kroah-Hartman
@ 2024-02-06 4:01 ` Tzung-Bi Shih
1 sibling, 0 replies; 3+ messages in thread
From: Tzung-Bi Shih @ 2024-02-06 4:01 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Brian Norris, Julius Werner, chrome-platform, linux-kernel,
Greg Kroah-Hartman
On Sun, Feb 04, 2024 at 01:10:18PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the coreboot_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
Applied, thanks!
[1/1] firmware: coreboot: make coreboot_bus_type const
commit: e3c5df138169b5494a16b20e74db1ee14b1901ce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-06 4:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-04 16:10 [PATCH] firmware: coreboot: make coreboot_bus_type const Ricardo B. Marliere
2024-02-05 12:50 ` Greg Kroah-Hartman
2024-02-06 4:01 ` Tzung-Bi Shih
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.