All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/systemd: needs sulogin for emergency target support
@ 2024-02-19 18:38 Marcus Hoffmann via buildroot
  2024-02-19 21:06 ` Yann E. MORIN
  2024-03-16 21:25 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Marcus Hoffmann via buildroot @ 2024-02-19 18:38 UTC (permalink / raw)
  To: buildroot; +Cc: Norbert Lange, Sen Hastings, Yann E. MORIN

systemd invokes util-linux' sulogin via systemd-sulogin-shell[1] via
emergency.service/emergency.target[2].

[1] https://github.com/systemd/systemd/blob/main/src/sulogin-shell/sulogin-shell.c
[2] https://github.com/systemd/systemd/blob/main/units/emergency.service.in#L23

Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
---
 package/systemd/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/systemd/Config.in b/package/systemd/Config.in
index 859332d9e4..58b4e51c6d 100644
--- a/package/systemd/Config.in
+++ b/package/systemd/Config.in
@@ -34,6 +34,7 @@ menuconfig BR2_PACKAGE_SYSTEMD
 	select BR2_PACKAGE_UTIL_LINUX_AGETTY
 	select BR2_PACKAGE_UTIL_LINUX_MOUNT
 	select BR2_PACKAGE_UTIL_LINUX_FSCK
+	select BR2_PACKAGE_UTIL_LINUX_SULOGIN # emergency target
 	select BR2_PACKAGE_KMOD
 	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools
 	select BR2_PACKAGE_KMOD_TOOLS
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/systemd: needs sulogin for emergency target support
  2024-02-19 18:38 [Buildroot] [PATCH] package/systemd: needs sulogin for emergency target support Marcus Hoffmann via buildroot
@ 2024-02-19 21:06 ` Yann E. MORIN
  2024-03-16 21:25 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2024-02-19 21:06 UTC (permalink / raw)
  To: Marcus Hoffmann; +Cc: Norbert Lange, Sen Hastings, buildroot

Marcus, All,

On 2024-02-19 19:38 +0100, Marcus Hoffmann via buildroot spake thusly:
> systemd invokes util-linux' sulogin via systemd-sulogin-shell[1] via
> emergency.service/emergency.target[2].
> 
> [1] https://github.com/systemd/systemd/blob/main/src/sulogin-shell/sulogin-shell.c
> [2] https://github.com/systemd/systemd/blob/main/units/emergency.service.in#L23

I thinks that, technically, it could be content with sulogin from
busybox, but since we already select a lot of util-linux' tools, adding
sulogin is not goign to add much to the target size.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
> ---
>  package/systemd/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index 859332d9e4..58b4e51c6d 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -34,6 +34,7 @@ menuconfig BR2_PACKAGE_SYSTEMD
>  	select BR2_PACKAGE_UTIL_LINUX_AGETTY
>  	select BR2_PACKAGE_UTIL_LINUX_MOUNT
>  	select BR2_PACKAGE_UTIL_LINUX_FSCK
> +	select BR2_PACKAGE_UTIL_LINUX_SULOGIN # emergency target
>  	select BR2_PACKAGE_KMOD
>  	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools
>  	select BR2_PACKAGE_KMOD_TOOLS
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/systemd: needs sulogin for emergency target support
  2024-02-19 18:38 [Buildroot] [PATCH] package/systemd: needs sulogin for emergency target support Marcus Hoffmann via buildroot
  2024-02-19 21:06 ` Yann E. MORIN
@ 2024-03-16 21:25 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-03-16 21:25 UTC (permalink / raw)
  To: Marcus Hoffmann via buildroot
  Cc: Norbert Lange, Marcus Hoffmann, Yann E. MORIN, Sen Hastings

>>>>> "Marcus" == Marcus Hoffmann via buildroot <buildroot@buildroot.org> writes:

 > systemd invokes util-linux' sulogin via systemd-sulogin-shell[1] via
 > emergency.service/emergency.target[2].

 > [1] https://github.com/systemd/systemd/blob/main/src/sulogin-shell/sulogin-shell.c
 > [2] https://github.com/systemd/systemd/blob/main/units/emergency.service.in#L23

 > Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-16 21:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-19 18:38 [Buildroot] [PATCH] package/systemd: needs sulogin for emergency target support Marcus Hoffmann via buildroot
2024-02-19 21:06 ` Yann E. MORIN
2024-03-16 21:25 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.