[PATCH] mm: remove __set_page_dirty_nobuffers()

[PATCH] mm: remove __set_page_dirty_nobuffers()

[Kefeng Wang]

There are no more callers of __set_page_dirty_nobuffers(), remove it.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 include/linux/pagemap.h | 1 -
 mm/folio-compat.c       | 6 ------
 2 files changed, 7 deletions(-)

diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 35636e67e2e1..9e988f6f0bb0 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -1163,7 +1163,6 @@ static inline void folio_cancel_dirty(struct folio *folio)
 bool folio_clear_dirty_for_io(struct folio *folio);
 bool clear_page_dirty_for_io(struct page *page);
 void folio_invalidate(struct folio *folio, size_t offset, size_t length);
-int __set_page_dirty_nobuffers(struct page *page);
 bool noop_dirty_folio(struct address_space *mapping, struct folio *folio);
 
 #ifdef CONFIG_MIGRATION
diff --git a/mm/folio-compat.c b/mm/folio-compat.c
index 50412014f16f..f31e0ce65b11 100644
--- a/mm/folio-compat.c
+++ b/mm/folio-compat.c
@@ -58,12 +58,6 @@ bool set_page_dirty(struct page *page)
 }
 EXPORT_SYMBOL(set_page_dirty);
 
-int __set_page_dirty_nobuffers(struct page *page)
-{
-	return filemap_dirty_folio(page_mapping(page), page_folio(page));
-}
-EXPORT_SYMBOL(__set_page_dirty_nobuffers);
-
 bool clear_page_dirty_for_io(struct page *page)
 {
 	return folio_clear_dirty_for_io(page_folio(page));
-- 
2.41.0

Re: [PATCH] mm: remove __set_page_dirty_nobuffers()

[David Hildenbrand]

On 27.03.24 15:30, Kefeng Wang wrote:
> There are no more callers of __set_page_dirty_nobuffers(), remove it.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>   include/linux/pagemap.h | 1 -
>   mm/folio-compat.c       | 6 ------
>   2 files changed, 7 deletions(-)
> 
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index 35636e67e2e1..9e988f6f0bb0 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -1163,7 +1163,6 @@ static inline void folio_cancel_dirty(struct folio *folio)
>   bool folio_clear_dirty_for_io(struct folio *folio);
>   bool clear_page_dirty_for_io(struct page *page);
>   void folio_invalidate(struct folio *folio, size_t offset, size_t length);
> -int __set_page_dirty_nobuffers(struct page *page);
>   bool noop_dirty_folio(struct address_space *mapping, struct folio *folio);
>   
>   #ifdef CONFIG_MIGRATION
> diff --git a/mm/folio-compat.c b/mm/folio-compat.c
> index 50412014f16f..f31e0ce65b11 100644
> --- a/mm/folio-compat.c
> +++ b/mm/folio-compat.c
> @@ -58,12 +58,6 @@ bool set_page_dirty(struct page *page)
>   }
>   EXPORT_SYMBOL(set_page_dirty);
>   
> -int __set_page_dirty_nobuffers(struct page *page)
> -{
> -	return filemap_dirty_folio(page_mapping(page), page_folio(page));
> -}
> -EXPORT_SYMBOL(__set_page_dirty_nobuffers);
> -
>   bool clear_page_dirty_for_io(struct page *page)
>   {
>   	return folio_clear_dirty_for_io(page_folio(page));

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH] mm: remove __set_page_dirty_nobuffers()

[Matthew Wilcox]

On Wed, Mar 27, 2024 at 10:30:08PM +0800, Kefeng Wang wrote:
> There are no more callers of __set_page_dirty_nobuffers(), remove it.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Yes, I have this exact patch in my tree, stuck behind a mess of other
patches for the last two months.  It had to wait until the ubifs patches
landed (which removed the last user), and as you can see I've been busy
submitting other patches first.

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Re: [PATCH] mm: remove __set_page_dirty_nobuffers()

[Vishal Moola]

On Wed, Mar 27, 2024 at 10:30:08PM +0800, Kefeng Wang wrote:
> There are no more callers of __set_page_dirty_nobuffers(), remove it.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>