All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Matthijs Kooijman <matthijs@stdin.nl>, linux-gpio@vger.kernel.org
Subject: Re: pinctrl: single: Cannot disable bias - PIN_CONFIG_BIAS_DISABLE not handled
Date: Fri, 29 Mar 2024 02:06:31 +0000	[thread overview]
Message-ID: <ZgYiJ5KM9pdESYKs@hackbox2.linaro.org> (raw)
In-Reply-To: <20240322062419.GA5129@atomide.com>

On Fri, Mar 22, 2024 at 08:24:19AM +0200, Tony Lindgren wrote:
> * Matthijs Kooijman <matthijs@stdin.nl> [240319 11:05]:
> > Hi Tony,
> > 
> > > > An obvious fix for this would be to lift the handling for
> > > > PIN_CONFIG_BIAS_DISABLE out of the inner loop, running that instead of
> > > > the inner loop in that case.
> > >
> > > Maybe post a suggested patch for Haojian to look at?
> > 
> > I've created a patch (will send in a followup) to do exactly this.
> 
> OK great thanks!
> 
> > I've compile-tested it but have not been able to runtime test it (I
> > managed to compile and run a mainline kernel for the BBB, but ran into
> > problems setting up the bias control devicetree). For now, I'll just
> > leave the patch here for review, maybe I'll find some time also runtime
> > test it in the future (but likely not).
> 
> OK
> 
> Regards,
> 
> Tony

Thanks. I'm fine on this patch.

Best Regards
Haojian

      reply	other threads:[~2024-03-29  2:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 12:04 pinctrl: single: Cannot disable bias - PIN_CONFIG_BIAS_DISABLE not handled Matthijs Kooijman
2024-02-29  7:32 ` Tony Lindgren
2024-02-29 18:31   ` Nathan Chancellor
2024-02-29 19:07     ` Matthijs Kooijman
2024-03-01 10:04     ` Tony Lindgren
2024-03-19 11:05   ` Matthijs Kooijman
2024-03-19 11:06     ` [PATCH] pinctrl: single: Fix PIN_CONFIG_BIAS_DISABLE handling Matthijs Kooijman
2024-03-28 21:02       ` Linus Walleij
2024-04-03  8:59         ` Tony Lindgren
2024-03-29  2:05       ` Haojian Zhuang
2024-04-04 12:00       ` Linus Walleij
2024-03-22  6:24     ` pinctrl: single: Cannot disable bias - PIN_CONFIG_BIAS_DISABLE not handled Tony Lindgren
2024-03-29  2:06       ` Haojian Zhuang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZgYiJ5KM9pdESYKs@hackbox2.linaro.org \
    --to=haojian.zhuang@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=matthijs@stdin.nl \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.