All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo2@yeah.net>
To: Frank Li <Frank.Li@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 4/5] arm64: dts: imx8: fix audio lpcg index
Date: Wed, 3 Apr 2024 08:46:23 +0800	[thread overview]
Message-ID: <Zgym35B8Ig5ej5QF@dragon> (raw)
In-Reply-To: <20240328-asrc_8qxp-v8-4-801cd6bb5be2@nxp.com>

On Thu, Mar 28, 2024 at 10:51:36AM -0400, Frank Li wrote:
> lpcg cell0 should be clock's 'indices' instead of 'index'.
> 
> imx_lpcg_of_clk_src_get(struct of_phandle_args *clkspec, void *data)
> {
>         struct clk_hw_onecell_data *hw_data = data;
>         unsigned int idx = clkspec->args[0] / 4;
> 
> 	....
> }
> 
> <@sai0_lpcg 1> will be the same as <@sai_lpcg 0>.
> 
> Replace 0 with IMX_LPCG_CLK_0 and replace 1 with IMX_LPCG_CLK_4.
> 
> It can work at iMX8QXP because IMX_LPCG_CLK_4 is ipg clock, which already
> enabled. But for iMX8QM IMX_LPCG_CLK_4 is mclk, which trigger issue.
> 
> Fixes: 0a9279e9ae88 ("arm64: dts: imx8qxp: Add audio SAI nodes")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Applied, thanks!


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo2@yeah.net>
To: Frank Li <Frank.Li@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 4/5] arm64: dts: imx8: fix audio lpcg index
Date: Wed, 3 Apr 2024 08:46:23 +0800	[thread overview]
Message-ID: <Zgym35B8Ig5ej5QF@dragon> (raw)
In-Reply-To: <20240328-asrc_8qxp-v8-4-801cd6bb5be2@nxp.com>

On Thu, Mar 28, 2024 at 10:51:36AM -0400, Frank Li wrote:
> lpcg cell0 should be clock's 'indices' instead of 'index'.
> 
> imx_lpcg_of_clk_src_get(struct of_phandle_args *clkspec, void *data)
> {
>         struct clk_hw_onecell_data *hw_data = data;
>         unsigned int idx = clkspec->args[0] / 4;
> 
> 	....
> }
> 
> <@sai0_lpcg 1> will be the same as <@sai_lpcg 0>.
> 
> Replace 0 with IMX_LPCG_CLK_0 and replace 1 with IMX_LPCG_CLK_4.
> 
> It can work at iMX8QXP because IMX_LPCG_CLK_4 is ipg clock, which already
> enabled. But for iMX8QM IMX_LPCG_CLK_4 is mclk, which trigger issue.
> 
> Fixes: 0a9279e9ae88 ("arm64: dts: imx8qxp: Add audio SAI nodes")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Applied, thanks!


  reply	other threads:[~2024-04-03  0:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 14:51 [PATCH v8 0/5] arm64: dts: imx8qxp add asrc and sai Frank Li
2024-03-28 14:51 ` Frank Li
2024-03-28 14:51 ` [PATCH v8 1/5] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains property Frank Li
2024-03-28 14:51   ` Frank Li
2024-03-28 14:51 ` [PATCH v8 2/5] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers Frank Li
2024-03-28 14:51   ` Frank Li
2024-03-28 14:51 ` [PATCH v8 3/5] ASoC: dt-bindings: fsl-sai: allow only one dma-names Frank Li
2024-03-28 14:51   ` Frank Li
2024-03-28 14:51 ` [PATCH v8 4/5] arm64: dts: imx8: fix audio lpcg index Frank Li
2024-03-28 14:51   ` Frank Li
2024-04-03  0:46   ` Shawn Guo [this message]
2024-04-03  0:46     ` Shawn Guo
2024-03-28 14:51 ` [PATCH v8 5/5] arm64: dts: imx8qxp: add asrc[0,1], esai0, spdif0 and sai[4,5] Frank Li
2024-03-28 14:51   ` Frank Li
2024-04-03  0:46   ` Shawn Guo
2024-04-03  0:46     ` Shawn Guo
2024-03-29 12:34 ` (subset) [PATCH v8 0/5] arm64: dts: imx8qxp add asrc and sai Mark Brown
2024-03-29 12:34   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zgym35B8Ig5ej5QF@dragon \
    --to=shawnguo2@yeah.net \
    --cc=Frank.Li@nxp.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.