* [linux-next:master 6398/6705] mm/page_table_check.c:194:1: warning: control reaches end of non-void function
@ 2024-04-17 10:01 kernel test robot
2024-04-17 16:54 ` Peter Xu
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2024-04-17 10:01 UTC (permalink / raw)
To: Peter Xu; +Cc: oe-kbuild-all, Linux Memory Management List, Andrew Morton
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4eab358930711bbeb85bf5ee267d0d42d3394c2c
commit: 62754e4df9e04c4576e989f5ea2b909e824d8164 [6398/6705] mm/page_table_check: support userfault wr-protect entries
config: riscv-randconfig-r001-20230105 (https://download.01.org/0day-ci/archive/20240417/202404171745.Zd13ydca-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240417/202404171745.Zd13ydca-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404171745.Zd13ydca-lkp@intel.com/
All warnings (new ones prefixed by >>):
mm/page_table_check.c: In function 'swap_cached_writable':
mm/page_table_check.c:192:24: error: 'SWP_DEVICE_EXCLUSIVE_WRITE' undeclared (first use in this function)
192 | return type == SWP_DEVICE_EXCLUSIVE_WRITE ||
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
mm/page_table_check.c:192:24: note: each undeclared identifier is reported only once for each function it appears in
>> mm/page_table_check.c:194:1: warning: control reaches end of non-void function [-Wreturn-type]
194 | }
| ^
vim +194 mm/page_table_check.c
186
187 /* Whether the swap entry cached writable information */
188 static inline bool swap_cached_writable(swp_entry_t entry)
189 {
190 unsigned type = swp_type(entry);
191
192 return type == SWP_DEVICE_EXCLUSIVE_WRITE ||
193 type == SWP_MIGRATION_WRITE;
> 194 }
195
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-next:master 6398/6705] mm/page_table_check.c:194:1: warning: control reaches end of non-void function
2024-04-17 10:01 [linux-next:master 6398/6705] mm/page_table_check.c:194:1: warning: control reaches end of non-void function kernel test robot
@ 2024-04-17 16:54 ` Peter Xu
0 siblings, 0 replies; 2+ messages in thread
From: Peter Xu @ 2024-04-17 16:54 UTC (permalink / raw)
To: kernel test robot
Cc: oe-kbuild-all, Linux Memory Management List, Andrew Morton
On Wed, Apr 17, 2024 at 06:01:49PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 4eab358930711bbeb85bf5ee267d0d42d3394c2c
> commit: 62754e4df9e04c4576e989f5ea2b909e824d8164 [6398/6705] mm/page_table_check: support userfault wr-protect entries
> config: riscv-randconfig-r001-20230105 (https://download.01.org/0day-ci/archive/20240417/202404171745.Zd13ydca-lkp@intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240417/202404171745.Zd13ydca-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404171745.Zd13ydca-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> mm/page_table_check.c: In function 'swap_cached_writable':
> mm/page_table_check.c:192:24: error: 'SWP_DEVICE_EXCLUSIVE_WRITE' undeclared (first use in this function)
> 192 | return type == SWP_DEVICE_EXCLUSIVE_WRITE ||
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> mm/page_table_check.c:192:24: note: each undeclared identifier is reported only once for each function it appears in
> >> mm/page_table_check.c:194:1: warning: control reaches end of non-void function [-Wreturn-type]
> 194 | }
> | ^
>
>
> vim +194 mm/page_table_check.c
>
> 186
> 187 /* Whether the swap entry cached writable information */
> 188 static inline bool swap_cached_writable(swp_entry_t entry)
> 189 {
> 190 unsigned type = swp_type(entry);
> 191
> 192 return type == SWP_DEVICE_EXCLUSIVE_WRITE ||
> 193 type == SWP_MIGRATION_WRITE;
> > 194 }
> 195
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
I'll send a v2 of this patch soon to fix all these issues, after I check
with Pasha on some other changes.
Thanks,
--
Peter Xu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-17 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 10:01 [linux-next:master 6398/6705] mm/page_table_check.c:194:1: warning: control reaches end of non-void function kernel test robot
2024-04-17 16:54 ` Peter Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.