* Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
@ 2020-04-19 9:34 ` Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-04-19 9:34 UTC (permalink / raw)
To: Bernard Zhao, amd-gfx, dri-devel, Alex Deucher,
Christian König, Chunming Zhou
Cc: Andrzej Pietrasiewicz, Daniel Vetter, David Airlie,
Dhinakaran Pandiyan, José Roberto de Souza, Lyude Paul,
Neil Armstrong, Sam Ravnborg, linux-kernel, opensource.kernel
> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.
I suggest to improve the commit message.
* Would you like to adjust the patch subject?
* How do you think about to add the tag “Fixes”
because of adjustments for the exception handling?
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
@ 2020-04-19 9:34 ` Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-04-19 9:34 UTC (permalink / raw)
To: Bernard Zhao, amd-gfx, dri-devel, Alex Deucher,
Christian König, Chunming Zhou
Cc: opensource.kernel, Neil Armstrong, David Airlie, linux-kernel,
José Roberto de Souza, Andrzej Pietrasiewicz,
Dhinakaran Pandiyan, Sam Ravnborg
> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.
I suggest to improve the commit message.
* Would you like to adjust the patch subject?
* How do you think about to add the tag “Fixes”
because of adjustments for the exception handling?
Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
@ 2020-04-19 9:34 ` Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-04-19 9:34 UTC (permalink / raw)
To: Bernard Zhao, amd-gfx, dri-devel, Alex Deucher,
Christian König, Chunming Zhou
Cc: opensource.kernel, Neil Armstrong, David Airlie, linux-kernel,
José Roberto de Souza, Andrzej Pietrasiewicz,
Dhinakaran Pandiyan, Daniel Vetter, Sam Ravnborg
> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.
I suggest to improve the commit message.
* Would you like to adjust the patch subject?
* How do you think about to add the tag “Fixes”
because of adjustments for the exception handling?
Regards,
Markus
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
2020-04-19 9:34 ` Markus Elfring
(?)
@ 2020-04-20 0:56 ` 赵军奎
-1 siblings, 0 replies; 6+ messages in thread
From: 赵军奎 @ 2020-04-20 0:56 UTC (permalink / raw)
To: Markus Elfring
Cc: amd-gfx, dri-devel, Alex Deucher, Christian König,
Chunming Zhou, Andrzej Pietrasiewicz, Daniel Vetter,
David Airlie, Dhinakaran Pandiyan, José Roberto de Souza,
Lyude Paul, Neil Armstrong, Sam Ravnborg, linux-kernel,
opensource.kernel
发件人：Markus Elfring <Markus.Elfring@web.de>
发送日期：2020-04-19 17:34:47
收件人：Bernard Zhao <bernard@vivo.com>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,Alex Deucher <alexander.deucher@amd.com>,"Christian König" <christian.koenig@amd.com>,Chunming Zhou <David1.Zhou@amd.com>
抄送人：Andrzej Pietrasiewicz <andrzej.p@collabora.com>,Daniel Vetter <daniel@ffwll.ch>,David Airlie <airlied@linux.ie>,Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,"José Roberto de Souza" <jose.souza@intel.com>,Lyude Paul <lyude@redhat.com>,Neil Armstrong <narmstrong@baylibre.com>,Sam Ravnborg <sam@ravnborg.org>,linux-kernel@vger.kernel.org,opensource.kernel@vivo.com
主题：Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()>> The "if(!encoder)" branch return the same value 0 of the success
>> branch, maybe return -EINVAL is more better.
>
>I suggest to improve the commit message.
Sure.
>
>* Would you like to adjust the patch subject?
>
>* How do you think about to add the tag “Fixes”
> because of adjustments for the exception handling?
This is a good idea, the code will be more in line with the Linux specifications.
I will adjust this patch commit message and modify the code. I will submit it again.
>
>Regards,
>Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
@ 2020-04-20 0:56 ` 赵军奎
0 siblings, 0 replies; 6+ messages in thread
From: 赵军奎 @ 2020-04-20 0:56 UTC (permalink / raw)
To: Markus Elfring
Cc: opensource.kernel, Neil Armstrong, David Airlie, linux-kernel,
dri-devel, Andrzej Pietrasiewicz, José Roberto de Souza,
amd-gfx, Alex Deucher, Sam Ravnborg, Christian König,
Dhinakaran Pandiyan
发件人：Markus Elfring <Markus.Elfring@web.de>
发送日期：2020-04-19 17:34:47
收件人：Bernard Zhao <bernard@vivo.com>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,Alex Deucher <alexander.deucher@amd.com>,"Christian König" <christian.koenig@amd.com>,Chunming Zhou <David1.Zhou@amd.com>
抄送人：Andrzej Pietrasiewicz <andrzej.p@collabora.com>,Daniel Vetter <daniel@ffwll.ch>,David Airlie <airlied@linux.ie>,Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,"José Roberto de Souza" <jose.souza@intel.com>,Lyude Paul <lyude@redhat.com>,Neil Armstrong <narmstrong@baylibre.com>,Sam Ravnborg <sam@ravnborg.org>,linux-kernel@vger.kernel.org,opensource.kernel@vivo.com
主题：Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()>> The "if(!encoder)" branch return the same value 0 of the success
>> branch, maybe return -EINVAL is more better.
>
>I suggest to improve the commit message.
Sure.
>
>* Would you like to adjust the patch subject?
>
>* How do you think about to add the tag “Fixes”
> because of adjustments for the exception handling?
This is a good idea, the code will be more in line with the Linux specifications.
I will adjust this patch commit message and modify the code. I will submit it again.
>
>Regards,
>Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
@ 2020-04-20 0:56 ` 赵军奎
0 siblings, 0 replies; 6+ messages in thread
From: 赵军奎 @ 2020-04-20 0:56 UTC (permalink / raw)
To: Markus Elfring
Cc: opensource.kernel, Chunming Zhou, Neil Armstrong, David Airlie,
linux-kernel, dri-devel, Andrzej Pietrasiewicz,
José Roberto de Souza, amd-gfx, Daniel Vetter, Alex Deucher,
Sam Ravnborg, Christian König, Dhinakaran Pandiyan
发件人：Markus Elfring <Markus.Elfring@web.de>
发送日期：2020-04-19 17:34:47
收件人：Bernard Zhao <bernard@vivo.com>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,Alex Deucher <alexander.deucher@amd.com>,"Christian König" <christian.koenig@amd.com>,Chunming Zhou <David1.Zhou@amd.com>
抄送人：Andrzej Pietrasiewicz <andrzej.p@collabora.com>,Daniel Vetter <daniel@ffwll.ch>,David Airlie <airlied@linux.ie>,Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,"José Roberto de Souza" <jose.souza@intel.com>,Lyude Paul <lyude@redhat.com>,Neil Armstrong <narmstrong@baylibre.com>,Sam Ravnborg <sam@ravnborg.org>,linux-kernel@vger.kernel.org,opensource.kernel@vivo.com
主题：Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()>> The "if(!encoder)" branch return the same value 0 of the success
>> branch, maybe return -EINVAL is more better.
>
>I suggest to improve the commit message.
Sure.
>
>* Would you like to adjust the patch subject?
>
>* How do you think about to add the tag “Fixes”
> because of adjustments for the exception handling?
This is a good idea, the code will be more in line with the Linux specifications.
I will adjust this patch commit message and modify the code. I will submit it again.
>
>Regards,
>Markus
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-20 6:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-19 9:34 [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property() Markus Elfring
2020-04-19 9:34 ` Markus Elfring
2020-04-19 9:34 ` Markus Elfring
2020-04-20 0:56 ` 赵军奎
2020-04-20 0:56 ` 赵军奎
2020-04-20 0:56 ` 赵军奎
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.