Re: [KJ] [PATCH][RESEND] is_power_of_2 in rtc

Re: [KJ] [PATCH][RESEND] is_power_of_2 in rtc

[Håkon Løvdal]

On 19/02/07, Vignesh Babu BM <vignesh.babu@wipro.com> wrote:>                 /* check for power of 2 */>> -               if ((arg & (arg-1)) != 0 || arg < 1) {> +               if (!is_power_of_2(arg)) {>                         ret = -EINVAL;>                         goto exit;>                 }
The comment is no longer necessary since the information it providednow also is present directly in the code (which of course is very good).
BR Håkon Løvdal
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] [PATCH][RESEND] is_power_of_2 in rtc

[Vignesh Babu BM]

Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2...resent to fix a change in the logic


Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
--- 
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index f406a2b..212ec32 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -20,6 +20,7 @@
 #include <linux/rtc.h>
 #include <linux/bcd.h>
 #include <linux/clk.h>
+#include <linux/log2.h>
 
 #include <asm/hardware.h>
 #include <asm/uaccess.h>
@@ -311,7 +312,7 @@ static int s3c_rtc_ioctl(struct device *dev,
 	case RTC_IRQP_SET:
 		/* check for power of 2 */
 
-		if ((arg & (arg-1)) != 0 || arg < 1) {
+		if (!is_power_of_2(arg)) {
 			ret = -EINVAL;
 			goto exit;
 		}

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors