* [PATCH] selftests: Add test cases for `ip nexthop flush proto XX`
@ 2019-09-16 12:26 Donald Sharp
2019-09-17 17:04 ` David Ahern
2019-09-20 1:36 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Donald Sharp @ 2019-09-16 12:26 UTC (permalink / raw)
To: netdev, dsahern
Add some test cases to allow the fib_nexthops.sh test code
to test the flushing of nexthops based upon the proto passed
in upon creation of the nexthop group.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---
tools/testing/selftests/net/fib_nexthops.sh | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh
index f9ebeac1e6f2..796670ebc65b 100755
--- a/tools/testing/selftests/net/fib_nexthops.sh
+++ b/tools/testing/selftests/net/fib_nexthops.sh
@@ -940,6 +940,20 @@ basic()
run_cmd "$IP nexthop add id 104 group 1 dev veth1"
log_test $? 2 "Nexthop group and device"
+ # Tests to ensure that flushing works as expected.
+ run_cmd "$IP nexthop add id 105 blackhole proto 99"
+ run_cmd "$IP nexthop add id 106 blackhole proto 100"
+ run_cmd "$IP nexthop add id 107 blackhole proto 99"
+ run_cmd "$IP nexthop flush proto 99"
+ check_nexthop "id 105" ""
+ check_nexthop "id 106" "id 106 blackhole proto 100"
+ check_nexthop "id 107" ""
+ run_cmd "$IP nexthop flush proto 100"
+ check_nexthop "id 106" ""
+
+ run_cmd "$IP nexthop flush proto 100"
+ log_test $? 0 "Test proto flush"
+
run_cmd "$IP nexthop add id 104 group 1 blackhole"
log_test $? 2 "Nexthop group and blackhole"
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: Add test cases for `ip nexthop flush proto XX`
2019-09-16 12:26 [PATCH] selftests: Add test cases for `ip nexthop flush proto XX` Donald Sharp
@ 2019-09-17 17:04 ` David Ahern
2019-09-20 1:36 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2019-09-17 17:04 UTC (permalink / raw)
To: Donald Sharp, netdev, dsahern
On 9/16/19 6:26 AM, Donald Sharp wrote:
> Add some test cases to allow the fib_nexthops.sh test code
> to test the flushing of nexthops based upon the proto passed
> in upon creation of the nexthop group.
>
> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
> ---
> tools/testing/selftests/net/fib_nexthops.sh | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: Add test cases for `ip nexthop flush proto XX`
2019-09-16 12:26 [PATCH] selftests: Add test cases for `ip nexthop flush proto XX` Donald Sharp
2019-09-17 17:04 ` David Ahern
@ 2019-09-20 1:36 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-09-20 1:36 UTC (permalink / raw)
To: Donald Sharp; +Cc: netdev, dsahern
On Mon, 16 Sep 2019 08:26:50 -0400, Donald Sharp wrote:
> Add some test cases to allow the fib_nexthops.sh test code
> to test the flushing of nexthops based upon the proto passed
> in upon creation of the nexthop group.
>
> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Applied, thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-20 1:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-16 12:26 [PATCH] selftests: Add test cases for `ip nexthop flush proto XX` Donald Sharp
2019-09-17 17:04 ` David Ahern
2019-09-20 1:36 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.