All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/3] configs: k2g_hs_evm: Resync defconfig with non-HS defconfig
@ 2018-03-22 20:44 Andrew F. Davis
  2018-03-22 20:44 ` [U-Boot] [PATCH 2/3] configs: k2e_hs_evm: " Andrew F. Davis
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Andrew F. Davis @ 2018-03-22 20:44 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 configs/k2g_hs_evm_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/configs/k2g_hs_evm_defconfig b/configs/k2g_hs_evm_defconfig
index 5402cd3214..b0c0e08584 100644
--- a/configs/k2g_hs_evm_defconfig
+++ b/configs/k2g_hs_evm_defconfig
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set
@@ -20,6 +21,9 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_OF_LIST="keystone-k2g-generic keystone-k2g-evm keystone-k2g-ice"
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y
 CONFIG_DM=y
 # CONFIG_BLK is not set
 CONFIG_DM_MMC=y
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 2/3] configs: k2e_hs_evm: Resync defconfig with non-HS defconfig
  2018-03-22 20:44 [U-Boot] [PATCH 1/3] configs: k2g_hs_evm: Resync defconfig with non-HS defconfig Andrew F. Davis
@ 2018-03-22 20:44 ` Andrew F. Davis
  2018-04-07 13:25   ` [U-Boot] [U-Boot, " Tom Rini
  2018-03-22 20:44 ` [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: " Andrew F. Davis
  2018-04-07 13:25 ` [U-Boot] [U-Boot, 1/3] configs: k2g_hs_evm: " Tom Rini
  2 siblings, 1 reply; 9+ messages in thread
From: Andrew F. Davis @ 2018-03-22 20:44 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 configs/k2e_hs_evm_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configs/k2e_hs_evm_defconfig b/configs/k2e_hs_evm_defconfig
index a79ce6060f..6224222129 100644
--- a/configs/k2e_hs_evm_defconfig
+++ b/configs/k2e_hs_evm_defconfig
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set
@@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig
  2018-03-22 20:44 [U-Boot] [PATCH 1/3] configs: k2g_hs_evm: Resync defconfig with non-HS defconfig Andrew F. Davis
  2018-03-22 20:44 ` [U-Boot] [PATCH 2/3] configs: k2e_hs_evm: " Andrew F. Davis
@ 2018-03-22 20:44 ` Andrew F. Davis
  2018-03-25  4:01   ` Lokesh Vutla
  2018-04-07 13:25   ` [U-Boot] [U-Boot, " Tom Rini
  2018-04-07 13:25 ` [U-Boot] [U-Boot, 1/3] configs: k2g_hs_evm: " Tom Rini
  2 siblings, 2 replies; 9+ messages in thread
From: Andrew F. Davis @ 2018-03-22 20:44 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 configs/k2hk_hs_evm_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configs/k2hk_hs_evm_defconfig b/configs/k2hk_hs_evm_defconfig
index 09ac21e8f3..1cca0caef8 100644
--- a/configs/k2hk_hs_evm_defconfig
+++ b/configs/k2hk_hs_evm_defconfig
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set
@@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig
  2018-03-22 20:44 ` [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: " Andrew F. Davis
@ 2018-03-25  4:01   ` Lokesh Vutla
  2018-03-26 14:54     ` Andrew F. Davis
  2018-04-07 13:25   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 1 reply; 9+ messages in thread
From: Lokesh Vutla @ 2018-03-25  4:01 UTC (permalink / raw)
  To: u-boot



On Friday 23 March 2018 02:14 AM, Andrew F. Davis wrote:
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  configs/k2hk_hs_evm_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/configs/k2hk_hs_evm_defconfig b/configs/k2hk_hs_evm_defconfig
> index 09ac21e8f3..1cca0caef8 100644
> --- a/configs/k2hk_hs_evm_defconfig
> +++ b/configs/k2hk_hs_evm_defconfig
> @@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
>  # CONFIG_USE_BOOTCOMMAND is not set
>  CONFIG_SYS_CONSOLE_INFO_QUIET=y
>  CONFIG_VERSION_VARIABLE=y
> +CONFIG_BOARD_EARLY_INIT_F=y
>  # CONFIG_CMD_FLASH is not set
>  # CONFIG_CMD_GPIO is not set
>  # CONFIG_CMD_GPT is not set
> @@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
>  CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
>  CONFIG_CMD_UBI=y
>  CONFIG_OF_CONTROL=y
> +CONFIG_DTB_RESELECT=y
> +CONFIG_MULTI_DTB_FIT=y

I understand you just synced with gp defconfig, but wondering why we
require DTB_RESELECT for k2hk? If not required we should probably
disable it in gp as well.

Thanks and regards,
Lokesh

>  CONFIG_ENV_IS_IN_NAND=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_DM=y
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig
  2018-03-25  4:01   ` Lokesh Vutla
@ 2018-03-26 14:54     ` Andrew F. Davis
  2018-03-27  5:33       ` Lokesh Vutla
  0 siblings, 1 reply; 9+ messages in thread
From: Andrew F. Davis @ 2018-03-26 14:54 UTC (permalink / raw)
  To: u-boot

On 03/24/2018 11:01 PM, Lokesh Vutla wrote:
> 
> 
> On Friday 23 March 2018 02:14 AM, Andrew F. Davis wrote:
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>>  configs/k2hk_hs_evm_defconfig | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/configs/k2hk_hs_evm_defconfig b/configs/k2hk_hs_evm_defconfig
>> index 09ac21e8f3..1cca0caef8 100644
>> --- a/configs/k2hk_hs_evm_defconfig
>> +++ b/configs/k2hk_hs_evm_defconfig
>> @@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
>>  # CONFIG_USE_BOOTCOMMAND is not set
>>  CONFIG_SYS_CONSOLE_INFO_QUIET=y
>>  CONFIG_VERSION_VARIABLE=y
>> +CONFIG_BOARD_EARLY_INIT_F=y
>>  # CONFIG_CMD_FLASH is not set
>>  # CONFIG_CMD_GPIO is not set
>>  # CONFIG_CMD_GPT is not set
>> @@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
>>  CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
>>  CONFIG_CMD_UBI=y
>>  CONFIG_OF_CONTROL=y
>> +CONFIG_DTB_RESELECT=y
>> +CONFIG_MULTI_DTB_FIT=y
> 
> I understand you just synced with gp defconfig, but wondering why we
> require DTB_RESELECT for k2hk? If not required we should probably
> disable it in gp as well.
> 


I'm not sure if it is needed either, but I'm not sure which one of these
fixed the boot issue, so as you noticed I just did a full sync and the
board started booting again.

If that config is removed for GP it should be removed for HS, I'll check
for any further breaks later, but so far what works for GP works for HS.

If I didn't have plans for merging the GP and HS configs at some point I
would say defconfig fragments for U-Boot would be something to look into..

Thanks,
Andrew


> Thanks and regards,
> Lokesh
> 
>>  CONFIG_ENV_IS_IN_NAND=y
>>  CONFIG_NET_RANDOM_ETHADDR=y
>>  CONFIG_DM=y
>>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig
  2018-03-26 14:54     ` Andrew F. Davis
@ 2018-03-27  5:33       ` Lokesh Vutla
  0 siblings, 0 replies; 9+ messages in thread
From: Lokesh Vutla @ 2018-03-27  5:33 UTC (permalink / raw)
  To: u-boot



On Monday 26 March 2018 08:24 PM, Andrew F. Davis wrote:
> On 03/24/2018 11:01 PM, Lokesh Vutla wrote:
>>
>>
>> On Friday 23 March 2018 02:14 AM, Andrew F. Davis wrote:
>>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>>> ---
>>>  configs/k2hk_hs_evm_defconfig | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/configs/k2hk_hs_evm_defconfig b/configs/k2hk_hs_evm_defconfig
>>> index 09ac21e8f3..1cca0caef8 100644
>>> --- a/configs/k2hk_hs_evm_defconfig
>>> +++ b/configs/k2hk_hs_evm_defconfig
>>> @@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
>>>  # CONFIG_USE_BOOTCOMMAND is not set
>>>  CONFIG_SYS_CONSOLE_INFO_QUIET=y
>>>  CONFIG_VERSION_VARIABLE=y
>>> +CONFIG_BOARD_EARLY_INIT_F=y
>>>  # CONFIG_CMD_FLASH is not set
>>>  # CONFIG_CMD_GPIO is not set
>>>  # CONFIG_CMD_GPT is not set
>>> @@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
>>>  CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
>>>  CONFIG_CMD_UBI=y
>>>  CONFIG_OF_CONTROL=y
>>> +CONFIG_DTB_RESELECT=y
>>> +CONFIG_MULTI_DTB_FIT=y
>>
>> I understand you just synced with gp defconfig, but wondering why we
>> require DTB_RESELECT for k2hk? If not required we should probably
>> disable it in gp as well.
>>
> 
> 
> I'm not sure if it is needed either, but I'm not sure which one of these
> fixed the boot issue, so as you noticed I just did a full sync and the
> board started booting again.

commit 3107696784d59 ("defconfig: keystone2: Enable U-boot runtime DTB
detection") enabled these configs. Looks like it is enforced to use
RESELECT on all K2 platforms.


For the entire series:
Reviewed-by: Lokesh vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh


> 
> If that config is removed for GP it should be removed for HS, I'll check
> for any further breaks later, but so far what works for GP works for HS.
> 
> If I didn't have plans for merging the GP and HS configs at some point I
> would say defconfig fragments for U-Boot would be something to look into..
> 
> Thanks,
> Andrew
> 
> 
>> Thanks and regards,
>> Lokesh
>>
>>>  CONFIG_ENV_IS_IN_NAND=y
>>>  CONFIG_NET_RANDOM_ETHADDR=y
>>>  CONFIG_DM=y
>>>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [U-Boot, 1/3] configs: k2g_hs_evm: Resync defconfig with non-HS defconfig
  2018-03-22 20:44 [U-Boot] [PATCH 1/3] configs: k2g_hs_evm: Resync defconfig with non-HS defconfig Andrew F. Davis
  2018-03-22 20:44 ` [U-Boot] [PATCH 2/3] configs: k2e_hs_evm: " Andrew F. Davis
  2018-03-22 20:44 ` [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: " Andrew F. Davis
@ 2018-04-07 13:25 ` Tom Rini
  2 siblings, 0 replies; 9+ messages in thread
From: Tom Rini @ 2018-04-07 13:25 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 22, 2018 at 03:44:38PM -0500, Andrew F. Davis wrote:

> Signed-off-by: Andrew F. Davis <afd@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180407/7cf3e8ac/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [U-Boot, 2/3] configs: k2e_hs_evm: Resync defconfig with non-HS defconfig
  2018-03-22 20:44 ` [U-Boot] [PATCH 2/3] configs: k2e_hs_evm: " Andrew F. Davis
@ 2018-04-07 13:25   ` Tom Rini
  0 siblings, 0 replies; 9+ messages in thread
From: Tom Rini @ 2018-04-07 13:25 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 22, 2018 at 03:44:39PM -0500, Andrew F. Davis wrote:

> Signed-off-by: Andrew F. Davis <afd@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180407/cf7d0ab2/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [U-Boot, 3/3] configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig
  2018-03-22 20:44 ` [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: " Andrew F. Davis
  2018-03-25  4:01   ` Lokesh Vutla
@ 2018-04-07 13:25   ` Tom Rini
  1 sibling, 0 replies; 9+ messages in thread
From: Tom Rini @ 2018-04-07 13:25 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 22, 2018 at 03:44:40PM -0500, Andrew F. Davis wrote:

> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Reviewed-by: Lokesh vutla <lokeshvutla@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180407/79026f80/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-04-07 13:25 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-22 20:44 [U-Boot] [PATCH 1/3] configs: k2g_hs_evm: Resync defconfig with non-HS defconfig Andrew F. Davis
2018-03-22 20:44 ` [U-Boot] [PATCH 2/3] configs: k2e_hs_evm: " Andrew F. Davis
2018-04-07 13:25   ` [U-Boot] [U-Boot, " Tom Rini
2018-03-22 20:44 ` [U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: " Andrew F. Davis
2018-03-25  4:01   ` Lokesh Vutla
2018-03-26 14:54     ` Andrew F. Davis
2018-03-27  5:33       ` Lokesh Vutla
2018-04-07 13:25   ` [U-Boot] [U-Boot, " Tom Rini
2018-04-07 13:25 ` [U-Boot] [U-Boot, 1/3] configs: k2g_hs_evm: " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.