Re: [PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver

From: Jason Wang <jasowang@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>,
	mst@redhat.com, qemu-devel@nongnu.org
Cc: joao.m.martins@oracle.com, boris.ostrovsky@oracle.com,
	qemu-stable@nongnu.org
Subject: Re: [PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver
Date: Thu, 15 Oct 2020 15:24:29 +0800	[thread overview]
Message-ID: <a0326690-31c1-60b3-b31e-99b1e6571c52@redhat.com> (raw)
In-Reply-To: <1601582985-14944-1-git-send-email-si-wei.liu@oracle.com>

On 2020/10/2 上午4:09, Si-Wei Liu wrote:
> Vendor driver may not support or implement config
> interrupt delivery for link status notifications.
> In this event, vendor driver is expected to NACK
> the feature, but guest will keep link always up.
>
> Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
>   net/vhost-vdpa.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index bc0e0d2..55e01d9 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -55,6 +55,7 @@ const int vdpa_feature_bits[] = {
>       VIRTIO_F_IOMMU_PLATFORM,
>       VIRTIO_F_RING_PACKED,
>       VIRTIO_NET_F_GUEST_ANNOUNCE,
> +    VIRTIO_NET_F_STATUS,
>       VHOST_INVALID_FEATURE_BIT
>   };
>   

Acked-by: Jason Wang <jasowang@redhat.com>

Michael, do you want to pick this patch or I will do that?

Thanks