* [PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver
@ 2020-10-01 20:09 Si-Wei Liu
2020-10-15 7:24 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Si-Wei Liu @ 2020-10-01 20:09 UTC (permalink / raw)
To: mst, jasowang, qemu-devel; +Cc: joao.m.martins, boris.ostrovsky, qemu-stable
Vendor driver may not support or implement config
interrupt delivery for link status notifications.
In this event, vendor driver is expected to NACK
the feature, but guest will keep link always up.
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
---
net/vhost-vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index bc0e0d2..55e01d9 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -55,6 +55,7 @@ const int vdpa_feature_bits[] = {
VIRTIO_F_IOMMU_PLATFORM,
VIRTIO_F_RING_PACKED,
VIRTIO_NET_F_GUEST_ANNOUNCE,
+ VIRTIO_NET_F_STATUS,
VHOST_INVALID_FEATURE_BIT
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver
2020-10-01 20:09 [PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver Si-Wei Liu
@ 2020-10-15 7:24 ` Jason Wang
2020-10-15 13:11 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Jason Wang @ 2020-10-15 7:24 UTC (permalink / raw)
To: Si-Wei Liu, mst, qemu-devel; +Cc: joao.m.martins, boris.ostrovsky, qemu-stable
On 2020/10/2 上午4:09, Si-Wei Liu wrote:
> Vendor driver may not support or implement config
> interrupt delivery for link status notifications.
> In this event, vendor driver is expected to NACK
> the feature, but guest will keep link always up.
>
> Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
> net/vhost-vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index bc0e0d2..55e01d9 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -55,6 +55,7 @@ const int vdpa_feature_bits[] = {
> VIRTIO_F_IOMMU_PLATFORM,
> VIRTIO_F_RING_PACKED,
> VIRTIO_NET_F_GUEST_ANNOUNCE,
> + VIRTIO_NET_F_STATUS,
> VHOST_INVALID_FEATURE_BIT
> };
>
Acked-by: Jason Wang <jasowang@redhat.com>
Michael, do you want to pick this patch or I will do that?
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver
2020-10-15 7:24 ` Jason Wang
@ 2020-10-15 13:11 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-10-15 13:11 UTC (permalink / raw)
To: Jason Wang
Cc: Si-Wei Liu, joao.m.martins, qemu-devel, boris.ostrovsky, qemu-stable
On Thu, Oct 15, 2020 at 03:24:29PM +0800, Jason Wang wrote:
>
> On 2020/10/2 上午4:09, Si-Wei Liu wrote:
> > Vendor driver may not support or implement config
> > interrupt delivery for link status notifications.
> > In this event, vendor driver is expected to NACK
> > the feature, but guest will keep link always up.
> >
> > Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
> > ---
> > net/vhost-vdpa.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> > index bc0e0d2..55e01d9 100644
> > --- a/net/vhost-vdpa.c
> > +++ b/net/vhost-vdpa.c
> > @@ -55,6 +55,7 @@ const int vdpa_feature_bits[] = {
> > VIRTIO_F_IOMMU_PLATFORM,
> > VIRTIO_F_RING_PACKED,
> > VIRTIO_NET_F_GUEST_ANNOUNCE,
> > + VIRTIO_NET_F_STATUS,
> > VHOST_INVALID_FEATURE_BIT
> > };
>
>
> Acked-by: Jason Wang <jasowang@redhat.com>
>
> Michael, do you want to pick this patch or I will do that?
>
> Thanks
Tagged, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-15 13:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 20:09 [PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver Si-Wei Liu
2020-10-15 7:24 ` Jason Wang
2020-10-15 13:11 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.