* [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
@ 2022-12-07 15:13 ` Alexander Stein
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-07 15:13 UTC (permalink / raw)
To: Marek Vasut, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski
Cc: Alexander Stein, dri-devel, devicetree
i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names.
Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 876015a44a1e6..793e8eccf8b8b 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -70,7 +70,9 @@ allOf:
properties:
compatible:
contains:
- const: fsl,imx6sx-lcdif
+ enum:
+ - fsl,imx6sx-lcdif
+ - fsl,imx8mp-lcdif
then:
properties:
clocks:
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
@ 2022-12-07 15:13 ` Alexander Stein
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-07 15:13 UTC (permalink / raw)
To: Marek Vasut, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski
Cc: Alexander Stein, devicetree, dri-devel
i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names.
Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 876015a44a1e6..793e8eccf8b8b 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -70,7 +70,9 @@ allOf:
properties:
compatible:
contains:
- const: fsl,imx6sx-lcdif
+ enum:
+ - fsl,imx6sx-lcdif
+ - fsl,imx8mp-lcdif
then:
properties:
clocks:
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
2022-12-07 15:13 ` Alexander Stein
@ 2022-12-07 15:14 ` Alexander Stein
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-07 15:14 UTC (permalink / raw)
To: Marek Vasut, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski
Cc: Alexander Stein, dri-devel, devicetree
i.MX8MP requires a power-domain for this peripheral to use. Add it as
an optional property.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 793e8eccf8b8b..9d9fb5ad587c2 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -52,6 +52,9 @@ properties:
interrupts:
maxItems: 1
+ power-domains:
+ maxItems: 1
+
port:
$ref: /schemas/graph.yaml#/properties/port
description: The LCDIF output port
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
@ 2022-12-07 15:14 ` Alexander Stein
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-07 15:14 UTC (permalink / raw)
To: Marek Vasut, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski
Cc: Alexander Stein, devicetree, dri-devel
i.MX8MP requires a power-domain for this peripheral to use. Add it as
an optional property.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 793e8eccf8b8b..9d9fb5ad587c2 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -52,6 +52,9 @@ properties:
interrupts:
maxItems: 1
+ power-domains:
+ maxItems: 1
+
port:
$ref: /schemas/graph.yaml#/properties/port
description: The LCDIF output port
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
2022-12-07 15:13 ` Alexander Stein
@ 2022-12-07 15:59 ` Marek Vasut
-1 siblings, 0 replies; 24+ messages in thread
From: Marek Vasut @ 2022-12-07 15:59 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski
Cc: dri-devel, devicetree
On 12/7/22 16:13, Alexander Stein wrote:
> i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names.
>
> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 876015a44a1e6..793e8eccf8b8b 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -70,7 +70,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: fsl,imx6sx-lcdif
> + enum:
> + - fsl,imx6sx-lcdif
> + - fsl,imx8mp-lcdif
> then:
> properties:
> clocks:
Reviewed-by: Marek Vasut <marex@denx.de>
btw you might want to update the clock-names and clock proerty order in
imx8mp.dtsi to match the clock-names order in these bindings.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
@ 2022-12-07 15:59 ` Marek Vasut
0 siblings, 0 replies; 24+ messages in thread
From: Marek Vasut @ 2022-12-07 15:59 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski
Cc: devicetree, dri-devel
On 12/7/22 16:13, Alexander Stein wrote:
> i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names.
>
> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 876015a44a1e6..793e8eccf8b8b 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -70,7 +70,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: fsl,imx6sx-lcdif
> + enum:
> + - fsl,imx6sx-lcdif
> + - fsl,imx8mp-lcdif
> then:
> properties:
> clocks:
Reviewed-by: Marek Vasut <marex@denx.de>
btw you might want to update the clock-names and clock proerty order in
imx8mp.dtsi to match the clock-names order in these bindings.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
2022-12-07 15:14 ` Alexander Stein
@ 2022-12-07 16:00 ` Marek Vasut
-1 siblings, 0 replies; 24+ messages in thread
From: Marek Vasut @ 2022-12-07 16:00 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski
Cc: dri-devel, devicetree
On 12/7/22 16:14, Alexander Stein wrote:
> i.MX8MP requires a power-domain for this peripheral to use. Add it as
> an optional property.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 793e8eccf8b8b..9d9fb5ad587c2 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -52,6 +52,9 @@ properties:
> interrupts:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
> port:
> $ref: /schemas/graph.yaml#/properties/port
> description: The LCDIF output port
Should this be required on mx8mp then ?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
@ 2022-12-07 16:00 ` Marek Vasut
0 siblings, 0 replies; 24+ messages in thread
From: Marek Vasut @ 2022-12-07 16:00 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski
Cc: devicetree, dri-devel
On 12/7/22 16:14, Alexander Stein wrote:
> i.MX8MP requires a power-domain for this peripheral to use. Add it as
> an optional property.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 793e8eccf8b8b..9d9fb5ad587c2 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -52,6 +52,9 @@ properties:
> interrupts:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
> port:
> $ref: /schemas/graph.yaml#/properties/port
> description: The LCDIF output port
Should this be required on mx8mp then ?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
2022-12-07 15:13 ` Alexander Stein
@ 2022-12-07 17:44 ` Rob Herring
-1 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-12-07 17:44 UTC (permalink / raw)
To: Alexander Stein
Cc: Daniel Vetter, David Airlie, dri-devel, Krzysztof Kozlowski,
devicetree, Rob Herring, Marek Vasut
On Wed, 07 Dec 2022 16:13:59 +0100, Alexander Stein wrote:
> i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names.
>
> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
@ 2022-12-07 17:44 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-12-07 17:44 UTC (permalink / raw)
To: Alexander Stein
Cc: Marek Vasut, devicetree, dri-devel, Rob Herring, Krzysztof Kozlowski
On Wed, 07 Dec 2022 16:13:59 +0100, Alexander Stein wrote:
> i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names.
>
> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
2022-12-07 15:14 ` Alexander Stein
@ 2022-12-07 17:44 ` Rob Herring
-1 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-12-07 17:44 UTC (permalink / raw)
To: Alexander Stein
Cc: Krzysztof Kozlowski, Rob Herring, Daniel Vetter, David Airlie,
dri-devel, devicetree, Marek Vasut
On Wed, 07 Dec 2022 16:14:00 +0100, Alexander Stein wrote:
> i.MX8MP requires a power-domain for this peripheral to use. Add it as
> an optional property.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
@ 2022-12-07 17:44 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-12-07 17:44 UTC (permalink / raw)
To: Alexander Stein
Cc: Marek Vasut, devicetree, Krzysztof Kozlowski, dri-devel, Rob Herring
On Wed, 07 Dec 2022 16:14:00 +0100, Alexander Stein wrote:
> i.MX8MP requires a power-domain for this peripheral to use. Add it as
> an optional property.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
2022-12-07 16:00 ` Marek Vasut
@ 2022-12-08 5:59 ` Alexander Stein
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-08 5:59 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Marek Vasut
Cc: dri-devel, devicetree
Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
> On 12/7/22 16:14, Alexander Stein wrote:
> > i.MX8MP requires a power-domain for this peripheral to use. Add it as
> > an optional property.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >
> > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
> > 793e8eccf8b8b..9d9fb5ad587c2 100644
> > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >
> > @@ -52,6 +52,9 @@ properties:
> > interrupts:
> > maxItems: 1
> >
> > + power-domains:
> > + maxItems: 1
> > +
> >
> > port:
> > $ref: /schemas/graph.yaml#/properties/port
> > description: The LCDIF output port
>
> Should this be required on mx8mp then ?
I'm hesitating to add a required property later on. But I'm okay with both.
Rob, Krzysztof: Any preference here? Shall power-domains be made required for
fsl,imx8mp-lcdif only?
Best regards,
Alexander
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
@ 2022-12-08 5:59 ` Alexander Stein
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-08 5:59 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Marek Vasut
Cc: devicetree, dri-devel
Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
> On 12/7/22 16:14, Alexander Stein wrote:
> > i.MX8MP requires a power-domain for this peripheral to use. Add it as
> > an optional property.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >
> > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
> > 793e8eccf8b8b..9d9fb5ad587c2 100644
> > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >
> > @@ -52,6 +52,9 @@ properties:
> > interrupts:
> > maxItems: 1
> >
> > + power-domains:
> > + maxItems: 1
> > +
> >
> > port:
> > $ref: /schemas/graph.yaml#/properties/port
> > description: The LCDIF output port
>
> Should this be required on mx8mp then ?
I'm hesitating to add a required property later on. But I'm okay with both.
Rob, Krzysztof: Any preference here? Shall power-domains be made required for
fsl,imx8mp-lcdif only?
Best regards,
Alexander
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
2022-12-07 15:59 ` Marek Vasut
@ 2022-12-08 6:31 ` Alexander Stein
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-08 6:31 UTC (permalink / raw)
To: Marek Vasut; +Cc: devicetree, dri-devel, Rob Herring, Krzysztof Kozlowski
Hello Marek,
Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut:
> On 12/7/22 16:13, Alexander Stein wrote:
> > i.MX8MP uses 3 clocks, so soften the restrictions for clocks &
> > clock-names.
> >
> > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >
> > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
> > 876015a44a1e6..793e8eccf8b8b 100644
> > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >
> > @@ -70,7 +70,9 @@ allOf:
> > properties:
> > compatible:
> > contains:
> > - const: fsl,imx6sx-lcdif
> > + enum:
> > + - fsl,imx6sx-lcdif
> > + - fsl,imx8mp-lcdif
> >
> > then:
> > properties:
> > clocks:
> Reviewed-by: Marek Vasut <marex@denx.de>
Thanks!
> btw you might want to update the clock-names and clock proerty order in
> imx8mp.dtsi to match the clock-names order in these bindings.
The lcdif nodes are not yet in linux-next ;-) So its probably a local commit
on your side. But yes, the upcoming patches will address this.
Best regards,
Alexander
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
@ 2022-12-08 6:31 ` Alexander Stein
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-08 6:31 UTC (permalink / raw)
To: Marek Vasut
Cc: David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
dri-devel, devicetree
Hello Marek,
Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut:
> On 12/7/22 16:13, Alexander Stein wrote:
> > i.MX8MP uses 3 clocks, so soften the restrictions for clocks &
> > clock-names.
> >
> > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >
> > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
> > 876015a44a1e6..793e8eccf8b8b 100644
> > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >
> > @@ -70,7 +70,9 @@ allOf:
> > properties:
> > compatible:
> > contains:
> > - const: fsl,imx6sx-lcdif
> > + enum:
> > + - fsl,imx6sx-lcdif
> > + - fsl,imx8mp-lcdif
> >
> > then:
> > properties:
> > clocks:
> Reviewed-by: Marek Vasut <marex@denx.de>
Thanks!
> btw you might want to update the clock-names and clock proerty order in
> imx8mp.dtsi to match the clock-names order in these bindings.
The lcdif nodes are not yet in linux-next ;-) So its probably a local commit
on your side. But yes, the upcoming patches will address this.
Best regards,
Alexander
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
2022-12-08 5:59 ` Alexander Stein
@ 2022-12-08 8:25 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:25 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Marek Vasut
Cc: dri-devel, devicetree
On 08/12/2022 06:59, Alexander Stein wrote:
> Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
>> On 12/7/22 16:14, Alexander Stein wrote:
>>> i.MX8MP requires a power-domain for this peripheral to use. Add it as
>>> an optional property.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>>
>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
>>> 793e8eccf8b8b..9d9fb5ad587c2 100644
>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>
>>> @@ -52,6 +52,9 @@ properties:
>>> interrupts:
>>> maxItems: 1
>>>
>>> + power-domains:
>>> + maxItems: 1
>>> +
>>>
>>> port:
>>> $ref: /schemas/graph.yaml#/properties/port
>>> description: The LCDIF output port
>>
>> Should this be required on mx8mp then ?
>
> I'm hesitating to add a required property later on. But I'm okay with both.
> Rob, Krzysztof: Any preference here? Shall power-domains be made required for
> fsl,imx8mp-lcdif only?
I don't know. That's not the question to us, but to someone who knows
the hardware/datasheet.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
@ 2022-12-08 8:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:25 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Marek Vasut
Cc: devicetree, dri-devel
On 08/12/2022 06:59, Alexander Stein wrote:
> Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
>> On 12/7/22 16:14, Alexander Stein wrote:
>>> i.MX8MP requires a power-domain for this peripheral to use. Add it as
>>> an optional property.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>>
>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
>>> 793e8eccf8b8b..9d9fb5ad587c2 100644
>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>
>>> @@ -52,6 +52,9 @@ properties:
>>> interrupts:
>>> maxItems: 1
>>>
>>> + power-domains:
>>> + maxItems: 1
>>> +
>>>
>>> port:
>>> $ref: /schemas/graph.yaml#/properties/port
>>> description: The LCDIF output port
>>
>> Should this be required on mx8mp then ?
>
> I'm hesitating to add a required property later on. But I'm okay with both.
> Rob, Krzysztof: Any preference here? Shall power-domains be made required for
> fsl,imx8mp-lcdif only?
I don't know. That's not the question to us, but to someone who knows
the hardware/datasheet.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
2022-12-08 8:25 ` Krzysztof Kozlowski
@ 2022-12-08 8:50 ` Alexander Stein
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-08 8:50 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Marek Vasut, Krzysztof Kozlowski
Cc: dri-devel, devicetree
Hello Krzysztof,
Am Donnerstag, 8. Dezember 2022, 09:25:31 CET schrieb Krzysztof Kozlowski:
> On 08/12/2022 06:59, Alexander Stein wrote:
> > Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
> >> On 12/7/22 16:14, Alexander Stein wrote:
> >>> i.MX8MP requires a power-domain for this peripheral to use. Add it as
> >>> an optional property.
> >>>
> >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >>> ---
> >>>
> >>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
> >>> 1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
> >>> 793e8eccf8b8b..9d9fb5ad587c2 100644
> >>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >>>
> >>> @@ -52,6 +52,9 @@ properties:
> >>> interrupts:
> >>> maxItems: 1
> >>>
> >>> + power-domains:
> >>> + maxItems: 1
> >>> +
> >>>
> >>> port:
> >>> $ref: /schemas/graph.yaml#/properties/port
> >>> description: The LCDIF output port
> >>
> >> Should this be required on mx8mp then ?
> >
> > I'm hesitating to add a required property later on. But I'm okay with
> > both.
> > Rob, Krzysztof: Any preference here? Shall power-domains be made required
> > for fsl,imx8mp-lcdif only?
>
> I don't know. That's not the question to us, but to someone who knows
> the hardware/datasheet.
I was not talking about the hardware, which needs the power-domain, but the DT
schema. Sorry to be not specific about this.
Is it okay to add a required property for a compatible later on?
Best regards,
Alexander
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
@ 2022-12-08 8:50 ` Alexander Stein
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Stein @ 2022-12-08 8:50 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Marek Vasut, Krzysztof Kozlowski
Cc: devicetree, dri-devel
Hello Krzysztof,
Am Donnerstag, 8. Dezember 2022, 09:25:31 CET schrieb Krzysztof Kozlowski:
> On 08/12/2022 06:59, Alexander Stein wrote:
> > Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
> >> On 12/7/22 16:14, Alexander Stein wrote:
> >>> i.MX8MP requires a power-domain for this peripheral to use. Add it as
> >>> an optional property.
> >>>
> >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >>> ---
> >>>
> >>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
> >>> 1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
> >>> 793e8eccf8b8b..9d9fb5ad587c2 100644
> >>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> >>>
> >>> @@ -52,6 +52,9 @@ properties:
> >>> interrupts:
> >>> maxItems: 1
> >>>
> >>> + power-domains:
> >>> + maxItems: 1
> >>> +
> >>>
> >>> port:
> >>> $ref: /schemas/graph.yaml#/properties/port
> >>> description: The LCDIF output port
> >>
> >> Should this be required on mx8mp then ?
> >
> > I'm hesitating to add a required property later on. But I'm okay with
> > both.
> > Rob, Krzysztof: Any preference here? Shall power-domains be made required
> > for fsl,imx8mp-lcdif only?
>
> I don't know. That's not the question to us, but to someone who knows
> the hardware/datasheet.
I was not talking about the hardware, which needs the power-domain, but the DT
schema. Sorry to be not specific about this.
Is it okay to add a required property for a compatible later on?
Best regards,
Alexander
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
2022-12-08 8:50 ` Alexander Stein
@ 2022-12-08 8:57 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:57 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Marek Vasut
Cc: dri-devel, devicetree
On 08/12/2022 09:50, Alexander Stein wrote:
> Hello Krzysztof,
>
> Am Donnerstag, 8. Dezember 2022, 09:25:31 CET schrieb Krzysztof Kozlowski:
>> On 08/12/2022 06:59, Alexander Stein wrote:
>>> Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
>>>> On 12/7/22 16:14, Alexander Stein wrote:
>>>>> i.MX8MP requires a power-domain for this peripheral to use. Add it as
>>>>> an optional property.
>>>>>
>>>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>>>> ---
>>>>>
>>>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
>>>>> 1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
>>>>> 793e8eccf8b8b..9d9fb5ad587c2 100644
>>>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>>>
>>>>> @@ -52,6 +52,9 @@ properties:
>>>>> interrupts:
>>>>> maxItems: 1
>>>>>
>>>>> + power-domains:
>>>>> + maxItems: 1
>>>>> +
>>>>>
>>>>> port:
>>>>> $ref: /schemas/graph.yaml#/properties/port
>>>>> description: The LCDIF output port
>>>>
>>>> Should this be required on mx8mp then ?
>>>
>>> I'm hesitating to add a required property later on. But I'm okay with
>>> both.
>>> Rob, Krzysztof: Any preference here? Shall power-domains be made required
>>> for fsl,imx8mp-lcdif only?
>>
>> I don't know. That's not the question to us, but to someone who knows
>> the hardware/datasheet.
>
> I was not talking about the hardware, which needs the power-domain, but the DT
> schema. Sorry to be not specific about this.
> Is it okay to add a required property for a compatible later on?
Yes, it is okay, assuming:
1. Linux implementation still works without it thus preserving ABI.
2. It is really required, e.g. device cannot operate without it (your
commit msg suggests that).
3. The property should be required since beginning, but we did not add
it due to mistake/forgot/lack of docs etc.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
@ 2022-12-08 8:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:57 UTC (permalink / raw)
To: Alexander Stein, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Marek Vasut
Cc: devicetree, dri-devel
On 08/12/2022 09:50, Alexander Stein wrote:
> Hello Krzysztof,
>
> Am Donnerstag, 8. Dezember 2022, 09:25:31 CET schrieb Krzysztof Kozlowski:
>> On 08/12/2022 06:59, Alexander Stein wrote:
>>> Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
>>>> On 12/7/22 16:14, Alexander Stein wrote:
>>>>> i.MX8MP requires a power-domain for this peripheral to use. Add it as
>>>>> an optional property.
>>>>>
>>>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>>>> ---
>>>>>
>>>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
>>>>> 1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
>>>>> 793e8eccf8b8b..9d9fb5ad587c2 100644
>>>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>>>
>>>>> @@ -52,6 +52,9 @@ properties:
>>>>> interrupts:
>>>>> maxItems: 1
>>>>>
>>>>> + power-domains:
>>>>> + maxItems: 1
>>>>> +
>>>>>
>>>>> port:
>>>>> $ref: /schemas/graph.yaml#/properties/port
>>>>> description: The LCDIF output port
>>>>
>>>> Should this be required on mx8mp then ?
>>>
>>> I'm hesitating to add a required property later on. But I'm okay with
>>> both.
>>> Rob, Krzysztof: Any preference here? Shall power-domains be made required
>>> for fsl,imx8mp-lcdif only?
>>
>> I don't know. That's not the question to us, but to someone who knows
>> the hardware/datasheet.
>
> I was not talking about the hardware, which needs the power-domain, but the DT
> schema. Sorry to be not specific about this.
> Is it okay to add a required property for a compatible later on?
Yes, it is okay, assuming:
1. Linux implementation still works without it thus preserving ABI.
2. It is really required, e.g. device cannot operate without it (your
commit msg suggests that).
3. The property should be required since beginning, but we did not add
it due to mistake/forgot/lack of docs etc.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
2022-12-08 6:31 ` Alexander Stein
@ 2022-12-08 13:25 ` Marek Vasut
-1 siblings, 0 replies; 24+ messages in thread
From: Marek Vasut @ 2022-12-08 13:25 UTC (permalink / raw)
To: Alexander Stein
Cc: David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
dri-devel, devicetree
On 12/8/22 07:31, Alexander Stein wrote:
> Hello Marek,
>
> Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut:
>> On 12/7/22 16:13, Alexander Stein wrote:
>>> i.MX8MP uses 3 clocks, so soften the restrictions for clocks &
>>> clock-names.
>>>
>>> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>>
>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
>>> 876015a44a1e6..793e8eccf8b8b 100644
>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>
>>> @@ -70,7 +70,9 @@ allOf:
>>> properties:
>>> compatible:
>>> contains:
>>> - const: fsl,imx6sx-lcdif
>>> + enum:
>>> + - fsl,imx6sx-lcdif
>>> + - fsl,imx8mp-lcdif
>>>
>>> then:
>>> properties:
>>> clocks:
>> Reviewed-by: Marek Vasut <marex@denx.de>
>
> Thanks!
>
>> btw you might want to update the clock-names and clock proerty order in
>> imx8mp.dtsi to match the clock-names order in these bindings.
>
> The lcdif nodes are not yet in linux-next ;-) So its probably a local commit
> on your side. But yes, the upcoming patches will address this.
Ah, right, seems they are still pending HDMI and DSIM addition. Sorry
for the noise.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
@ 2022-12-08 13:25 ` Marek Vasut
0 siblings, 0 replies; 24+ messages in thread
From: Marek Vasut @ 2022-12-08 13:25 UTC (permalink / raw)
To: Alexander Stein; +Cc: devicetree, dri-devel, Rob Herring, Krzysztof Kozlowski
On 12/8/22 07:31, Alexander Stein wrote:
> Hello Marek,
>
> Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut:
>> On 12/7/22 16:13, Alexander Stein wrote:
>>> i.MX8MP uses 3 clocks, so soften the restrictions for clocks &
>>> clock-names.
>>>
>>> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>>
>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
>>> 876015a44a1e6..793e8eccf8b8b 100644
>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>
>>> @@ -70,7 +70,9 @@ allOf:
>>> properties:
>>> compatible:
>>> contains:
>>> - const: fsl,imx6sx-lcdif
>>> + enum:
>>> + - fsl,imx6sx-lcdif
>>> + - fsl,imx8mp-lcdif
>>>
>>> then:
>>> properties:
>>> clocks:
>> Reviewed-by: Marek Vasut <marex@denx.de>
>
> Thanks!
>
>> btw you might want to update the clock-names and clock proerty order in
>> imx8mp.dtsi to match the clock-names order in these bindings.
>
> The lcdif nodes are not yet in linux-next ;-) So its probably a local commit
> on your side. But yes, the upcoming patches will address this.
Ah, right, seems they are still pending HDMI and DSIM addition. Sorry
for the noise.
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2022-12-08 13:29 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 15:13 [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp Alexander Stein
2022-12-07 15:13 ` Alexander Stein
2022-12-07 15:14 ` [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain Alexander Stein
2022-12-07 15:14 ` Alexander Stein
2022-12-07 16:00 ` Marek Vasut
2022-12-07 16:00 ` Marek Vasut
2022-12-08 5:59 ` Alexander Stein
2022-12-08 5:59 ` Alexander Stein
2022-12-08 8:25 ` Krzysztof Kozlowski
2022-12-08 8:25 ` Krzysztof Kozlowski
2022-12-08 8:50 ` Alexander Stein
2022-12-08 8:50 ` Alexander Stein
2022-12-08 8:57 ` Krzysztof Kozlowski
2022-12-08 8:57 ` Krzysztof Kozlowski
2022-12-07 17:44 ` Rob Herring
2022-12-07 17:44 ` Rob Herring
2022-12-07 15:59 ` [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp Marek Vasut
2022-12-07 15:59 ` Marek Vasut
2022-12-08 6:31 ` Alexander Stein
2022-12-08 6:31 ` Alexander Stein
2022-12-08 13:25 ` Marek Vasut
2022-12-08 13:25 ` Marek Vasut
2022-12-07 17:44 ` Rob Herring
2022-12-07 17:44 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.