* [Nouveau] [PATCH] drm/nouveau: remove trace_dma_fence_emit
@ 2022-05-03 8:59 Christian König
2022-05-04 19:14 ` Lyude Paul
0 siblings, 1 reply; 2+ messages in thread
From: Christian König @ 2022-05-03 8:59 UTC (permalink / raw)
To: nouveau; +Cc: Christian König, Ben Skeggs
Hardware drivers which don't have much difference between emit and init
shouldn't use this trace point.
Signed-off-by: Christian König <christian.koenig@amd.com>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nouveau_fence.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c
index 7f01dcf81fab..abcac7db4347 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fence.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
@@ -224,7 +224,6 @@ nouveau_fence_emit(struct nouveau_fence *fence, struct nouveau_channel *chan)
&fctx->lock, fctx->context, ++fctx->sequence);
kref_get(&fctx->fence_ref);
- trace_dma_fence_emit(&fence->base);
ret = fctx->emit(fence);
if (!ret) {
dma_fence_get(&fence->base);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau: remove trace_dma_fence_emit
2022-05-03 8:59 [Nouveau] [PATCH] drm/nouveau: remove trace_dma_fence_emit Christian König
@ 2022-05-04 19:14 ` Lyude Paul
0 siblings, 0 replies; 2+ messages in thread
From: Lyude Paul @ 2022-05-04 19:14 UTC (permalink / raw)
To: Christian König, nouveau; +Cc: Christian König, Ben Skeggs
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push to the appropriate branch in a moment
On Tue, 2022-05-03 at 10:59 +0200, Christian König wrote:
> Hardware drivers which don't have much difference between emit and init
> shouldn't use this trace point.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nouveau_fence.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c
> b/drivers/gpu/drm/nouveau/nouveau_fence.c
> index 7f01dcf81fab..abcac7db4347 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
> @@ -224,7 +224,6 @@ nouveau_fence_emit(struct nouveau_fence *fence, struct
> nouveau_channel *chan)
> &fctx->lock, fctx->context, ++fctx-
> >sequence);
> kref_get(&fctx->fence_ref);
>
> - trace_dma_fence_emit(&fence->base);
> ret = fctx->emit(fence);
> if (!ret) {
> dma_fence_get(&fence->base);
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-04 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-03 8:59 [Nouveau] [PATCH] drm/nouveau: remove trace_dma_fence_emit Christian König
2022-05-04 19:14 ` Lyude Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.