From: Jan Beulich <jbeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH 2/2][4.15?] x86: fix build when NR_CPUS == 1
Date: Mon, 1 Mar 2021 16:14:26 +0100 [thread overview]
Message-ID: <a0664115-2b36-7a56-2814-bb234fb379cf@suse.com> (raw)
In-Reply-To: <YDzzt1CXau8vKCn1@Air-de-Roger>
On 01.03.2021 15:01, Roger Pau Monné wrote:
> On Mon, Mar 01, 2021 at 09:31:07AM +0100, Jan Beulich wrote:
>> In this case the compiler is recognizing that no valid array indexes
>> remain (in x2apic_cluster()'s access to per_cpu(cpu_2_logical_apicid,
>> ...)), but oddly enough isn't really consistent about the checking it
>> does (see the code comment).
>
> I assume this is because of the underlying per_cpu access to
> __per_cpu_offset using cpu as the index, in which case wouldn't it be
> better to place the BUG_ON there?
Not sure, to be honest. It seemed more logical to me to place it
next to where the issue is.
> Also I wonder why the accesses the same function does to the per_cpu
> area before the modified chunk using this_cpu as index don't also
> trigger such warnings.
The compiler appears to be issuing the warning when it can prove
that no legitimate index can make it to a respective use. in this
case it means that is is
if ( this_cpu == cpu )
continue;
which makes it possible for the compiler to know that what gets
past this would be an out of bounds access, since for NR_CPUS=1
both this_cpu and cpu can only validly both be zero. (This also
plays into my choice of placement, because it is not
x2apic_cluster() on its own which has this issue.)
Jan
next prev parent reply other threads:[~2021-03-01 15:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 8:27 [PATCH 0/2][4.15?] fix build when NR_CPUS == 1 Jan Beulich
2021-03-01 8:30 ` [PATCH 1/2][4.15?] sched: " Jan Beulich
2021-03-01 15:57 ` Ian Jackson
2021-03-01 17:50 ` Dario Faggioli
2021-03-01 8:31 ` [PATCH 2/2][4.15?] x86: " Jan Beulich
2021-03-01 14:01 ` Roger Pau Monné
2021-03-01 15:14 ` Jan Beulich [this message]
2021-03-01 18:00 ` Roger Pau Monné
2021-03-02 9:59 ` Jan Beulich
2021-03-02 10:57 ` Roger Pau Monné
2021-03-02 11:18 ` Jan Beulich
2021-03-01 16:03 ` Ian Jackson
2021-03-02 10:02 ` Jan Beulich
2021-03-02 12:28 ` Ian Jackson
2021-03-02 13:37 ` Jan Beulich
2021-03-01 8:33 ` [PATCH 0/2][4.15?] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0664115-2b36-7a56-2814-bb234fb379cf@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.