All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: "Colin King" <colin.king@canonical.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name
Date: Wed, 20 Jan 2021 09:46:45 -0500	[thread overview]
Message-ID: <a06aeb18-b02d-41cd-f717-6ff30ea48bb4@amd.com> (raw)
In-Reply-To: <20210120092624.13061-1-colin.king@canonical.com>

On 2021-01-20 4:26 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> There are two spelling mistakes of the function name, fix this
> by using __func__ instead of a hard coded name string.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index c16af3983fdb..91d4130cd2cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
>   
>   	link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>   
> -	DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> +	DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
>   	return true;
>   device_tag_fail:
>   	link->link_enc->funcs->destroy(&link->link_enc);
> @@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
>   		link->hpd_gpio = NULL;
>   	}
>   
> -	DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> +	DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
>   	kfree(info);
>   
>   	return false;
> 

WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <harry.wentland@amd.com>
To: "Colin King" <colin.king@canonical.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name
Date: Wed, 20 Jan 2021 14:46:45 +0000	[thread overview]
Message-ID: <a06aeb18-b02d-41cd-f717-6ff30ea48bb4@amd.com> (raw)
In-Reply-To: <20210120092624.13061-1-colin.king@canonical.com>

On 2021-01-20 4:26 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> There are two spelling mistakes of the function name, fix this
> by using __func__ instead of a hard coded name string.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index c16af3983fdb..91d4130cd2cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
>   
>   	link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>   
> -	DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> +	DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
>   	return true;
>   device_tag_fail:
>   	link->link_enc->funcs->destroy(&link->link_enc);
> @@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
>   		link->hpd_gpio = NULL;
>   	}
>   
> -	DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> +	DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
>   	kfree(info);
>   
>   	return false;
> 

WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <harry.wentland@amd.com>
To: "Colin King" <colin.king@canonical.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name
Date: Wed, 20 Jan 2021 09:46:45 -0500	[thread overview]
Message-ID: <a06aeb18-b02d-41cd-f717-6ff30ea48bb4@amd.com> (raw)
In-Reply-To: <20210120092624.13061-1-colin.king@canonical.com>

On 2021-01-20 4:26 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> There are two spelling mistakes of the function name, fix this
> by using __func__ instead of a hard coded name string.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index c16af3983fdb..91d4130cd2cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
>   
>   	link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>   
> -	DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> +	DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
>   	return true;
>   device_tag_fail:
>   	link->link_enc->funcs->destroy(&link->link_enc);
> @@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
>   		link->hpd_gpio = NULL;
>   	}
>   
> -	DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> +	DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
>   	kfree(info);
>   
>   	return false;
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <harry.wentland@amd.com>
To: "Colin King" <colin.king@canonical.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name
Date: Wed, 20 Jan 2021 09:46:45 -0500	[thread overview]
Message-ID: <a06aeb18-b02d-41cd-f717-6ff30ea48bb4@amd.com> (raw)
In-Reply-To: <20210120092624.13061-1-colin.king@canonical.com>

On 2021-01-20 4:26 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> There are two spelling mistakes of the function name, fix this
> by using __func__ instead of a hard coded name string.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index c16af3983fdb..91d4130cd2cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
>   
>   	link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>   
> -	DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> +	DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
>   	return true;
>   device_tag_fail:
>   	link->link_enc->funcs->destroy(&link->link_enc);
> @@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
>   		link->hpd_gpio = NULL;
>   	}
>   
> -	DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> +	DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
>   	kfree(info);
>   
>   	return false;
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2021-01-20 17:29 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  9:26 [PATCH][next] drm/amd/display: Fix spelling mistake of function name Colin King
2021-01-20  9:26 ` Colin King
2021-01-20  9:26 ` Colin King
2021-01-20  9:26 ` Colin King
2021-01-20 14:46 ` Harry Wentland [this message]
2021-01-20 14:46   ` Harry Wentland
2021-01-20 14:46   ` Harry Wentland
2021-01-20 14:46   ` Harry Wentland
2021-01-20 21:58   ` Alex Deucher
2021-01-20 21:58     ` Alex Deucher
2021-01-20 21:58     ` Alex Deucher
2021-01-20 21:58     ` Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2020-08-04 17:34 [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported" Colin King
2020-08-04 17:34 ` Colin King
2020-08-04 17:34 ` Colin King
2020-08-04 17:34 ` Colin King
2020-08-04 17:39 ` NAK: " Colin Ian King
2020-08-04 17:39   ` Colin Ian King
2020-08-04 17:39   ` Colin Ian King
2020-08-04 17:39   ` Colin Ian King
2020-06-04 10:35 [PATCH][next] drm/amd/display: fix spelling mistake: "propogation" -> "propagation" Colin King
2020-06-04 10:35 ` Colin King
2020-06-04 10:35 ` Colin King
2020-06-04 10:35 ` Colin King
2020-06-04 18:55 ` Alex Deucher
2020-06-04 18:55   ` Alex Deucher
2020-06-04 18:55   ` Alex Deucher
2020-06-04 18:55   ` Alex Deucher
2019-11-09 19:49 [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution" Colin King
2019-11-09 19:49 ` Colin King
2019-11-09 19:49 ` Colin King
2019-11-09 19:49 ` Colin King
2019-11-11 13:37 ` Kazlauskas, Nicholas
2019-11-11 13:37   ` Kazlauskas, Nicholas
2019-11-11 13:37   ` Kazlauskas, Nicholas
2019-11-11 13:37   ` Kazlauskas, Nicholas
2019-11-11 17:28   ` Alex Deucher
2019-11-11 17:28     ` Alex Deucher
2019-11-11 17:28     ` Alex Deucher
2019-11-11 17:28     ` Alex Deucher
2019-11-11 17:28     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a06aeb18-b02d-41cd-f717-6ff30ea48bb4@amd.com \
    --to=harry.wentland@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=colin.king@canonical.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.