* [PATCH] virglrenderer: remove link option -Bsymbolic
@ 2019-04-04 7:52 kai.kang
2019-04-08 1:58 ` Kang Kai
0 siblings, 1 reply; 4+ messages in thread
From: kai.kang @ 2019-04-04 7:52 UTC (permalink / raw)
To: raj.khem; +Cc: openembedded-core
From: Kai Kang <kai.kang@windriver.com>
When gcc compile options '-O2 -fvisibility=default' are applied, it
fails to compile virglrenderer for x86:
| ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
when making a shared object
| ld: final link failed: bad value
| collect2: error: ld returned 1 exit status
Remove link option '-Bsymbolic' to fix the failure.
Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
.../0001-Remove-link-option-Bsymbolic.patch | 34 +++++++++++++++++++
.../virglrenderer/virglrenderer_0.7.0.bb | 1 +
2 files changed, 35 insertions(+)
create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
new file mode 100644
index 0000000000..faefa16aae
--- /dev/null
+++ b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
@@ -0,0 +1,34 @@
+When gcc compile options '-O2 -fvisibility=default' are applied, it fails to
+compile virglrenderer for x86:
+
+| ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
+ R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
+ when making a shared object
+| ld: final link failed: bad value
+| collect2: error: ld returned 1 exit status
+
+Remove link option '-Bsymbolic' to fix the failure.
+
+Upstream-Status: Submitted [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/213]
+
+Signed-off-by: Kai Kang <kai.kang@windriver.com>
+---
+ src/Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/Makefile.am b/src/Makefile.am
+index 9b668c8..7a421b8 100644
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -48,7 +49,7 @@ endif
+ lib_LTLIBRARIES = libvirglrenderer.la
+ noinst_LTLIBRARIES = libvrend.la
+
+-GM_LDFLAGS = -Wl,-Bsymbolic -version-number 0:2 -no-undefined
++GM_LDFLAGS = -version-number 0:2 -no-undefined
+
+ libvirglrenderer_la_SOURCES = virglrenderer.c
+ libvirglrenderer_ladir = $(libdir)
+--
+2.20.1
+
diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
index 225a0b8b0c..afc709bc48 100644
--- a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
+++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
@@ -9,6 +9,7 @@ SRCREV = "402c228861c9893f64cffbbcb4cb23044b8c721c"
SRC_URI = "git://anongit.freedesktop.org/virglrenderer \
file://0001-vtest-add-missing-includes.patch \
file://0001-Makefile.am-explicitly-link-with-libdrm.patch \
+ file://0001-Remove-link-option-Bsymbolic.patch \
"
S = "${WORKDIR}/git"
--
2.20.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] virglrenderer: remove link option -Bsymbolic
2019-04-04 7:52 [PATCH] virglrenderer: remove link option -Bsymbolic kai.kang
@ 2019-04-08 1:58 ` Kang Kai
2019-04-08 16:36 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Kang Kai @ 2019-04-08 1:58 UTC (permalink / raw)
To: raj.khem; +Cc: openembedded-core
On 2019/4/4 下午3:52, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> When gcc compile options '-O2 -fvisibility=default' are applied, it
> fails to compile virglrenderer for x86:
>
> | ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
> R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
> when making a shared object
> | ld: final link failed: bad value
> | collect2: error: ld returned 1 exit status
>
> Remove link option '-Bsymbolic' to fix the failure.
Any comments on this patch? Thank.
Kai
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
> .../0001-Remove-link-option-Bsymbolic.patch | 34 +++++++++++++++++++
> .../virglrenderer/virglrenderer_0.7.0.bb | 1 +
> 2 files changed, 35 insertions(+)
> create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
>
> diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
> new file mode 100644
> index 0000000000..faefa16aae
> --- /dev/null
> +++ b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
> @@ -0,0 +1,34 @@
> +When gcc compile options '-O2 -fvisibility=default' are applied, it fails to
> +compile virglrenderer for x86:
> +
> +| ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
> + R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
> + when making a shared object
> +| ld: final link failed: bad value
> +| collect2: error: ld returned 1 exit status
> +
> +Remove link option '-Bsymbolic' to fix the failure.
> +
> +Upstream-Status: Submitted [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/213]
> +
> +Signed-off-by: Kai Kang <kai.kang@windriver.com>
> +---
> + src/Makefile.am | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/src/Makefile.am b/src/Makefile.am
> +index 9b668c8..7a421b8 100644
> +--- a/src/Makefile.am
> ++++ b/src/Makefile.am
> +@@ -48,7 +49,7 @@ endif
> + lib_LTLIBRARIES = libvirglrenderer.la
> + noinst_LTLIBRARIES = libvrend.la
> +
> +-GM_LDFLAGS = -Wl,-Bsymbolic -version-number 0:2 -no-undefined
> ++GM_LDFLAGS = -version-number 0:2 -no-undefined
> +
> + libvirglrenderer_la_SOURCES = virglrenderer.c
> + libvirglrenderer_ladir = $(libdir)
> +--
> +2.20.1
> +
> diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
> index 225a0b8b0c..afc709bc48 100644
> --- a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
> +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
> @@ -9,6 +9,7 @@ SRCREV = "402c228861c9893f64cffbbcb4cb23044b8c721c"
> SRC_URI = "git://anongit.freedesktop.org/virglrenderer \
> file://0001-vtest-add-missing-includes.patch \
> file://0001-Makefile.am-explicitly-link-with-libdrm.patch \
> + file://0001-Remove-link-option-Bsymbolic.patch \
> "
>
> S = "${WORKDIR}/git"
--
Kai Kang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virglrenderer: remove link option -Bsymbolic
2019-04-08 1:58 ` Kang Kai
@ 2019-04-08 16:36 ` Khem Raj
2019-04-10 5:23 ` Kang Kai
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2019-04-08 16:36 UTC (permalink / raw)
To: Kang Kai; +Cc: Patches and discussions about the oe-core layer
On Sun, Apr 7, 2019 at 6:59 PM Kang Kai <Kai.Kang@windriver.com> wrote:
>
> On 2019/4/4 下午3:52, kai.kang@windriver.com wrote:
> > From: Kai Kang <kai.kang@windriver.com>
> >
> > When gcc compile options '-O2 -fvisibility=default' are applied, it
> > fails to compile virglrenderer for x86:
> >
> > | ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
> > R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
> > when making a shared object
> > | ld: final link failed: bad value
> > | collect2: error: ld returned 1 exit status
> >
> > Remove link option '-Bsymbolic' to fix the failure.
>
>
> Any comments on this patch? Thank.
>
> Kai
>
>
> >
> > Signed-off-by: Kai Kang <kai.kang@windriver.com>
> > ---
> > .../0001-Remove-link-option-Bsymbolic.patch | 34 +++++++++++++++++++
> > .../virglrenderer/virglrenderer_0.7.0.bb | 1 +
> > 2 files changed, 35 insertions(+)
> > create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
> >
> > diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
> > new file mode 100644
> > index 0000000000..faefa16aae
> > --- /dev/null
> > +++ b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
> > @@ -0,0 +1,34 @@
> > +When gcc compile options '-O2 -fvisibility=default' are applied, it fails to
> > +compile virglrenderer for x86:
> > +
> > +| ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
> > + R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
> > + when making a shared object
> > +| ld: final link failed: bad value
> > +| collect2: error: ld returned 1 exit status
> > +
> > +Remove link option '-Bsymbolic' to fix the failure.
> > +
In spite of removing the option can we try replacing it with
-Bsymbolic-functions
> > +Upstream-Status: Submitted [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/213]
> > +
> > +Signed-off-by: Kai Kang <kai.kang@windriver.com>
> > +---
> > + src/Makefile.am | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/src/Makefile.am b/src/Makefile.am
> > +index 9b668c8..7a421b8 100644
> > +--- a/src/Makefile.am
> > ++++ b/src/Makefile.am
> > +@@ -48,7 +49,7 @@ endif
> > + lib_LTLIBRARIES = libvirglrenderer.la
> > + noinst_LTLIBRARIES = libvrend.la
> > +
> > +-GM_LDFLAGS = -Wl,-Bsymbolic -version-number 0:2 -no-undefined
> > ++GM_LDFLAGS = -version-number 0:2 -no-undefined
> > +
> > + libvirglrenderer_la_SOURCES = virglrenderer.c
> > + libvirglrenderer_ladir = $(libdir)
> > +--
> > +2.20.1
> > +
> > diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
> > index 225a0b8b0c..afc709bc48 100644
> > --- a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
> > +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
> > @@ -9,6 +9,7 @@ SRCREV = "402c228861c9893f64cffbbcb4cb23044b8c721c"
> > SRC_URI = "git://anongit.freedesktop.org/virglrenderer \
> > file://0001-vtest-add-missing-includes.patch \
> > file://0001-Makefile.am-explicitly-link-with-libdrm.patch \
> > + file://0001-Remove-link-option-Bsymbolic.patch \
> > "
> >
> > S = "${WORKDIR}/git"
>
>
> --
> Kai Kang
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virglrenderer: remove link option -Bsymbolic
2019-04-08 16:36 ` Khem Raj
@ 2019-04-10 5:23 ` Kang Kai
0 siblings, 0 replies; 4+ messages in thread
From: Kang Kai @ 2019-04-10 5:23 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On 2019/4/9 上午12:36, Khem Raj wrote:
> On Sun, Apr 7, 2019 at 6:59 PM Kang Kai <Kai.Kang@windriver.com> wrote:
>> On 2019/4/4 下午3:52, kai.kang@windriver.com wrote:
>>> From: Kai Kang <kai.kang@windriver.com>
>>>
>>> When gcc compile options '-O2 -fvisibility=default' are applied, it
>>> fails to compile virglrenderer for x86:
>>>
>>> | ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
>>> R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
>>> when making a shared object
>>> | ld: final link failed: bad value
>>> | collect2: error: ld returned 1 exit status
>>>
>>> Remove link option '-Bsymbolic' to fix the failure.
>>
>> Any comments on this patch? Thank.
>>
>> Kai
>>
>>
>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>> ---
>>> .../0001-Remove-link-option-Bsymbolic.patch | 34 +++++++++++++++++++
>>> .../virglrenderer/virglrenderer_0.7.0.bb | 1 +
>>> 2 files changed, 35 insertions(+)
>>> create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
>>>
>>> diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
>>> new file mode 100644
>>> index 0000000000..faefa16aae
>>> --- /dev/null
>>> +++ b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
>>> @@ -0,0 +1,34 @@
>>> +When gcc compile options '-O2 -fvisibility=default' are applied, it fails to
>>> +compile virglrenderer for x86:
>>> +
>>> +| ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
>>> + R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
>>> + when making a shared object
>>> +| ld: final link failed: bad value
>>> +| collect2: error: ld returned 1 exit status
>>> +
>>> +Remove link option '-Bsymbolic' to fix the failure.
>>> +
> In spite of removing the option can we try replacing it with
> -Bsymbolic-functions
Thanks. I'll try it.
Regards,
Kai
>
>>> +Upstream-Status: Submitted [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/213]
>>> +
>>> +Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>> +---
>>> + src/Makefile.am | 2 +-
>>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>>> +
>>> +diff --git a/src/Makefile.am b/src/Makefile.am
>>> +index 9b668c8..7a421b8 100644
>>> +--- a/src/Makefile.am
>>> ++++ b/src/Makefile.am
>>> +@@ -48,7 +49,7 @@ endif
>>> + lib_LTLIBRARIES = libvirglrenderer.la
>>> + noinst_LTLIBRARIES = libvrend.la
>>> +
>>> +-GM_LDFLAGS = -Wl,-Bsymbolic -version-number 0:2 -no-undefined
>>> ++GM_LDFLAGS = -version-number 0:2 -no-undefined
>>> +
>>> + libvirglrenderer_la_SOURCES = virglrenderer.c
>>> + libvirglrenderer_ladir = $(libdir)
>>> +--
>>> +2.20.1
>>> +
>>> diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
>>> index 225a0b8b0c..afc709bc48 100644
>>> --- a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
>>> +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
>>> @@ -9,6 +9,7 @@ SRCREV = "402c228861c9893f64cffbbcb4cb23044b8c721c"
>>> SRC_URI = "git://anongit.freedesktop.org/virglrenderer \
>>> file://0001-vtest-add-missing-includes.patch \
>>> file://0001-Makefile.am-explicitly-link-with-libdrm.patch \
>>> + file://0001-Remove-link-option-Bsymbolic.patch \
>>> "
>>>
>>> S = "${WORKDIR}/git"
>>
>> --
>> Kai Kang
>>
--
Kai Kang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-10 5:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 7:52 [PATCH] virglrenderer: remove link option -Bsymbolic kai.kang
2019-04-08 1:58 ` Kang Kai
2019-04-08 16:36 ` Khem Raj
2019-04-10 5:23 ` Kang Kai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.