From: Jason Wang <jasowang@redhat.com> To: Wu Zongyong <wuzongyong@linux.alibaba.com>, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mst@redhat.com Cc: wei.yang1@linux.alibaba.com Subject: Re: [PATCH v4 4/7] vdpa: add new callback get_vq_num_min in vdpa_config_ops Date: Mon, 11 Oct 2021 11:04:14 +0800 [thread overview] Message-ID: <a07c02e3-e5eb-ae94-33d9-26c29de484c9@redhat.com> (raw) In-Reply-To: <451ce3c272ebd5d532db1ed19c2ab53c4609f7ad.1632882380.git.wuzongyong@linux.alibaba.com> 在 2021/9/29 下午2:11, Wu Zongyong 写道: > This callback is optional. For vdpa devices that not support to change > virtqueue size, get_vq_num_min and get_vq_num_max will return the same > value, so that users can choose a correct value for that device. > > Suggested-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Wu Zongyong <wuzongyong@linux.alibaba.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > include/linux/vdpa.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index a896ee021e5f..30864848950b 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -171,6 +171,9 @@ struct vdpa_map_file { > * @get_vq_num_max: Get the max size of virtqueue > * @vdev: vdpa device > * Returns u16: max size of virtqueue > + * @get_vq_num_min: Get the min size of virtqueue (optional) > + * @vdev: vdpa device > + * Returns u16: min size of virtqueue > * @get_device_id: Get virtio device id > * @vdev: vdpa device > * Returns u32: virtio device id > @@ -266,6 +269,7 @@ struct vdpa_config_ops { > void (*set_config_cb)(struct vdpa_device *vdev, > struct vdpa_callback *cb); > u16 (*get_vq_num_max)(struct vdpa_device *vdev); > + u16 (*get_vq_num_min)(struct vdpa_device *vdev); > u32 (*get_device_id)(struct vdpa_device *vdev); > u32 (*get_vendor_id)(struct vdpa_device *vdev); > u8 (*get_status)(struct vdpa_device *vdev); _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Wu Zongyong <wuzongyong@linux.alibaba.com>, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mst@redhat.com Cc: wei.yang1@linux.alibaba.com Subject: Re: [PATCH v4 4/7] vdpa: add new callback get_vq_num_min in vdpa_config_ops Date: Mon, 11 Oct 2021 11:04:14 +0800 [thread overview] Message-ID: <a07c02e3-e5eb-ae94-33d9-26c29de484c9@redhat.com> (raw) In-Reply-To: <451ce3c272ebd5d532db1ed19c2ab53c4609f7ad.1632882380.git.wuzongyong@linux.alibaba.com> 在 2021/9/29 下午2:11, Wu Zongyong 写道: > This callback is optional. For vdpa devices that not support to change > virtqueue size, get_vq_num_min and get_vq_num_max will return the same > value, so that users can choose a correct value for that device. > > Suggested-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Wu Zongyong <wuzongyong@linux.alibaba.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > include/linux/vdpa.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index a896ee021e5f..30864848950b 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -171,6 +171,9 @@ struct vdpa_map_file { > * @get_vq_num_max: Get the max size of virtqueue > * @vdev: vdpa device > * Returns u16: max size of virtqueue > + * @get_vq_num_min: Get the min size of virtqueue (optional) > + * @vdev: vdpa device > + * Returns u16: min size of virtqueue > * @get_device_id: Get virtio device id > * @vdev: vdpa device > * Returns u32: virtio device id > @@ -266,6 +269,7 @@ struct vdpa_config_ops { > void (*set_config_cb)(struct vdpa_device *vdev, > struct vdpa_callback *cb); > u16 (*get_vq_num_max)(struct vdpa_device *vdev); > + u16 (*get_vq_num_min)(struct vdpa_device *vdev); > u32 (*get_device_id)(struct vdpa_device *vdev); > u32 (*get_vendor_id)(struct vdpa_device *vdev); > u8 (*get_status)(struct vdpa_device *vdev);
next prev parent reply other threads:[~2021-10-11 3:04 UTC|newest] Thread overview: 223+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-08 12:20 [PATCH 0/6] vDPA driver for legacy virtio-pci device Wu Zongyong 2021-09-08 12:20 ` [PATCH 1/6] virtio-pci: introduce legacy device module Wu Zongyong 2021-09-08 12:20 ` [PATCH 2/6] vdpa: fix typo Wu Zongyong 2021-09-08 12:20 ` [PATCH 3/6] vp_vdpa: add vq irq offloading support Wu Zongyong 2021-09-09 2:53 ` Jason Wang 2021-09-09 2:53 ` Jason Wang 2021-09-08 12:20 ` [PATCH 4/6] vp_vdpa: split out reusable and device specific codes to separate file Wu Zongyong 2021-09-08 12:20 ` [PATCH 5/6] vdpa: add get_vq_num_unchangeable callback in vdpa_config_ops Wu Zongyong 2021-09-09 2:55 ` Jason Wang 2021-09-09 2:55 ` Jason Wang 2021-09-09 8:01 ` Wu Zongyong 2021-09-09 9:28 ` Jason Wang 2021-09-09 9:28 ` Jason Wang 2021-09-09 9:57 ` Wu Zongyong 2021-09-10 1:45 ` Jason Wang 2021-09-10 1:45 ` Jason Wang 2021-09-10 7:32 ` Wu Zongyong 2021-09-10 8:25 ` Cindy Lu 2021-09-10 9:20 ` Wu Zongyong 2021-09-10 15:10 ` Cindy Lu 2021-09-13 1:43 ` Jason Wang 2021-09-13 1:43 ` Jason Wang 2021-09-13 2:59 ` Wu Zongyong 2021-09-13 3:13 ` Jason Wang 2021-09-13 3:13 ` Jason Wang 2021-09-13 6:22 ` Cindy Lu 2021-09-09 9:18 ` Michael S. Tsirkin 2021-09-09 9:18 ` Michael S. Tsirkin 2021-09-09 9:32 ` Jason Wang 2021-09-09 9:32 ` Jason Wang 2021-09-08 12:20 ` [PATCH 6/6] vp_vdpa: introduce legacy virtio pci driver Wu Zongyong 2021-09-09 13:57 ` Michael S. Tsirkin 2021-09-09 13:57 ` Michael S. Tsirkin 2021-09-10 2:28 ` Wu Zongyong 2021-09-10 9:57 ` Michael S. Tsirkin 2021-09-10 9:57 ` Michael S. Tsirkin 2021-09-10 10:01 ` Wu Zongyong 2021-10-22 9:37 ` Michael S. Tsirkin 2021-10-22 9:37 ` Michael S. Tsirkin 2021-09-09 3:05 ` [PATCH 0/6] vDPA driver for legacy virtio-pci device Jason Wang 2021-09-09 3:05 ` Jason Wang 2021-09-09 3:20 ` Jason Wang 2021-09-09 3:20 ` Jason Wang 2021-09-09 8:12 ` Wu Zongyong 2021-09-09 9:29 ` Jason Wang 2021-09-09 9:29 ` Jason Wang 2021-09-09 9:21 ` Michael S. Tsirkin 2021-09-09 9:21 ` Michael S. Tsirkin 2021-09-09 9:31 ` Jason Wang 2021-09-09 9:31 ` Jason Wang 2021-09-09 12:53 ` Wu Zongyong 2021-09-10 1:44 ` Jason Wang 2021-09-10 1:44 ` Jason Wang 2021-09-14 12:24 ` [PATCH v2 0/5] vDPA driver for Alibaba ENI Wu Zongyong 2021-09-14 12:24 ` Wu Zongyong 2021-09-14 12:24 ` [PATCH v2 1/5] virtio-pci: introduce legacy device module Wu Zongyong 2021-09-14 22:37 ` Randy Dunlap 2021-09-14 22:37 ` Randy Dunlap 2021-09-14 12:24 ` [PATCH v2 2/5] vdpa: fix typo Wu Zongyong 2021-09-15 3:15 ` Jason Wang 2021-09-15 3:15 ` Jason Wang 2021-09-14 12:24 ` [PATCH v2 3/5] vp_vdpa: add vq irq offloading support Wu Zongyong 2021-09-15 3:16 ` Jason Wang 2021-09-15 3:16 ` Jason Wang 2021-09-15 3:31 ` Wu Zongyong 2021-09-15 4:13 ` Jason Wang 2021-09-15 4:13 ` Jason Wang 2021-09-14 12:24 ` [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1 Wu Zongyong 2021-09-14 12:58 ` Michael S. Tsirkin 2021-09-14 12:58 ` Michael S. Tsirkin 2021-09-15 3:18 ` Jason Wang 2021-09-15 3:18 ` Jason Wang 2021-09-15 7:38 ` Michael S. Tsirkin 2021-09-15 7:38 ` Michael S. Tsirkin 2021-09-15 8:06 ` Jason Wang 2021-09-15 8:06 ` Jason Wang 2021-09-15 11:08 ` Michael S. Tsirkin 2021-09-15 11:08 ` Michael S. Tsirkin 2021-09-15 12:12 ` Wu Zongyong 2021-09-16 1:11 ` Jason Wang 2021-09-16 1:11 ` Jason Wang 2021-09-16 1:05 ` Jason Wang 2021-09-16 1:05 ` Jason Wang 2021-09-17 2:34 ` Wu Zongyong 2021-09-17 7:51 ` Jason Wang 2021-09-17 7:51 ` Jason Wang 2021-09-15 3:24 ` Wu Zongyong 2021-09-15 7:30 ` Michael S. Tsirkin 2021-09-15 7:30 ` Michael S. Tsirkin 2021-09-15 8:05 ` Jason Wang 2021-09-15 8:05 ` Jason Wang 2021-09-15 11:10 ` Michael S. Tsirkin 2021-09-15 11:10 ` Michael S. Tsirkin 2021-09-14 12:24 ` [PATCH v2 5/5] eni_vdpa: add vDPA driver for Alibaba ENI Wu Zongyong 2021-09-14 22:35 ` Randy Dunlap 2021-09-14 22:35 ` Randy Dunlap 2021-09-15 3:14 ` Jason Wang 2021-09-15 3:14 ` Jason Wang 2021-09-15 3:47 ` Wu Zongyong 2021-09-15 13:36 ` kernel test robot 2021-09-15 13:36 ` kernel test robot 2021-09-15 13:36 ` kernel test robot 2021-09-22 12:46 ` [PATCH v3 0/7] " Wu Zongyong 2021-09-22 12:46 ` [PATCH v3 1/7] virtio-pci: introduce legacy device module Wu Zongyong 2021-09-22 12:46 ` [PATCH v3 2/7] vdpa: fix typo Wu Zongyong 2021-09-22 12:46 ` [PATCH v3 3/7] vp_vdpa: add vq irq offloading support Wu Zongyong 2021-09-22 12:46 ` [PATCH v3 4/7] vdpa: add new callback get_vq_num_min in vdpa_config_ops Wu Zongyong 2021-09-22 12:46 ` [PATCH v3 5/7] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Wu Zongyong 2021-09-22 12:46 ` [PATCH v3 6/7] vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE Wu Zongyong 2021-09-22 12:46 ` [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI Wu Zongyong 2021-09-26 2:24 ` Jason Wang 2021-09-26 2:24 ` Jason Wang 2021-09-26 3:24 ` Wu Zongyong 2021-09-26 4:18 ` Jason Wang 2021-09-26 4:18 ` Jason Wang 2021-09-27 10:36 ` Michael S. Tsirkin 2021-09-27 10:36 ` Michael S. Tsirkin 2021-09-28 2:17 ` Jason Wang 2021-09-28 2:17 ` Jason Wang 2021-09-26 2:26 ` Jason Wang 2021-09-26 2:26 ` Jason Wang 2021-09-26 3:27 ` Wu Zongyong 2021-09-26 4:19 ` Jason Wang 2021-09-26 4:19 ` Jason Wang 2021-09-29 12:54 ` kernel test robot 2021-09-29 12:54 ` kernel test robot 2021-09-29 12:54 ` kernel test robot 2021-09-29 6:11 ` [PATCH v4 0/7] " Wu Zongyong 2021-09-29 6:11 ` [PATCH v4 1/7] virtio-pci: introduce legacy device module Wu Zongyong 2021-10-11 3:00 ` Jason Wang 2021-10-11 3:00 ` Jason Wang 2021-10-11 3:02 ` Jason Wang 2021-10-11 3:02 ` Jason Wang 2021-09-29 6:11 ` [PATCH v4 2/7] vdpa: fix typo Wu Zongyong 2021-10-11 3:03 ` Jason Wang 2021-10-11 3:03 ` Jason Wang 2021-09-29 6:11 ` [PATCH v4 3/7] vp_vdpa: add vq irq offloading support Wu Zongyong 2021-09-29 6:11 ` [PATCH v4 4/7] vdpa: add new callback get_vq_num_min in vdpa_config_ops Wu Zongyong 2021-10-11 3:04 ` Jason Wang [this message] 2021-10-11 3:04 ` Jason Wang 2021-09-29 6:11 ` [PATCH v4 5/7] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Wu Zongyong 2021-10-11 3:06 ` Jason Wang 2021-10-11 3:06 ` Jason Wang 2021-09-29 6:11 ` [PATCH v4 6/7] vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE Wu Zongyong 2021-10-11 3:10 ` Jason Wang 2021-10-11 3:10 ` Jason Wang 2021-09-29 6:11 ` [PATCH v4 7/7] eni_vdpa: add vDPA driver for Alibaba ENI Wu Zongyong 2021-10-11 3:18 ` Jason Wang 2021-10-11 3:18 ` Jason Wang 2021-10-15 7:14 ` [PATCH v5 0/8] " Wu Zongyong 2021-10-15 7:14 ` [PATCH v5 1/8] virtio-pci: introduce legacy device module Wu Zongyong 2021-10-15 8:22 ` Jason Wang 2021-10-15 8:22 ` Jason Wang 2021-10-15 7:14 ` [PATCH v5 2/8] vdpa: fix typo Wu Zongyong 2021-10-15 7:14 ` [PATCH v5 3/8] vp_vdpa: add vq irq offloading support Wu Zongyong 2021-10-15 7:14 ` [PATCH v5 4/8] vdpa: add new callback get_vq_num_min in vdpa_config_ops Wu Zongyong 2021-10-15 8:22 ` Jason Wang 2021-10-15 8:22 ` Jason Wang 2021-10-15 7:14 ` [PATCH v5 5/8] vdpa: min vq num of vdpa device cannot be greater than max vq num Wu Zongyong 2021-10-15 8:24 ` Jason Wang 2021-10-15 8:24 ` Jason Wang 2021-10-15 7:14 ` [PATCH v5 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Wu Zongyong 2021-10-15 8:30 ` Jason Wang 2021-10-15 8:30 ` Jason Wang 2021-10-15 7:15 ` [PATCH v5 7/8] vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE Wu Zongyong 2021-10-15 7:15 ` [PATCH v5 8/8] eni_vdpa: add vDPA driver for Alibaba ENI Wu Zongyong 2021-10-15 8:18 ` Jason Wang 2021-10-15 8:18 ` Jason Wang 2021-10-15 19:13 ` Randy Dunlap 2021-10-15 19:13 ` Randy Dunlap 2021-10-22 2:44 ` [PATCH v6 0/8] " Wu Zongyong 2021-10-22 2:44 ` [PATCH v6 1/8] virtio-pci: introduce legacy device module Wu Zongyong 2021-10-25 1:30 ` Jason Wang 2021-10-25 1:30 ` Jason Wang 2021-10-22 2:44 ` [PATCH v6 2/8] vdpa: fix typo Wu Zongyong 2021-10-22 2:44 ` [PATCH v6 3/8] vp_vdpa: add vq irq offloading support Wu Zongyong 2021-10-22 2:44 ` [PATCH v6 4/8] vdpa: add new callback get_vq_num_min in vdpa_config_ops Wu Zongyong 2021-10-25 2:17 ` Jason Wang 2021-10-25 2:17 ` Jason Wang 2021-10-22 2:44 ` [PATCH v6 5/8] vdpa: min vq num of vdpa device cannot be greater than max vq num Wu Zongyong 2021-10-25 2:18 ` Jason Wang 2021-10-25 2:18 ` Jason Wang 2021-10-22 2:44 ` [PATCH v6 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Wu Zongyong 2021-10-25 2:22 ` Jason Wang 2021-10-25 2:22 ` [PATCH v6 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max, min} Jason Wang [not found] ` <20211025024403.GA3684@L-PF27918B-1352.localdomain> 2021-10-25 4:45 ` [PATCH v6 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Jason Wang 2021-10-25 4:45 ` Jason Wang [not found] ` <20211025062454.GA4832@L-PF27918B-1352.localdomain> 2021-10-26 4:46 ` Jason Wang 2021-10-26 4:46 ` [PATCH v6 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max, min} Jason Wang 2021-10-22 2:44 ` [PATCH v6 7/8] vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE Wu Zongyong 2021-10-25 2:23 ` Jason Wang 2021-10-25 2:23 ` Jason Wang 2021-10-22 2:44 ` [PATCH v6 8/8] eni_vdpa: add vDPA driver for Alibaba ENI Wu Zongyong 2021-10-25 2:27 ` Jason Wang 2021-10-25 2:27 ` Jason Wang [not found] ` <20211025032146.GC3684@L-PF27918B-1352.localdomain> 2021-10-25 4:40 ` Jason Wang 2021-10-25 4:40 ` Jason Wang 2021-10-27 2:47 ` Wu Zongyong 2021-10-27 3:55 ` Jason Wang 2021-10-27 3:55 ` Jason Wang 2021-10-27 7:04 ` Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 0/9] " Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 1/9] virtio-pci: introduce legacy device module Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 2/9] vdpa: fix typo Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 3/9] vp_vdpa: add vq irq offloading support Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 4/9] vdpa: add new callback get_vq_num_min in vdpa_config_ops Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 5/9] vdpa: min vq num of vdpa device cannot be greater than max vq num Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 6/9] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 7/9] vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 8/9] eni_vdpa: add vDPA driver for Alibaba ENI Wu Zongyong 2021-10-29 9:14 ` [PATCH v7 9/9] eni_vdpa: alibaba: fix Kconfig typo Wu Zongyong 2021-11-01 8:18 ` Michael S. Tsirkin 2021-11-01 8:18 ` Michael S. Tsirkin 2021-11-01 3:31 ` [PATCH v7 0/9] vDPA driver for Alibaba ENI Jason Wang 2021-11-01 3:31 ` Jason Wang 2021-11-01 6:22 ` Wu Zongyong 2021-11-01 7:02 ` Jason Wang 2021-11-01 7:02 ` Jason Wang 2021-11-01 8:11 ` Wu Zongyong 2021-11-01 11:12 ` Michael S. Tsirkin 2021-11-01 11:12 ` Michael S. Tsirkin 2021-11-01 8:19 ` Michael S. Tsirkin 2021-11-01 8:19 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a07c02e3-e5eb-ae94-33d9-26c29de484c9@redhat.com \ --to=jasowang@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=wei.yang1@linux.alibaba.com \ --cc=wuzongyong@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.