From: John Harrison <john.c.harrison@intel.com> To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>, <Intel-GFX@Lists.FreeDesktop.Org> Cc: DRI-Devel@Lists.FreeDesktop.Org Subject: Re: [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts Date: Fri, 4 Nov 2022 11:58:24 -0700 [thread overview] Message-ID: <a08b7c7b-bfa4-9ed2-e48b-b311f696c6e5@intel.com> (raw) In-Reply-To: <307671a5-08c9-8ef3-9774-e40338968dc0@intel.com> On 11/4/2022 11:53, Ceraolo Spurio, Daniele wrote: > On 11/2/2022 12:21 PM, John.C.Harrison@Intel.com wrote: >> From: John Harrison <John.C.Harrison@Intel.com> >> >> If a context has already been registered prior to first submission >> then context init code was not being called. The noticeable effect of >> that was the scheduling priority was left at zero (meaning super high >> priority) instead of being set to normal. This would occur with >> kernel contexts at start of day as they are manually pinned up front >> rather than on first submission. So add a call to initialise those >> when they are pinned. > > Does this need a fixes tag? on one side, we were leaving the priority > to the wrong value, but on the other there were no actual consequences. > I think that's the point. There was no actual issue, it's just a theoretical problem. So there is nothing to be gained by pushing this as a fix. It it seems like it would be a lot of unnecessary effort to push it all the way back to 5.17. John. > Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > > Daniele > >> Signed-off-by: John Harrison <John.C.Harrison@Intel.com> >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> index 4ccb29f9ac55c..941613be3b9dd 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> @@ -4111,6 +4111,9 @@ static inline void >> guc_kernel_context_pin(struct intel_guc *guc, >> if (context_guc_id_invalid(ce)) >> pin_guc_id(guc, ce); >> + if (!test_bit(CONTEXT_GUC_INIT, &ce->flags)) >> + guc_context_init(ce); >> + >> try_context_registration(ce, true); >> } >
WARNING: multiple messages have this Message-ID (diff)
From: John Harrison <john.c.harrison@intel.com> To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>, <Intel-GFX@Lists.FreeDesktop.Org> Cc: DRI-Devel@Lists.FreeDesktop.Org Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts Date: Fri, 4 Nov 2022 11:58:24 -0700 [thread overview] Message-ID: <a08b7c7b-bfa4-9ed2-e48b-b311f696c6e5@intel.com> (raw) In-Reply-To: <307671a5-08c9-8ef3-9774-e40338968dc0@intel.com> On 11/4/2022 11:53, Ceraolo Spurio, Daniele wrote: > On 11/2/2022 12:21 PM, John.C.Harrison@Intel.com wrote: >> From: John Harrison <John.C.Harrison@Intel.com> >> >> If a context has already been registered prior to first submission >> then context init code was not being called. The noticeable effect of >> that was the scheduling priority was left at zero (meaning super high >> priority) instead of being set to normal. This would occur with >> kernel contexts at start of day as they are manually pinned up front >> rather than on first submission. So add a call to initialise those >> when they are pinned. > > Does this need a fixes tag? on one side, we were leaving the priority > to the wrong value, but on the other there were no actual consequences. > I think that's the point. There was no actual issue, it's just a theoretical problem. So there is nothing to be gained by pushing this as a fix. It it seems like it would be a lot of unnecessary effort to push it all the way back to 5.17. John. > Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > > Daniele > >> Signed-off-by: John Harrison <John.C.Harrison@Intel.com> >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> index 4ccb29f9ac55c..941613be3b9dd 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> @@ -4111,6 +4111,9 @@ static inline void >> guc_kernel_context_pin(struct intel_guc *guc, >> if (context_guc_id_invalid(ce)) >> pin_guc_id(guc, ce); >> + if (!test_bit(CONTEXT_GUC_INIT, &ce->flags)) >> + guc_context_init(ce); >> + >> try_context_registration(ce, true); >> } >
next prev parent reply other threads:[~2022-11-04 18:58 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-02 19:21 [PATCH v2 0/2] Fix for two GuC issues John.C.Harrison 2022-11-02 19:21 ` [Intel-gfx] " John.C.Harrison 2022-11-02 19:21 ` [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts John.C.Harrison 2022-11-02 19:21 ` [Intel-gfx] " John.C.Harrison 2022-11-04 18:53 ` Ceraolo Spurio, Daniele 2022-11-04 18:53 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-11-04 18:58 ` John Harrison [this message] 2022-11-04 18:58 ` John Harrison 2022-11-05 5:18 ` Lucas De Marchi 2022-11-05 5:18 ` [Intel-gfx] " Lucas De Marchi 2022-11-02 19:21 ` [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset John.C.Harrison 2022-11-02 19:21 ` [Intel-gfx] " John.C.Harrison 2022-11-03 11:31 ` Tvrtko Ursulin 2022-11-03 18:45 ` John Harrison 2022-11-03 18:54 ` Umesh Nerlige Ramappa 2022-11-03 18:54 ` Umesh Nerlige Ramappa 2022-11-02 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Fix for two GuC issues (rev2) Patchwork 2022-11-03 4:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-11-04 19:40 ` John Harrison
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a08b7c7b-bfa4-9ed2-e48b-b311f696c6e5@intel.com \ --to=john.c.harrison@intel.com \ --cc=DRI-Devel@Lists.FreeDesktop.Org \ --cc=Intel-GFX@Lists.FreeDesktop.Org \ --cc=daniele.ceraolospurio@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.