All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: stm32: Fix AV96 and DHCOR split
@ 2020-04-27 11:16 Marek Vasut
  2020-04-28  8:44 ` Patrick DELAUNAY
  2020-05-14  9:33 ` Patrick DELAUNAY
  0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2020-04-27 11:16 UTC (permalink / raw)
  To: u-boot

The commit 132e5b68986d ("ARM: dts: stm32: Split AV96 into DHCOR SoM
and AV96 board") was not applied correctly and in full, and omitted
an important split of the SoM into 3V3 and 1V8 options. The Avenger96
board is based on the 1V8 IO option of the DHCOR SoM, however this is
an optional modification of the 3V3 IO DHCOR SoM with extra on-SoM
regulator to cater for the 96boards 1V8 IO requirements.

Reinstate the split between the 1V8 and 3V3 IO variants.

Fixes: 132e5b68986d ("ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
---
 arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts  |  2 +-
 arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi     | 24 +++++++++++++++++++
 ...hcor.dtsi => stm32mp15xx-dhcor-io3v3.dtsi} | 13 +---------
 3 files changed, 26 insertions(+), 13 deletions(-)
 create mode 100644 arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi
 rename arch/arm/dts/{stm32mp15xx-dhcor.dtsi => stm32mp15xx-dhcor-io3v3.dtsi} (94%)

diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts b/arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts
index a600677563..1b0579c8ab 100644
--- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts
+++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts
@@ -7,7 +7,7 @@
 
 /dts-v1/;
 
-#include "stm32mp15xx-dhcor.dtsi"
+#include "stm32mp15xx-dhcor-io1v8.dtsi"
 #include "stm32mp15xx-dhcor-avenger96-u-boot.dtsi"
 
 / {
diff --git a/arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi
new file mode 100644
index 0000000000..75435424d6
--- /dev/null
+++ b/arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/*
+ * Copyright (C) 2020 Marek Vasut <marex@denx.de>
+ */
+
+#include "stm32mp15xx-dhcor-io3v3.dtsi"
+
+/ {
+	/* Enpirion EP3A8LQI U2 on the 1V8 IO DHCOR */
+	vdd_io: regulator-buck-io {
+		compatible = "regulator-fixed";
+		regulator-name = "buck-io";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&vdd>;
+	};
+};
+
+&pwr_regulators {
+	vdd-supply = <&vdd_io>;
+	vdd_3v3_usbfs-supply = <&vdd_usb>;
+};
diff --git a/arch/arm/dts/stm32mp15xx-dhcor.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-io3v3.dtsi
similarity index 94%
rename from arch/arm/dts/stm32mp15xx-dhcor.dtsi
rename to arch/arm/dts/stm32mp15xx-dhcor-io3v3.dtsi
index 97d370e119..248fc455e3 100644
--- a/arch/arm/dts/stm32mp15xx-dhcor.dtsi
+++ b/arch/arm/dts/stm32mp15xx-dhcor-io3v3.dtsi
@@ -21,17 +21,6 @@
 		device_type = "memory";
 		reg = <0xc0000000 0x40000000>;
 	};
-
-	/* Enpirion EP3A8LQI U2 on the DHCOR */
-	vdd_io: regulator-buck-io {
-		compatible = "regulator-fixed";
-		regulator-name = "buck-io";
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
-		regulator-always-on;
-		regulator-boot-on;
-		vin-supply = <&vdd>;
-	};
 };
 
 &i2c4 {
@@ -200,7 +189,7 @@
 };
 
 &pwr_regulators {
-	vdd-supply = <&vdd_io>;
+	vdd-supply = <&vdd>;
 	vdd_3v3_usbfs-supply = <&vdd_usb>;
 };
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: dts: stm32: Fix AV96 and DHCOR split
  2020-04-27 11:16 [PATCH] ARM: dts: stm32: Fix AV96 and DHCOR split Marek Vasut
@ 2020-04-28  8:44 ` Patrick DELAUNAY
  2020-05-14  9:33 ` Patrick DELAUNAY
  1 sibling, 0 replies; 3+ messages in thread
From: Patrick DELAUNAY @ 2020-04-28  8:44 UTC (permalink / raw)
  To: u-boot

Dear Marek,

> From: Marek Vasut <marex@denx.de>
> Sent: lundi 27 avril 2020 13:16
> 
> The commit 132e5b68986d ("ARM: dts: stm32: Split AV96 into DHCOR SoM and
> AV96 board") was not applied correctly and in full, and omitted an important split
> of the SoM into 3V3 and 1V8 options. The Avenger96 board is based on the 1V8
> IO option of the DHCOR SoM, however this is an optional modification of the 3V3
> IO DHCOR SoM with extra on-SoM regulator to cater for the 96boards 1V8 IO
> requirements.
> 
> Reinstate the split between the 1V8 and 3V3 IO variants.
> 
> Fixes: 132e5b68986d ("ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96
> board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> ---
>  arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts  |  2 +-
>  arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi     | 24 +++++++++++++++++++
>  ...hcor.dtsi => stm32mp15xx-dhcor-io3v3.dtsi} | 13 +---------
>  3 files changed, 26 insertions(+), 13 deletions(-)  create mode 100644
> arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi
>  rename arch/arm/dts/{stm32mp15xx-dhcor.dtsi => stm32mp15xx-dhcor-
> io3v3.dtsi} (94%)
>

Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>

Thanks

Patrick

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: dts: stm32: Fix AV96 and DHCOR split
  2020-04-27 11:16 [PATCH] ARM: dts: stm32: Fix AV96 and DHCOR split Marek Vasut
  2020-04-28  8:44 ` Patrick DELAUNAY
@ 2020-05-14  9:33 ` Patrick DELAUNAY
  1 sibling, 0 replies; 3+ messages in thread
From: Patrick DELAUNAY @ 2020-05-14  9:33 UTC (permalink / raw)
  To: u-boot

Hi,

> From: Marek Vasut <marex@denx.de>
> Sent: lundi 27 avril 2020 13:16
> 
> The commit 132e5b68986d ("ARM: dts: stm32: Split AV96 into DHCOR SoM and
> AV96 board") was not applied correctly and in full, and omitted an important split
> of the SoM into 3V3 and 1V8 options. The Avenger96 board is based on the 1V8
> IO option of the DHCOR SoM, however this is an optional modification of the 3V3
> IO DHCOR SoM with extra on-SoM regulator to cater for the 96boards 1V8 IO
> requirements.
> 
> Reinstate the split between the 1V8 and 3V3 IO variants.
> 
> Fixes: 132e5b68986d ("ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96
> board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> ---
>  arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts  |  2 +-
>  arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi     | 24 +++++++++++++++++++
>  ...hcor.dtsi => stm32mp15xx-dhcor-io3v3.dtsi} | 13 +---------
>  3 files changed, 26 insertions(+), 13 deletions(-)  create mode 100644
> arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi
>  rename arch/arm/dts/{stm32mp15xx-dhcor.dtsi => stm32mp15xx-dhcor-
> io3v3.dtsi} (94%)
> 

Applied to u-boot-stm/master, thanks!

Regards

Patrick

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-14  9:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 11:16 [PATCH] ARM: dts: stm32: Fix AV96 and DHCOR split Marek Vasut
2020-04-28  8:44 ` Patrick DELAUNAY
2020-05-14  9:33 ` Patrick DELAUNAY

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.