All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: Add name for DRM_DP_DUAL_MODE_LSPCON
@ 2017-02-22 12:59 Ander Conselvan de Oliveira
  2017-02-22 13:09 ` Sharma, Shashank
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ander Conselvan de Oliveira @ 2017-02-22 12:59 UTC (permalink / raw)
  To: dri-devel
  Cc: Ander Conselvan de Oliveira, Jani Nikula, intel-gfx,
	Rodrigo Vivi, Daniel Vetter

Handle DRM_DP_DUAL_MODE_LSPCON in drm_dp_get_dual_mode_type_name(),
otherwise a call to that function can theoretically trigger a WARN.

Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
 drivers/gpu/drm/drm_dp_dual_mode_helper.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
index e025639..80e62f6 100644
--- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c
+++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
@@ -386,6 +386,8 @@ const char *drm_dp_get_dual_mode_type_name(enum drm_dp_dual_mode_type type)
 		return "type 2 DVI";
 	case DRM_DP_DUAL_MODE_TYPE2_HDMI:
 		return "type 2 HDMI";
+	case DRM_DP_DUAL_MODE_LSPCON:
+		return "lspcon";
 	default:
 		WARN_ON(type != DRM_DP_DUAL_MODE_UNKNOWN);
 		return "unknown";
-- 
2.9.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Add name for DRM_DP_DUAL_MODE_LSPCON
  2017-02-22 12:59 [PATCH] drm: Add name for DRM_DP_DUAL_MODE_LSPCON Ander Conselvan de Oliveira
@ 2017-02-22 13:09 ` Sharma, Shashank
  2017-02-22 16:52 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-02-23 18:50 ` [PATCH] " Sean Paul
  2 siblings, 0 replies; 4+ messages in thread
From: Sharma, Shashank @ 2017-02-22 13:09 UTC (permalink / raw)
  To: Ander Conselvan de Oliveira, dri-devel
  Cc: Jani Nikula, intel-gfx, David Airlie, Rodrigo Vivi, Daniel Vetter

At the first glace, I thought LSPCON is type2 HDMI only, then I realized 
not really for us (:-))

Reviewed-by: Shashank Sharma

Regards
Shashank
On 2/22/2017 6:29 PM, Ander Conselvan de Oliveira wrote:
> Handle DRM_DP_DUAL_MODE_LSPCON in drm_dp_get_dual_mode_type_name(),
> otherwise a call to that function can theoretically trigger a WARN.
>
> Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Dave Airlie <airlied@gmail.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: intel-gfx@lists.freedesktop.org
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> ---
>   drivers/gpu/drm/drm_dp_dual_mode_helper.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> index e025639..80e62f6 100644
> --- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> +++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> @@ -386,6 +386,8 @@ const char *drm_dp_get_dual_mode_type_name(enum drm_dp_dual_mode_type type)
>   		return "type 2 DVI";
>   	case DRM_DP_DUAL_MODE_TYPE2_HDMI:
>   		return "type 2 HDMI";
> +	case DRM_DP_DUAL_MODE_LSPCON:
> +		return "lspcon";
>   	default:
>   		WARN_ON(type != DRM_DP_DUAL_MODE_UNKNOWN);
>   		return "unknown";

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm: Add name for DRM_DP_DUAL_MODE_LSPCON
  2017-02-22 12:59 [PATCH] drm: Add name for DRM_DP_DUAL_MODE_LSPCON Ander Conselvan de Oliveira
  2017-02-22 13:09 ` Sharma, Shashank
@ 2017-02-22 16:52 ` Patchwork
  2017-02-23 18:50 ` [PATCH] " Sean Paul
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-02-22 16:52 UTC (permalink / raw)
  To: Ander Conselvan de Oliveira; +Cc: intel-gfx

== Series Details ==

Series: drm: Add name for DRM_DP_DUAL_MODE_LSPCON
URL   : https://patchwork.freedesktop.org/series/20062/
State : success

== Summary ==

Series 20062v1 drm: Add name for DRM_DP_DUAL_MODE_LSPCON
https://patchwork.freedesktop.org/api/1.0/series/20062/revisions/1/mbox/

fi-bdw-5557u     total:253  pass:242  dwarn:0   dfail:0   fail:0   skip:11 
fi-bsw-n3050     total:253  pass:214  dwarn:0   dfail:0   fail:0   skip:39 
fi-bxt-j4205     total:253  pass:234  dwarn:0   dfail:0   fail:0   skip:19 
fi-bxt-t5700     total:83   pass:70   dwarn:0   dfail:0   fail:0   skip:12 
fi-byt-j1900     total:253  pass:226  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:253  pass:222  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:253  pass:237  dwarn:0   dfail:0   fail:0   skip:16 
fi-hsw-4770r     total:253  pass:237  dwarn:0   dfail:0   fail:0   skip:16 
fi-ilk-650       total:253  pass:203  dwarn:0   dfail:0   fail:0   skip:50 
fi-ivb-3520m     total:253  pass:235  dwarn:0   dfail:0   fail:0   skip:18 
fi-ivb-3770      total:253  pass:235  dwarn:0   dfail:0   fail:0   skip:18 
fi-kbl-7500u     total:253  pass:235  dwarn:0   dfail:0   fail:0   skip:18 
fi-skl-6260u     total:253  pass:243  dwarn:0   dfail:0   fail:0   skip:10 
fi-skl-6700hq    total:253  pass:236  dwarn:0   dfail:0   fail:0   skip:17 
fi-skl-6700k     total:253  pass:231  dwarn:4   dfail:0   fail:0   skip:18 
fi-skl-6770hq    total:253  pass:243  dwarn:0   dfail:0   fail:0   skip:10 
fi-snb-2520m     total:253  pass:225  dwarn:0   dfail:0   fail:0   skip:28 
fi-snb-2600      total:253  pass:224  dwarn:0   dfail:0   fail:0   skip:29 

bf89ec45d0822835b03910371ac0baf46c4efa2d drm-tip: 2017y-02m-22d-14h-30m-04s UTC integration manifest
e507271 drm: Add name for DRM_DP_DUAL_MODE_LSPCON

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3930/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Add name for DRM_DP_DUAL_MODE_LSPCON
  2017-02-22 12:59 [PATCH] drm: Add name for DRM_DP_DUAL_MODE_LSPCON Ander Conselvan de Oliveira
  2017-02-22 13:09 ` Sharma, Shashank
  2017-02-22 16:52 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-02-23 18:50 ` Sean Paul
  2 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2017-02-23 18:50 UTC (permalink / raw)
  To: Ander Conselvan de Oliveira
  Cc: Jani Nikula, Daniel Vetter, intel-gfx, dri-devel, Rodrigo Vivi

On Wed, Feb 22, 2017 at 02:59:28PM +0200, Ander Conselvan de Oliveira wrote:
> Handle DRM_DP_DUAL_MODE_LSPCON in drm_dp_get_dual_mode_type_name(),
> otherwise a call to that function can theoretically trigger a WARN.
> 
> Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Dave Airlie <airlied@gmail.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: intel-gfx@lists.freedesktop.org
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>

Applied to -misc

Thanks,

Sean

> ---
>  drivers/gpu/drm/drm_dp_dual_mode_helper.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> index e025639..80e62f6 100644
> --- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> +++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> @@ -386,6 +386,8 @@ const char *drm_dp_get_dual_mode_type_name(enum drm_dp_dual_mode_type type)
>  		return "type 2 DVI";
>  	case DRM_DP_DUAL_MODE_TYPE2_HDMI:
>  		return "type 2 HDMI";
> +	case DRM_DP_DUAL_MODE_LSPCON:
> +		return "lspcon";
>  	default:
>  		WARN_ON(type != DRM_DP_DUAL_MODE_UNKNOWN);
>  		return "unknown";
> -- 
> 2.9.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-23 18:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-22 12:59 [PATCH] drm: Add name for DRM_DP_DUAL_MODE_LSPCON Ander Conselvan de Oliveira
2017-02-22 13:09 ` Sharma, Shashank
2017-02-22 16:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-23 18:50 ` [PATCH] " Sean Paul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.